Commit e4c4abdd authored by Karl Fogel's avatar Karl Fogel

* lisp/bookmark.el (bookmark-write-file): Bind `print-circle' to `t'

  here to allow circular custom bookmark types.  (Bug#12503)
parent 9267dbfd
......@@ -2,6 +2,8 @@
* bookmark.el (bookmark-version-control): Give tags in the
:type choices (Bug#12309), and improve doc string.
(bookmark-write-file): Bind `print-circle' to `t' to allow
circular custom bookmark types. (Bug#12503)
2012-10-01 Paul Eggert <>
......@@ -1359,7 +1359,12 @@ for a file, defaulting to the file defined by variable
(goto-char (point-min))
(delete-region (point-min) (point-max))
(let ((print-length nil)
(print-level nil))
(print-level nil)
;; See bug #12503 for why we bind `print-circle'. Users
;; can define their own bookmark types, which can result in
;; arbitrary Lisp objects being stored in bookmark records,
;; and some users create objects containing circularities.
(print-circle t))
(insert "(")
;; Rather than a single call to `pp' we make one per bookmark.
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment