1. 01 Jan, 2019 1 commit
  2. 01 Jan, 2018 1 commit
  3. 13 Sep, 2017 1 commit
    • Paul Eggert's avatar
      Prefer HTTPS to FTP and HTTP in documentation · bc511a64
      Paul Eggert authored
      Most of this change is to boilerplate commentary such as license URLs.
      This change was prompted by ftp://ftp.gnu.org's going-away party,
      planned for November.  Change these FTP URLs to https://ftp.gnu.org
      instead.  Make similar changes for URLs to other organizations moving
      away from FTP.  Also, change HTTP to HTTPS for URLs to gnu.org and
      fsf.org when this works, as this will further help defend against
      man-in-the-middle attacks (for this part I omitted the MS-DOS and
      MS-Windows sources and the test tarballs to keep the workload down).
      HTTPS is not fully working to lists.gnu.org so I left those URLs alone
      for now.
      bc511a64
  4. 04 Aug, 2017 1 commit
    • Paul Eggert's avatar
      Fix version numbers for some GnuTLS features · e8ca0c5e
      Paul Eggert authored
      Problem reported by Glenn Morris (Bug#27708#58).
      * src/gnutls.c (HAVE_GNUTLS_X509_SYSTEM_TRUST):
      New macro.  Use it instead of low-level version number checks.
      (HAVE_GNUTLS_AEAD): Move here from gnutls.h, and rename from
      HAVE_GNUTLS3_AEAD.  All uses changed.  Indent preprocessor lines.
      * src/gnutls.h (HAVE_GNUTLS3_CIPHER, HAVE_GNUTLS3_DIGEST)
      (HAVE_GNUTLS3_HMAC): Remove, since these were available
      before GnuTLS 3.0.0 and the code checks them only if HAVE_GNUTLS3
      is defined.  Remove all uses; this simplifies the code a bit.
      e8ca0c5e
  5. 03 Aug, 2017 2 commits
    • Paul Eggert's avatar
      Port GnuTLS usage to Ubuntu 16.04.2 LTS · f465efe4
      Paul Eggert authored
      * src/gnutls.h (HAVE_GNUTLS3_AEAD): Define only if GnuTLS 3.5.1 or
      later, as opposed to the old 3.4.0 or later.
      f465efe4
    • Paul Eggert's avatar
      Simplify configuration of HAVE_GNUTLS3 etc. · a8a81df8
      Paul Eggert authored
      There's only one GnuTLS, so configuring these symbols at
      'configure' time is overkill.  Simplify things by moving their
      configuration to src/gnutls.h (Bug#27708).
      * configure.ac (HAVE_GNUTLS3, HAVE_GNUTLS3_HMAC, HAVE_GNUTLS3_AEAD)
      (HAVE_GNUTLS3_CIPHER, HAVE_GNUTLS3_DIGEST): Move these definitions
      from here ...
      * src/gnutls.h: ... to here, and simplify.
      a8a81df8
  6. 14 Jul, 2017 2 commits
    • Eli Zaretskii's avatar
      Fix the MS-Windows build due to added GnuTLS functions · 389fb2ae
      Eli Zaretskii authored
      * src/gnutls.c [WINDOWSNT]: Add DEF_DLL_FN for new functions.
      (init_gnutls_functions) [WINDOWSNT]: Add LOAD_DLL_FN for new
      functions.  Add #define redirections for new functions.
      (gnutls_symmetric_aead): Fix format specs to be more portable when
      printing ptrdiff_t arguments.
      * src/fns.c (gnutls_rnd) [WINDOWSNT]: Redirect to w32_gnutls_rnd
      wrapper.
      * src/gnutls.h [WINDOWSNT]: Add prototype for w32_gnutls_rnd.
      
      * test/lisp/net/gnutls-tests.el (gnutls-tests-tested-macs)
      (gnutls-tests-tested-digests, gnutls-tests-tested-ciphers): Call
      gnutls-available-p, otherwise GnuTLS functions might not be loaded
      from the DLL on MS-Windows.
      389fb2ae
    • Ted Zlatanov's avatar
      GnuTLS HMAC and symmetric cipher support · 583995c6
      Ted Zlatanov authored
          * etc/NEWS: Add news for new feature.
      
          * doc/lispref/text.texi (GnuTLS Cryptography): Add
          documentation.
      
          * configure.ac: Add macros HAVE_GNUTLS3_DIGEST,
          HAVE_GNUTLS3_CIPHER, HAVE_GNUTLS3_AEAD, HAVE_GNUTLS3_HMAC.
      
          * src/fns.c (Fsecure_hash_algorithms): Add function to list
          supported `secure-hash' algorithms.
          (extract_data_from_object): Add data extraction function that
          can operate on buffers and strings.
          (secure_hash): Use it.
          (Fsecure_hash): Mention `secure-hash-algorithms'.
      
          * src/gnutls.h: Include gnutls/crypto.h.
      
          * src/gnutls.c (Fgnutls_ciphers, gnutls_symmetric_aead)
          (gnutls_symmetric, Fgnutls_symmetric_encrypt, Fgnutls_symmetric_decrypt)
          (Fgnutls_macs, Fgnutls_digests, Fgnutls_hash_mac, Fgnutls_hash_digest)
          (Fgnutls_available_p): Implement GnuTLS cryptographic integration.
      
          * test/lisp/net/gnutls-tests.el: Add tests.
      583995c6
  7. 01 Jan, 2017 1 commit
  8. 22 Jun, 2016 1 commit
    • Paul Eggert's avatar
      Improve --without-x GCC pacification · 1c019905
      Paul Eggert authored
      * src/composite.c (autocmp_chars):
      * src/conf_post.h (DebPrint) [HAVE_NTGUI && !DebPrint && !EMACSDEBUG]:
      Use simpler ((void) 0) for no-op expression returning void.
      * src/dispextern.h [HAVE_WINDOW_SYSTEM]:
      Include fontset.h, for face_for_char.
      (FACE_SUITABLE_FOR_ASCII_CHAR_P, FACE_FOR_CHAR):
      Now inline functions instead of macros.  This avoids the need for
      all those casts to void.
      (FACE_SUITABLE_FOR_ASCII_CHAR_P): Omit 2nd (unused) arg.
      All uses changed.
      * src/frame.c (Ficonify_frame, Fset_frame_position):
      * src/xdisp.c (Fmove_point_visually, show_mouse_face):
      * src/xdisp.c (note_mode_line_or_margin_highlight)
      (note_mouse_highlight):
      Assume HAVE_WINDOW_SYSTEM for simplicity, since the code should
      now work either way without generating warnings.
      * src/frame.c (display_available) [HAVE_WINDOW_SYSTEM]: New function.
      (window_system_available) [HAVE_WINDOW_SYSTEM]: Move to frame.h.
      (decode_window_system_frame): Use check_window_system instead of
      rolling the code ourself.  Return needed only if HAVE_WINDOW_SYSTEM.
      (decode_window_system_frame, check_window_system):
      Merge the HAVE_WINDOW_SYSTEM and !HAVE_WINDOW_SYSTEM versions into one.
      * src/frame.c (Ficonify_frame, Fset_frame_position):
      * src/xdisp.c (show_mouse_face, define_frame_cursor1)
      (note_mouse_highlight):
      Narrow the scope of the HAVE_WINDOW_SYSTEM #ifdef;
      this is a better way to pacify GCC.
      * src/xdisp.c (x_set_left_fringe, x_set_right_fringe)
      (x_set_right_divider_width, x_set_bottom_divider_width):
      * src/xfns.c (x_set_internal_border_width):
      Don’t use what are now function calls as lvalues.
      * src/frame.h (WINDOW_SYSTEM_RETURN): New macro.
      (decode_window_system_frame, check_window_system):
      Use it, to avoid the need for duplicate declarations.
      (window_system_available): Now an inline function.
      (display_available): New decl.
      (frame_dimension): New inline function.
      (FRAME_FRINGE_COLS, FRAME_LEFT_FRINGE_WIDTH)
      (FRAME_RIGHT_FRINGE_WIDTH, FRAME_TOTAL_FRINGE_WIDTH)
      (FRAME_INTERNAL_BORDER_WIDTH, FRAME_RIGHT_DIVIDER_WIDTH)
      (FRAME_BOTTOM_DIVIDER_WIDTH):
      Use it, to avoid the need for duplicate definitions.
      Now inline functions instead of macros.
      * src/gnutls.c (gnutls_log_function2i): Remove.
      * src/gnutls.h (GNUTLS_LOG2i): Use ‘message’ directly.
      This avoids complaints about gnutls_log_function2i being defined
      and not used on older platforms that do not need to call GNUTLS_LOG2i.
      * src/image.c (DefaultDepthOfScreen) [0]: Remove unused macro.
      * src/lisp.h (AUTO_STRING_WITH_LEN): Revert change from ‘type id =
      expr’ to ‘type id; id = expr’, as this would suppress valid
      jump-misses-init diagnostics.  Let’s find a better way to address
      the problem.
      * src/vm-limit.c (__MALLOC_HOOK_VOLATILE):
      Define only if needed.
      * src/xdisp.c (handle_single_display_spec):
      Simplify fringe_bitmap computation.
      (define_frame_cursor1): Do nothing unless in a window system.
      All callers changed and simplified.
      * src/xfaces.c (realize_default_face):
      Use a simpler way to pacify GCC when a return value is not used
      on some platforms.
      1c019905
  9. 10 Mar, 2016 1 commit
    • Paul Eggert's avatar
      Rework C source files to avoid ^( · 7352c6c6
      Paul Eggert authored
      Work around Bug#22884 by rewording comments and strings to avoid ‘(’
      at the start of a line unless it starts a function.  This change
      is a short-term hack; in the longer run we plan to fix cc-mode’s
      performance for C files that have ‘(’ at the start of a line in a
      comment or string.
      7352c6c6
  10. 03 Mar, 2016 1 commit
    • Lars Ingebrigtsen's avatar
      Ensure TLS negotiation progress · 0c5c04d5
      Lars Ingebrigtsen authored
      * src/gnutls.h (GNUTLS_EMACS_HANDSHAKES_LIMIT): Increase the
      number of retries so that we try for about a minute.
      
      * src/process.c (wait_reading_process_output): Ensure progress
      for DNS resolution and TLS negotiation.
      0c5c04d5
  11. 18 Feb, 2016 1 commit
    • Lars Ingebrigtsen's avatar
      Verify the TLS connection asynchronously · e96df838
      Lars Ingebrigtsen authored
      * src/gnutls.c (gnutls_verify_boot): Refactor out into its own
      function so that we can call it asynchronously.
      (Fgnutls_boot): Use it.
      
      * src/process.c (wait_reading_process_output): Verify the TLS
      negotiation.
      e96df838
  12. 16 Feb, 2016 1 commit
    • Lars Ingebrigtsen's avatar
      Implement asynch TLS negotiation · ac6e085c
      Lars Ingebrigtsen authored
      * src/gnutls.c (gnutls_try_handshake): Factor out into its own
      function.
      (emacs_gnutls_handshake): Use it.
      (emacs_gnutls_read): Just return instead of retrying the handshake.
      
      * src/process.c (finish_after_tls_connection): Factor out
      into its own function.
      (connect_network_socket): Use it.
      (wait_reading_process_output): Retry TLS handshakes.
      (wait_reading_process_output): Defer sentinel until TLS completes.
      ac6e085c
  13. 18 Jan, 2016 1 commit
    • Paul Eggert's avatar
      Initialize GnuTLS before calling gnutls_rnd · 130d5120
      Paul Eggert authored
      * src/gnutls.c (emacs_gnutls_global_init): Now extern.
      Don’t set gnutls_global_initialized if gnutls_global_init fails.
      * src/sysdep.c: Include "gnutls.h", and <gnutls/crypto.h>
      if 2.12 or later, which has gnutls_rnd.
      (emacs_gnutls_global_init, gnutls_rnd): New fallback
      placeholder macros if before 2.12.
      (init_random): Initialize gnutls globals before trying to
      use gnutls_rnd.
      130d5120
  14. 01 Jan, 2016 1 commit
  15. 16 Oct, 2015 1 commit
    • Paul Eggert's avatar
      Make src headers idempotent and standalone · 55ba8c02
      Paul Eggert authored
      Redo src/*.h so that each include file is idempotent (that is, can
      be included multiple times with the latter inclusions having no
      effect) and standalone (that is, can be included by itself,
      with no include file other than config.h needed as a prerequisite).
      This is standard practice in GNU programs nowadays.
      * lwlib/lwlib-widget.h, src/buffer.h, src/category.h, src/character.h:
      * src/charset.h, src/coding.h, src/commands.h, src/disptab.h:
      * src/fontset.h, src/gnutls.h, src/indent.h, src/keymap.h, src/macros.h:
      * src/regex.h [emacs]:
      * src/syntax.h, src/systty.h, src/termhooks.h:
      Include lisp.h, for Lisp_Object.
      * src/buffer.h, src/category.h, src/cm.h, src/commands.h, src/disptab.h:
      * src/indent.h, src/intervals.h, src/keyboard.h, src/macros.h:
      * src/process.h, src/puresize.h, src/region-cache.h, src/syntax.h:
      * src/syssignal.h, src/sysstdio.h, src/systty.h, src/termchar.h:
      * src/termopts.h, src/tparam.h, src/unexec.h:
      Protect against multiple inclusion.
      * src/buffer.h: Include character.h, for STRING_CHAR.
      * src/emacsgtkfixed.h (struct frame):
      * src/fontset.h (struct face):
      * src/region-cache.h (struct buffer):
      * src/termhooks.h (struct glyph):
      * src/xsettings.h (struct x_display_info):
      Add possibly-forward decl.
      * src/syntax.h: Include buffer.h, for BVAR.
      * src/sysselect.h: Include lisp.h, for eassume.
      * src/termchar.h: Include <stdio.h>, for FILE.
      * src/widget.h: Include <X11/IntrinsicP.h>, for Widget.
      * src/xsettings.h: Include <X11/Xlib.h>, for XEvent.
      55ba8c02
  16. 01 Jan, 2015 2 commits
  17. 13 Dec, 2014 1 commit
    • Ted Zlatanov's avatar
      Merge from origin/emacs-24 · 28e0d0c9
      Ted Zlatanov authored
      bd6c4418 * simple.el (password-word-equivalents): Add "passcode", used for numeric secrets like PINs or RSA tokens.
      16d4c1cd A better fix for bug#19346
      82ec808f * .gitignore: Add !lib/std*.in.h, so as to not ignore the .in.h files.
      3cf7629f Git ignore lib/std*.h
      301a4014 Always define `gnutls-available-p' even if GnuTLS is not available.
      d76b9b2a Don't break example string between 2 lines (bug#19257)
      75b4857e Port commit-msg to mawk
      9ac03320 Improve commit-msg messages and autosquash
      0c2f254b Support overflow-newline-into-fringe together with word-wrap (bug#19300)
      935ee05f * net/tramp-sh.el (tramp-get-remote-path): Use a login shell in order to determine `tramp-own-remote-path'.
      c2db9393 python.el: Support interpreter paths with spaces
      d83f3299 ChangeLog fix
      0f9fbb92 Port commit-message checking to FreeBSD 9.
      3db1adac admin/MAINTAINERS: Update my interests and responsibilities.
      6382f241 * .gitignore: Ignore autosave files.
      
      Conflicts:
      	ChangeLog
      	lisp/progmodes/python.el
      	src/gnutls.c
      28e0d0c9
  18. 11 Dec, 2014 1 commit
    • Ted Zlatanov's avatar
      Always define `gnutls-available-p' even if GnuTLS is not available. · 301a4014
      Ted Zlatanov authored
      Fixes: debbugs:19346
      
      * gnutls.c (Fgnutls_available_p syms_of_gnutls): Move later for
      clarity.  Let the availability check return Qnil when the GnuTLS
      integration is not available, instead of erroring out.
      
      * gnutls.h: Always declare syms_of_gnutls.
      
      * emacs.c (main): Always include gnutls.h and run syms_of_gnutls.
      301a4014
  19. 01 Jan, 2014 1 commit
  20. 14 Dec, 2013 1 commit
    • Paul Eggert's avatar
      Use bool for boolean, focusing on headers. · 96c06863
      Paul Eggert authored
      * configure.ac (PTY_OPEN, GC_MARK_SECONDARY_STACK):
      Use bool for boolean.
      * lib-src/emacsclient.c, lib-src/etags.c, lib-src/hexl.c (FALSE, TRUE):
      Remove.  All uses replaced with uncapitalized version.
      * lib-src/emacsclient.c (message):
      * lib-src/etags.c (make_tag, pfnote, consider_token, make_C_tag, lang_names):
      * lib-src/hexl.c (un_flag, iso_flag, endian):
      * lib-src/pop.c (pop_debug, pop_open, pop_multi_first, pop_multi_next)
      (pop_trash):
      Use bool for boolean.
      * lib-src/etags.c (bool): Remove.
      * lib-src/etags.c (globals, members, declarations, no_line_directive)
      (no_duplicates): Use 'int' for boolean values that getopt requires
      to be 'int'.  Formerly, these were 'bool' and 'bool' was 'int',
      but we can no longer rely on this implementation.
      * lib-src/pop.h (struct _popserver): Use bool_bf for boolean bit-fields.
      * lwlib/xlwmenuP.h (XlwMenu_part): Use bool_bf for boolean bit-fields.
      * src/atimer.h, src/lisp.h, src/syssignal.h, src/syswait.h, src/unexelf.c:
      No need to include <stdbool.h>, since conf_post.h does it now.
      * src/buffer.h (BUF_COMPUTE_UNCHANGED, DECODE_POSITION)
      (BUFFER_CHECK_INDIRECTION, GET_OVERLAYS_AT, PER_BUFFER_VALUE_P)
      (SET_PER_BUFFER_VALUE_P):
      * src/ccl.c, src/ccl.h (setup_ccl_program):
      * src/ccl.h (CHECK_CCL_PROGRAM):
      * src/character.h (MAKE_CHAR_UNIBYTE, CHECK_CHARACTER_CAR)
      (CHECK_CHARACTER_CDR, CHAR_STRING_ADVANCE, NEXT_CHAR_BOUNDARY)
      (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE)
      (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE)
      (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, FETCH_CHAR_ADVANCE)
      (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, INC_BOTH)
      (DEC_BOTH, BUF_INC_POS, BUF_DEC_POS):
      * src/charset.h (CHECK_CHARSET, CHECK_CHARSET_GET_ID)
      (CHECK_CHARSET_GET_ATTR, CHECK_CHARSET_GET_CHARSET)
      (CHARSET_FAST_MAP_SET):
      * src/coding.c (decode_coding_ccl, encode_coding_ccl):
      * src/coding.h (CHECK_CODING_SYSTEM, CHECK_CODING_SYSTEM_GET_SPEC)
      (CHECK_CODING_SYSTEM_GET_ID, SJIS_TO_JIS, SJIS_TO_JIS2)
      (JIS_TO_SJIS, JIS_TO_SJIS2, ENCODE_FILE, DECODE_FILE)
      (ENCODE_SYSTEM, DECODE_SYSTEM, ENCODE_UTF_8)
      (decode_coding_c_string):
      * src/composite.h (COMPOSITION_DECODE_REFS, COMPOSITION_DECODE_RULE):
      * src/conf_post.h (has_attribute):
      * src/dispextern.h (trace_redisplay_p):
      (INC_TEXT_POS, DEC_TEXT_POS, SET_GLYPH_FROM_GLYPH_CODE)
      (SET_CHAR_GLYPH, SET_CHAR_GLYPH_FROM_GLYPH)
      (SET_GLYPH_FROM_CHAR_GLYPH):
      (WINDOW_WANTS_MODELINE_P, WINDOW_WANTS_HEADER_LINE_P)
      (FACE_SUITABLE_FOR_ASCII_CHAR_P, FACE_SUITABLE_FOR_CHAR_P)
      (PRODUCE_GLYPHS, reset_mouse_highlight, in_display_vector_p)
      (cursor_in_mouse_face_p):
      * src/dispnew.c (adjust_glyph_matrix, clear_glyph_matrix_rows)
      (blank_row, prepare_desired_row)
      (build_frame_matrix_from_leaf_window, make_current)
      (mirror_make_current, mirrored_line_dance, mirror_line_dance)
      (update_window, scrolling_window, update_frame_line):
      * src/disptab.h (GLYPH_FOLLOW_ALIASES):
      * src/editfns.c (Fformat):
      * src/font.h (FONT_WEIGHT_SYMBOLIC, FONT_SLANT_SYMBOLIC)
      (FONT_WIDTH_SYMBOLIC, FONT_WEIGHT_FOR_FACE, FONT_SLANT_FOR_FACE)
      (FONT_WIDTH_FOR_FACE, FONT_WEIGHT_NAME_NUMERIC)
      (FONT_SLANT_NAME_NUMERIC, FONT_WIDTH_NAME_NUMERIC)
      (FONT_SET_STYLE, CHECK_FONT, CHECK_FONT_SPEC, CHECK_FONT_ENTITY)
      (CHECK_FONT_OBJECT, CHECK_FONT_GET_OBJECT, FONT_ADD_LOG)
      (FONT_DEFERRED_LOG):
      * src/frame.h (FRAME_W32_P, FRAME_MSDOS_P, FRAME_WINDOW_P):
      (FRAME_EXTERNAL_TOOL_BAR, FRAME_EXTERNAL_MENU_BAR, FOR_EACH_FRAME)
      (FRAME_MOUSE_UPDATE):
      * src/fringe.c (Fdefine_fringe_bitmap):
      * src/image.c (x_create_bitmap_from_data, x_create_bitmap_mask)
      (x_create_bitmap_from_xpm_data, xpm_load_image):
      * src/intervals.h (INTERVAL_HAS_PARENT, INTERVAL_PARENT)
      (set_interval_parent, RESET_INTERVAL, COPY_INTERVAL_CACHE)
      (MERGE_INTERVAL_CACHE):
      * src/keymap.h (KEYMAPP):
      * src/lisp.h (eassert, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE)
      (STRING_SET_UNIBYTE, STRING_SET_MULTIBYTE, DEFSYM, PSEUDOVECTORP)
      (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER)
      (CHECK_NUMBER_COERCE_MARKER, CHECK_NUMBER_OR_FLOAT_COERCE_MARKER)
      (DEFVAR_LISP, DEFVAR_LISP_NOPRO, DEFVAR_BOOL, DEFVAR_INT)
      (DEFVAR_BUFFER_DEFAULTS, DEFVAR_KBOARD, QUIT)
      (RETURN_UNGCPRO, USE_SAFE_ALLOCA, SAFE_NALLOCA, SAFE_FREE)
      (SAFE_ALLOCA_LISP, FOR_EACH_ALIST_VALUE, functionp):
      * src/syntax.h (SYNTAX_ENTRY, SYNTAX_WITH_FLAGS, SYNTAX)
      (UPDATE_SYNTAX_TABLE_FORWARD, UPDATE_SYNTAX_TABLE_BACKWARD)
      (SETUP_BUFFER_SYNTAX_TABLE):
      * src/systime.h (timespec_valid_p):
      * src/term.c (save_and_enable_current_matrix):
      * src/window.h (WINDOW_MENU_BAR_P, WINDOW_TOOL_BAR_P):
      * src/xdisp.c (in_display_vector_p, display_tool_bar_line)
      (redisplay_internal, try_window_reusing_current_matrix)
      (sync_frame_with_window_matrix_rows, try_window_id)
      (display_menu_bar, display_tty_menu_item, display_mode_line)
      (coords_in_mouse_face_p, cursor_in_mouse_face_p):
      * src/xmenu.c (xmenu_show):
      * src/xterm.c (use_xim, x_term_init):
      * src/xterm.h (XSync, GTK_CHECK_VERSION, use_xim, SET_SCROLL_BAR_X_WIDGET)
      (struct x_bitmap_record):
      Use bool for booleans.
      * src/ccl.c (struct buffer_text):
      * src/ccl.h (struct ccl_program):
      * src/charset.h (struct charset):
      * src/cm.h (struct cm):
      * src/coding.h (struct iso_2022_spec, struct coding_system):
      * src/dispextern.h (struct glyph, struct glyph_matrix, struct glyph_row)
      (struct glyph_string, struct face, struct face_cache)
      (struct bidi_string_data, struct bidi_it)
      (struct draw_fringe_bitmap_params, struct it, Mouse_HLInfo)
      (struct image):
      * src/editfns.c (Fformat):
      * src/frame.h (struct frame):
      * src/fringe.c (struct fringe_bitmap):
      * src/intervals.h (struct interval):
      * src/keyboard.h (struct kboard):
      * src/lisp.h (struct Lisp_Symbol, struct Lisp_Misc_Any, struct Lisp_Marker)
      (struct Lisp_Overlay, struct Lisp_Save_Value, struct Lisp_Free)
      (struct Lisp_Buffer_Local_Value, union specbinding):
      * src/macfont.m (struct macfont_info):
      * src/process.h (struct Lisp_Process):
      * src/termchar.h (struct tty_display_info):
      * src/window.h (struct window):
      * src/xterm.h (struct x_output):
      Use bool_bf for boolean bit-fields.
      * src/ccl.c (setup_ccl_program): Now returns bool instead of -1 or 0.
      All callers changed.
      * src/ccl.h (struct ccl_program): Remove unused members private_state,
      src_multibyte, dst_multibyte, cr_consumed, suppress_error,
      eight_bit_control.
      (struct ccl_spec): Remove unused members cr_carryover,
      eight_bit_carryover.
      * src/conf_post.h: Include <stdbool.h>.
      (bool_bf): New type.
      * src/dispextern.h (TRACE, PREPARE_FACE_FOR_DISPLAY):
      * src/interval.h (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE)
      Surround statement macro with proper 'do { ... } while (false)' brackets.
      (SET_MATRIX_ROW_ENABLED_P): Assume 2nd arg is bool.
      (PRODUCE_GLYPHS): Simplify use of boolean.
      * src/fileio.c (Fcopy_file):
      If I is an integer, prefer 'if (I != 0)' to 'if (I)'.
      * src/lisp.h (UNGCPRO): Return void, not int.
      (FOR_EACH_TAIL): Use void expression, not int expression.
      * src/region-cache.c: Reindent.
      * src/region-cache.h: Copy comments from region-cache.c, to fix
      incorrect remarks about booleans.
      96c06863
  21. 13 Dec, 2013 1 commit
  22. 17 Oct, 2013 1 commit
    • Paul Eggert's avatar
      Make some functions static in non-Microsoft builds. · 3d798ba7
      Paul Eggert authored
      On my platform (Fedora 19 x86-64), this shrinks the
      Emacs executable (text+data) by 0.25%.
      * dispextern.h (erase_phys_cursor) [!WINDOWSNT]:
      (load_color) [!MSDOS]:
      * gnutls.h (emacs_gnutls_transport_set_errno) [!WINDOWSNT]:
      * keyboard.h (make_ctrl_char) [!WINDOWSNT]:
      * lisp.h (check_existing):
      * process.h (conv_sockaddr_to_lisp, network_interface_list)
      (network_interface_info) [!WINDOWSNT]:
      * termhooks.h (encode_terminal_code) [!WINDOWSNT]:
      Remove extern decls.
      * fileio.c (check_existing):
      * keyboard.c (make_ctrl_char) [!WINDOWSNT]:
      * process.c (conv_sockaddr_to_lisp, network_interface_list)
      (network_interface_info) [!WINDOWSNT]:
      * term.c (encode_terminal_code) [!WINDOWSNT]:
      * xdisp.c (erase_phys_cursor) [!WINDOWSNT]:
      * xfaces.c (load_color) [!MSDOS]:
      Now static.
      * fileio.c (check_existing, check_executable, check_writable):
      * process.c (network_interface_list, network_interface_info):
      Move earlier, so that we don't need forward decls.
      * gnutls.c (fn_gnutls_transport_set_errno)
      (emacs_gnutls_transport_set_errno) [!WINDOWNT]:
      Remove; unused.
      * w32.c (init_environment): Use faccessat rather than
      check_existing, partly for consistency with the rest of the code
      in this file, partly so that check_existing can be static.
      3d798ba7
  23. 10 Jul, 2013 1 commit
    • Paul Eggert's avatar
      Port to C89. · 29abe551
      Paul Eggert authored
      * lib-src/ebrowse.c (USAGE): Remove macro with too-long string literal ...
      (usage_message): ... and replace it with this new static constant
      containing multiple literals.  All uses changed.
      * lib-src/emacsclient.c (print_help_and_exit):
      Rewrite to avoid string literals longer than the C89 limits.
      (start_daemon_and_retry_set_socket):
      Rewrite to avoid non-constant array initializer.
      * lib-src/make-docfile.c (enum global_type): Omit trailing comma.
      * src/bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
      (B__dummy__): New dummy symbol, to pacify C89.
      * src/dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
      they can't grok varargs macros.
      * src/dispnew.c (add_window_display_history)
      (add_frame_display_history):
      * src/print.c (print_object):
      * src/xdisp.c (debug_method_add):
      Use %p printf format only for void pointers.
      * src/emacs.c (usage_message): New constant, replacing ...
      (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
      (main): Adjust to usage reorg.
      * src/fns.c (syms_of_fns):
      * src/profiler.c (syms_of_profiler):
      Don't use non-constant struct initializers.
      * src/gnutls.h (gnutls_initstage_t):
      * src/lisp.h (enum Lisp_Fwd_Type):
      * src/lread.c (lisp_file_lexically_bound_p):
      * src/xsettings.c (anonymous enum):
      Remove trailing comma.
      * src/xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
      * src/lisp.h (ENUM_BF): Use unsigned if pedantic.
      (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
      (DEFUN): Use it.
      * src/regex.c (const_re_char): New type, to pacify strict C89.
      All uses of 'const re_char' replaced to use it.
      * src/regex.h (_Restrict_): Rename from __restrict, to avoid clash
      with glibc when strict C89.  This change is imported from gnulib.
      All uses changed.
      (_Restrict_arr_): Rename from __restrict_arr, similarly.
      * src/sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
      Omit GNU_LINUX implementation, since it requires long long.
      * src/xterm.c (x_draw_underwave):
      Do not assume the traditional order of struct's members.
      (x_term_init): Rewrite to avoid the need for non-constant structure
      initializers.
      29abe551
  24. 01 Jan, 2013 1 commit
  25. 09 Apr, 2012 1 commit
    • Ted Zlatanov's avatar
      Limit number of GnuTLS handshakes per connection. · a18ecafa
      Ted Zlatanov authored
      * gnutls.c (gnutls_log_function2i): Convenience log function.
      (emacs_gnutls_read): Use new log functions,
      `gnutls_handshakes_tried' process member, and
      `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
      attempts per process (connection).
      
      * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.  Add
      convenience `GNUTLS_LOG2i' macro.
      
      * process.c (make_process):
      * process.h: Add integer `gnutls_handshakes_tried' member to
      process struct.
      a18ecafa
  26. 05 Jan, 2012 1 commit
  27. 27 Oct, 2011 2 commits
    • Chong Yidong's avatar
      More gnutls memory fixes. · 435c1d67
      Chong Yidong authored
      * src/gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
      non-NULL, regardless of GNUTLS_INITSTAGE.
      (Fgnutls_boot): Cleanups.  Call emacs_gnutls_deinit if we signal
      an error.  Set process slots as soon as we allocate them.
      
      * src/gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
      
      * src/process.c (make_process): Set gnutls_state to NULL.
      435c1d67
    • Chong Yidong's avatar
      Fix a memory leak in the built-in GnuTLS support. · 9c6c6f49
      Chong Yidong authored
      * src/gnutls.c (emacs_gnutls_deinit): New function.  Deallocate
      credentials structures as well as calling gnutls_deinit.
      (Fgnutls_deinit, Fgnutls_boot): Use it.
      
      * src/process.c (make_process): Initialize GnuTLS credentials to NULL.
      (deactivate_process): Call emacs_gnutls_deinit.
      9c6c6f49
  28. 21 Sep, 2011 1 commit
    • Paul Eggert's avatar
      * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp): · d311d28c
      Paul Eggert authored
      (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
      (string_bytes, check_sblock, allocate_string_data):
      (compact_small_strings, Fmake_bool_vector, make_string)
      (make_unibyte_string, make_multibyte_string)
      (make_string_from_bytes, make_specified_string)
      (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
      (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
      (mark_vectorlike):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (allocate_pseudovector):
      Use int, not EMACS_INT, where int is wide enough.
      (inhibit_garbage_collection, Fgarbage_collect):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
      int might not be wide enough.
      (bidi_cache_search, bidi_cache_find, bidi_init_it)
      (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
      (bidi_at_paragraph_end, bidi_find_paragraph_start)
      (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
      (bidi_level_of_next_char, bidi_move_to_visually_next):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
      (Fkill_buffer, Fset_buffer_major_mode)
      (advance_to_char_boundary, Fbuffer_swap_text)
      (Fset_buffer_multibyte, overlays_at, overlays_in)
      (overlay_touches_p, struct sortvec, record_overlay_string)
      (overlay_strings, recenter_overlay_lists)
      (adjust_overlays_for_insert, adjust_overlays_for_delete)
      (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
      (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
      (Foverlay_recenter, last_overlay_modification_hooks_used)
      (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (validate_region): Omit unnecessary test for b <= e, since
      that's guaranteed by the previous test.
      (adjust_overlays_for_delete): Avoid pos + length overflow.
      (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
      (report_overlay_modification):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
      Omit pointer cast, which isn't needed anyway, and doesn't work
      after the EMACS_INT -> ptrdiff_t change.
      * buffer.h: Adjust decls to match defn changes elsewhere.
      (struct buffer_text, struct buffer):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      Use EMACS_INT, not int, where int might not be wide enough.
      * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, to avoid
      needless 32-bit limit on 64-bit hosts.  Remove unnecessary
      memory-full test.  Use EMACS_INT, not ptrdiff_t or int, where
      ptrdiff_t or int might not be wide enough.
      * callint.c (Fcall_interactively):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * callproc.c (call_process_kill, Fcall_process):
      Don't assume pid_t fits into an Emacs fixnum.
      (call_process_cleanup, Fcall_process, child_setup):
      Don't assume pid_t fits into int.
      (call_process_cleanup, Fcall_process, delete_temp_file)
      (Fcall_process_region):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Fcall_process): Simplify handling of volatile integers.
      Use int, not EMACS_INT, where int will do.
      * casefiddle.c (casify_object, casify_region, operate_on_word)
      (Fupcase_word, Fdowncase_word, Fcapitalize_word):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (casify_object): Avoid integer overflow when overallocating buffer.
      * casetab.c (set_identity, shuffle): Prefer int to unsigned when
      either works.
      * category.c (Fchar_category_set): Don't assume fixnum fits in int.
      * category.h (CATEGORYP): Don't assume arg is nonnegative.
      * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
      integers are now checked earlier.  All uses replaced with XINT.
      (ccl_driver):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      For CCL_MapSingle, check that content and value are in int range.
      (resolve_symbol_ccl_program): Check that vector header is in range.
      Always copy the vector, so that we can check its contents reliably
      now rather than having to recheck each instruction as it's being
      executed.  Check that vector words fit in 'int'.
      (ccl_get_compiled_code, Fregister_ccl_program)
      (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
      program indexes, to avoid needless 32-bit limit on 64-bit hosts.
      (Fccl_execute, Fccl_execute_on_string): Check that initial reg
      contents are in range.
      (Fccl_execute_on_string): Check that status is in range.
      * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
      * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
      Accept and return EMACS_INT, not int, because callers can pass values
      out of 'int' range.
      (c_string_width, strwidth, lisp_string_width, chars_in_text)
      (multibyte_chars_in_text, parse_str_as_multibyte)
      (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
      (str_as_unibyte, str_to_unibyte, string_count_byte8)
      (string_escape_byte8, Fget_byte):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Funibyte_string): Use CHECK_CHARACTER, not CHECK_NATNUM, to
      avoid mishandling large integers.
      * character.h: Adjust decls to match defn changes elsewhere.
      * charset.c (load_charset_map_from_file, find_charsets_in_text)
      (Ffind_charset_region):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (load_charset_map_from_file): Redo idx calculation to avoid overflow.
      (load_charset_map_from_vector, Fdefine_charset_internal):
      Don't assume fixnum fits in int or unsigned int.
      (load_charset_map_from_vector, Fmap_charset_chars):
      Remove now-unnecessary CHECK_NATNUMs.
      (Fdefine_charset_internal): Check ranges here, more carefully.
      * chartab.c (Fmake_char_table, Fset_char_table_range)
      (uniprop_get_decoder, uniprop_get_encoder):
      Don't assume fixnum fits in int.
      * cmds.c (move_point): New function, that does the gist of
      Fforward_char and Fbackward_char, but does so while checking
      for integer overflow more accurately.
      (Fforward_char, Fbackward_char, internal_self_insert): Use it.
      (Fforward_line, Fend_of_line, internal_self_insert)
      (internal_self_insert):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      Fix a FIXME, by checking for integer overflow when calculating
      target_clm and actual_clm.
      * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
      (ASSURE_DESTINATION, coding_alloc_by_realloc)
      (coding_alloc_by_making_gap, alloc_destination)
      (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
      (encode_coding_utf_16, detect_coding_emacs_mule)
      (decode_coding_emacs_mule, encode_coding_emacs_mule)
      (detect_coding_iso_2022, decode_coding_iso_2022)
      (encode_invocation_designation, encode_designation_at_bol)
      (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
      (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
      (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
      (encode_coding_ccl, encode_coding_raw_text)
      (detect_coding_charset, decode_coding_charset)
      (encode_coding_charset, detect_eol, decode_eol, produce_chars)
      (produce_composition, produce_charset, produce_annotation)
      (decode_coding, handle_composition_annotation)
      (handle_charset_annotation, consume_chars, decode_coding_gap)
      (decode_coding_object, encode_coding_object, detect_coding_system)
      (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
      (code_convert_region, code_convert_string)
      (Fdefine_coding_system_internal):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
      (Fdefine_coding_system_internal):
      Don't assume fixnums fit in int.
      (decode_coding_gap, decode_coding_object, encode_coding_object)
      (Fread_coding_system, Fdetect_coding_region, Funencodable_char_position)
      (Fcheck_coding_systems_region):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
      (Fdefine_coding_system_internal): Check for charset-id overflow.
      * coding.h: Adjust decls to match defn changes elsewhere.
      (struct coding_system):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * composite.c (get_composition_id, find_composition)
      (run_composition_function, update_compositions)
      (compose_text, composition_gstring_put_cache)
      (composition_gstring_p, composition_gstring_width)
      (fill_gstring_header, fill_gstring_body, autocmp_chars)
      (composition_compute_stop_pos, composition_reseat_it)
      (composition_update_it, struct position_record)
      (find_automatic_composition, composition_adjust_point)
      (Fcomposition_get_gstring, Ffind_composition_internal):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (update_compositions):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * composite.h: Adjust decls to match defn changes elsewhere.
      (struct composition):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
      Do not attempt to compute the address of the object just before a
      buffer; this is not portable.
      (Faref, Faset):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Faset): Use int, not EMACS_INT, where int is wide enough.
      (Fstring_to_number): Don't assume fixnums fit in int.
      (Frem): Don't assume arg is nonnegative.
      * dbusbind.c (xd_append_arg): Check for integers out of range.
      (Fdbus_call_method): Don't overflow the timeout int.
      * dired.c (directory_files_internal, file_name_completion, scmp)
      (file_name_completion_stat):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (file_name_completion): Don't overflow matchcount.
      (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
      * dispextern.h: Adjust decls to match defn changes elsewhere.
      (struct text_pos, struct glyph, struct bidi_saved_info)
      (struct bidi_string_data, struct bidi_it, struct composition_it)
      (struct it):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (struct display_pos, struct composition_it, struct it):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * dispnew.c (increment_matrix_positions)
      (increment_row_positions, mode_line_string)
      (marginal_area_string):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (change_frame_size_1, Fredisplay):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (duration_to_sec_usec): New function, to check for overflow better.
      (Fsleep_for, sit_for): Use it.
      * doc.c (get_doc_string, store_function_docstring):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (get_doc_string, Fsnarf_documentation):
      Use int, not EMACS_INT, where int is wide enough.
      (get_doc_string):
      Use SAFE_ALLOCA, not alloca.
      Check for overflow when converting EMACS_INT to off_t.
      * doprnt.c (doprnt):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
      Don't assume uid_t fits into fixnum.
      (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
      (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
      (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
      (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
      (general_insert_function)
      (Finsert_char, make_buffer_string, make_buffer_string_both)
      (update_buffer_properties, Fbuffer_substring)
      (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
      (Fsubst_char_in_region, check_translation)
      (Ftranslate_region_internal, save_restriction_restore, Fformat)
      (transpose_markers, Ftranspose_regions):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (clip_to_bounds): Move to lisp.h as an inline function).
      (Fconstrain_to_field): Don't assume integers are nonnegative.
      (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
      (Fsubst_char_in_region, Fsave_restriction):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Femacs_pid): Don't assume pid_t fits into fixnum.
      (lo_time): Use int, not EMACS_INT, when int suffices.
      (lisp_time_argument): Check for usec out of range.
      (Fencode_time): Don't assume fixnum fits in int.
      * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
      (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
      (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
      (init_cmdargs, Fdump_emacs):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
      the bottom (typically) 32 bits of the fixnum.
      * eval.c (specpdl_size, call_debugger):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (when_entered_debugger, Fbacktrace_debug):
      Don't assume fixnum can fit in int.
      (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
      the object just before a buffer; this is not portable.
      (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
      (grow_specpdl, unbind_to):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
      (grow_specpdl): Simplify allocation by using xpalloc.
      * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
      (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
      (a_write, e_write):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fcopy_file, non_regular_nbytes, read_non_regular)
      (Finsert_file_contents):
      Use int, not EMACS_INT, where int is wide enough.
      (READ_BUF_SIZE): Verify that it fits in int.
      (Finsert_file_contents): Check that counts are in proper range,
      rather than assuming fixnums fit into ptrdiff_t etc.
      Don't assume fixnums fit into int.
      (Fdo_auto_save, Fset_buffer_auto_saved)
      (Fclear_buffer_auto_save_failure):
      Don't assume time_t is signed, or that it fits in int.
      * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec)
      (concat, string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
      (string_char_to_byte, string_byte_to_char)
      (string_make_multibyte, string_to_multibyte)
      (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
      (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
      (substring_both, Fdelete, internal_equal, Ffillarray)
      (Fclear_string, mapcar1)
      (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
      (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
      (larger_vector, make_hash_table, maybe_resize_hash_table)
      (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
      (Fmaphash, secure_hash):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (concat): Check for string index and length overflow.
      (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
      (Frequire):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (larger_vector): New API (vec, incr_min, size_max) replaces old
      one (vec, new_size, init).  This catches size overflow.
      INIT was removed because it was always Qnil.
      All callers changed.
      (INDEX_SIZE_BOUND): New macro, which calculates more precisely
      the upper bound on a hash table index size.
      (make_hash_table, maybe_resize_hash_table): Use it.
      (secure_hash): Computer start_byte and end_byte only after
      they're known to be in ptrdiff_t range.
      * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
      (Ffont_get_glyphs, Ffont_at):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
      (Flist_fonts, Fopen_font):
      Don't assume fixnum can fit in int.
      (check_gstring): Don't assume index can fit in int.
      (font_match_p): Check that fixnum is a character, not a nonnegative
      fixnum, since the later code needs to stuff it into an int.
      (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
      (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
      conversion overflow issues.
      (Fopen_font): Check for integer out of  range.
      (Ffont_get_glyphs): Don't assume index can fit in int.
      * font.h: Adjust decls to match defn changes elsewhere.
      * fontset.c (reorder_font_vector): Redo score calculation to avoid
      integer overflow.
      (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
      printmax_t, where ptrdiff_t is wide enough.
      (Finternal_char_font):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
      (Fset_frame_height, Fset_frame_width, Fset_frame_size)
      (Fset_frame_position, x_set_frame_parameters)
      (x_set_line_spacing, x_set_border_width)
      (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
      Check that fixnums are in proper range for system types.
      (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fmodify_frame_parameters): Don't assume fixnum fits in int.
      Use SAFE_ALLOCA_LISP, not alloca.
      * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
      intptr_t is wide enough.
      * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
      (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
      (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
      Check for fixnum out of range.
      * ftfont.c (ftfont_list): Don't assume index fits in int.
      Check that fixnums are in proper range for system types.
      (ftfont_shape_by_flt):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      Remove no-longer-needed lint_assume.
      * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
      Check that fixnums are in proper range for system types.
      * gnutls.h: Adjust decls to match defn changes elsewhere.
      * gtkutil.c (xg_dialog_run):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (update_frame_tool_bar):
      Check that fixnums are in proper range for system types.
      * image.c (parse_image_spec): Redo count calculation to avoid overflow.
      (lookup_image): Check that fixnums are in proper range for system types.
      * indent.c (last_known_column, last_known_column_point):
      (current_column_bol_cache):
      (skip_invisible, current_column, check_display_width):
      (check_display_width, scan_for_column, current_column_1)
      (Findent_to, Fcurrent_indentation, position_indentation)
      (indented_beyond_p, Fmove_to_column, compute_motion):
      (Fcompute_motion, Fvertical_motion):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (last_known_column_modified): Use EMACS_INT, not int.
      (check_display_width):
      (Fcompute_motion):
      Check that fixnums and floats are in proper range for system types.
      (compute_motion): Don't assume index or fixnum fits in int.
      (compute_motion, Fcompute_motion):
      Use int, not EMACS_INT, when it is wide enough.
      (vmotion): Omit local var start_hpos that is always 0; that way
      we don't need to worry about overflow in expressions involving it.
      * indent.h: Adjust decls to match defn changes elsewhere.
      (struct position):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      Use int, not EMACS_INT, where int is wide enough.
      Remove unused members ovstring_chars_done and tab_offset;
      all uses removed.
      * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
      (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
      (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
      (make_gap, copy_text, insert, insert_and_inherit)
      (insert_before_markers, insert_before_markers_and_inherit)
      (insert_1, count_combining_before, count_combining_after)
      (insert_1_both, insert_from_string)
      (insert_from_string_before_markers, insert_from_string_1)
      (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
      (adjust_after_replace, adjust_after_insert, replace_range)
      (replace_range_2, del_range, del_range_1, del_range_byte)
      (del_range_both, del_range_2, modify_region)
      (prepare_to_modify_buffer, signal_before_change)
      (signal_after_change, Fcombine_after_change_execute):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * intervals.c (traverse_intervals, rotate_right, rotate_left)
      (balance_an_interval, split_interval_right, split_interval_left)
      (find_interval, next_interval, update_interval)
      (adjust_intervals_for_insertion, delete_node, delete_interval)
      (interval_deletion_adjustment, adjust_intervals_for_deletion)
      (static_offset_intervals, offset_intervals)
      (merge_interval_right, merge_interval_left, make_new_interval)
      (graft_intervals_into_buffer, temp_set_point_both)
      (temp_set_point, set_point, adjust_for_invis_intang)
      (set_point_both, move_if_not_intangible, get_property_and_range)
      (get_local_map, copy_intervals, copy_intervals_to_string)
      (compare_string_intervals, set_intervals_multibyte_1):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * intervals.h: Adjust decls to match defn changes elsewhere.
      (struct interval):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * keyboard.c (this_command_key_count, this_single_command_key_start)
      (before_command_key_count, before_command_echo_length, echo_now)
      (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
      (command_loop_1, safe_run_hooks, read_char, timer_check_2)
      (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
      (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (last_non_minibuf_size, last_point_position, echo_truncate)
      (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
      (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
      (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
      (stuff_buffered_input):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (last_auto_save, command_loop_1, read_char):
      Use EMACS_INT, not int, to avoid integer overflow.
      (record_char): Avoid overflow in total_keys computation.
      (parse_modifiers_uncached): Redo index calculation to avoid overflow.
      * keyboard.h: Adjust decls to match defn changes elsewhere.
      * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
      (Fkey_description, Fdescribe_vector, Flookup_key):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (click_position): New function, to check that positions are in range.
      (Fcurrent_active_maps):
      (describe_command):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Faccessible_keymaps, Fkey_description):
      (preferred_sequence_p):
      Don't assume fixnum can fit into int.
      (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
      Check for integer overflow in size calculations.
      (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
      avoid mishandling large integers.
      * lisp.h: Adjust decls to match defn changes elsewhere.
      (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
      (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
      (struct Lisp_Marker):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (clip_to_bounds): Now an inline function, moved here from editfns.c.
      (XSETSUBR): Use size of 0 since the actual size doesn't matter,
      and using 0 avoids overflow.
      (GLYPH_CODE_P): Check for overflow in system types, subsuming the
      need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
      All callers changed.
      (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
      Assume the arg has valid form, since it always does.
      (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
      unsigned integer system type.
      (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
      (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
      (duration_to_sec_usec): New decl.
      * lread.c (read_from_string_index, read_from_string_index_byte)
      (read_from_string_limit, readchar, unreadchar, openp)
      (read_internal_start, read1, oblookup):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fload, readevalloop, Feval_buffer, Feval_region):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (openp): Check for out-of-range argument to 'access'.
      (read1): Use int, not EMACS_INT, where int is wide enough.
      Don't assume fixnum fits into int.
      * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
      in size calculation.
      (Fexecute_kbd_macro):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * marker.c (cached_charpos, cached_bytepos, CONSIDER)
      (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
      (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
      (set_marker_both, set_marker_restricted_both, marker_position)
      (marker_byte_position, Fbuffer_has_markers_at):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
      * menu.c (ensure_menu_items): Renamed from grow_menu_items.
      It now merely ensures that the menu is large enough, without
      necessarily growing it, as this avoids some integer overflow issues.
      All callers changed.
      (keymap_panes, parse_single_submenu, Fx_popup_menu):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
      Use SAFE_ALLOCA_LISP, not alloca.
      (find_and_return_menu_selection): Avoid unnecessary casts of pointers
      to EMACS_INT.  Check that fixnums are in proper range for system types.
      * minibuf.c (minibuf_prompt_width, string_to_object)
      (Fminibuffer_contents, Fminibuffer_contents_no_properties)
      (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (get_minibuffer, read_minibuf_unwind):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
      this simplifies overflow checking.  All callers changed.
      (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
      (Ftest_completion):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
      (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
      Check that fixnums are in proper range for system types.
      (Fx_create_frame, Fx_show_tip):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * nsfont.m (ns_findfonts, nsfont_list_family):
      Don't assume fixnum fits in long.
      * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
      wide enough.
      * nsselect.m (ns_get_local_selection):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
      (PRINTDECLARE, PRINTPREPARE):
      (strout, print_string):
      (print, print_preprocess, print_check_string_charset_prop)
      (print_object):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (PRINTDECLARE):
      (temp_output_buffer_setup, Fprin1_to_string, print_object):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
      (PRINTFINISH): Use SAFE_ALLOCA, not alloca.
      (printchar, strout): Use xpalloc to catch size calculation overflow.
      (Fexternal_debugging_output): Use CHECK_CHARACTER, not CHECK_NUMBER,
      to avoid mishandling large integers.
      (print_error_message): Use SAFE_ALLOCA, not alloca.
      (print_object): Use int, not EMACS_INT, where int is wide enough.
      * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
      (Fset_process_window_size, Fformat_network_address)
      (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
      (Fsignal_process, sigchld_handler):
      Check that fixnums are in proper range for system types.
      (Fformat_network_address, read_process_output, send_process)
      (Fprocess_send_region, status_notify):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
      (wait_reading_process_output, read_process_output, exec_sentinel):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
      (Faccept_process_output): Use duration_to_sec_usec to do proper
      overflow checking on durations.
      * scroll.c (calculate_scrolling, calculate_direct_scrolling)
      (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
      * search.c (looking_at_1, string_match_1):
      (fast_string_match, fast_c_string_match_ignore_case)
      (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
      (scan_newline, find_before_next_newline, search_command)
      (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
      (set_search_regs, wordify):
      (Freplace_match):
      (Fmatch_data):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (string_match_1, search_buffer, set_search_regs):
      (Fmatch_data):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (wordify): Check for overflow in size calculation.
      (Freplace_match): Avoid potential buffer overflow in search_regs.start.
      (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
      Check that fixnums are in proper range for system types.
      * sound.c (struct sound_device)
      (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fplay_sound_internal):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * syntax.c (ST_COMMENT_STYLE, ST_STRING_STYLE):
      In definitions, make it clearer that these values must be out of range
      for the respective integer ranges.  This fixes a bug with ST_STRING_STYLE
      and non-ASCII characters.
      (struct lisp_parse_state, find_start_modiff)
      (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
      (Fparse_partial_sexp):
      Don't assume fixnums can fit in int.
      (struct lisp_parse_state, find_start_pos, find_start_value)
      (find_start_value_byte, find_start_begv)
      (update_syntax_table, char_quoted, dec_bytepos)
      (find_defun_start, prev_char_comend_first, back_comment):
      (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
      (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Finternal_describe_syntax_value): Check that match_lisp is a
      character, not an integer, since the code stuffs it into int.
      (scan_words, scan_sexps_forward):
      Check that fixnums are in proper range for system types.
      (Fforward_word):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (scan_sexps_forward):
      Use CHARACTERP, not INTEGERP, since the value must fit into int.
      (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
      * syntax.h: Adjust decls to match defn changes elsewhere.
      (struct gl_state_s):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * sysdep.c (wait_for_termination_1, wait_for_termination)
      (interruptible_wait_for_termination, mkdir):
      Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
      (emacs_read, emacs_write):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (system_process_attributes): Don't assume uid_t, gid_t, and
      double all fit in int or even EMACS_INT.
      * term.c (set_tty_color_mode):
      Check that fixnums are in proper range for system types.
      * termhooks.h (struct input_event):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * textprop.c (validate_interval_range, interval_of)
      (Fadd_text_properties, set_text_properties_1)
      (Fremove_text_properties, Fremove_list_of_text_properties)
      (Ftext_property_any, Ftext_property_not_all)
      (copy_text_properties, text_property_list, extend_property_ranges)
      (verify_interval_modification):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fnext_single_char_property_change)
      (Fprevious_single_char_property_change):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (copy_text_properties): Check for integer overflow in index calculation.
      * undo.c (last_boundary_position, record_point, record_insert)
      (record_delete, record_marker_adjustment, record_change)
      (record_property_change):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
      (Fx_hide_tip, Fx_file_dialog):
      * w32menu.c (set_frame_menubar):
      Use ptrdiff_t, not int, for consistency with rest of code.
      * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
      (select_window, Fdelete_other_windows_internal)
      (window_scroll_pixel_based, window_scroll_line_based)
      (Frecenter, Fset_window_configuration):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (Fset_window_hscroll, run_window_configuration_change_hook)
      (set_window_buffer, temp_output_buffer_show, scroll_command)
      (Fscroll_other_window):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
      Don't assume fixnum fits in int.
      (Fset_window_scroll_bars):
      Check that fixnums are in proper range for system types.
      * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
      (string_pos, c_string_pos, number_of_chars, init_iterator)
      (in_ellipses_for_invisible_text_p, init_from_display_pos)
      (compute_stop_pos, next_overlay_change, compute_display_string_pos)
      (compute_display_string_end, handle_face_prop)
      (face_before_or_after_it_pos, handle_invisible_prop, handle_display_prop)
      (handle_display_spec, handle_single_display_spec)
      (display_prop_intangible_p, string_buffer_position_lim)
      (string_buffer_position, handle_composition_prop, load_overlay_strings)
      (get_overlay_strings_1, get_overlay_strings)
      (iterate_out_of_display_property, forward_to_next_line_start)
      (back_to_previous_visible_line_start, reseat, reseat_to_string)
      (get_next_display_element, set_iterator_to_next)
      (get_visually_first_element, compute_stop_pos_backwards)
      (handle_stop_backwards, next_element_from_buffer)
      (move_it_in_display_line_to, move_it_in_display_line)
      (move_it_to, move_it_vertically_backward, move_it_by_lines)
      (add_to_log, message_dolog, message_log_check_duplicate)
      (message2, message2_nolog, message3, message3_nolog
      (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
      (current_message_1, truncate_echo_area, truncate_message_1)
      (set_message, set_message_1, store_mode_line_noprop)
      (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
      (text_outside_line_unchanged_p, check_point_in_composition)
      (reconsider_clip_changes)
      (redisplay_internal, set_cursor_from_row, try_scrolling)
      (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
      (redisplay_window, find_last_unchanged_at_beg_row)
      (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
      (trailing_whitespace_p, find_row_edges, display_line)
      (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
      (display_mode_element, store_mode_line_string)
      (pint2str, pint2hrstr, decode_mode_spec)
      (display_count_lines, display_string, draw_glyphs)
      (x_produce_glyphs, x_insert_glyphs)
      (rows_from_pos_range, mouse_face_from_buffer_pos)
      (fast_find_string_pos, mouse_face_from_string_pos)
      (note_mode_line_or_margin_highlight, note_mouse_highlight):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (safe_call, init_from_display_pos, handle_fontified_prop)
      (handle_single_display_spec, load_overlay_strings)
      (with_echo_area_buffer, setup_echo_area_for_printing)
      (display_echo_area, echo_area_display)
      (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
      (update_tool_bar, hscroll_window_tree, redisplay_internal)
      (redisplay_window, dump_glyph_row, display_mode_line, Fformat_mode_line)
      (decode_mode_spec, on_hot_spot_p):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (handle_single_display_spec, build_desired_tool_bar_string)
      (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
      (get_specified_cursor_type):
      Check that fixnums are in proper range for system types.
      (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
      (Flookup_image_map):
      Don't assume fixnums fit in int.
      (compare_overlay_entries):
      Avoid mishandling comparisons due to subtraction overflow.
      (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
      (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
      (handle_tool_bar_click):
      Use int, not unsigned, since we prefer signed and the signedness
      doesn't matter here.
      (get_next_display_element, next_element_from_display_vector):
      Use int, not EMACS_INT, when int is wide enough.
      (start_hourglass): Use duration_to_sec_usec to do proper
      overflow checking on durations.
      * xfaces.c (Fbitmap_spec_p):
      Check that fixnums are in proper range for system types.
      (compare_fonts_by_sort_order):
      Avoid mishandling comparisons due to subtraction overflow.
      (Fx_family_fonts, realize_basic_faces):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Fx_family_fonts):
      Don't assume fixnum fits in int.
      Use SAFE_ALLOCA_LISP, not alloca.
      (merge_face_heights): Remove unnecessary cast to EMACS_INT.
      (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
      (face_at_buffer_position, face_for_overlay_string)
      (face_at_string_position):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      (merge_faces): Use int, not EMACS_INT, where int is wide enough.
      * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
      (Fx_show_tip):
      Check that fixnums are in proper range for system types.
      (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
      (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (Fx_change_window_property): Don't assume fixnums fit in int.
      * xfont.c (xfont_chars_supported):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * xmenu.c (Fx_popup_dialog, set_frame_menubar)
      (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * xml.c (parse_region):
      * xrdb.c (magic_file_p):
      Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
      * xselect.c (TRACE1): Don't assume pid_t promotes to int.
      (x_get_local_selection, x_reply_selection_request)
      (x_handle_selection_request, wait_for_property_change):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      (selection_data_to_lisp_data): Use short, not EMACS_INT, where
      short is wide enough.
      (x_send_client_event): Don't assume fixnum fits in int.
      * xterm.c (x_x_to_emacs_modifiers):
      Don't assume EMACS_INT overflows nicely into int.
      (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
      may come from Lisp.
      (handle_one_xevent): NATNUMP can eval its arg twice.
      (x_connection_closed):
      Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
      * xterm.h: Adjust decls to match defn changes elsewhere.
      (struct scroll_bar): Use struct vectorlike_header
      rather than rolling our own approximation.
      (SCROLL_BAR_VEC_SIZE): Remove; not used.
      d311d28c
  29. 04 May, 2011 2 commits
    • Juanma Barranquero's avatar
      src/gnutls.c: Remove unused parameter `fildes'. · e968f4f3
      Juanma Barranquero authored
      * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
      * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
        Remove unused parameter `fildes'.
      * process.c (read_process_output, send_process): Don't pass it.
      e968f4f3
    • Juanma Barranquero's avatar
      Implement dynamic loading of GnuTLS on Windows. · 0898ca10
      Juanma Barranquero authored
      * lisp/term/w32-win.el (dynamic-library-alist): Add `gnutls'.
      
      * nt/INSTALL: Clarify GnuTLS support.
      
      * src/callproc.c, src/emacs.c: Include lisp.h before src/w32.h, not after.
      
      * src/gnutls.c (Qgnutls_dll): Define.
        (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
        (gnutls_*): Declare function pointers.
        (init_gnutls_functions): New function to initialize function pointers.
        (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
        (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
        (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
        Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
        (emacs_gnutls_write, emacs_gnutls_read)
        (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
        (Fgnutls_available_p): New function.
        (Fgnutls_boot): Call Fgnutls_available_p.  Use function pointers.
        (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
        (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
      
      * src/gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
        (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
        (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
        Declare.
      
      * src/w32.c (QCloaded_from, Vlibrary_cache): Define.
        (w32_delayed_load): Move from image.c.  When loading a library, record
        its filename in the :loaded-from property of the library id.
        (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
        Initialize and staticpro them.
        (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
      
      * src/image.c: Include w32.h.
        (Vimage_type_cache): Delete.
        (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
        (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
        (w32_delayed_load): Move to w32.c.
      
      * src/process.c: Include lisp.h before src/w32.h, not after.
        (wait_reading_process_output): Call emacs_gnutls_record_check_pending
        instead of gnutls_record_check_pending.
      
      * src/w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
      0898ca10
  30. 25 Apr, 2011 1 commit
    • Ted Zlatanov's avatar
      Add GnuTLS support for W32 and certificate and hostname verification in GnuTLS. · e061a11b
      Ted Zlatanov authored
      * src/gnutls.c: Renamed global_initialized to
      gnutls_global_initialized.  Added internals for the
      :verify-hostname-error, :verify-error, and :verify-flags
      parameters of `gnutls-boot' and documented those parameters in the
      docstring.  Start callback support.
      (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
      unless a fatal error occured. Call gnutls_alert_send_appropriate
      on error. Return error code.
      (emacs_gnutls_write): Call emacs_gnutls_handle_error.
      (emacs_gnutls_read): Likewise.
      (Fgnutls_boot): Return handshake error code.
      (emacs_gnutls_handle_error): New function.
      (wsaerror_to_errno): Likewise.
      
      * src/gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
      callbacks stage.
      
      * src/w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
      (emacs_gnutls_push): Likewise.
      
      * src/w32.h (emacs_gnutls_pull): Add prototype.
      (emacs_gnutls_push): Likewise.
      e061a11b
  31. 15 Apr, 2011 1 commit
  32. 13 Apr, 2011 1 commit
    • Paul Eggert's avatar
      emacs_write: Return size_t, not ssize_t, to avoid overflow issues. · 273a5f82
      Paul Eggert authored
      * gnutls.c, gnutls.h (emacs_gnutls_write): Return size_t, not ssize_t.
      * sysdep.c, lisp.h (emacs_write): Likewise.
      Without the above change, emacs_gnutls_write and emacs_write had
      undefined behavior and would typically mistakenly report an error
      when writing a buffer whose size exceeds SSIZE_MAX.
      (emacs_read, emacs_write): Remove check for negative size, as the
      Emacs source code has been audited now.
      (emacs_write): Adjust to new signature, making the code look more
      like that of emacs_gnutls_write.
      * process.c (send_process): Adjust to the new signatures of
      emacs_write and emacs_gnutls_write.  Do not attempt to store
      a byte offset into an 'int'; it might overflow.
      273a5f82
  33. 10 Apr, 2011 1 commit
    • Jim Meyering's avatar
      use ssize_t and size_t for read- and write-like emacs_gnutls_* functions · 368f4090
      Jim Meyering authored
      * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
      return ssize_t not "int", and use size_t as the buffer length.
      (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
      * gnutls.h: Update declarations.
      * process.c (read_process_output): Use ssize_t, to match.
      (send_process): Likewise.
      368f4090
  34. 25 Jan, 2011 1 commit
  35. 15 Jan, 2011 1 commit