1. 04 Jul, 2014 1 commit
    • Eli Zaretskii's avatar
      Fix bug #17905 with display of point in partially visible line at end of window. · 5b5953c0
      Eli Zaretskii authored
       src/xdisp.c (redisplay_window): If redisplay of a window ends up
       with point in a partially visible line at end of the window, make
       sure the amended position of point actually has smaller Y
       coordinate; if not, give up and scroll the display.
       src/window.c (window_scroll_pixel_based): When point ends up at the
       last fully visible line, don't let move_it_to stop at the left
       edge of the line and dupe us into thinking point is inside the
       scroll margin.
      5b5953c0
  2. 17 Jun, 2014 1 commit
    • Paul Eggert's avatar
      Omit redundant extern decls. · 73bfe891
      Paul Eggert authored
      Most of this patch is from Dmitry Antipov, in:
      http://lists.gnu.org/archive/html/emacs-devel/2014-06/msg00263.html
      * configure.ac (WERROR_CFLAGS): Add -Wredundant-decls.
      * lib-src/emacsclient.c (getenv): Remove decl.
      * lib-src/make-docfile.c (write_globals): Add ATTRIBUTE_CONST for
      Fbyteorder, Ftool_bar_height, Fmax_char, Fidentity.
      * lwlib/lwlib-Xm.c (lw_motif_widget_p, xm_update_one_value)
      (xm_create_dialog, xm_destroy_instance, xm_popup_menu)
      (xm_set_keyboard_focus, xm_set_main_areas): Remove decls.
      * src/commands.h (update_mode_lines):
      * src/frame.h (Qbackground_color, Qforeground_color)
      (x_set_menu_bar_lines):
      * src/ftfont.c (ftfont_font_format):
      * src/intervals.h (Qkeymap, Qfont):
      * src/keyboard.c (timer_check, safe_run_hooks, Qregion_extract_function):
      * src/lisp.h (Ffboundp, Qnil, Qt, Qlambda, Qintegerp, Qwholenump)
      (Qsymbolp, Qlisp, Qconsp, Qstringp, Qarrayp, Qbufferp, Qmarkerp)
      (Qvectorp, Qbuffer_or_string_p, Qchar_table_p, Qvector_or_char_table_p)
      (Qfloatp, Qnumberp, Qfont_spec, Qfont_entity, Qfont_object)
      (Fbyteorder, wrong_type_argument, Fmax_char, syms_of_composite)
      (Fidentity, extract_float, init_display, syms_of_display, Qdisplay):
      (Qimage, Qbox, redisplay_preserve_echo_area, char_table_ref)
      (char_table_set, char_table_translate, Qautoload, Qbottom, Qtop)
      (Qvisible, Qfont, Qfront_sticky, Qrear_nonsticky, init_sigio)
      (Qtool_bar, Qheader_line):
      * src/macros.c (Fexecute_kbd_macro):
      * src/xdisp.c (Ftool_bar_height, Ftool_bar_height):
      * src/xterm.c (x_delete_terminal, XSetIMValues):
      * src/xterm.h (x_set_window_size, x_query_color, x_get_focus_frame)
      (x_implicitly_set_name, popup_activated)
      (widget_store_internal_border):
      Remove redundant decls.
      * src/frame.c [USE_X_TOOLKIT]: Include widget.h.
      * src/keyboard.c (Fexit_recursive_edit, Fabort_recursive_edit):
      Remove _Noreturn, as make-docfile now does that for us.
      * src/lisp.h (DEFUN): Don't declare fnname here; rely on make-docfile.
      (Qregion_extract_function): New decl.
      * src/window.c, src/xfns.c: Include menu.h.
      73bfe891
  3. 06 Jun, 2014 1 commit
  4. 29 Apr, 2014 1 commit
    • Stefan Monnier's avatar
      * src/window.c (struct saved_window): Remove mark. · 4d89ee37
      Stefan Monnier authored
      (Fset_window_configuration, save_window_save)
      (compare_window_configurations): Don't touch marks any more.
      * doc/lispref/windows.texi (Window Configurations, Window Configurations):
      Window configs don't store marks any more.
      4d89ee37
  5. 24 Apr, 2014 1 commit
  6. 16 Apr, 2014 1 commit
  7. 07 Mar, 2014 1 commit
    • Martin Rudalics's avatar
      Update docs for select-window and buffer-list-update-hook. · 2c6053e8
      Martin Rudalics authored
      * buffer.c (Vbuffer_list_update_hook): Doc-string fix.
      * window.c (Fselect_window): Explain NORECORD and
      `buffer-list-update-hook' in doc-string.
      * buffers.texi (The Buffer List): Rename node to Buffer List.
      Describe `buffer-list-update-hook'.
      * elisp.texi (Top): "The Buffer List" renamed to "Buffer List".
      Add node for Window Dividers.
      * hooks.texi (Standard Hooks): Add reference to
      `buffer-list-update-hook'.
      * windows.texi (Selecting Windows): Update description of
      `select-window'.
      2c6053e8
  8. 06 Mar, 2014 1 commit
    • Martin Rudalics's avatar
      More window code related fixes and documentation changes. · cac0a1d6
      Martin Rudalics authored
      * window.c (Fother_window_for_scrolling): Check that
      Vother_window_scroll_buffer is a buffer.
      * window.el (fit-frame-to-buffer, fit-frame-to-buffer-margins):
      Fix doc-strings.
      (fit-frame-to-buffer): New argument ONLY.  Remove dependency on
      fit-frame-to-buffer variable.  Fix doc-string.
      (fit-window-to-buffer): Set ONLY argument in call of
      fit-frame-to-buffer.  Fix doc-string.
      * frames.texi (Size and Position): Rewrite entries for
      `fit-frame-to-buffer' and `fit-frame-to-buffer-margins'.  Add
      description for `fit-frame-to-buffer-sizes'.
      * windows.texi (Resizing Windows): Add descriptions for
      pixelwise resizing.  Add entries for `window-resize-pixelwise'
      and `fit-window-to-buffer-horizontally'.  Rewrite
      `fit-window-to-buffer' entry.
      cac0a1d6
  9. 05 Mar, 2014 1 commit
    • Martin Rudalics's avatar
      Various window code related fixes and documentation changes. · e1a2cb1c
      Martin Rudalics authored
      * dispnew.c (change_frame_size_1): Add new_lines instead of
      new_height, the latter may be still zero if passed as such.
      * window.c (Fwindow_pixel_height): Mention bottom divider in
      doc-string.
      * window.el (window-min-height, window-min-width): Rewrite
      doc-strings.
      (window-body-size): Add PIXELWISE argument to make it consistent
      with its callees.
      * display.texi (Window Dividers): New section.
      * frames.texi (Layout Parameters): Add right-divider-width and
      bottom-divider-width.
      * windows.texi (Window Sizes): Redraw schematic and rewrite its
      description.  Rewrite descriptions of `window-total-height',
      `window-total-width', `window-total-size', `window-body-height',
      `window-body-width' and `window-size-fixed'.  Add descriptions
      for `window-pixel-height', `window-pixel-width',
      `window-min-height' and `window-min-width'.  Remove description
      of `window-size-fixed-p' moving part of it to that of
      `window-size-fixed'.
      (Resizing Windows): Mention dividers when talking about minimum
      sizes.
      e1a2cb1c
  10. 01 Mar, 2014 1 commit
  11. 27 Feb, 2014 1 commit
    • Martin Rudalics's avatar
      More fixes for mouse glyph calculations (Bug#16647). · 653b6ea3
      Martin Rudalics authored
      More fixes for mouse glyph calculations (Bug#16647).
      * window.c (coordinates_in_window): In intersection of
      horizontal and vertical window dividers prefer the horizontal
      one.  Add some extra parens to last fix.
      (window_relative_x_coord): Return x-coordinate for header and
      mode line too.
      * xdisp.c (remember_mouse_glyph): In text area don't extend
      glyph into mode line to show the vertical drag cursor there
      immediately.  Subdivide mouse glyphs in right fringes to show a
      horizontal drag cursor as soon as we enter the "grabbable width"
      portion.  Handle vertical border case separately.  Do not
      subdivide window divider areas.
      (note_mouse_highlight): On bottom divider of bottommost windows
      show vertical drag cursor only when the minibuffer window can be
      resized.
      653b6ea3
  12. 26 Feb, 2014 1 commit
    • Martin Rudalics's avatar
      Fixes around Bug#16647. · aea124c4
      Martin Rudalics authored
      * xdisp.c (remember_mouse_glyph): Handle ON_RIGHT_DIVIDER and
      ON_BOTTOM_DIVIDER cases.
      * window.c (coordinates_in_window): Return ON_VERTICAL_BORDER
      only if the window has no right divider.
      (Fcoordinates_in_window_p): Fix doc-string.
      aea124c4
  13. 22 Feb, 2014 1 commit
    • Glenn Morris's avatar
      Misc small frame/window doc · ca58fa73
      Glenn Morris authored
      * src/frame.c (frame-alpha-lower-limit, frame-resize-pixelwise):
      * src/window.c (window-resize-pixelwise): Doc fixes.
      
      * etc/NEWS: Related edits.
      This including unmarking some items marked as ---, where it it not
      clear to me that no doc updates are needed.
      ca58fa73
  14. 21 Feb, 2014 1 commit
    • Martin Rudalics's avatar
      Fix handling of window-min-height/-width (Bug#16738). · 8dd3e94f
      Martin Rudalics authored
      * window.el (window--dump-window, window--dump-frame): New
      functions.
      (window--min-size-1): Account for window dividers.  When
      window-resize-pixelwise is nil, delay rounding till after the
      sum of the window components has been calculated.
      (window--min-delta-1, window--max-delta-1): When PIXELWISE is
      nil make sure at least one text line and two text columns remain
      fully visible.
      (window-resize): Signal an error when window-resize-apply fails.
      (window--resize-child-windows): Fix calculation of by how many
      pixels a window can still be shrunk via window-new-normal.
      (adjust-window-trailing-edge): Call window--resizable with
      correct TRAIL argument.
      8dd3e94f
  15. 07 Feb, 2014 2 commits
  16. 22 Jan, 2014 1 commit
    • Martin Rudalics's avatar
      Fixes in window size functions around Bug#16430 and Bug#16470. · 6cb4da45
      Martin Rudalics authored
      * window.c (Fwindow_pixel_width, Fwindow_pixel_height)
      (Fwindow_mode_line_height, Fwindow_header_line_height)
      (Fwindow_right_divider_width, Fwindow_bottom_divider_width):
      Minor doc-string adjustments.
      (Fwindow_total_height, Fwindow_total_width): New argument ROUND.
      Rewrite doc-strings.
      (window_body_height, window_body_width): Do not count partially
      visible lines/columns when PIXELWISE is nil (Bug#16470).
      (Qfloor, Qceiling): New symbols.
      * window.el (window-total-size, window-size): New argument
      ROUND.
      (window--min-delta-1, window-min-delta, window--max-delta-1): Be
      more conservative when calculating the numbers of lines or
      columns a window can shrink (Bug#16430).
      (fit-window-to-buffer): Simplify code.
      * term.el (term-window-width): Call window-body-width again.
      6cb4da45
  17. 11 Jan, 2014 1 commit
    • Martin Rudalics's avatar
      Fix handling of internal borders (Bug#16348). · 7d7ccb88
      Martin Rudalics authored
      * dispnew.c (adjust_frame_glyphs_for_window_redisplay): Remove
      internal border width from pixel width of windows.
      (change_frame_size_1): Don't return early when frame's pixel
      size changes - we still have to record the new sizes in the
      frame structure.
      * w32fns.c (x_set_tool_bar_lines): Clear internal border width
      also when toolbar gets larger.
      * window.c (check_frame_size): Include internal_border_width in
      check.
      * xdisp.c (Ftool_bar_height): Fix doc-string typo.
      * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): In
      non-toolkit/non-GTK version clear internal border.
      * xterm.c (x_clear_under_internal_border): New function for
      non-toolkit/non-GTK version.
      (x_after_update_window_line): In non-toolkit/non-GTK version
      don't do that.
      (handle_one_xevent, x_set_window_size): Call
      x_clear_under_internal_border in non-toolkit/non-GTK version.
      * xterm.h (x_clear_under_internal_border): Extern it.
      7d7ccb88
  18. 02 Jan, 2014 1 commit
    • Martin Rudalics's avatar
      Further adjust frame/window scrollbar width calculations. · 44c5e192
      Martin Rudalics authored
      * window.c (apply_window_adjustment): Set
      windows_or_buffers_changed.
      (Fwindow_scroll_bars): Return actual scrollbar width.
      * xfns.c (x_set_scroll_bar_default_width): Rename wid to unit.
      For non-toolkit builds again use 14 as minimum width and set
      FRAME_CONFIG_SCROLL_BAR_WIDTH accordingly.
      * xterm.c (XTset_vertical_scroll_bar): Take width from
      WINDOW_SCROLL_BAR_AREA_WIDTH.
      (x_new_font): Rename wid to unit.  Base calculation of new
      scrollbar width on toolkit used and make it analogous to that of
      x_set_scroll_bar_default_width.
      * w32fns.c (x_set_scroll_bar_default_width): Rename wid to unit.
      (Fx_create_frame): Call x_set_scroll_bar_default_width instead
      of GetSystemMetrics.
      * w32term.c (w32_set_vertical_scroll_bar): Take width from
      WINDOW_SCROLL_BAR_AREA_WIDTH.
      (x_new_font): Make it correspond to changes in xterm.c.
      44c5e192
  19. 01 Jan, 2014 1 commit
  20. 31 Dec, 2013 2 commits
    • Martin Rudalics's avatar
      Fix last change of grow_mini_window. · 91415fb1
      Martin Rudalics authored
      * window.c (grow_mini_window): Fix last change.
      91415fb1
    • Martin Rudalics's avatar
      Some more fixes following pixelwise resize changes including one for Bug#16306. · 9b3c0a16
      Martin Rudalics authored
      * gtkutil.c (x_wm_set_size_hint): Have size hints respect value
      of frame_resize_pixelwise.
      * widget.c (pixel_to_text_size): New function.
      (update_wm_hints): Have size hints respect value of
      frame_resize_pixelwise.
      (EmacsFrameResize): Alway process resize requests pixelwise.
      * window.c (grow_mini_window): Make sure mini window is at least
      one line tall.
      * xdisp.c (display_menu_bar): Make sure menubar extends till
      right end of frame.
      * xfns.c (x_set_menu_bar_lines): Resize frame windows pixelwise.
      (x_set_tool_bar_lines): Calculate pixelwise.
      * xterm.c (x_wm_set_size_hint): Have size hints respect value of
      frame_resize_pixelwise.
      9b3c0a16
  21. 26 Dec, 2013 1 commit
    • Martin Rudalics's avatar
      Some more tinkering with Bug#16051. · 0cbab19e
      Martin Rudalics authored
      * window.c (resize_frame_windows): Don't let the size of the
      root window drop below the frame's default character size.
      Never ever delete any subwindows - let the window manager do the
      clipping.
      
      * w32fns.c (x_set_tool_bar_lines): Rewrite calculation of number
      of toolbar lines needed when they exceed the height of the root
      window.
      (unwind_create_frame_1): New function.
      (Fx_create_frame): Generally inhibit calling the window
      configuration change hook here.  Remove extra call to
      change_frame_size - it's not needed when we don't run the
      configuration change hook.
      0cbab19e
  22. 22 Dec, 2013 1 commit
  23. 20 Dec, 2013 1 commit
    • Martin Rudalics's avatar
      Some more fixes for pixelwise resizing. · c44de18d
      Martin Rudalics authored
      Remove scroll_bar_actual_width from frames.
      * frame.h (struct frame): Remove scroll_bar_actual_width slot.
      * frame.c (Fscroll_bar_width): Return scroll bar area width.
      (x_figure_window_size):
      * nsterm.m (x_set_window_size):
      * widget.c (set_frame_size):
      * w32term.c (x_set_window_size):
      * xterm.c (x_set_window_size, x_set_window_size_1): Don't set
      scroll_bar_actual_width.
      
      Convert scroll_bar members to integers on Windows.
      * w32term.h (struct scroll_bar): Convert top, left, width,
      height, start, end and dragging to integers.
      * w32fns.c (w32_createscrollbar): Remove XINT conversions for
      scroll_bar members.
      * w32term.c (w32_set_scroll_bar_thumb)
      (w32_scroll_bar_handle_click): Remove XINT conversions for
      scroll_bar members.  Treat bar->dragging as integer.
      (x_scroll_bar_create): Call ALLOCATE_PSEUDOVECTOR with "top" as
      first element.  Remove XINT conversions for scroll_bar members.
      (w32_set_vertical_scroll_bar, x_scroll_bar_report_motion):
      Remove XINT conversions for scroll_bar members.
      
      Fix assignment for new window total sizes.
      * window.c (Fwindow_resize_apply_total): Assign values for
      minibuffer window.
      * window.el (window--pixel-to-size): Remove function.
      (window--pixel-to-total-1, window--pixel-to-total): Fix
      calculation of new total sizes.
      c44de18d
  24. 11 Dec, 2013 1 commit
    • Martin Rudalics's avatar
      Various fixes around Bug#16013. · d94c40c1
      Martin Rudalics authored
      * window.c (resize_frame_windows): Don't return immediately when
      the root window's size doesn't change - the minibuffer window
      may still have to be repositioned/resized.
      * xfns.c (Fx_create_frame): Always change the frame size after
      initializing the frame's faces.
      * xterm.c (handle_one_xevent): Don't set pixel sizes here,
      change_frame_size should already have done it.
      (x_new_font): Assign new tool- and menu-bar heights.
      (x_set_window_size_1): Account for tool- and menu-bar heights
      (Bug#16013). Don't set pixel sizes since change_frame_size
      should already have done it.
      d94c40c1
  25. 08 Dec, 2013 1 commit
  26. 04 Dec, 2013 2 commits
    • Stefan Monnier's avatar
      * src/window.c (select_window): Call second wset_redisplay before we change · 22800ae9
      Stefan Monnier authored
      selected_window.
      
      Fixes: debbugs:16034
      22800ae9
    • Stefan Monnier's avatar
      * src/window.c (window_scroll): Mark window for redisplay. · 5961ad6c
      Stefan Monnier authored
      (scroll_command, Fscroll_other_window): Don't cause redisplay now that
      window_scroll takes care of it.
      (Fset_window_point, Fdelete_other_windows_internal)
      (set_window_buffer, Fwindow_resize_apply, resize_frame_windows)
      (Fsplit_window_internal, Fdelete_window_internal)
      (Fresize_mini_window_internal, Fset_window_configuration)
      (apply_window_adjustment): Use fset_redisplay and wset_redisplay to
      cause redisplay instead of forcing a complete redisplay.
      * src/xdisp.c (wset_redisplay): Don't set windows_or_buffers_changed if
      we're only affecting the selected_window.
      
      Fixes: debbugs:16034
      5961ad6c
  27. 03 Dec, 2013 3 commits
    • Paul Eggert's avatar
      Minor integer overflow fixes. · 2654ac09
      Paul Eggert authored
      * window.c (Fset_window_new_pixel): Don't let new_pixel go negative.
      This improves on the previous fix to this function.
      (window_resize_check): When summing up pixel counts, don't rely on
      undefined behavior if the sum overflows.
      
      Fixes: debbugs:16033
      2654ac09
    • Martin Rudalics's avatar
      Fix issues related to pixelwise resizing. (Bug#16013) (Bug#16033) · 7303a0ae
      Martin Rudalics authored
      * window.c (Fset_window_new_pixel): Don't choke at negative
      argument value (Bug#16033).
      
      * xfns.c (Fx_create_frame): Add another call to change_frame_size
      to avoid crash in window_box_height.
      
      * gtkutil.h: Fix external declaration of xg_frame_set_char_size.
      * gtkutil.c (xg_frame_set_char_size, style_changed_cb): Fix size
      calculation.
      * xterm.c (x_set_window_size): Fix size calculation (Bug#16013).
      7303a0ae
    • Paul Eggert's avatar
      Minor integer overflow fixes. · 25636e13
      Paul Eggert authored
      * window.c (Fset_window_new_pixel, grow_mini_window):
      * xdisp.c (Fwindow_text_pixel_size):
      Avoid undefined behavior on signed integer overflow.
      * xfns.c (x_set_mouse_color):
      Check that drag shape fits in 'unsigned', since that's what X wants.
      25636e13
  28. 01 Dec, 2013 1 commit
  29. 30 Nov, 2013 3 commits
    • Martin Rudalics's avatar
      Remove some unused items introduced during pixelwise change. · 90caab3f
      Martin Rudalics authored
      * window.c (window_resize_total_check): Remove unused function.
      * xdisp.c (remember_mouse_glyph): Remove unused label.
      (Ftool_bar_height): Move declaration inside #if.
      * xterm.c (x_set_window_size): Don't use r and c.
      90caab3f
    • Juanma Barranquero's avatar
      src/w32term.c,window.c,xdisp.c: Remove unused variables. · 6ae87264
      Juanma Barranquero authored
      * w32term.c (w32_read_socket): Remove unused variable `buf'.
      
      * window.c (Fset_window_configuration): Comment out unused variables.
      
      * xdisp.c (Fwindow_text_pixel_size): Remove unused variables
      `value' and `endp'.
      6ae87264
    • Martin Rudalics's avatar
      Support resizing frames and windows pixelwise. · 880e6158
      Martin Rudalics authored
      * dispextern.h (enum window_part): Add ON_SCROLL_BAR,
      ON_RIGHT_DIVIDER and ON_BOTTOM_DIVIDER.
      (struct glyph_matrix): Replace window_left_col and
      window_top_line by window_pixel_left and window_pixel_top.
      (WINDOW_WANTS_MODELINE_P, WINDOW_WANTS_HEADER_LINE_P): Minor
      rewrite.
      (enum face_id): Add WINDOW_DIVIDER_FACE_ID.
      (draw_window_divider, move_it_to, x_draw_right_divider)
      (x_draw_bottom_divider, change_frame_size): Add or fix
      declarations.
      * dispnew.c (change_frame_size_1): Change prototype.
      (adjust_glyph_matrix, required_matrix_width)
      (adjust_frame_glyphs_for_window_redisplay): Use pixel
      values instead of lines and columns.
      (marginal_area_string): Use WINDOW_FRINGES_WIDTH instead of
      WINDOW_TOTAL_FRINGE_WIDTH.
      (handle_window_change_signal, do_pending_window_change)
      (init_display): Adjusts calls of change_frame_size.
      (change_frame_size, change_frame_size_1): Handle pixelwise
      changes.
      * frame.c (Qright_divider_width, Qbottom_divider_width): New
      Lisp objects.
      (set_menu_bar_lines_1, set_menu_bar_lines, make_frame)
      (make_terminal_frame, Fmake_terminal_frame, Fframe_parameters)
      (x_set_internal_border_width, x_set_vertical_scroll_bars)
      (x_set_scroll_bar_width, x_figure_window_size): Handle pixel
      values.
      (set_frame_param): New function.
      (Fframe_text_cols, Fframe_text_lines, Fframe_total_cols)
      (Fframe_text_width, Fframe_text_height, Fscroll_bar_width)
      (Ffringe_width, Fborder_width, Fright_divider_width)
      (Fbottom_divider_width): New functions, defsubr them.
      (Fset_frame_height, Fset_frame_width, Fset_frame_size): New
      argument pixelwise.
      (struct frame_parm_table): New members Qright_divider_width and
      Qbottom_divider_width.
      (x_set_frame_parameters): Handle parameters for pixelwise sizes.
      (x_report_frame_params): Handle Qright_divider_width and
      Qbottom_divider_width.
      (x_set_right_divider_width, x_set_bottom_divider_width): New
      functions.
      (frame_resize_pixelwise): New option.
      * frame.h (struct frame): Add tool_bar_height, menu_bar_height,
      new_pixelwise, right_divider_width and bottom_divider_width;
      remove total_lines; rename text_lines, text_cols, new_text_lines
      and new_text_cols to text_height, text_width, new_height and
      new_width respectively.
      (FRAME_LINES, FRAME_COLS): Rename to FRAME_TEXT_HEIGHT and
      FRAME_TEXT_WIDTH respectively.
      (FRAME_MENU_BAR_HEIGHT, FRAME_TOOL_BAR_HEIGHT)
      (FRAME_RIGHT_DIVIDER_WIDTH, FRAME_BOTTOM_DIVIDER_WIDTH)
      (FRAME_TEXT_TO_PIXEL_WIDTH, FRAME_PIXEL_TO_TEXT_WIDTH): New
      macros.
      (FRAME_TOP_MARGIN_HEIGHT, FRAME_LEFT_SCROLL_BAR_AREA_WIDTH)
      (FRAME_RIGHT_SCROLL_BAR_AREA_WIDTH, FRAME_SCROLL_BAR_AREA_WIDTH)
      (SET_FRAME_COLS, SET_FRAME_WIDTH, SET_FRAME_HEIGHT)
      (FRAME_TEXT_COLS_TO_PIXEL_WIDTH, FRAME_PIXEL_WIDTH_TO_TEXT_COLS)
      (FRAME_TEXT_COLS_TO_PIXEL_WIDTH): Rewrite macros.
      (FRAME_TOTAL_COLS_ARG): Remove macro.
      * fringe.c (draw_fringe_bitmap_1): Handle right divder.
      * gtkutil.c (xg_frame_resized, xg_frame_set_char_size)
      (x_wm_set_size_hint): Handle frame pixel sizes.
      * indent.c (compute_motion, Fcompute_motion): Call
      window_body_width instead of window_body_cols.
      * keyboard.c (Qright_divider, Qbottom_divider): New symbols.
      (make_lispy_position): Handle right and bottom dividers.
      (Fsuspend_emacs): Pixelize call of change_frame_size.
      * keyboard.h: Extern Qright_divider, Qbottom_divider.
      * lisp.h: Extern set_frame_param.
      * nsfns.m (x_set_tool_bar_lines): Pixelize call of
      x_set_window_size.
      (Fx_create_frame): Add entry for vertical_drag_cursor.  Pixelize
      call of change_frame_size.
      * nsterm.h (struct ns_output): Add vertical_drag_cursor.
      * nsterm.m (ns_update_window_end): Optionally draw right
      divider.
      (x_set_window_size): Add argument pixelwise.  Call
      check_frame_size and change_frame_size with pixelwise zero.
      (ns_draw_window_divider): New function.
      (ns_redisplay_interface): Add ns_draw_window_divider.
      (updateFrameSize:): Call change_frame_size with pixelwise zero.
      (x_new_font): Call x_set_window_size with pixelwise zero.
      * print.c (print_object): For a window print its sequence
      number again.
      * term.c (Fresume_tty): Pixelize call of change_frame_size.
      * w32fns.c (x_set_mouse_color): Handle vertical drag cursor.
      (x_set_menu_bar_lines, x_set_tool_bar_lines): Calculate pixelwise.
      (w32_createwindow): Use scroll bar area width.
      (w32_wnd_proc): Handle bottom divider width.  For
      WM_WINDOWPOSCHANGING return zero if we resize pixelwise.
      (Fx_create_frame): Default divider width parameters.  Caclulate
      sizes pixelwise.  Add vertical drag cursor support.
      (x_create_tip_frame): Default divider widths to zero.  Pixelize
      call to change_frame_size.
      (Fx_show_tip): Add handling of divider widths.  Pixelize window
      position and sizes.
      (Fw32_frame_rect): New function.
      (frame_parm_handler w32_frame_parm_handlers): Add divider
      widths.
      (Vx_window_vertical_drag_shape): Add variable.
      * w32inevt.c (resize_event, maybe_generate_resize_event):
      Pixelize change_frame_size calls.
      * w32menu.c (set_frame_menubar): Pixelize x_set_window_size
      call.
      * w32term.c (w32_draw_window_divider): New function.
      (x_update_window_end): Handle right divider.
      (w32_draw_fringe_bitmap, x_scroll_run)
      (w32_set_vertical_scroll_bar): Pixelize scrollbar widths.
      (w32_read_socket): Handle SIZE_MAXIMIZED separately.  Calculate
      new frame sizes pixelwise.
      (x_new_font): Pixelize call to x_set_window_size.
      (x_check_fullscreen): Pixelize call to change_frame_size.
      (x_set_window_size_1, x_set_window_size): New argument
      pixelwise.  Calculate pixelwise.
      (x_wm_set_size_hint): Use scroll bar area width.
      (w32_redisplay_interface): Add w32_draw_window_divider.
      * w32term.h (struct w32_output): Add vertical drag cursor.
      * widget.c (set_frame_size, update_wm_hints)
      (EmacsFrameResize, EmacsFrameSetValues): Pixelize calls of
      change_frame_size.
      (EmacsFrameSetCharSize): Pixelize call of x_set_window_size.
      * window.c (sequence_number): Restore.
      (Fwindow_pixel_width, Fwindow_pixel_height)
      (Fwindow_mode_line_height, Fwindow_header_line_height)
      (window_pixel_to_total, Frun_window_scroll_functions)
      (Fset_window_new_pixel, window_resize_apply_total)
      (Fwindow_resize_apply_total): New functions.
      (window_body_height, window_body_width): Rename from
      window_body_lines.  New argument PIXELWISE.  Calculate
      pixelwise.
      (Fwindow_body_height, Fwindow_body_width): New argument
      PIXELWISE.
      (coordinates_in_window, window_relative_x_coord): Use window's
      pixel width instead of total width.
      (replace_window, recombine_windows): Initialize pixel values.
      (resize_root_window, resize_frame_windows, grow_mini_window)
      (shrink_mini_window): New argument PIXELWISE.  Calculate
      pixelwise.
      (Fdelete_other_windows_internal, adjust_window_margins)
      (window_resize_check, window_resize_apply)
      (Fdelete_window_internal, Fresize_mini_window_internal)
      (Fwindow_text_width, Fwindow_text_height): Calculate pixelwise.
      (check_frame_size): Rename arguments.  New argument PIXELWISE.
      Calculate pixelwise.
      (set_window_buffer): Make samebuf bool.  Run configuration change
      hook only if buffer changed.
      (Fset_window_buffer): Rewrite doc-string.
      (make_window): Initialize new_pixel slot.
      (Fwindow_resize_apply): Check pixel size of root window.
      (Fsplit_window_internal): Call 2nd argument pixel_size.
      Calculate pixelwise.
      (Fscroll_left, Fscroll_right): Call window_body_width instead of
      window_body_cols.
      (save_window_data): New slots frame_text_width,
      frame_text_height, frame_menu_bar_height, frame_tool_bar_height.
      (saved_window): New slots pixel_left, pixel_top, pixel_height,
      pixel_width.
      (Fcurrent_window_configuration, Fset_window_configuration)
      (save_window_save, compare_window_configurations): Handle new
      slots in save_window_data and saved_window.
      (Fset_window_scroll_bars): Fix doc-string.
      (window_resize_pixelwise): New variable.
      (coordinates_in_window, Fcoordinates_in_window_p): Handle
      dividers.
      (make_parent_window): Adjust sequence_number.
      (Fwindow_right_divider_width, Fwindow_bottom_divider_width): New
      functions.
      * window.h (struct window): New members new_pixel, pixel_left,
      pixel_top, pixel_width, pixel_height.  Restore sequence_number.
      (wset_new_pixel): New function.
      (WINDOW_PIXEL_WIDTH, WINDOW_PIXEL_HEIGHT)
      (MIN_SAFE_WINDOW_PIXEL_WIDTH, MIN_SAFE_WINDOW_PIXEL_HEIGHT)
      (WINDOW_LEFT_PIXEL_EDGE, WINDOW_RIGHT_PIXEL_EDGE)
      (WINDOW_TOP_PIXEL_EDGE, WINDOW_BOTTOM_PIXEL_EDGE)
      (WINDOW_BOTTOMMOST_P, WINDOW_BOX_LEFT_PIXEL_EDGE)
      (WINDOW_BOX_RIGHT_PIXEL_EDGE, WINDOW_MARGINS_COLS)
      (WINDOW_MARGINS_WIDTH, WINDOW_RIGHT_DIVIDER_WIDTH)
      (WINDOW_BOTTOM_DIVIDER_WIDTH): New macros.
      (WINDOW_TOTAL_FRINGE_WIDTH): Rename to WINDOW_FRINGES_WIDTH.
      (WINDOW_TOTAL_WIDTH, WINDOW_TOTAL_HEIGHT): Remove macros.
      (WINDOW_RIGHT_EDGE_X, WINDOW_LEFT_EDGE_X, WINDOW_TOP_EDGE_Y)
      (WINDOW_BOTTOM_EDGE_Y, WINDOW_FULL_WIDTH_P, WINDOW_LEFTMOST_P)
      (WINDOW_RIGHTMOST_P, WINDOW_BOX_LEFT_EDGE_X)
      (WINDOW_BOX_RIGHT_EDGE_X, WINDOW_FRINGE_COLS)
      (WINDOW_BOX_HEIGHT_NO_MODE_LINE, WINDOW_BOX_TEXT_HEIGHT):
      Rewrite.
      (resize_frame_windows, grow_mini_window, shrink_mini_window)
      (window_body_width, check_frame_size): Adapt external declarations.
      * xdisp.c (last_max_ascent): New integer.
      (window_text_bottom_y): Handle bottom divider.
      (window_box_width, window_box_height): Calculate pixelwise.
      (get_glyph_string_clip_rects): Handle right divider.
      (remember_mouse_glyph): When windows are resized pixelwise
      proceed with width and height set to 1.
      (init_iterator): Use WINDOW_PIXEL_WIDTH instead of
      WINDOW_TOTAL_WIDTH.
      (move_it_to): Calculate and return maximum x position
      encountered.
      (Fwindow_text_pixel_size): New function.
      (resize_mini_window, update_tool_bar): Calculate pixelwise.
      (tool_bar_lines_needed): Rename to tool_bar_height.  Calculate
      pixelwise.
      (Ftool_bar_lines_needed): Rename to Ftool_bar_height.  Calculate
      pixelwise.
      (redisplay_tool_bar): Calculate pixelwise.
      (redisplay_window): Calculate pixelwise.  Handle dividers.
      (draw_glyphs, x_clear_end_of_line, note_mouse_highlight)
      (x_draw_vertical_border): Handle dividers.
      (define_frame_cursor1): Handle vertical drag cursor.
      (x_draw_right_divider, x_draw_bottom_divider): New functions.
      (expose_window): Calculate pixelwise.  Handle dividers.
      (init_xdisp): Initialize pixel values.
      * xfaces.c (Qwindow_divider): New face.
      (realize_basic_faces): Realize it.
      * xfns.c (x_set_mouse_color): Handle vertical_drag_cursor.
      (x_set_menu_bar_lines, x_set_tool_bar_lines): Calculate pixelwise.
      (x_set_scroll_bar_default_width): Default actual width to 16.
      (Fx_create_frame): Set sizes pixelwise.
      (x_create_tip_frame): Default divider widths to zero.  Pixelize
      call of change_frame_size.
      (Fx_show_tip): Handle divider widths.  Initial pixel position
      and sizes.
      (frame_parm_handler x_frame_parm_handlers): Add divider widths.
      (Vx_window_vertical_drag_shape): New option.
      * xmenu.c (free_frame_menubar): Pixelize call of
      x_set_window_size.
      * xterm.c (x_draw_window_divider): New function.
      (x_update_window_end): Optionally draw right divider.
      (x_draw_fringe_bitmap, x_scroll_run, x_scroll_bar_create)
      (XTset_vertical_scroll_bar): Use scroll bar pixel width.
      (handle_one_xevent, x_new_font): Calculate pixelwise.
      (x_set_window_size_1, x_set_window_size): New argument
      pixelwise.  Calculate pixelwise.
      (x_wm_set_size_hint): Pixelize call of check_frame_size.
      (struct x_redisplay_interface): Add x_draw_window_divider.
      * xterm.h (struct x_output): Add vertical_drag_cursor.
      
      * cus-start.el (frame-resize-pixelwise)
      (window-resize-pixelwise): New entries.
      * emacs-lisp/debug.el (debug): Use window-total-height instead
      of window-total-size.
      * frame.el (tool-bar-lines-needed): Defalias to tool-bar-height.
      * help.el (describe-bindings-internal): Call help-buffer
      (temp-buffer-max-width): New option.
      (resize-temp-buffer-window, help-window-setup)
      (with-help-window): Rewrite.
      * mouse.el (mouse-drag-line): Rewrite.  Add key bindings for
      dragging dividers.
      * window.el (frame-char-size, window-min-pixel-height)
      (window-safe-min-pixel-height, window-safe-min-pixel-width)
      (window-min-pixel-width, window-safe-min-pixel-size)
      (window-combination-p, window-safe-min-size)
      (window-resizable-p, window--size-to-pixel)
      (window--pixel-to-size, window--resize-apply-p): New functions.
      (window-safe-min-height): Fix doc-string.
      (window-size, window-min-size, window--min-size-1)
      (window-sizable, window-sizable-p, window--min-delta-1)
      (window-min-delta, window--max-delta-1, window-max-delta)
      (window--resizable, window--resizable-p, window-resizable)
      (window-full-height-p, window-full-width-p, window-at-side-p)
      (window--in-direction-2, window-in-direction)
      (window--resize-reset-1, window--resize-mini-window)
      (window-resize, window-resize-no-error)
      (window--resize-child-windows-normal)
      (window--resize-child-windows, window--resize-siblings)
      (window--resize-this-window, window--resize-root-window)
      (window--resize-root-window-vertically)
      (adjust-window-trailing-edge, enlarge-window, shrink-window)
      (maximize-window, minimize-window, delete-window)
      (quit-restore-window, window-split-min-size, split-window)
      (balance-windows-2, balance-windows)
      (balance-windows-area-adjust, balance-windows-area)
      (window--state-get-1, window-state-get, window--state-put-1)
      (window--state-put-2, window-state-put)
      (display-buffer-record-window, window--display-buffer): Make
      functions handle pixelwise sizing of windows.
      (display-buffer--action-function-custom-type)
      (display-buffer-fallback-action): Add
      display-buffer-in-previous-window.
      (display-buffer-use-some-window): Resize window to height it had
      before.
      (fit-window-to-buffer-horizontally): New option.
      (fit-frame-to-buffer): Describe new values.
      (fit-frame-to-buffer-bottom-margin): Replace with
      fit-frame-to-buffer-margins.
      (window--sanitize-margin): New function.
      (fit-frame-to-buffer, fit-window-to-buffer): Rewrite completely
      using window-text-pixel-size.
      880e6158
  30. 29 Nov, 2013 2 commits
  31. 28 Nov, 2013 1 commit
    • Stefan Monnier's avatar
      Refine redisplay optimizations to only redisplay *some* frames/windows · 655ab9a3
      Stefan Monnier authored
      rather than all of them.
      * src/xdisp.c (REDISPLAY_SOME): New constant.
      (redisplay_other_windows, wset_redisplay, fset_redisplay)
      (bset_redisplay, bset_update_mode_line): New functions.
      (message_dolog): Use bset_redisplay.
      (clear_garbaged_frames): Use fset_redisplay.
      (echo_area_display): Use wset_redisplay.
      (buffer_shared_and_changed): Remove.
      (prepare_menu_bars): Call Vpre_redisplay_function before updating
      frame titles.  Compute the actual set of windows redisplayed.
      Don't update frame titles and menu bars for frames that don't need to
      be redisplayed.
      (propagate_buffer_redisplay): New function.
      (AINC): New macro.
      (redisplay_internal): Use it.  Be more selective in the set of windows
      we redisplay.  Propagate windows_or_buffers_changed to
      update_mode_lines a bit later to simplify the code.
      (mark_window_display_accurate_1): Reset window and buffer's
      `redisplay' flag.
      (redisplay_window): Do nothing if neither the window nor the buffer nor
      the frame needs redisplay.
      * src/window.h (struct window): Add `redisplay' field.
      (wset_redisplay, fset_redisplay, bset_redisplay, bset_update_mode_line)
      (redisplay_other_windows, window_list): New declarations.
      * src/window.c (select_window, Fset_window_start): Use wset_redisplay.
      (window_list): Not static any more.
      (grow_mini_window, shrink_mini_window): Use fset_redisplay.
      * src/minibuf.c (read_minibuf_unwind): Don't redisplay everything.
      * src/insdel.c (prepare_to_modify_buffer_1): Use bset_redisplay.
      * src/frame.c (Fmake_frame_visible): Don't redisplay everything.
      * src/frame.h (struct frame): Add `redisplay' field.
      Move `external_menu_bar' bitfield next to other bit-fields.
      (SET_FRAME_GARBAGED): Use fset_redisplay.
      (SET_FRAME_VISIBLE): Don't garbage the frame;
      Use redisplay_other_windows.
      * src/buffer.h (struct buffer): Add `redisplay' field.
      * src/buffer.c (Fforce_mode_line_update): Pay attention to the `all' flag.
      (modify_overlay): Use bset_redisplay.
      * src/alloc.c (gc_sweep): Don't unmark strings while sweeping symbols.
      
      * lisp/doc-view.el (doc-view-goto-page): Update mode-line.
      655ab9a3
  32. 27 Nov, 2013 1 commit