1. 19 Nov, 2017 2 commits
  2. 18 Nov, 2017 2 commits
  3. 17 Nov, 2017 3 commits
    • Eli Zaretskii's avatar
      Prevent aborts in line-move-visual · 90add182
      Eli Zaretskii authored
      * src/indent.c (line_number_display_width): Avoid assertion
      violations in init_iterator when the window's buffer was
      temporarily switched without updating window-start.  (Bug#29326)
      90add182
    • Eli Zaretskii's avatar
      More fixes in src/.gdbinit · 648c128b
      Eli Zaretskii authored
      * src/.gdbinit (pwinx): Update to match 'struct window'.
      (pcursorx): Use "." instead of "->" because the argument is a
      struct, not a pointer.
      648c128b
    • Eli Zaretskii's avatar
      Fix .gdbinit following lisp.h changes · 42c87681
      Eli Zaretskii authored
      * src/.gdbinit (xsymname, pwinx, pgx, xbuffer, xcar, xcdr, xlist)
      (xprintstr): Adapt to latest changes in Lisp object C structures.
      (Bug#29332)
      42c87681
  4. 13 Nov, 2017 4 commits
    • Paul Eggert's avatar
      Port to IBM xlc 12.01 · 79108894
      Paul Eggert authored
      Work around a compiler bug by using a separate enum for alignment.
      * src/alloc.c (roundup_size): Declare in a separate enum.
      79108894
    • Paul Eggert's avatar
      Simplify by removing HAVE_STRUCT_ATTRIBUTE_ALIGNED · d1495609
      Paul Eggert authored
      * configure.ac (HAVE_STRUCT_ATTRIBUTE_ALIGNED): Remove.  No longer
      needed, since we no longer rely on __attribute__ ((aligned (8))).
      All uses removed.
      * src/emacs-module.c (HAVE_STRUCT_ATTRIBUTE_ALIGNED): Remove.
      (lisp_to_value): Simplify now that we no longer need to worry
      whether HAVE_STRUCT_ATTRIBUTE_ALIGNED is false.
      d1495609
    • Paul Eggert's avatar
      Use alignas to fix GCALIGN-related bugs · b1573a97
      Paul Eggert authored
      Use alignas and unions to specify alignments of objects needing
      addresses that are at least a multiple of GCALIGNMENT.  Using
      these standard C facilities should be safer than relying on ad hoc
      and poorly-understood features like GCC’s __attribute__
      ((aligned (N))), the root cause for recent porting bugs like
      Bug#29040.  The alignas macro was standardized by C11 and Gnulib
      supports alignas for pre-C11 platforms.  I have tested this on Sun
      Studio 12 sparc (2007) and GCC 4.4.7 x86-64 (2012) as well as on
      more recent platforms like GCC 7.2.1 (2017) on Fedora 26 (both
      x86-64 and x86).
      * lib-src/make-docfile.c (close_emacs_globals): lispsym is now
      just an array of struct Lisp_Symbol, since struct Lisp_Symbol is
      now properly aligned.  All uses changed.
      * src/alloc.c (NEXT_FREE_LISP_STRING): Just use the new u.next
      member; this is simpler and safer than casting a pointer that
      might not be aligned properly.
      (aligned_Lisp_Symbol): Remove.  No longer needed, now that struct
      Lisp_Symbol is aligned properly.  All uses replaced with struct
      Lisp_Symbol.
      * src/lisp.h (GCALIGNED): Remove, as it does not work as expected:
      it can cause the natural alignment to be ignored.  All uses
      replaced by unions with a ‘char alignas (GCALIGNMENT)’ member as
      described below.
      (struct Lisp_Symbol, struct Lisp_Cons, struct Lisp_String):
      Change definition from ‘struct TAG { MEMBERS };’ to
      ‘struct TAG { union { struct { MEMBERS } s; char alignas
      (GCALIGNMENT) gcaligned; } u; };’.  This guarantees ‘struct TAG’
      to have an alignment that at least max (GCALIGNMENT, N) where N is
      its old alignment.  All uses like ‘PTR->MEMBER’ changed to
      ‘PTR->u.s.MEMBER’; these uses were supposed to be mostly private
      anyway.  Verify that the resulting ‘struct TAG’ is properly
      aligned for Emacs.
      (union vectorlike_header): New member ‘gcaligned’ to guarantee
      that this type, and its containing types like ‘struct Lisp_Subr’,
      ‘struct buffer’ and ‘struct thread_state’, are all properly
      aligned for Emacs.
      (struct Lisp_String): New union member ‘next’, for the benefit
      of NEXT_FREE_LISP_STRING.
      (union Aligned_Cons, union Aligned_String): Remove.  All uses
      replaced by struct Lisp_Cons and struct Lisp_String, since they
      are now properly aligned.
      (USE_STACK_CONS, USE_STACK_STRING): Simplify now that we can
      assume struct Lisp_Cons and struct Lisp_String are properly
      aligned.
      b1573a97
    • Paul Eggert's avatar
      Change vectorlike from struct to union · 5d68dc9a
      Paul Eggert authored
      * src/lisp.h (vectorlike_headed): Change from struct to union.
      All uses changed.  Since it has only one member, this does not
      change semantics.  This is designed to simplify future changes
      needed to fix bugs like Bug#29040.  All uses changed.
      5d68dc9a
  5. 12 Nov, 2017 2 commits
    • Michael Albinus's avatar
      Fix Bug#29225 · 48ad0039
      Michael Albinus authored
      * src/fileio.c (Fset_file_acl): Report error only when
      acl_errno_valid returns true.  (Bug#29225)
      
      * test/lisp/net/tramp-tests.el (tramp-test24-file-acl)
      (tramp-test25-file-selinux): New tests.
      (tramp-test26-file-name-completion, tramp-test27-load)
      (tramp-test28-process-file, tramp-test29-start-file-process)
      (tramp-test30-interrupt-process, tramp-test31-shell-command)
      (tramp-test32-environment-variables)
      (tramp-test32-environment-variables-and-port-numbers)
      (tramp-test33-explicit-shell-file-name)
      (tramp-test34-vc-registered)
      (tramp-test35-make-auto-save-file-name)
      (tramp-test36-find-backup-file-name)
      (tramp-test37-make-nearby-temp-file)
      (tramp-test38-special-characters)
      (tramp-test38-special-characters-with-stat)
      (tramp-test38-special-characters-with-perl)
      (tramp-test38-special-characters-with-ls, tramp-test39-utf8)
      (tramp-test39-utf8-with-stat, tramp-test39-utf8-with-perl)
      (tramp-test39-utf8-with-ls, tramp-test40-file-system-info)
      (tramp-test41-asynchronous-requests)
      (tramp-test42-recursive-load, tramp-test43-remote-load-path)
      (tramp-test44-delay-load, tramp-test45-unload): Rename.
      48ad0039
    • Paul Eggert's avatar
      Pacify GCC when configured --with-x-toolkit=no · e470d164
      Paul Eggert authored
      Without these changes, Emacs does not build on Fedora 26 x86-64
      when configured --with-x-toolkit=no --enable-gcc-warnings.
      * oldXMenu/Activate.c (XMenuActivate): Add FALLTHROUGH.
      * src/xterm.c (x_dispatch_event): Define only if
      USE_X_TOOLKIT || USE_MOTIF || USE_GTK.
      e470d164
  6. 11 Nov, 2017 1 commit
    • Eli Zaretskii's avatar
      Fix comparisons with tip_frame in GTK builds · 7657a867
      Eli Zaretskii authored
      * src/xterm.c (x_update_begin, x_new_font):
      * src/xfns.c (Fx_display_monitor_attributes_list):
      * src/frame.c (Fframe_list) [USE_GTK]: Don't consider tip_frame a
      tooltip frame unless its 'tooltip' parameter is non-nil.  (Bug#26747)
      7657a867
  7. 10 Nov, 2017 2 commits
    • Paul Eggert's avatar
      Fix off-by-1 bug in --enable-checking=stringbytes · 05aa6d4a
      Paul Eggert authored
      Evidently nobody builds Emacs with --enable-checking=all,
      which is no surprise as it is so slow as to be unusable nowadays.
      Perhaps we should remove the slowest checks, or move them into
      another category, or speed them up, or something.
      * src/alloc.c (SDATA_SIZE) [GC_CHECK_STRING_BYTES]: Fix off-by-one
      error in size calculation, which caused a failure when
      --enable-checking=stringbytes was used.  I introduced this bug in
      2016-09-08T01:08:45!eggert@cs.ucla.edu "Port flexible array
      members to GCC + valgrind".
      05aa6d4a
    • Eli Zaretskii's avatar
      Fix display of line numbers in GTK builds · f3e69a80
      Eli Zaretskii authored
      * src/xdisp.c (should_produce_line_number) [USE_GTK]: Make sure
      tip_frame is indeed a tooltip frame, before disabling line numbers
      on it.  (Bug#27647)
      
      * src/dispextern.h (tip_frame): Add commentary describing the
      kludgey usage of this variable in GTK builds.
      f3e69a80
  8. 09 Nov, 2017 2 commits
    • Eli Zaretskii's avatar
      Fix redisplay of overlay-arrows on GUI frames · 9dde8be9
      Eli Zaretskii authored
      * src/xdisp.c (try_window_reusing_current_matrix)
      (try_cursor_movement): Disallow these optimizations if the buffer
      has overlay arrow(s) shown on the fringe(s).  (Bug#29198)
      9dde8be9
    • Paul Eggert's avatar
      Use GCALIGNED properly for GCC · 9e59de94
      Paul Eggert authored
      Apparently GCC requires that ‘__attribute__ ((aligned (8)))’ must
      immediately follow the ‘struct’ keyword when aligning a structure.
      The attribute silently does not work if it follows a tag after the
      ‘struct’ keyword.  Who knew?  Anyway, this patch is designed to
      fix a SIGSEGV problem reported by John Mastro (Bug#29183).
      * lib-src/make-docfile.c (close_emacs_globals):
      * src/buffer.c (buffer_defaults, buffer_local_symbols):
      * src/lisp.h (DEFUN):
      * src/thread.c (main_thread):
      Put 'GCALIGNED' immediately after 'struct'.
      9e59de94
  9. 07 Nov, 2017 1 commit
  10. 05 Nov, 2017 2 commits
    • Eli Zaretskii's avatar
      Fix last change in hscroll_window_tree · 5d36f222
      Eli Zaretskii authored
      * src/xdisp.c (hscroll_window_tree): When hscroll suspension is
      being disabled, set the frame's garbaged flag less eagerly.
      (Bug#29002)
      5d36f222
    • Eli Zaretskii's avatar
      Return non-nil from gnutls-available-p under GnuTLS 2.x · c572e1f3
      Eli Zaretskii authored
      * doc/misc/emacs-gnutls.texi (Help For Users): Update the
      documentation of 'gnutls-available-p'.
      
      * etc/NEWS (GnuTLS): Mention the change in the value returned by
      'gnutls-available-p'.
      
      * src/gnutls.c (Fgnutls_available_p): Return non-nil when GnuTLS
      2.x is available.  (Bug#29147)
      c572e1f3
  11. 04 Nov, 2017 4 commits
  12. 03 Nov, 2017 2 commits
  13. 02 Nov, 2017 5 commits
  14. 01 Nov, 2017 1 commit
  15. 31 Oct, 2017 2 commits
    • Charles A. Roelli's avatar
      ; Doc fixes · 460fe4a1
      Charles A. Roelli authored
      * lisp/progmodes/xref.el (xref-file-location)
      (xref-backend-apropos):
      * etc/NEWS (Lisp Changes in Emacs 26.1):
      * doc/emacs/msdos.texi (Windows Keyboard):
      * lisp/vc/vc.el (vc-print-branch-log):
      * src/buffer.c (word-wrap): Doc additions and fixes.
      460fe4a1
    • Eli Zaretskii's avatar
      Avoid duplicate calls to xfree for the same pointer · 41adf328
      Eli Zaretskii authored
      * src/alloc.c (sweep_symbols): Avoid freeing an already freed
      pointer to a symbol's buffer-local value.  (Bug#29066)
      41adf328
  16. 30 Oct, 2017 1 commit
    • Martin Rudalics's avatar
      Fix doc and doc-strings for minibuffer window related functions (Bug#28978) · d10c9479
      Martin Rudalics authored
      These fixes were suggested by Drew Adams.
      
      * src/window.c (Fminibuffer_selected_window): Disambiguate
      doc-string.
      * doc/lispref/minibuf.texi (Intro to Minibuffers)
      (Minibuffer Windows, Recursive Mini, Minibuffer Misc):  Avoid
      the term "currently active minibuffer window".  Disambiguate
      documentation of `minibuffer-selected-window'.
      d10c9479
  17. 29 Oct, 2017 1 commit
    • Martin Rudalics's avatar
      Fix minibuffer window related docs and strings (Bug#28978) · 4189d0ef
      Martin Rudalics authored
      * src/frame.c (Vdefault_minibuffer_frame): Fix doc-string.
      * src/window.c (Fminibuffer_selected_window): Fix doc-string.
      * doc/lispref/frames.texi (Buffer Parameters): Rewrite
      description of `minibuffer' parameter.
      * doc/lispref/minibuf.texi (Minibuffer Windows): Reorder
      entries and partly rewrite section.
      (Minibuffer Misc): Clarify description of
      `minibuffer-selected-window'.
      * etc/NEWS: Mention new semantics of 'minibuffer' frame
      parameter.
      4189d0ef
  18. 28 Oct, 2017 3 commits
    • Eli Zaretskii's avatar
      Avoid segfaults in 64-bit Windows builds · 00c3c6d8
      Eli Zaretskii authored
      * src/lisp.h (COMMON_MULTIPLE): Move here from alloc.c.
      * src/thread.c (THREAD_ALIGNMENT): New macro.
      (main_thread): Use THREAD_ALIGNMENT to align propertly.  (Bug#29040)
      00c3c6d8
    • Eli Zaretskii's avatar
      Fix conversion of pixel coordinates to buffer position · a8e67410
      Eli Zaretskii authored
      * src/dispnew.c (buffer_posn_from_coords): Adapt to
      auto-hscroll-mode == current-line.
      a8e67410
    • Glenn Morris's avatar
      Fix some doc typos · e6b4e5ff
      Glenn Morris authored
      * lisp/calendar/todo-mode.el (todo-next-item)
      (todo-previous-item, todo-toggle-item-header):
      * lisp/window.el (move-to-window-group-line):
      * src/editfns.c (Fformat):
      * test/lisp/calendar/todo-mode-tests.el (todo-test-move-item05):
      Fix doc typos.
      
      ; And in some comments.
      e6b4e5ff