1. 24 Dec, 2012 2 commits
  2. 23 Dec, 2012 3 commits
    • Eli Zaretskii's avatar
      Don't fail in acl_set_file on MS-Windows if the operation is a no-op. · 40ff07a5
      Eli Zaretskii authored
       src/w32.c (acl_set_file): If setting the file security descriptor
       fails, and the new DACL is identical to the existing one, silently
       return success.  This fixes problems for users backing up their
       own files without having the necessary privileges for setting
       security descriptors.
      40ff07a5
    • Eli Zaretskii's avatar
      Improve handling of subprocess shutdown on MS-Windows. · 299614f3
      Eli Zaretskii authored
       src/w32proc.c (reader_thread): Do not index fd_info[] with negative
       values.
       (reader_thread): Exit when cp->status becomes STATUS_READ_ERROR
       after WaitForSingleObject returns normally.  This expedites reader
       thread shutdown when delete_child triggers it.
       (reap_subprocess): More accurate commentary for why we call
       delete_child only when cp->fd is negative.
       src/w32.c (sys_close): Do not call delete_child on a subprocess
       whose handle is not yet closed.  Instead, set its file descriptor
       to a negative value, so that reap_subprocess will call
       delete_child on that subprocess when its SIGCHLD arrives.  This
       avoids closing handles used for communications between sys_select
       and reader_thread, which doesn't give sys_select a chance to
       notice that the process exited and invoke the SIGCHLD handler for
       it.
      299614f3
    • Jan Djärv's avatar
      * nsfns.m (Fns_do_applescript): Run event loop until script has · cf162aee
      Jan Djärv authored
      been executed.
      (ns_run_ascript): Chech as_script for nil, set to nil after
      executing script.
      
      Fixes: debbugs:12969
      cf162aee
  3. 22 Dec, 2012 2 commits
  4. 21 Dec, 2012 4 commits
  5. 20 Dec, 2012 4 commits
  6. 19 Dec, 2012 1 commit
  7. 18 Dec, 2012 1 commit
  8. 17 Dec, 2012 4 commits
    • Juanma Barranquero's avatar
      8725c076
    • Stefan Monnier's avatar
      * src/xdisp.c (select_frame_for_redisplay): Use select_window_1 to · 1e101a4b
      Stefan Monnier authored
      propagate redisplay's scrolling (if any) to the right window.
      (redisplay_internal): Use ensure_selected_frame.
      (display_mode_lines): Complete last fix.
      * src/window.c (select_window_1): New func, extracted from select_window.
      (select_window): Use it.
      * src/window.h (select_window_1): Declare.
      1e101a4b
    • Eli Zaretskii's avatar
      Support Posix ACL APIs on MS-Windows. · 66447e07
      Eli Zaretskii authored
       src/w32.c: Include sddl.h and sys/acl.h.
       (SDDL_REVISION_1): Define if not already defined.
       (g_b_init_get_security_descriptor_dacl)
       (g_b_init_convert_sd_to_sddl, g_b_init_convert_sddl_to_sd)
       (g_b_init_is_valid_security_descriptor)
       (g_b_init_set_file_security): New static flags.
       (globals_of_w32): Initialize them to zero.
       (SetFileSecurity_Name): New string constant.
       (SetFileSecurity_Proc, GetSecurityDescriptorDacl_Proc)
       (ConvertStringSecurityDescriptorToSecurityDescriptor_Proc)
       (ConvertSecurityDescriptorToStringSecurityDescriptor_Proc)
       (IsValidSecurityDescriptor_Proc): New typedefs.
       (get_file_security, get_security_descriptor_owner)
       (get_security_descriptor_group): Set errno to ENOTSUP.
       (set_file_security, get_security_descriptor_dacl)
       (is_valid_security_descriptor, convert_sd_to_sddl)
       (convert_sddl_to_sd, acl_valid, acl_to_text, acl_from_text)
       (acl_free, acl_get_file, acl_set_file): New functions.
       src/fileio.c (Fcopy_file) [WINDOWSNT]: Support copying ACLs.
      
       nt/inc/sys/acl.h: New file.
       nt/inc/ms-w32.h (ENOTSUP): Define if undefined.
       nt/config.nt (HAVE_POSIX_ACL): Define.
      
       doc/lispref/files.texi (File Attributes, Changing Files): Update to include
       MS-Windows support for ACLs.
      66447e07
    • Paul Eggert's avatar
      Don't reraise SIGCHLD, as that can now lose. · 207a7ef0
      Paul Eggert authored
      With the 2012-12-03 fix for Bug#12980 in place, an old workaround
      for some of that bug's symptoms can now cause Emacs to abort.
      Remove the workaround.
      * process.c (wait_reading_process_output): Don't reraise SIGCHLD.
      The bug that caused SIGCHLD to get lost has been fixed, and the
      workaround for it can now cause Emacs to abort.
      
      Fixes: debbugs:13192
      207a7ef0
  9. 16 Dec, 2012 2 commits
    • Paul Eggert's avatar
      * sysdep.c (emacs_abort): Bump backtrace size to 40. · 17fdfc15
      Paul Eggert authored
      Companion to the 2012-09-30 patch.  Suggested by Eli Zaretskii in
      <http://lists.gnu.org/archive/html/emacs-devel/2012-09/msg00796.html>.
      17fdfc15
    • Romain Francoise's avatar
      Add support for preserving ACL entries of files. · 7c3d167f
      Romain Francoise authored
      	* configure.ac (acl): New option.
      	(HAVE_POSIX_ACL): Test for POSIX ACL support.  This is typically
      	provided by libacl on GNU/Linux.
      
      	* fileio.c (Ffile_acl, Fset_file_acl): New functions.
      	(Fcopy_file): Change last arg to `preserve_extended_attributes'
      	and copy ACL entries of file in addition to SELinux context if
      	set.
      	(syms_of_fileio): Add `file-acl' and `set-file-acl'.
      
      	* Makefile.in (LIBACL_LIBS): New macro.
      	(LIBES): Use it.
      
      	* files.el (file-extended-attributes)
      	(set-file-extended-attributes): New functions.
      	(backup-buffer): Use them to handle both SELinux context and ACL
      	entries.
      	(backup-buffer-copy): Work with an alist of extended attributes,
      	rather than an SELinux context.
      	(basic-save-buffer-2): Ditto.
      
      	* files.texi (File Attributes): Document ACL support and new
      	`file-acl' function.
      	(Changing Files): Mention argument name change of `copy-file' and
      	document new function `set-file-acl'.
      7c3d167f
  10. 15 Dec, 2012 3 commits
    • Paul Eggert's avatar
      7d80ea23
    • Chong Yidong's avatar
      * fns.c (Fcompare_strings): Doc fix. · 5bec25eb
      Chong Yidong authored
      * strings.texi (Text Comparison): Doc fix for compare-strings.
      
      Fixes: debbugs:13081
      5bec25eb
    • Eli Zaretskii's avatar
      Fix bug #13079 on MS-Windows with temp files not being deleted. · b0728617
      Eli Zaretskii authored
       src/w32.h (_child_process): New members input_file and
       pending_deletion.
       (register_child): First argument is now pid_t.
       (record_infile, record_pending_deletion): New prototypes.
       src/w32proc.c (new_child): Initialize input_file and
       pending_deletion members of the child.
       (delete_child): Delete the child's temporary input file, if any,
       that is pending deletion.
       (register_child): First argument is now pid_t.
       (record_infile, record_pending_deletion): New functions.
       (reap_subprocess): Fix a typo in DebPrint string.
       (sys_spawnve, sys_kill): Use pid_t for PID arguments.
       src/fileio.c (internal_delete_file): Return an int again: non-zero
       if delete-file succeeds, zero otherwise.
       src/lisp.h (internal_delete_file): Adjust prototype.
       src/callproc.c (Fcall_process): Don't overwrite infile with result
       of DECODE_FILE.
       [WINDOWSNT] If BUFFER is an integer, i.e. we are launching an
       asynchronous subprocess, record the name of the input file name,
       if any.
       (delete_temp_file) [WINDOWSNT]: If internal_delete_file fails to
       delete the file, record it as pending deletion when the subprocess
       exits.
      
       nt/inc/ms-w32.h (sys_unlink): Provide prototype.
      b0728617
  11. 14 Dec, 2012 7 commits
    • Paul Eggert's avatar
      Spelling fixes. · cccaebd2
      Paul Eggert authored
      My favorite was that the word "dictionary" was misspelled.
      Also, correct the title in the DeRemer & Pennello 1982 citation,
      and add a URL.
      cccaebd2
    • Eli Zaretskii's avatar
      Fix compilation warnings in the Windows build. · 7e90af26
      Eli Zaretskii authored
       src/editfns.c [HAVE_PWD_H]: Include grp.h.
       src/makefile.w32-in ($(BLD)/editfns.$(O)): Add $(NT_INC)/grp.h.
      7e90af26
    • Paul Eggert's avatar
      Fix permissions bugs with setgid directories etc. · 97976f9f
      Paul Eggert authored
      * configure.ac (BSD4_2): Remove; no longer needed.
      * admin/CPP-DEFINES (BSD4_2): Remove.
      * doc/lispintro/emacs-lisp-intro.texi (Files List):
      directory-files-and-attributes now outputs t for attribute that's
      now a placeholder.
      * doc/lispref/files.texi (Testing Accessibility): Document GROUP arg
      of file-ownership-preserved-p.
      (File Attributes): Document that 9th element is now
      just a placeholder.
      * doc/lispref/os.texi (User Identification): Document new functions group-gid,
      group-real-gid.
      * etc/NEWS: Document changes to file-attributes,
      file-ownership-preserved-p.
      Mention new functions group-gid, group-real-gid.
      * lisp/files.el (backup-buffer): Don't rely on 9th output of
      file-attributes, as it's now a placeholder.  Instead, use the new
      optional arg of file-ownership-preserved-p.
      (file-ownership-preserved-p): New optional arg GROUP.
      Fix mishandling of setuid directories that would cause this
      function to return t when it should have returned nil.
      Document what happens if the file does not exist, and when
      it's not known whether the ownership will be preserved.
      * lisp/net/tramp-sh.el (tramp-sh-handle-file-ownership-preserved-p):
      Likewise.
      (tramp-get-local-gid): Use group-gid for integer, as that's
      faster and more reliable.
      * src/dired.c (Ffile_attributes): Return t as the 9th attribute,
      to mark it as a placeholder.  The old value was often wrong.
      The only user of this attribute has been changed to use
      file-ownership-preserved-p instead, with its new group arg.
      * src/editfns.c (Fgroup_gid, Fgroup_real_gid): New functions.
      
      Fixes: debbugs:13125
      97976f9f
    • Stefan Monnier's avatar
    • Stefan Monnier's avatar
      * src/xdisp.c (select_frame_for_redisplay): Keep selected_window and · 26ec1f49
      Stefan Monnier authored
      selected_frame in sync.
      26ec1f49
    • Eli Zaretskii's avatar
      Speed up most calls to 'stat' and 'lstat' on MS-Windows. · 5c207910
      Eli Zaretskii authored
       src/w32.c (stat_worker): If w32_stat_get_owner_group is zero, do not
       try to get accurate owner and group information from NT file
       security APIs.  This is to make most callers of 'stat' and
       'lstat', which don't need that information, much faster.
       src/dired.c (Ffile_attributes) [WINDOWSNT]: Set
       w32_stat_get_owner_group to a non-zero value, to request accurate
       owner and group information from 'lstat'.
      
       nt/inc/sys/stat.h: Declare w32_stat_get_owner_group.
      5c207910
    • Eli Zaretskii's avatar
      Fix bug #12621 with crashes on MS-Windows in LookupAccountSid. · 92340ec7
      Eli Zaretskii authored
       src/w32.c (get_name_and_id): Always pass NULL as the first argument
       of lookup_account_sid.  Avoids crashes with UNC file names that
       refer to DFS domains, not to specific machine names.  (Bug#12621)
       Remove now unused argument FNAME; all callers changed.
       (get_file_owner_and_group): Remove now unused argument FNAME; all
       callers changed.
      92340ec7
  12. 13 Dec, 2012 4 commits
  13. 12 Dec, 2012 2 commits
  14. 11 Dec, 2012 1 commit