1. 11 Oct, 2015 1 commit
    • Paul Eggert's avatar
      Use ‘echo’ safely with ‘\’ or leading ‘-’ · 29dfca23
      Paul Eggert authored
      POSIX says that ‘echo FOO’ produces implementation-defined output
      if FOO contains leading ‘-’, or ‘\’ anywhere, so don’t assume GNU
      behavior in that case.
      * Makefile.in (removenullpaths): Remove.
      (epaths-force): Rewrite to avoid the need for ‘echo’.
      (install-etc): Be clearer about escaping the shell metacharacters
      ‘\’ and ‘$’.
      * Makefile.in (install-arch-indep, install-etcdoc):
      * admin/charsets/mapconv, admin/merge-gnulib, admin/merge-pkg-config:
      * admin/quick-install-emacs, build-aux/gitlog-to-emacslog:
      * configure.ac, lib-src/rcs2log, make-dist:
      * src/Makefile.in (lisp.mk):
      Don’t assume ‘echo’ outputs ‘\’ and leading ‘-’ unscathed.
      For example, use ‘printf '%s\n' "$foo"’ rather than ‘echo "$foo"’
      if $foo can contain arbitrary characters.
      * lisp/Makefile.in (TAGS): Use ‘ls’, not ‘echo’, to avoid ‘\’ issues.
      * doc/lispref/two-volume.make (vol1.pdf):
      * test/etags/make-src/Makefile (web ftp publish):
      Use ‘printf’ rather than ‘echo -e’.
      29dfca23
  2. 10 Oct, 2015 9 commits
  3. 09 Oct, 2015 13 commits
  4. 08 Oct, 2015 9 commits
    • Paul Eggert's avatar
      * src/image.c (image_size_error): Simplify. · a00634c2
      Paul Eggert authored
      a00634c2
    • Paul Eggert's avatar
      Fix problems caught with --enable-gcc-warnings · 5a3a6aa7
      Paul Eggert authored
      * src/image.c (lookup_rgb_color):
      * src/xfns.c (x_defined_color):
      * src/xterm.c (x_parse_color):
      Remove unused locals.
      5a3a6aa7
    • Jay Belanger's avatar
      52fecf53
    • Jay Belanger's avatar
      Format initial input uniformly. · 2124b332
      Jay Belanger authored
      * lisp/calc/calc.el (calc-digit-start-entry): New function.
      * lisp/calc/calc.el (calcDigit-start):
      * lisp/calc/calc-aent.el (calc-alg-digit-entry):
      Use `calc-digit-start-entry' to format input.
      2124b332
    • Ken Raeburn's avatar
      Disable non-working pointerColor setting for X tooltip frame. · 1f37714a
      Ken Raeburn authored
      It generates a bunch of server traffic, but there's some bug wherein
      the new mouse cursor settings don't seem to get used.  In most
      situations the cursor isn't likely to be seen anyway, so it's not
      urgent to fix.
      
      * src/xfns.c (x_create_tip_frame): Don't set pointerColor.
      1f37714a
    • Ken Raeburn's avatar
      Reduce some unnecessary X calls. · ee529429
      Ken Raeburn authored
      * src/xfns.c (x_real_pos_and_offsets): Remove a redundant XGetGeometry
      call.  If border width is wanted, get it from the XGetGeometry call
      instead of calling XGetWindowAttributes on the same window.  Skip some
      X calls if we've already detected an error from the X server.
      * src/xterm.c (x_wm_supports): Delete x_sync before x_had_errors_p.
      (handle_one_xevent): Delete XSync call before x_uncatch_errors.
      ee529429
    • Ken Raeburn's avatar
      Reduce color allocation/query traffic in the TrueColor case. · e23ed19f
      Ken Raeburn authored
      When working with an X visual with TrueColor class, pixel values can
      be generated from the RGB values according to mask value provided by
      the server on connection.  Some of the image-handling code was already
      doing this.
      
      * src/xterm.h (x_make_truecolor_pixel): New function; code taken from
      lookup_rgb_color.
      (x_mutable_colormap): New function.
      * src/image.c (lookup_rgb_color): Move pixel composition code to
      x_make_truecolor_pixel.
      (x_kill_gs_process): Call x_mutable_colormap.
      * src/xfaces.c (x_free_colors, x_free_dpy_colors): Call
      x_mutable_colormap.
      * src/xftfont.c (xftfont_get_colors): Call x_query_colors.
      * src/xterm.c (x_query_colors): For a TrueColor display, decompose the
      pixel value into RGB values directly, and don't send a request to the
      server.
      (x_alloc_nearest_color): For a TrueColor display, construct the pixel
      value with x_make_truecolor_pixel.
      (x_copy_color): For an immutable color map, just return the provided
      pixel value.
      e23ed19f
    • Ken Raeburn's avatar
      Cache XParseColor results in the X display info structure. · b8eea1d7
      Ken Raeburn authored
      With repeated lookups of foreground and background colors for multiple
      faces per frame, we issue a lot of redundant color name lookups to the
      X server, waiting every time for the response.  On a remote network
      with, say, 30ms round-trip time, this can add nearly a full second to
      creation of a new frame.
      
      * src/gtkutil.c (xg_check_special_colors): Call x_parse_color.
      * src/image.c (get_spec_bg_or_alpha_as_argb):
      (xpm_init_color_cache, xpm_lookup_color):
      * src/xfns.c (x_defined_color):
      * src/xterm.c (x_parse_color): New function; caches color names not
      starting with "#" in the display-info structure.
      (x_delete_display): Delete the cache content.
      * src/xterm.h (struct color_name_cache_entry): New type.
      (x_parse_color): Declare.
      (struct x_display_info): Add a new field for the cache.
      b8eea1d7
    • Stefan Monnier's avatar
  5. 07 Oct, 2015 8 commits