1. 10 Apr, 2021 6 commits
  2. 09 Apr, 2021 17 commits
    • Dmitry Gutov's avatar
      Don't stop when before space or closing paren · 0db2126d
      Dmitry Gutov authored
      * lisp/progmodes/elisp-mode.el (elisp-completion-at-point):
      Don't stop when before space or closing paren (bug#47665).
      0db2126d
    • Alan Mackenzie's avatar
      CC Mode: fix c-where-wrt-brace-construct to cope with class declarations · f493a9be
      Alan Mackenzie authored
      Make the function correctly recognize a brace block preceded by an
      introductory line without a parameter list.
      
      * lisp/progmodes/cc-cmds.el (c-where-wrt-brace-contruct): Reintroduce the use
      of c-beginning-of-decl-1, which was removed some weeks ago, in place of a
      c-syntactic-skip-backward.  Reformulate the code generally.
      f493a9be
    • Mattias Engdegård's avatar
      Fix condition-case optimiser bug · 59342f68
      Mattias Engdegård authored
      * lisp/emacs-lisp/byte-opt.el (byte-optimize-form-code-walker): Don't
      perform incorrect optimisations when a condition-case variable shadows
      another lexical variable.
      * test/lisp/emacs-lisp/bytecomp-tests.el (bytecomp-tests--test-cases):
      New test case.
      59342f68
    • Mattias Engdegård's avatar
      Better compiler warning tests · b7a7e879
      Mattias Engdegård authored
      These changes allow all bytecomp-tests to be run interactively.
      
      * test/lisp/emacs-lisp/bytecomp-tests.el (bytecomp--with-warning-test)
      (bytecomp--define-warning-file-test): Interpret any space in the
      pattern as arbitrary whitespace to tolerate line breaks.
      Don't abuse the expected-failure mechanism when checking
      for the expected absense of a warning.
      (bytecomp/*.el): Rewrite patterns to work with line breaks
      in the middle.
      b7a7e879
    • Mattias Engdegård's avatar
      Clean up bytecomp-tests.el · a2a7cfde
      Mattias Engdegård authored
      Now all test cases are run with both lexical and dynamic binding
      where applicable, comparing interpreted against compiled results.
      Previously, almost all tests were only run with dynamic binding
      which was definitely not intended.
      
      * test/lisp/emacs-lisp/bytecomp-tests.el
      (byte-opt-testsuite-arith-data): Rename to bytecomp-tests--test-cases.
      (bytecomp-check-1, bytecomp-explain-1, bytecomp-tests)
      (bytecomp-lexbind-tests, bytecomp-lexbind-check-1)
      (bytecomp-lexbind-explain-1): Remove.
      (bytecomp-tests--eval-interpreted, bytecomp-tests--eval-compiled)
      (bytecomp-tests-lexbind, bytecomp-tests-dynbind)
      (bytecomp-tests--test-cases-lexbind-only): New.
      a2a7cfde
    • Stefan Kangas's avatar
      Make refer-every into obsolete alias for seq-every-p · 40db6056
      Stefan Kangas authored
      * lisp/textmodes/refer.el (refer-every): Make into obsolete
      function alias for seq-every-p.  Update single caller.
      40db6056
    • Stefan Kangas's avatar
      Remove redundant #' before lambda in ibuf-*.el · 512ec97b
      Stefan Kangas authored
      * lisp/ibuf-ext.el (ibuffer-included-in-filters-p)
      (ibuffer-included-in-filter-p-1, ibuffer-do-kill-lines)
      (ibuffer-jump-to-buffer, ibuffer-mark-on-buffer)
      (ibuffer-mark-by-name-regexp, ibuffer-mark-by-mode-regexp)
      (ibuffer-mark-by-content-regexp, ibuffer-mark-by-mode)
      (ibuffer-mark-modified-buffers, ibuffer-mark-unsaved-buffers)
      (ibuffer-mark-dissociated-buffers, ibuffer-mark-help-buffers)
      (ibuffer-mark-compressed-file-buffers, ibuffer-mark-old-buffers)
      (ibuffer-mark-special-buffers, ibuffer-mark-read-only-buffers)
      (ibuffer-mark-dired-buffers, ibuffer-do-occur):
      * lisp/ibuf-macs.el (ibuffer-save-marks, define-ibuffer-sorter)
      (define-ibuffer-op): Remove redundant #' before lambda.
      512ec97b
    • Stefan Kangas's avatar
      Don't preserve window-line in tabulated-list-print · cdd72c5d
      Stefan Kangas authored
      * lisp/emacs-lisp/tabulated-list.el (tabulated-list-print): Don't
      try to preserve window-line.  (Bug#42747)
      cdd72c5d
    • Stefan Kangas's avatar
      Use lexical-binding in winner.el · 22515134
      Stefan Kangas authored
      * lisp/winner.el: Use lexical-binding.  Remove redundant :group
      args.
      (winner-set, winner-mode-map): Quote function symbols as such.
      22515134
    • Stefan Monnier's avatar
      e7ee3f73
    • Stefan Kangas's avatar
      Use lexical-binding in cmuscheme.el · fb596973
      Stefan Kangas authored
      * lisp/cmuscheme.el: Use lexical-binding.  Doc fixes.  Remove
      redundant :group args.  Quote function symbols as such.
      fb596973
    • Stefan Kangas's avatar
      caeb86b4
    • Stefan Kangas's avatar
      Use lexical-binding in foldout.el · 064d933e
      Stefan Kangas authored
      * lisp/foldout.el: Use lexical-binding.  Doc and formatting fixes.
      Quote function symbols as such.
      064d933e
    • Stefan Kangas's avatar
      Use lexical-binding in loadhist.el and add tests · 841dcfa7
      Stefan Kangas authored
      * lisp/loadhist.el: Use lexical-binding.
      * test/lisp/loadhist-tests.el: New file.
      841dcfa7
    • Mattias Engdegård's avatar
      Self-TCO in `condition-case` error handlers · 612d7316
      Mattias Engdegård authored
      * lisp/emacs-lisp/cl-macs.el (cl--self-tco): Recognise
      `condition-case` handlers as being in the tail position.
      * test/lisp/emacs-lisp/cl-macs-tests.el (cl-macs--labels):
      Extend test.
      612d7316
    • Jim Porter's avatar
      Fix hostname completion on MS Windows · 1d42f480
      Jim Porter authored
      * lisp/net/tramp.el (tramp-completion-file-name-regexp-default):
      Handle volume letter being added to paths for file name completion on W32
      systems.  This fixes hostname (and method) autocomplete on W32.
      
      Copyright-paperwork-exempt: yes
      1d42f480
    • Stefan Monnier's avatar
      * test/lisp/shadowfile-tests.el: Fix recent test failures · dfdec267
      Stefan Monnier authored
      (shadow--tests-cleanup): `shadow-hashtable` is now a hash table (duh!).
      dfdec267
  3. 08 Apr, 2021 12 commits
    • Stefan Monnier's avatar
      * lisp/progmodes/vhdl-mode.el: Use lexical-binding · 5b1e7af7
      Stefan Monnier authored
      Use #' to quote function names to get better compiler diagnostics.
      Wrap some lines to avoid arguments "hidden" in positions that are easy
      to misread.
      Prefix unused arguments with a semi-colon to silence compiler warnings.
      Fix a few comments that used ;;; even though they were not headings.
      
      (vhdl-emacs-21): Delete variable.
      Replace all uses with (not (featurep 'xemacs)) instead since `vhdl-mode`
      has been incompatible with Emacs<21 for more than 10 years already.
      (vhdl-prepare-search-1): Add Edebug declaration.
      (vhdl-prepare-search-2): Add Edebug declaration and use
      `with-syntax-table`.
      (vhdl-visit-file): Add Edebug and indentation declaration.
      Move the bulk of the code to a function for easier debugging.
      (vhdl--visit-file): New function extracted from `vhdl-visit-file`.
      Be careful not to modify syntax tables in unrelated buffers.
      (vhdl-speedbar-refresh): Remove unused var `pos`.
      (vhdl-backward-sexp): Remove unused var `last-forward`.
      (vhdl-electric-tab, vhdl-minibuffer-tab, vhdl-line-expand):
      Rename arg to avoid conflict with the `prefix-arg`
      global variable.
      (vhdl-align-region-1): Remove unused var `indent`.
      (vhdl-character-to-event): Actually give a body to that poor function.
      (vhdl-template-context): Remove unused vars `entity-exists` and `string`.
      (vhdl-template-group): Remove unused var `start`.
      (vhdl-template-argument-list): Remove unused var `start`.
      (vhdl-port-paste-context-clause): Remove unused var `margin`.
      (vhdl-port-paste-testbench): Remove unused var `source-buffer`.
      (vhdl-hs-minor-mode): Declare function `hs-hide-all`.
      (vhdl-get-hierarchy): Rename arguments `ent-alist`, `conf-alist`, and
      `conf-key` and bind those dynamically scoped var via `let` instead
      since arguments can't be dynamically scoped.
      (vhdl-speedbar-insert-hierarchy, vhdl-compose-configuration-architecture):
      Same thing with arguments `ent-alist` and `conf-alist`.
      (vhdl-cache-version): Declare variable.
      (speedbar-expand-line, speedbar-edit-line): Declare functions.
      (vhdl-speedbar-update-current-unit): Declare before first use.
      (vhdl-compose-new-component): Remove unused var `project`.
      (lazy-lock-minimum-size): Declare variable.
      (vhdl-submit-bug-report): Declare variable `reporter-prompt-for-summary-p`.
      5b1e7af7
    • Stefan Kangas's avatar
      Revert "Load all generic-x.el modes unconditionally" · 9a604501
      Stefan Kangas authored
      This reverts commit 0161c9df.
      9a604501
    • Stefan Monnier's avatar
      * lisp/shadowfile.el: Use lexical-binding · a4575655
      Stefan Monnier authored
      Delete redundant `:group` args.
      
      (shadow-hashtable): Make it an actual hash-table.
      (shadow-shadows-of, shadow-invalidate-hashtable): Adjust accordingly.
      (shadow-insert-var): Strength-reduce `eval` to `symbol-value`.
      (shadow--save-buffers-kill-emacs): New function extracted from
      `shadow-save-buffers-kill-emacs`.
      (shadow-save-buffers-kill-emacs): Use it and use `save-buffers-kill-emacs`.
      (shadow-initialize, shadowfile-unload-function):
      Use `advice-add/remove` rather than override `save-buffers-kill-emacs`
      with `defalias`.
      a4575655
    • Stefan Kangas's avatar
      Remove redundant #' before lambda in {calendar,erc,mh-e}/*.el · 3492cc36
      Stefan Kangas authored
      * lisp/calendar/icalendar.el (icalendar--get-most-recent-observance):
      * lisp/calendar/parse-time.el (parse-time-rules):
      * lisp/erc/erc-dcc.el (pcomplete/erc-mode/DCC):
      * lisp/erc/erc-track.el (erc-modified-channels-display):
      * lisp/erc/erc.el (erc-toggle-debug-irc-protocol)
      (erc-cmd-IGNORE, erc-cmd-JOIN, erc-default-server-handler)
      (erc-banlist-update):
      * lisp/mh-e/mh-search.el (mh-search, mh-mairix-convert-to-sop*)
      (mh-index-create-sequences):
      * lisp/mh-e/mh-thread.el (mh-toggle-threads, mh-thread-generate)
      (mh-thread-prune-containers, mh-thread-sort-containers):
      * lisp/mh-e/mh-utils.el (mh-sub-folders): Remove redundant #' before
      lambda.
      3492cc36
    • Gregory Heytings's avatar
      Terminate isearch when point has moved to another buffer · ff796823
      Gregory Heytings authored
      * lisp/isearch.el (isearch-post-command-hook): Terminate isearch
      when the command just executed has moved point to another buffer.
      https://lists.gnu.org/archive/html/emacs-devel/2021-04/msg00309.html
      ff796823
    • Gregory Heytings's avatar
      User option to move to another match when changing direction in isearch. · 972bab09
      Gregory Heytings authored
      * lisp/isearch.el (isearch-direction-change-changes-match):
      New user option (bug#47599).
      (isearch-repeat): Use the new option.
      (isearch-repeat-forward, isearch-repeat-backward): Adapt to the
      new option.
      
      * etc/NEWS: Mention the new user option.
      
      * doc/emacs/search.texi: Document the new user option.
      972bab09
    • Juri Linkov's avatar
      * lisp/repeat.el (repeat-post-hook): Check for prefix-arg. · b4eb84d4
      Juri Linkov authored
      This is instead of checking for a list of argument-related commands
      that set prefix-arg anyway.
      b4eb84d4
    • Juri Linkov's avatar
      * lisp/repeat.el (repeat-post-hook): Skip repeating in minibuffer (bug#47566). · 580c4c65
      Juri Linkov authored
      (repeat-map)<defvar>: Add docstring.
      580c4c65
    • Stefan Monnier's avatar
      * lisp/progmodes/vhdl-mode.el: Use progress-reporter · d365c947
      Stefan Monnier authored
      This was actually prompted by a backward compatibility problem
      (because of the use of Emacs-27's `time-convert`).  The new code
      seems to work fine in Emacs-25.
      It also fixes a minor bug that made the echo area messages of
      `vhdl-indent-region` compete with those of `indent-region`.
      
      (vhdl-progress-info): Delete variable.
      (vhdl--progress-reporter): New var to replace it.
      (vhdl-update-progress-info): Delete function.
      (vhdl-indent-line): Call progress-reporter-update instead.
      (vhdl-indent-region): Make it an obsolete alias of `indent-region`.
      Change all users.
      (vhdl-align-region-groups, vhdl-align-region, vhdl-fix-case-region-1):
      Use `make-progress-reporter` and `progress-reporter-update`.
      d365c947
    • Stefan Monnier's avatar
      * lisp/array.el: Use lexical-binding · a45493f2
      Stefan Monnier authored
      a45493f2
    • Michael Albinus's avatar
    • Michael Albinus's avatar
      Revert use of powershell in Tramp, there are collateral damages · 9e8ac1f5
      Michael Albinus authored
      * lisp/net/tramp-sh.el (tramp-methods) <sshx, scpx>: Fix quoting
      for MS Windows.
      (tramp-connection-properties): Don't set "encoding-shell".
      (tramp-actions-before-shell): Remove `tramp-no-job-control-regexp'.
      (tramp-maybe-open-connection): Revert changes for "encoding-shell".
      
      * lisp/net/tramp.el (tramp-no-job-control-regexp): Remove.
      9e8ac1f5
  4. 07 Apr, 2021 5 commits