1. 08 Apr, 2019 9 commits
    • Katsumi Yamaoka's avatar
      Make `move article' work again (bug#33653) · 3e5e097f
      Katsumi Yamaoka authored
      * lisp/gnus/gnus-sum.el (gnus-summary-move-article): Back to while loop
      m dolist that blocks nov and active from saving (bug#33653).
    • Stefan Monnier's avatar
      * lisp/gnus/gnus-sum.el: Prepare for lexical-binding · 36dc39bf
      Stefan Monnier authored
      Add defvars for all the gnus-tmp-*.
      (gnus-summary-make-local-variables): Move let binding to avoid setq.
      (gnus-set-global-variables): Use dolist.
      (gnus-summary-from-or-to-or-newsgroups, gnus-summary-insert-line)
      (gnus-summary-insert-dummy-line): Avoid dynbind args.
      (gnus-build-old-threads): Remove unused var 'id'.
      (gnus-nov-parse-line): Remove unused var 'buffer'.
      (gnus-thread-header): Prepare it for a lexbind world.
      (gnus-adjust-marked-articles): Remove unused var 'marks'.
      (gnus-mark-xrefs-as-read): Remove unused var 'idlist'.
      (gnus-summary-display-article): Erase&widen before mm-enable-multibyte.
      (gnus-summary-better-unread-subject): Remove unused var 'score'.
      (gnus-summary-find-matching): Remove unused var 'd'.
      (ps-right-header, ps-left-header, shr-ignore-cache): Declare vars.
      (gnus-summary-idna-message, gnus-summary-morse-message)
      Fix interactive spec since we don't actually use any prefix arg.
      (gnus-summary-move-article, gnus-read-move-group-name): Use user-error.
      (gnus-summary-move-article): Use dolist.
      (gnus-summary-edit-article): Fix unquoting.
      (gnus-summary-highlight-line-0, gnus-summary-highlight-line):
      Declare dynbind vars documented in gnus-summary-highlight.
    • Juri Linkov's avatar
      * lisp/vc/diff-mode.el (diff-syntax-fontify-props): Check both buffer-local · 0667c737
      Juri Linkov authored
      and default value of find-file-hook.
    • Paul Eggert's avatar
      Allow gap before first non-Lisp pseudovec member · a038df77
      Paul Eggert authored
      Problem reported by Keith David Bershatsky in:
      Solution suggested by Stefan Monnier in:
      * src/buffer.h (BUFFER_LISP_SIZE): Simplify by using PSEUDOVECSIZE.
      (BUFFER_REST_SIZE): Simplify by using VECSIZE and BUFFER_LISP_SIZE.
      * src/lisp.h (PSEUDOVECSIZE): Base it on the last Lisp field,
      not the first non-Lisp field.  All callers changed.  Callers
      without Lisp fields changed to use ALLOCATE_PLAIN_PSEUDOVECTOR.
    • Stefan Monnier's avatar
      * lisp/gnus/gnus-agent.el (gnus-agent-fetch-articles): Use match-string · 31e9087c
      Stefan Monnier authored
      (gnus-agent-expire-group-1): Dial down on the 'setq'.
    • Stefan Monnier's avatar
    • Stefan Monnier's avatar
      Eshell: Try to untangle the dependencies; move 'provide's to the end · 0d5e8361
      Stefan Monnier authored
      * lisp/eshell/esh-arg.el: Move defsubst and vars before first use.
      Don't require `esh-mode but esh-util instead.
      * lisp/eshell/esh-cmd.el: Require esh-module and esh-io.
      * lisp/eshell/esh-ext.el: Don't require esh-proc nor esh-cmd.
      (eshell-external-command): Require esh-proc for
      * lisp/eshell/esh-mode.el: Don't require esh-io nor esh-var, but
      require esh-arg.
      (eshell-directory-name): Move from eshell.el.
      * lisp/eshell/esh-module.el: Don't require eshell.
      * lisp/eshell/esh-opt.el: Don't require esh-ext at top-level.
      (eshell--do-opts, eshell-show-usage): Require it here instead.
      * lisp/eshell/esh-proc.el: Don't require esh-cmd, but require esh-io.
      (eshell-reset-after-proc, eshell-record-process-object)
      (eshell-gather-process-output, eshell-send-eof-to-process):
      Require esh-mode and esh-var here.
      * lisp/eshell/esh-var.el: Require esh-module, esh-arg, and esh-io.
      * lisp/eshell/eshell.el: Require esh-module, esh-proc, esh-io, and esh-cmd.
      But don't require esh-mode.
      (eshell-directory-name): Move to esh-mode.
      (eshell-return-exits-minibuffer): Don't bind 'return' and 'M-return'
      since we already bind RET and M-RET.
    • Michael Albinus's avatar
      Fix file-readable-p and file-executable-p in some Tramp backends · a20845c1
      Michael Albinus authored
      * lisp/net/tramp-archive.el (tramp-archive-handle-file-readable-p):
      Use tramp-gvfs.
      * lisp/net/tramp-gvfs.el (tramp-gvfs-handle-file-executable-p):
      Check that FILENAME exists.
      (tramp-gvfs-handle-file-readable-p): Check that FILENAME exists.
      Use heuristic in case it cannot be determined correctly.
    • Alexander Gramiak's avatar
      ; * src/frame.h (MonitorInfo): Remove const modifier · 0b8117ed
      Alexander Gramiak authored
      This removes a compiler warning with xfree.
  2. 07 Apr, 2019 14 commits
  3. 06 Apr, 2019 10 commits
  4. 05 Apr, 2019 5 commits
  5. 04 Apr, 2019 2 commits
    • Troy Hinckley's avatar
      Don't check comp-buffer-name-function in derived mode (Bug#34956) · 905f6195
      Troy Hinckley authored
      * lisp/progmodes/compile.el (define-compilation-mode): Remove
      'compilation-buffer-name-function' from the list of overridden
      variables to ensure that it is not mistaken for a variable that can be
      major mode specific.  'compilation-buffer-name-function' is used
      before the major mode is loaded, therefore overriding it here is
      ineffectual.  Also, the function 'compilation-start' takes an optional
      argument name-function, so there is already a mechanism to override
    • Basil L. Contovounesios's avatar
      Fix comment-empty-lines docstring (bug#35152) · 690c678f
      Basil L. Contovounesios authored
      * lisp/newcomment.el (comment-empty-lines): Consistently use US
      commas in docstring.  Fix indentation of and typo in custom :type.