1. 19 Mar, 2019 3 commits
    • Mattias Engdegård's avatar
      Disallow reversed char ranges in `rx' · 3ed1621d
      Mattias Engdegård authored
      (any "a-Z0-9") generated "[0-9]", and (any (?9 . ?0)) generated "[9-0]".
      Reversed ranges are either mistakes or abuse.  Neither should be allowed.
      
      etc/NEWS: Explain the change.
      lisp/emacs-lisp/rx.el (rx): Document.
      (rx-check-any-string, rx-check-any): Add error checks for reversed ranges.
      test/lisp/emacs-lisp/rx-tests.el (rx-char-any-range-bad): New test.
      3ed1621d
    • Paul Eggert's avatar
      Remove buggy regexp use in comint-output-filter · c0936672
      Paul Eggert authored
      This reverts commit 2012-07-02T16:18:02!monnier@iro.umontreal.ca
      which perhaps could be rethought and recommitted, and perhaps
      it’s no longer needed now that comint-use-prompt-regexp
      is almost always nil.
      * lisp/comint.el (comint-output-filter): Don’t try to skip
      repeated prompts, since comint-prompt-regexp typically begins
      with "^" and the resulting "^^" in the regular expression does
      not have the desired effect.  Noted by Mattias Engdegård in:
      https://lists.gnu.org/r/emacs-devel/2019-03/msg00380.html
      c0936672
    • Paul Eggert's avatar
      Fix more regular expression typos · bc2a93d5
      Paul Eggert authored
      Problem reported by Mattias Engdegård in:
      https://lists.gnu.org/r/emacs-devel/2019-03/msg00548.html
      except that I didn’t address the issues involving Hebrew,
      or involving comint-prompt-regexp.
      * lisp/align.el (align-rules-list, align-exclude-rules-list):
      * lisp/auth-source-pass.el (auth-source-pass--parse-secret)
      (auth-source-pass--parse-data):
      * lisp/cedet/data-debug.el (data-debug-next)
      (data-debug-prev, data-debug-expand-or-contract):
      * lisp/comint.el (comint-within-quotes):
      * lisp/emacs-lisp/checkdoc.el (checkdoc-this-string-valid-engine):
      * lisp/emulation/viper-ex.el (ex-cmd-complete):
      * lisp/gnus/gnus-cite.el (gnus-message-search-citation-line):
      * lisp/gnus/nnir.el (nnir-imap-end-of-input):
      * lisp/mail/mail-extr.el (mail-extr-all-letters):
      * lisp/minibuffer.el (minibuffer-maybe-quote-filename):
      * lisp/nxml/rng-nxml.el (rng-complete-tag)
      (rng-complete-end-tag, rng-complete-attribute-name):
      * lisp/obsolete/vip.el (vip-get-ex-token, vip-get-ex-pat):
      * lisp/org/org-pcomplete.el (org-thing-at-point):
      * lisp/org/org.el (org-set-tags)
      (org-increase-number-at-point)
      (org-fill-line-break-nobreak-p):
      * lisp/pcomplete.el (pcomplete-parse-comint-arguments):
      * lisp/progmodes/ada-mode.el (ada-compile-goto-error):
      * lisp/progmodes/cperl-mode.el (cperl-highlight-charclass)
      (cperl-find-pods-heres, cperl-not-bad-style-regexp)
      (cperl-regext-to-level-start):
      * lisp/progmodes/ebnf-yac.el (ebnf-yac-skip-spaces):
      * lisp/progmodes/flymake-proc.el (flymake-proc-master-tex-init):
      * lisp/progmodes/flymake.el (flymake-diag-region):
      * lisp/progmodes/fortran.el (fortran-current-line-indentation):
      * lisp/progmodes/idlw-complete-structtag.el:
      (idlwave-complete-structure-tag):
      * lisp/progmodes/idlwave.el (idlwave-complete-sysvar-or-tag):
      * lisp/progmodes/prolog.el (prolog-pred-end)
      (prolog-clause-info):
      * lisp/progmodes/ruby-mode.el (ruby-forward-sexp)
      (ruby-backward-sexp):
      * lisp/progmodes/verilog-mode.el (verilog-repair-open-comma):
      * lisp/term.el (term-within-quotes):
      * lisp/textmodes/bib-mode.el (bib-capitalize-title-stop-words):
      * lisp/textmodes/refbib.el (r2b-capitalize-title-stop-words):
      * lisp/textmodes/reftex-parse.el (reftex-nth-arg):
      * lisp/textmodes/rst.el (rst-svn-rev):
      * lisp/url/url-http.el (url-http-parse-response):
      * test/lisp/progmodes/f90-tests.el (f90-test-bug3730):
      Fix regular expression typos.
      bc2a93d5
  2. 18 Mar, 2019 3 commits
    • Stefan Monnier's avatar
      * src/fileio.c: Don't convert \r to \n just because of C-x $ · 7f6c6253
      Stefan Monnier authored
      (choose_write_coding_system): Setup the \r to \n conversion only if
      selective-display is t.
      7f6c6253
    • Stefan Monnier's avatar
      * lisp/locate.el (locate-mode): Setup invisibility for Dired commands · fa80f93a
      Stefan Monnier authored
      Also, use lexical-binding.
      fa80f93a
    • Stefan Monnier's avatar
      Ebrowse: Use invisibility-spec instead of selective-display · 799eb257
      Stefan Monnier authored
      * lisp/progmodes/ebrowse.el: Use lexical-binding.
      (ebrowse-tree-mode): Set invisibility-spec instead of selective-display.
      (ebrowse--hidden-p, ebrowse--hide, ebrowse--unhide): New functions.
      (ebrowse-expand-all, ebrowse-unhide-base-classes, ebrowse-hide-line)
      (ebrowse-mouse-1-in-tree-buffer): Use them.
      (ebrowse-output): Remove macro, use with-silent-modifications instead.
      (ebrowse-save-selective): Remove macro, not needed any more.
      (ebrowse-trim-string, ebrowse-read, ebrowse-collapse-fn):
      No need to pay attention to \r.
      (ebrowse-files-list): Use push.
      (ebrowse-view/find-file-and-search-pattern): Use add-hook here...
      (ebrowse-find-pattern): ...and remove-hook here.
      (ebrowse-view/find-position): Use add/remove-hook.
      799eb257
  3. 17 Mar, 2019 4 commits
  4. 16 Mar, 2019 6 commits
    • Alexander Gramiak's avatar
      Define macros to abstract support for external menu/tool-bars · cc06d768
      Alexander Gramiak authored
      * src/lisp.h (HAVE_EXT_MENU_BAR)
      (HAVE_EXT_TOOL_BAR): Define.
      
      *src/dispnew.c:
      *src/frame.c:
      *src/frame.h:
      *src/keyboard.c:
      *src/menu.c:
      *src/menu.h:
      *src/window.c:
      *src/window.h:
      *src/xdisp.c:
      *src/xfns: Use the new macros.
      cc06d768
    • Paul Eggert's avatar
      Fix regexp typo in vc-git--program-version · 7d8fe1f9
      Paul Eggert authored
      * lisp/vc/vc-git.el (vc-git--program-version):
      Require a period after ".windows", instead of allowing any char.
      7d8fe1f9
    • Mattias Engdegård's avatar
      Fix some ineffective backslashes in string literals · 8832cc5f
      Mattias Engdegård authored
      Deal with lone backslashes that have no effect in string literals,
      but indicate that something is amiss.
      
      * lisp/auth-source-pass.el (auth-source-pass-entries):
      * lisp/textmodes/artist.el (artist-figlet-get-font-list-windows):
      * lisp/org/ob-abc.el (org-babel-expand-body:abc, org-babel-execute:abc):
      * lisp/org/ob-forth.el (org-babel-forth-session-execute):
      * lisp/vc/vc-git.el (vc-git--program-version):
      Add backslash in regexp for correctness.
      
      * lisp/gnus/nnmail.el (nnmail-split-abbrev-alist):
      Replace `\||' with `\\|' to follow the obvious regexp intent.
      
      * lisp/org/org-list.el (org-plain-list-ordered-item-terminator):
      Add backslash in doc comment so that it appears as intended.
      
      * lisp/progmodes/cc-engine.el (c-forward-decl-or-cast-1, c-end-of-decl-1):
      * lisp/progmodes/f90.el (f90-font-lock-keywords-2):
      * lisp/progmodes/etags.el (etags-tags-completion-table):
      * lisp/progmodes/ruby-mode.el (ruby-syntax-propertize):
      * test/lisp/emacs-lisp/cl-print-tests.el (cl-print-tests-1):
      Remove superfluous backslashes from regexp.
      
      * test/lisp/emacs-lisp/rx-tests.el (rx-char-any):
      Remove superfluous backslash from doc comment.
      8832cc5f
    • Eli Zaretskii's avatar
      Improve locale and language environment setting at startup · 34dd4e0a
      Eli Zaretskii authored
      * lisp/international/mule-cmds.el (locale-language-names): Add
      more locales and their language environments.
      (set-locale-environment): Use w32-multibyte-code-page, if
      non-zero, as locale-coding-system.  (Bug#34684)
      
      * src/w32fns.c (globals_of_w32fns) <w32-multibyte-code-page>:
      New variable.
      
      * etc/NEWS: Mention w32-multibyte-code-page.
      34dd4e0a
    • Paul Eggert's avatar
      Bring back Emacs 26 compatibility to flymake.el · 164b78c7
      Paul Eggert authored
      * lisp/progmodes/flymake.el (flymake--schedule-timer-maybe):
      Revert to using seconds-to-time, since this file is part
      of ELPA and needs to work on Emacs 26 too.
      164b78c7
    • Paul Eggert's avatar
      Use bool for menu_items_inuse · 0eeb8c59
      Paul Eggert authored
      * src/menu.c (menu_items_inuse): Now bool, instead of a
      Lisp_Object that is always Qt or Qnil.  All uses changed.
      0eeb8c59
  5. 15 Mar, 2019 5 commits
  6. 13 Mar, 2019 9 commits
  7. 12 Mar, 2019 4 commits
    • Christopher Wellons's avatar
      * lisp/mail/hashcash.el: Get rid of backquoted lambdas · c8bf09ed
      Christopher Wellons authored
      Copyright-paperwork-exempt: yes
      
      (hashcash-generate-payment-async): η-reduce.
      (hashcash-insert-payment-async): Use proper closure.
      c8bf09ed
    • Michael Albinus's avatar
      * lisp/net/tramp-adb.el (tramp-adb-handle-make-process): · 3ec05e1c
      Michael Albinus authored
      Use proper range when deleting the region.
      3ec05e1c
    • Alan Mackenzie's avatar
      Correct the indentation of CC Mode brace lists · aa1a4cce
      Alan Mackenzie authored
      while preserving the indentation of nested C++ uniform initialization.
      
      * lisp/progmodes/cc-align.el (c-lineup-2nd-brace-entry-in-arglist)
      (c-lineup-class-decl-init-+, c-lineup-class-decl-init-after-brace): New
      indentation functions.
      
      * lisp/progmodes/cc-engine.el (c-forward-class-decl): New function.
      (c-do-declarators): New function, partially extracted from
      c-font-lock-declarators, which now calls the new function.
      (c-inside-bracelist-p): Amend the introductory comment.
      (c-add-stmt-syntax): Add code to prevent the spurious recognition of a
      'defun-block-intro when a brace pair is used as an initializer.
      (c-evaluate-offset): No longer ignore vectors of length >= 2.
      (c-calc-offset): Refactor clumsily nested `if'/`or' into a cond form.
      
      * lisp/progmodes/cc-fonts.el (c-font-lock-declarators): Replace the bulk of
      this function by a call to the new c-forward-class-decl.
      
      * lisp/progmodes/cc-langs.el (c-type-decl-prefix-key): Recognize "~" as a
      type decl operator.
      
      * lisp/progmodes/cc-mode.el (c-fl-decl-start): While searching backward for a
      "}" at an EOD, deal with actually finding the end of a brace list.
      
      * doc/misc/cc-mode.texi (List Line-Up): document
      c-lineup-2nd-brace-entry-in-arglist, c-lineup-class-decl-init-+, and
      c-lineup-class-decl-init-after-brace.
      
      * lisp/progmodes/cc-styles.el (c-style-alist): In styles "gnu", "bsd",
      "stroustrup", "python", and "java", change the offset for brace-list-intro
      from the default value or c-lineup-arglist-intro-after-paren to a list
      beginning with the symbol first, followed by two of the new alignment
      functions, followed by +.
      
      * lisp/progmodes/cc-vars.el (c-offset-alist): Change the default value of
      brace-list-entry from c-lineup-under-anchor back to 0.
      aa1a4cce
    • Martin Rudalics's avatar
      Revert last tweak in 'comint-output-filter' · d58c29b3
      Martin Rudalics authored
      * lisp/comint.el (comint-output-filter): Revert last tweak because
      it can hang gdb indefinitely.
      d58c29b3
  8. 11 Mar, 2019 6 commits
    • Paul Eggert's avatar
      Reindent pdumper per usual Emacs style · 1d65985a
      Paul Eggert authored
      * src/pdumper.c, src/pdumper.h: Reindent.
      1d65985a
    • Eli Zaretskii's avatar
      Fix show-trailing-whitespace in R2L text · 7fddde1f
      Eli Zaretskii authored
      * src/xdisp.c (highlight_trailing_whitespace): Allow for
      stretch glyphs at the left edge of R2L lines, when skipping
      glyphs inserted by the display engine.  This unbreaks
      show-trailing-whitespace in R2L lines.
      7fddde1f
    • Paul Eggert's avatar
      Fix a small pdumper memory leak · 93c0527a
      Paul Eggert authored
      * src/pdumper.c (dump_mmap_reset): Free the private area here ...
      (dump_mm_heap_cb_release): ... instead of here.
      (dump_mmap_release_heap): Simplify by avoiding a local.
      (dump_mmap_contiguous): Reindent GNU style.
      93c0527a
    • Martin Rudalics's avatar
      Rewrite minibuffer window resizing code · 95373b69
      Martin Rudalics authored
      * src/frame.c (resize_mini_frames): New variable.
      * src/window.c (resize_mini_window_apply): New function.
      (grow_mini_window, shrink_mini_window): Remove PIXELWISE
      argument.  Call resize_mini_window_apply to apply changes.
      (Fresize_mini_window_internal): Call resize_mini_window_apply
      to apply changes.
      (Qwindow__resize_mini_frame): New symbol.
      * src/window.h (grow_mini_window, shrink_mini_window): Adjust
      external declarations.
      * src/xdisp.c (resize_mini_window): For minibuffer-only frames
      call 'window--resize-mini-frame' if resize_mini_frames is
      non-nil.  Offload parts of logic to grow_mini_window and
      shrink_mini_window which are now called without the PIXELWISE
      argument.
      (Vresize_mini_windows): Mention 'resize-mini-frames' in
      doc-string.
      * lisp/cus-start.el (resize-mini-frames): Add customization
      support.
      * lisp/window.el (window--resize-mini-window): Simplify code.
      (window--resize-mini-frame): New function.
      * doc/lispref/minibuf.texi (Minibuffer Windows): Describe new
      option 'resize-mini-frames'.
      * etc/NEWS: Mention new option 'resize-mini-frames'.
      95373b69
    • Paul Eggert's avatar
      * src/editfns.c: Fix docstring typo. · 27466c62
      Paul Eggert authored
      27466c62
    • Paul Eggert's avatar
      Improve binary-as-unsigned treatment (Bug#34792) · 9b4d34fa
      Paul Eggert authored
      * etc/NEWS:
      * src/editfns.c (Fformat, binary_as_unsigned):
      Update now that we always have bignums.
      (syms_of_editfns) [!defined lisp_h_FIXNUMP]: Remove now-obsolete
      code, since lisp_h_FIXNUMP is always defined now.
      * test/src/editfns-tests.el (read-large-integer): Simplify,
      now that we can assume binary-as-unsigned defaults to nil.
      9b4d34fa