1. 30 Jul, 2013 4 commits
    • Paul Eggert's avatar
      Fix tempfile bug on platforms lacking mkostemp and mkstemp. · f4b169ce
      Paul Eggert authored
      * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
      Do not assume that emacs_close (INT_MAX) is a no-op.
      Fixes: debbugs:14986
    • Dmitry Antipov's avatar
      * xfaces.c (make_face_cache): For struct face_cache, prefer · bee6a2c7
      Dmitry Antipov authored
      xmalloc to xzalloc and so avoid redundant call to memset.
      (Finternal_set_lisp_face_attribute): Fix comment typo and style.
    • Dmitry Antipov's avatar
      * fringe.c (draw_window_fringes, update_window_fringes) · d7e6881a
      Dmitry Antipov authored
      * w32term.c (x_draw_glyph_string):
      * window.c (candidate_window_p, Frecenter):
      * xfaces.c (realize_basic_faces, realize_default_face)
      (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
      (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
      * xfns.c (x_set_cursor_color, xic_free_xfontset):
      * xmenu.c (Fx_menu_bar_open_internal):
      * xselect.c (x_reply_selection_request, Fx_get_atom_name):
      * xsettings.c (xft_settings_event):
      * xterm.c (x_draw_glyph_string, x_had_errors_p):
      Use bool for booleans.  Adjust style and comments where
      * dispextern.h (draw_window_fringes, update_window_fringes)
      * xterm.h (x_had_errors_p): Adjust prototype.
    • Dmitry Antipov's avatar
      * frame.c (Fmodify_frame_parameters): Always check 2nd arg with · ec3058af
      Dmitry Antipov authored
      CHECK_LIST.  Rewrite the loop to avoid useless local variable.
  2. 29 Jul, 2013 1 commit
  3. 28 Jul, 2013 2 commits
  4. 27 Jul, 2013 1 commit
    • Eli Zaretskii's avatar
      Fix focus-out events on MS-Windows. · e95da6d3
      Eli Zaretskii authored
       src/w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
       w32_detect_focus_change instead of doing part of its job by hand.
       This fixes the problem whereby FOCUS_OUT events were not sent to
       the event queue.
  5. 26 Jul, 2013 4 commits
    • Eli Zaretskii's avatar
      Fix documentation of list-processes and process-list. · fec92060
      Eli Zaretskii authored
       src/process.c (Fprocess_list): Doc fix.
       lisp/simple.el (list-processes): Doc fix.
    • Eli Zaretskii's avatar
      Fix bug #14841 with invisible frames on MS-Windows. · a8f93651
      Eli Zaretskii authored
       src/w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
       being re-exposed only if it didn't ask to become visible.
       <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
       was previously iconified.
       (x_iconify_frame): Mark the frame iconified.
    • Paul Eggert's avatar
      Fix minor problems found by static checking. · d5a7a9d9
      Paul Eggert authored
      * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
      (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
    • Stefan Monnier's avatar
      Add support for lexical variables to the debugger's `e' command. · 56ea7291
      Stefan Monnier authored
      * lisp/emacs-lisp/debug.el (debug): Don't let-bind the debugger-outer-*
      vars, except for debugger-outer-match-data.
      (debugger-frame-number): Move check for "on a function call" from
      callers into it.  Add `skip-base' argument.
      (debugger-frame, debugger-frame-clear): Simplify accordingly.
      (debugger-env-macro): Only reset the state stored in non-variables,
      i.e. current-buffer and match-data.
      (debugger-eval-expression): Rewrite using backtrace-eval.
      * lisp/subr.el (internal--called-interactively-p--get-frame): Remove.
      * lisp/emacs-lisp/edebug.el (edebug--called-interactively-skip): Use the new
      `base' arg of backtrace-frame instead.
      * src/eval.c (set_specpdl_old_value): New function.
      (unbind_to): Minor simplification.
      (get_backtrace_frame): New function.
      (Fbacktrace_frame): Use it.  Add `base' argument.
      (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
      (syms_of_eval): Export backtrace-eval.
      * src/xterm.c (x_focus_changed): Simplify.
  6. 25 Jul, 2013 1 commit
  7. 24 Jul, 2013 3 commits
  8. 23 Jul, 2013 6 commits
  9. 22 Jul, 2013 1 commit
  10. 21 Jul, 2013 4 commits
  11. 20 Jul, 2013 4 commits
  12. 19 Jul, 2013 8 commits
    • Paul Eggert's avatar
      Fix some minor file descriptor leaks and related glitches. · 3f5bef16
      Paul Eggert authored
      * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
      (create_lock_file): Use write, not emacs_write.
      * image.c (slurp_file, png_load_body):
      * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
      Don't leak an fd on memory allocation failure.
      * image.c (slurp_file): Add a cheap heuristic for growing files.
      * xfaces.c (Fx_load_color_file): Block input around the fopen too,
      as that's what the other routines do.  Maybe input need not be
      blocked at all, but it's better to be consistent.
      Avoid undefined behavior when strlen is zero.
    • Paul Eggert's avatar
      * alloc.c (staticpro): Avoid buffer overrun on repeated calls. · 4195afc3
      Paul Eggert authored
      (NSTATICS): Now a constant; doesn't need to be a macro.
    • Richard M. Stallman's avatar
    • Paul Eggert's avatar
    • Eli Zaretskii's avatar
      Fix the fix for bug #14901. · 621dd9ac
      Eli Zaretskii authored
       src/keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
       unportable 'struct x_display_info'.
       (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
       is a portable type.
    • Paul Eggert's avatar
      * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues. · ab9980cd
      Paul Eggert authored
      (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
      or fscanf fails.
      (system_process_attributes): Prefer plain char to unsigned char
      when either will do.  Clean up properly if interrupted or if
      memory allocations fail.  Don't assume sscanf succeeds.  Remove
      no-longer-needed workaround to stop GCC from whining.  Read
      command-line once, instead of multiple times.  Check read status a
      bit more carefully.
    • Paul Eggert's avatar
      Fix obscure porting bug with varargs functions. · 1396ac86
      Paul Eggert authored
      The code assumed that int is treated like ptrdiff_t in a vararg
      function, which is not a portable assumption.  There was a similar
      -- though these days less likely -- porting problem with various
      assumptions that pointers of different types all smell the same as
      far as vararg functions is conserved.  To make this problem less
      likely in the future, redo the API to use varargs functions.
      * alloc.c (make_save_value): Remove this vararg function.
      All uses changed to ...
      (make_save_int_int_int, make_save_obj_obj_obj_obj)
      (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
      New functions.
      (make_save_ptr): Rename from make_save_pointer, for consistency with
      the above.  Define only on platforms that need it.  All uses changed.
    • Juanma Barranquero's avatar
  13. 18 Jul, 2013 1 commit