1. 09 May, 2011 1 commit
    • Chong Yidong's avatar
      Various fixes to compilation-error-regexp-alist-alist. · 4c44026c
      Chong Yidong authored
      * lisp/progmodes/compile.el (compilation-error-regexp-alist-alist): Fix
      the ant regexp to handle end-line and end-column info from jikes.
      Re-introduce maven regexp.  Give the ruby-Test::Unit regexp a
      higher priority to avoid clobbering by gnu.
  2. 08 May, 2011 1 commit
    • Chong Yidong's avatar
      Perform grep-mode's buffer modifications in a process filter (Bug#7952) · d9c54a06
      Chong Yidong authored
      * progmodes/grep.el (grep-mode-font-lock-keywords): Remove
      buffer-changing entries.
      (grep-filter): New function.
      (grep-mode): Add it to compilation-filter-hook.
      * progmodes/compile.el (compilation-filter-hook)
      (compilation-filter-start): New defvars.
      (compilation-filter): Call compilation-filter-hook prior to
      updating the process mark.
  3. 22 Apr, 2011 1 commit
  4. 12 Mar, 2011 1 commit
  5. 19 Feb, 2011 1 commit
    • Chong Yidong's avatar
      Improvements to vc-bzr conffile handling and pull/merge support. · 3ab713fd
      Chong Yidong authored
      * vc/vc-bzr.el (vc-bzr--branch-conf): Function deleted.
      (vc-bzr-branch-conf): New function, similar to vc-bzr--branch-conf
      but returning an alist.  Ignore comments in bzr conffile.
      (vc-bzr-pull, vc-bzr-merge-branch): Use vc-bzr-branch-conf.
      (vc-bzr-error-regex-alist): New var.
      (vc-bzr-merge-branch): Use it to highlight the pull/merge buffer.
      * progmodes/compile.el (compilation--flush-directory-cache):
      Handle the case where cdr of compilation--flush-directory-cache
      points to no buffer, which can occur if we previously switched to
      compilation-mode in a pregenerated buffer.
      * vc/vc-dispatcher.el (vc-do-async-command): Bind
      inhibit-read-only to t.
  6. 02 Feb, 2011 1 commit
    • Chong Yidong's avatar
      * progmodes/compile.el: Make all faces inherit from font-lock faces. · 90db975f
      Chong Yidong authored
      (compilation-warning): Inherit from font-lock-variable-name-face.
      (compilation-info): Inherit from font-lock-type-face.
      (compilation-line-number): Reassign to font-lock-keyword-face.
      (compilation-column-number): Reassign to font-lock-doc-face.
      (compilation-leave-directory-face): Reassign to font-lock-builtin-face.
  7. 01 Feb, 2011 2 commits
    • Sam Steingold's avatar
      * lisp/simple.el (special-mode-map): Bind "h" to `describe-mode'; · abef340a
      Sam Steingold authored
      bind "z" to `kill-this-buffer'.
      (completion-list-mode-map): Bind "z" to `kill-this-buffer'.
      * lisp/apropos.el (apropos-mode-map): Inherit from `special-mode-map'.
      (apropos-mode): Inherit from `special-mode'.
      * lisp/arc-mode.el (archive-mode-map): Inherit from `special-mode-map'.
      * lisp/bookmark.el (bookmark-bmenu-mode): Define using
      `define-derived-mode' inheriting from `special-mode'.
      * lisp/dired.el (dired-mode-map): Inherit from `special-mode-map'.
      * lisp/image-mode.el (image-mode-map): Ditto.
      * lisp/replace.el (occur-mode): Define using
      `define-derived-mode' inheriting from `special-mode'.
      * lisp/tar-mode.el (tar-mode): Inherit from `special-mode'.
      * lisp/calendar/diary-lib.el (diary-fancy-display-mode):
      Inherit from `special-mode-map'.
      * lisp/emacs-lisp/ert.el (ert-simple-view-mode, ert-results-mode):
      Inherit from `special-mode'.
      * lisp/emacs-lisp/package.el (package-menu-mode-map): Copy from
      (package-menu-mode): Define using `define-derived-mode'
      inheriting from `special-mode'.
      * erc/erc-list.el (erc-list-menu-mode): Inherit from `special-mode'.
      * lisp/net/xesam.el (xesam-mode): Inherit from `special-mode'.
      (xesam-mode-map): Define separately.
      * lisp/play/solitaire.el (solitaire-mode): Inherit from `special-mode'.
      * lisp/progmodes/compile.el (compilation-minor-mode-map)
      (compilation-mode-map): Inherit from `special-mode-map'.
      * lisp/vc/diff-mode.el (diff-mode-shared-map):
      Inherit from `special-mode-map'.
      * lisp/vc/log-view.el (log-view-mode-map): Add a comment.
    • Stefan Monnier's avatar
      * lisp/progmodes/compile.el (compilation-next-error): Check there's · 7d116647
      Stefan Monnier authored
      a message before using it.
      Fixes: debbugs:7941
  8. 31 Jan, 2011 3 commits
  9. 29 Jan, 2011 1 commit
    • Stefan Monnier's avatar
      * lisp/progmodes/compile.el: Avoid an N² behavior in grep. · e52f87a1
      Stefan Monnier authored
      (compilation--previous-directory): New fun.
      (compilation--previous-directory-cache): New var.
      (compilation--remove-properties): Flush it.
      (compilation-directory-properties, compilation-error-properties):
      Use the new fun to speed up looking for the current directory.
  10. 28 Jan, 2011 3 commits
    • Stefan Monnier's avatar
      * lisp/progmodes/compile.el: Don't use font-lock any more. · 55fb9013
      Stefan Monnier authored
      (compilation-error-regexp-alist-alist): Change handling of makepp
      so it preserves the warning/error distinction on subsequent files.
      Simplify various rules.
      (compilation-directory-properties): Use font-lock-face.
      Add a compilation-message property.
      (compilation-internal-error-properties): Use font-lock-face.
      Don't set the compilation-debug property here.
      (compilation--put-prop, compilation--remove-properties)
      (compilation--parse-region, compilation--ensure-parse)
      (compilation--ensure-parse): New functions.
      (compilation-parse-errors): New function, largely inspired of
      compilation-mode-font-lock-keywords.  Set compilation-debug here.
      (compilation--parsed): New var.
      (compilation--flush-parse): Use compilation--ensure-parse.
      (compilation-start): Don't call font-lock.
      (compilation-turn-on-font-lock): Remove.
      (compilation-setup): Don't set font-lock-extra-managed-props not change
      other font-lock settings, other than keywords.
      Don't activate font-lock-mode.
      Set change-major-mode-hook and before-change-functions.
      (compilation--unsetup): Remove properties and hooks.
      (compilation-next-single-property-change): New function.
      (compilation-next-error): Use it to parse when needed.
      (compile-goto-error): Parse buffer as needed.
      (compilation--compat-error-properties): Don't need a dummy `face'
      property any more.
    • Stefan Monnier's avatar
      * lisp/progmodes/compile.el: Use accessors for clarity and fix omake hack. · 8fe52384
      Stefan Monnier authored
      (compilation-process-setup-function): Fix docstring's false promises.
      (compilation-error-regexp-alist-alist): Catch omake's continuous
      recompilation message and avoid reuse of old markers.
      (compilation-parse-errors-function): Declare obsolete.
      (compilation-buffer-modtime): Remove.
      (compilation--make-cdrloc, compilation--loc->col)
      (compilation--loc->line, compilation--loc->file-struct)
      (compilation--loc->marker, compilation--loc->visited)
      (compilation--make-file-struct, compilation--file-struct->file-spec)
      (compilation--file-struct->loc-tree): New macros.  Use them.
      (compilation--message): New defstruct.  Use them.
      (compilation-next-error-function): Don't mess with timestamps to try
      and guess when to reparse.
    • Stefan Monnier's avatar
      Minor cleanup for compile.el and grep.el. · 07b741a7
      Stefan Monnier authored
      * lisp/progmodes/compile.el: Cleanup text-properties namespace by using
      `compilation-message' instead of `message', `compilation-directory'
      instead of `directory', and `compilation-debug' instead of `debug'.
      (compilation-last-buffer, compilation-parsing-end)
      (compilation-error-list, compilation-old-error-list): Move to the
      compatibility part of the code.
      (compilation-error-properties): If `file' is a function, let it return
      a file name.
      (compilation-mode-font-lock-keywords): Be more conservative with the
      omake "^ *" pattern prefix, to try and minimize the risk of
      pathologically slow regexp matching.
      (compilation-start): Use inhibit-read-only.
      (compilation--unsetup): New function.
      (compilation-shell-minor-mode, compilation-minor-mode): Use it.
      (compilation-filter): Minor tweaks.
      (compilation-next-error-function): Try and avoid abusing variable names.
      (compilation--flush-file-structure): New fun.
      (compilation-fake-loc): Use it for cleaner behavior when file is reused.
      (debug-ignored-errors): Add "Moved past last ...".
      (compilation--compat-parse-errors): Rename by doubling the "-".
      * lisp/progmodes/grep.el (grep-regexp-alist): Tighten regexp.
      (grep-mode-font-lock-keywords): Remove regexp that seems like
      a left-over from before we used compile.el.
      (grep-mode-font-lock-keywords): Call syntax-ppss-flush-cache when
      modifying the buffer within with-silent-modifications.
  11. 25 Jan, 2011 1 commit
  12. 21 Jan, 2011 1 commit
  13. 15 Jan, 2011 1 commit
  14. 09 Jan, 2011 1 commit
    • Chong Yidong's avatar
      Tweaks to tool-bar for default, VC-dir, Compile, and Info. · 900503ae
      Chong Yidong authored
      * tool-bar.el (tool-bar-setup): Remove Help button.  Remove label
      from Search and add a label to Undo.
      * vc/vc-dir.el (vc-dir-tool-bar-map): Rearrange, removing
      inappropriate buttons and adding :vert-only tags.
      * progmodes/compile.el (compilation-mode-tool-bar-map): Adjust to
      removal of Help tool-bar button.  Remove Undo button for space.
      * info.el (info-tool-bar-map): Add :vert-only tags.
  15. 08 Jan, 2011 2 commits
  16. 02 Jan, 2011 1 commit
  17. 10 Dec, 2010 1 commit
    • Stefan Monnier's avatar
      Derive from prog-mode, use derived-mode-p, and fix up various · 175069ef
      Stefan Monnier authored
      minor style issues in lisp/progmodes.
      * lisp/progmodes/vhdl-mode.el (vhdl-write-file-hooks-init)
      (vhdl-hs-minor-mode, vhdl-ps-print-init): Fix make-local-variable ->
      * lisp/progmodes/sh-script.el (sh-require-final-newline): Remove.
      (sh-set-shell): Don't set require-final-newline since it's already done
      by prog-mode.
      * lisp/progmodes/modula2.el (m2-mode): Don't make m2-end-comment-column
      since we never set it.
      * lisp/progmodes/ebrowse.el (ebrowse-set-tree-indentation):
      Use read-string and standard prompt.
      * lisp/progmodes/dcl-mode.el (dcl-mode-map): Move init into declaration.
      * lisp/progmodes/meta-mode.el (meta-mode-abbrev-table): Merge init and decl.
      (meta-common-mode-syntax-table): Rename from meta-mode-syntax-table.
      (meta-common-mode-map): Rename from meta-mode-map.
      Remove C-m binding, which is a user preference, not mode specific.
      (meta-common-mode): New major mode; replace meta-common-initialization.
      * lisp/progmodes/js.el (js-mode): Call syntax-propertize rather than messing
      around with font-lock.
      * lisp/progmodes/etags.el (select-tags-table-mode):
      Derive from special-mode.
      * lisp/progmodes/octave-mod.el (octave-mode):
      * lisp/progmodes/gdb-mi.el (gdb-inferior-io-mode, gdb-threads-mode)
      (gdb-memory-mode, gdb-disassembly-mode, gdb-breakpoints-mode)
      (gdb-frames-mode, gdb-locals-mode, gdb-registers-mode):
      Let define-derived-mode do its job.
      * lisp/progmodes/cpp.el (cpp-edit-mode-map):
      Move initialization into declaration.
      (cpp-edit-mode): Use define-derived-mode.
      (cpp-edit-load): Use derived-mode-p.
      * lisp/progmodes/mixal-mode.el (mixal-mode):
      * lisp/progmodes/f90.el (f90-mode):
      * lisp/progmodes/cfengine.el (cfengine-mode): Don't bother setting
      require-final-newline since prog-mode does it already.
      * lisp/progmodes/cc-cmds.el (c-update-modeline): Use match-string.
      * lisp/progmodes/asm-mode.el (asm-mode-map): Fix menu setup.
      * lisp/progmodes/antlr-mode.el: Require cc-mode upfront.
      (antlr-mode-syntax-table, antlr-action-syntax-table): Initialize in
      the declaration.
      (antlr-directory-dependencies, antlr-show-makefile-rules):
      Use derived-mode-p.
      (antlr-language-option): Don't assume point-min==1.
      (antlr-mode): Use define-derived-mode.
      * lisp/progmodes/ada-mode.el: Use derived-mode-p.
      (ada-mode): Use define-derived-mode.
      Use hack-local-variables-hook.
      * lisp/progmodes/vhdl-mode.el (vhdl-mode):
      * lisp/progmodes/verilog-mode.el (verilog-mode):
      * lisp/progmodes/vera-mode.el (vera-mode):
      * lisp/progmodes/sql.el (sql-mode):
      * lisp/progmodes/scheme.el (scheme-mode):
      * lisp/progmodes/perl-mode.el (perl-mode):
      * lisp/progmodes/octave-inf.el (inferior-octave-mode):
      * lisp/progmodes/autoconf.el (autoconf-mode):
      * lisp/progmodes/m4-mode.el (m4-mode):
      * lisp/progmodes/inf-lisp.el (inferior-lisp-mode):
      * lisp/progmodes/idlwave.el (idlwave-mode):
      * lisp/progmodes/icon.el (icon-mode):
      * lisp/progmodes/idlw-help.el (idlwave-help-mode):
      * lisp/progmodes/dcl-mode.el (dcl-mode):
      * lisp/progmodes/idlw-shell.el (idlwave-shell-mode):
      * lisp/progmodes/ebrowse.el (ebrowse-tree-mode, ebrowse-electric-list-mode)
      (ebrowse-member-mode, ebrowse-electric-position-mode):
      Use define-derived-mode.
      * lisp/progmodes/xscheme.el (xscheme-start)
      (local-set-scheme-interaction-buffer, scheme-interaction-mode):
      * lisp/progmodes/which-func.el (which-function):
      * lisp/progmodes/vhdl-mode.el (vhdl-set-style):
      * lisp/progmodes/verilog-mode.el (verilog-set-compile-command)
      (verilog-modify-compile-command, verilog-error-regexp-add-xemacs)
      (verilog-set-define, verilog-auto-reeval-locals):
      * lisp/progmodes/sql.el (sql-product-font-lock, sql-interactive-mode):
      * lisp/progmodes/simula.el (simula-mode):
      * lisp/progmodes/scheme.el (scheme-mode-variables, dsssl-mode):
      * lisp/progmodes/python.el (python-check, python-mode):
      * lisp/progmodes/prolog.el (prolog-mode-variables):
      * lisp/progmodes/gud.el (gud-tooltip-activate-mouse-motions):
      * lisp/progmodes/ebrowse.el (ebrowse-view-file-other-frame):
      * lisp/progmodes/delphi.el (delphi-mode):
      * lisp/progmodes/cc-styles.el (c-setup-paragraph-variables):
      * lisp/progmodes/cc-mode.el (c-basic-common-init, c-common-init)
      (c-font-lock-init): Move make-local-variable to their setq.
      * lisp/progmodes/xscheme.el (exit-scheme-interaction-mode)
      (xscheme-enter-interaction-mode, xscheme-enter-debugger-mode)
      (xscheme-debugger-mode-p, xscheme-send-string-1):
      * lisp/progmodes/tcl.el (inferior-tcl-proc, tcl-current-word)
      (tcl-load-file, tcl-restart-with-file):
      * lisp/progmodes/ps-mode.el (ps-run-running):
      * lisp/progmodes/gdb-mi.el (gud-watch, gdb-mouse-set-clear-breakpoint):
      * lisp/progmodes/js.el (js--get-all-known-symbols):
      * lisp/progmodes/inf-lisp.el (inferior-lisp-proc):
      * lisp/progmodes/idlwave.el (idlwave-beginning-of-statement)
      (idlwave-template, idlwave-update-buffer-routine-info)
      (idlwave-get-routine-info-from-buffers, idlwave-choose)
      (idlwave-scan-class-info, idlwave-fix-keywords)
      * lisp/progmodes/idlw-toolbar.el (idlwave-toolbar, idlwave-toolbar-add)
      * lisp/progmodes/idlw-shell.el (idlwave-shell-save-and-action)
      (idlwave-shell-file-name, idlwave-shell-electric-debug-all-off)
      * lisp/progmodes/idlw-complete-structtag.el
      * lisp/progmodes/gud.el (gud-set-buffer):
      * lisp/progmodes/f90.el (f90-backslash-not-special):
      * lisp/progmodes/delphi.el (delphi-find-unit): Use derived-mode-p.
  18. 28 Oct, 2010 1 commit
  19. 24 Sep, 2010 1 commit
    • Glenn Morris's avatar
      Move some autoloaded auto-mode-alist entries to files.el. · 5e339ee2
      Glenn Morris authored
      * image-mode.el, progmodes/compile.el, progmodes/gud.el:
      * progmodes/mixal-mode.el, textmodes/bibtex-style.el:
      * textmodes/css-mode.el, textmodes/dns-mode.el:
      Move autoloaded auto-mode-alist entries to files.el.
      * files.el (auto-mode-alist): Move entries here.
  20. 08 Sep, 2010 1 commit
  21. 04 Sep, 2010 1 commit
    • Chong Yidong's avatar
      Fix Ruby compilation error matching. · 13ef65a4
      Chong Yidong authored
      * progmodes/compile.el (compilation-error-regexp-alist-alist):
      Remove ruby regexp; handle Ruby errors with gcc-include and gnu.
      Recognize leading tab in gcc-include regexp.  Ignore names with
      leading "from" or "in" in gnu regexp (Bug#6937).
  22. 15 Aug, 2010 1 commit
  23. 17 Jul, 2010 1 commit
  24. 10 Jul, 2010 1 commit
  25. 08 May, 2010 1 commit
  26. 23 Apr, 2010 1 commit
  27. 20 Apr, 2010 1 commit
  28. 10 Apr, 2010 1 commit
  29. 09 Apr, 2010 1 commit
  30. 07 Apr, 2010 1 commit
  31. 28 Mar, 2010 1 commit
  32. 24 Mar, 2010 1 commit
  33. 23 Mar, 2010 1 commit
    • Sam Steingold's avatar
      Fix bug#5620: recalculate all markers on compilation buffer · f4087766
      Sam Steingold authored
      modifications, not on file modifications.
      (buffer-modtime): New buffer-local variable:
      the buffer modification time, for buffers not associated with files.
      (compilation-mode): Create it.
      (compilation-filter): Update it.
      (compilation-next-error-function): Use it instead of
      `visited-file-modtime' for timestamp.
  34. 20 Feb, 2010 1 commit