1. 21 Jun, 2016 2 commits
    • Ken Brown's avatar
      Fix compiler warnings in Cygwin-w32 build · 560c4ab1
      Ken Brown authored
      * src/conf_post.h (DebPrint) [!EMACSDEBUG]: Add empty do-while
      loop to avoid compiler warnings about empty body of 'if'
      * src/image.c [HAVE_NTGUI] (DefaultDepthOfScreen): Disable unused
      (x_create_bitmap_from_data): Declare 'frame'.
      (x_create_bitmap_from_file): Don't declare unused variable
      * src/lisp.h (AUTO_STRING_WITH_LEN): Avoid initialization to
      prevent "jump-misses-init" compiler warnings.
      * src/w32fns.c (check_w32_winkey_state): Define and use only if
      (Fx_show_tip): Declare 'f'.
      (Fx_file_dialog): Declare 'filter_a' only if not NTGUI_UNICODE.
      (w32_strerror): Use format specifier %d for sprintf argument of
      type int.
      (emacs_abort): Cast sprintf argument of type DWORD to unsigned
      int, and use format specifier %x, for compatibility with Cygwin.
      (unicode_append_menu) [NTGUI_UNICODE]:
      * src/w32menu.c [NTGUI_UNICODE] (get_menu_item_info)
      (set_menu_item_info, unicode_append_menu)
      * src/menu.c [NTGUI_UNICODE] (unicode_append_menu): Define as
      functions rather than macros to avoid "address will always
      evaluate as true" compiler warnings.
      * src/w32font.c (w32_to_x_charset): Use format specifier %d for
      sprintf argument of type int.
      * src/w32term.c (x_draw_glyphless_glyph_string_foreground): Cast
      sprintf argument of type int to unsigned int to match %X format
      (w32_horizontal_scroll_bar_handle_click): Declare 'f'.
      * src/w32term.h (FRAME_DISPLAY_INFO): Explicitly discard unused
    • Ken Brown's avatar
      Fix compiler warnings in no-window-system-build · d4c1535c
      Ken Brown authored
      * src/composite.c (autocmp_chars): Declare and set 'f' only if
      * src/dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P)
      (FACE_FOR_CHAR): Explicitly discard unused arguments.
      * src/font.c (font_open_entity): Declare 'min_width' where it is
      first set, and only if HAVE_WINDOW_SYSTEM.
      * src/frame.c [!HAVE_WINDOW_SYSTEM] (decode_window_system_frame):
      Define _Noreturn version to avoid "suggest attribute noreturn"
      compiler warning.
      (check_window_system): Declare as _Noreturn.
      (Fset_frame_position): Don’t declare and set 'f'.
      * src/frame.h [!HAVE_WINDOW_SYSTEM] (decode_window_system_frame)
      (check_window_system):  Add _Noreturn prototypes.
      (FRAME_BOTTOM_DIVIDER_WIDTH): Explicitly discard unused argument.
      * src/xdisp.c (handle_single_display_spec): Declare
      'fringe_bitmap' only if HAVE_WINDOW_SYSTEM.
      (append_space_for_newline): Declare 'g' where it is first set.
      (Fmove_point_visually): Declare and set 'target_is_eol_p' only if
      (show_mouse_face): Declare and set 'f' and 'phys_cursor_on_p' only
      (note_mouse_highlight): Declare and set 'cursor' and 'pointer'
      only if HAVE_WINDOW_SYSTEM.
      * src/xfaces.c (realize_default_face): Declare and set 'face' only
      if HAVE_X_WINDOWS.  Remove redundant #ifdef.
  2. 20 Jun, 2016 3 commits
    • Michael Albinus's avatar
      ; Simplify in filenotify-tests.el · 9eaec685
      Michael Albinus authored
    • Michael Albinus's avatar
      Weaken test conditions in filenotify-tests.el · f11f6e54
      Michael Albinus authored
      * test/lisp/filenotify-tests.el (file-notify--test-with-events):
      Fix thinko in test.
      (file-notify-test02-events, file-notify-test04-file-validity)
      (file-notify-test08-watched-file-in-watched-dir): Make test
      conditions more weak.  (Bug#23618)
    • Paul Eggert's avatar
      Minor ABLOCKS_BUSY cleanups in alloc.c · 9341142d
      Paul Eggert authored
      * src/alloc.c (ABLOCKS_BUSY): Rename arg to avoid potential clash
      with member ‘abase’ in definiens.
      (lisp_align_malloc, lisp_align_free): Use bool for boolean.
      Avoid compiler warning with fewer casts.
      (lisp_align_free): Check busy-field values; this can help the
      compiler a bit when optimizing, too.
  3. 19 Jun, 2016 6 commits
  4. 18 Jun, 2016 12 commits
  5. 17 Jun, 2016 2 commits
    • Glenn Morris's avatar
    • Noam Postavsky's avatar
      Fbackward_prefix_chars: stay within buffer bounds · b49cb0ab
      Noam Postavsky authored
      The commit 1fd3172d "(Fbackward_prefix_chars): Set point properly while
      scanning" (1998-03-18), moved the check against of the position against the
      buffer beginning out the loop condition so that we might end up checking
      the syntax of characters before the beginning of the buffer.  This can
      cause segfaults or trigger a "Point before start of properties" error in
      `update_interval' (called indirectly from `char_quoted').
      * src/syntax.c (Fbackward_prefix_chars): Stop the loop when beginning of
      buffer is reached (Bug #3552, Bug #17132, Bug #19379).
  6. 16 Jun, 2016 3 commits
  7. 15 Jun, 2016 9 commits
  8. 14 Jun, 2016 3 commits
    • Stephen Berman's avatar
      Fix todo-mode use of minibuffer completion keymap (bug#23695). · d7084f22
      Stephen Berman authored
      * lisp/calendar/todo-mode.el (todo-read-category): Don't
      override minibuffer-local-completion-map globally (bug#23695).
      Bind <SPC> key to self-insert-command.
    • Paul Eggert's avatar
      Port to platforms where char * has top bit set · c5461d03
      Paul Eggert authored
      This fixes a five-year-old FIXME comment.  Although I don’t know
      of a platform where this is a problem in practice, better safe
      than sorry.
      * src/doc.c (Fdocumentation): If SUBRP, simply use doc as integer,
      as it is now an integer, not char *.
      (store_function_docstring): Offset is now EMACS_INT, not ptrdiff_t;
      this is a file offset and EMACS_INT is better if --with-wide-int.
      If SUBRP, simply store the offset rather than negating it and
      converting it to char *.
      * src/lisp.h (struct Lisp_Subr.doc): Now EMACS_INT, not char *.
    • Paul Eggert's avatar
      Remove recursion from store_function_docstring · 7f35d5cb
      Paul Eggert authored
      * src/doc.c (store_function_docstring):
      Refactor to avoid the need for C-level recursion.