1. 01 Jun, 2019 16 commits
  2. 31 May, 2019 3 commits
    • Simen Heggestøyl's avatar
      Use lexical-binding in autoinsert.el and add tests · 12f530a7
      Simen Heggestøyl authored
      * lisp/autoinsert.el: Use lexical-binding.
      Remove redundant :group args.
      (auto-insert): Simplify.
      
      * test/lisp/autoinsert-tests.el: New file with tests for
      autoinsert.el.
      12f530a7
    • Eli Zaretskii's avatar
      Unbreak MinGW64 build with pthreads.h installed · c3748b13
      Eli Zaretskii authored
      * nt/mingw-cfg.site (gl_cv_func_pthread_sigmask_macro): Set to
      "no", to avoid compiling Gnulib's pthread_sigmask.c.
      Reported by Richard Copley <rcopley@gmail.com>.
      c3748b13
    • Stefan Monnier's avatar
      * lisp/emacs-lisp/package.el: Obey buffer-file-coding-system (bug#35739) · b3df3729
      Stefan Monnier authored
      `url-insert-file-contents` saves in buffer-file-coding-system
      the coding-system used to decode the contents.  Preserve this
      as the contents is moved from buffer to string to buffer, and use
      it when saving the contents to file, so as to try and better preserve
      the original byte sequence.
      
      (package--buffer-string, package--cs): New functions.
      (package--check-signature): Encode `string` if a coding-system
      was specified in buffer-file-coding-system.
      (package--download-one-archive, package-install-from-archive):
      Obey and preserve the buffer-file-coding-system if specified.
      
      Do not merge.
      b3df3729
  3. 30 May, 2019 18 commits
    • Noam Postavsky's avatar
      Warn about wrong number of args for subrs (Bug#35767) · 134edc10
      Noam Postavsky authored
      * lisp/emacs-lisp/bytecomp.el (byte-compile-callargs-warn): Don't
      assume byte-compile-fdefinition will return non-nil.
      * test/lisp/emacs-lisp/bytecomp-tests.el (bytecomp-warn-wrong-args)
      (bytecomp-warn-wrong-args-subr): New tests.
      134edc10
    • Noam Postavsky's avatar
      Use plain symbols for eieio type descriptors (Bug#29220) · 5f01af6c
      Noam Postavsky authored
      Since Emacs 26, eieio objects use a class record (with circular
      references) as the type descriptor of the object record.  This causes
      problems when reading back an object from a string, because the class
      record is not `eq' to the canonical one (which means that read objects
      don't satisfy the foo-p predicate).
      * lisp/emacs-lisp/eieio.el (make-instance): As a (partial) fix, set
      the record's type descriptor to a plain symbol for the type descriptor
      when eieio-backward-compatibility is non-nil (the default).
      * lisp/emacs-lisp/eieio-core.el (eieio--object-class): Call
      eieio--class-object on the type tag when eieio-backward-compatibility
      is non-nil.
      (eieio-object-p): Use eieio--object-class instead of
      eieio--object-class-tag.
      * test/lisp/emacs-lisp/eieio-tests/eieio-test-persist.el
      (eieio-test-persist-hash-and-vector)
      (eieio-test-persist-interior-lists): Make into functions.
      (eieio-persist-hash-and-vector-backward-compatibility)
      (eieio-persist-hash-and-vector-no-backward-compatibility)
      (eieio-test-persist-interior-lists-backward-compatibility)
      (eieio-test-persist-interior-lists-no-backward-compatibility): New
      tests which call them, eieio-backward-compatibility let-bound.
      5f01af6c
    • Paul Eggert's avatar
      Pacify librsvg 2.45.1 and later · 7871c3dc
      Paul Eggert authored
      * src/image.c (svg_load_image): Pacify librsvg 2.45.1 and later,
      and add a FIXME comment about the deprecated librsvg functions.
      Backport from master.
      7871c3dc
    • Paul Eggert's avatar
      Pacify GCC when compiling unexelf.c on Fedora 30 · b2e44b42
      Paul Eggert authored
      * src/unexelf.c (unexec): Pacify GCC 9.
      b2e44b42
    • Paul Eggert's avatar
      Suppress GCC 9 “no longer supported” messages · fa9e575c
      Paul Eggert authored
      * m4/manywarnings.m4 (gl_MANYWARN_ALL_GCC): Remove -Wchkp.
      This suppresses a boatload of warnings of the form
      “gcc: warning: switch ‘-Wchkp’ is no longer supported”.
      when using GCC 9.  Do not merge to master.
      fa9e575c
    • Paul Eggert's avatar
      Pacify GCC 9 -Wredundant-decls · 4b24b018
      Paul Eggert authored
      * src/gmalloc.c (_fraghead) [!HYBRID_MALLOC]:
      Make it static in this case, too.  This avoids having both
      ‘extern struct list _fraghead[];’ and
      ‘static struct list _fraghead[BLOCKLOG];’, which
      GCC 9 complains about.
      4b24b018
    • Paul Eggert's avatar
      Simplify xd_signature to pacify GCC 9 · d93f4bda
      Paul Eggert authored
      * src/dbusbind.c (xd_signature): Use simpler way to set up
      the subsignature.  This also pacifies GCC 9 on Fedora 30 x86-64.
      Backport from master.
      d93f4bda
    • Paul Eggert's avatar
      Improve eq1/memql performance · 40bc7ddb
      Paul Eggert authored
      * src/fns.c (Fmemql, Feql): Inline to tweak performance.
      40bc7ddb
    • Mattias Engdegård's avatar
      Fix `memql' for bignums · b3549359
      Mattias Engdegård authored
      * src/fns.c (Fmemql): Make `memql' work for bignums.
      * test/src/fns-tests.el (test-bignum-eql): Also test `memql'.
      b3549359
    • Alan Mackenzie's avatar
      Optimize one of CC Mode's syntax caches for long comments and strings. · 57e9141a
      Alan Mackenzie authored
      * lisp/progmoes/cc-langs.el (c-block-comment-awkward-chars): New lang
      constant and variable.
      
      * lisp/progmodes/cc-engine.el (c-state-semi-nonlit-pos-cache): Enhance the
      doc comment.
      (c-state-semi-get-near-cache-entry, c-state-semi-pp-to-literal): Reuse entry
      if the sought position is in a literal, and lies between the literal start and
      the entry's position.
      (c-cache-to-parse-ps-state, c-parse-ps-state-below): Amend such that instead
      of cacheing a state for a position after a backslash or first character of a
      2-character comment delimiter, this is done for the previous character
      position.
      57e9141a
    • Dmitry Gutov's avatar
      Fix a void-function error · a0c7a640
      Dmitry Gutov authored
      * lisp/dired-aux.el (dired-do-find-regexp):
      Require 'xref' (bug#35352).
      a0c7a640
    • Dmitry Gutov's avatar
      Rename xref-refresh-results to xref-revert-buffer · a01693a4
      Dmitry Gutov authored
      * lisp/progmodes/xref.el (xref-revert-buffer): Rename from
      'xref-refresh-results' (https://debbugs.gnu.org/35737#40).
      a01693a4
    • Dmitry Gutov's avatar
      New command ruby-find-library-file · 27f56271
      Dmitry Gutov authored
      * lisp/progmodes/ruby-mode.el (ruby-find-library-file):
      New command.
      (ruby-mode-map): Add binding for it.
      27f56271
    • Dmitry Gutov's avatar
      b367a3de
    • Stefan Kangas's avatar
      Fix docstring of bookmark-get-bookmark · 1b2f83bb
      Stefan Kangas authored
      * lisp/bookmark.el (bookmark-get-bookmark): Document optional
      argument NOERROR. (bug#20148)
      1b2f83bb
    • YAMAMOTO Mitsuharu's avatar
      Add stipple support on cairo · cc71a82f
      YAMAMOTO Mitsuharu authored
      * src/xterm.h (struct x_bitmap_record) [USE_CAIRO]: Remove unused member img.
      Add member stipple.
      (x_bitmap_stipple) [USE_CAIRO]: Add extern.
      
      * src/image.c (x_bitmap_stipple) [HAVE_X_WINDOWS && USE_CAIRO]: New function.
      (image_create_bitmap_from_data, image_create_bitmap_from_file)
      (x_create_bitmap_from_xpm_data) [HAVE_X_WINDOWS && USE_CAIRO]: Initialize
      stipple member of struct x_bitmap_record.
      (free_bitmap_record) [HAVE_X_WINDOWS && USE_CAIRO]: Destroy stipple member.
      
      * src/xterm.c (x_fill_rectangle) [USE_CAIRO]: Inspect gc and draw stipple if
      necessary.  Use x_bitmap_stipple.
      cc71a82f
    • Basil L. Contovounesios's avatar
      Simplify Gnus buffer liveness checking and killing · ceca1740
      Basil L. Contovounesios authored
      * lisp/gnus/gnus-agent.el (gnus-agent-synchronize-group-flags):
      Fix indentation.
      * lisp/gnus/gnus-util.el (gnus-buffer-exists-p): Define as obsolete
      alias of gnus-buffer-live-p.
      (gnus-buffer-live-p): If the given argument is or names a live
      buffer, return the corresponding buffer object instead of a boolean.
      * lisp/gnus/gnus-win.el (gnus-delete-windows-in-gnusey-frames)
      (gnus-remove-some-windows): Simplify.
      * lisp/gnus/gnus.el (gnus-prune-buffers): Redefine as alias of
      gnus-buffers.
      (gnus-kill-buffer, gnus-buffers, gnus-group-find-parameter):
      * lisp/gnus/gnus-art.el (gnus-kill-sticky-article-buffers)
      (gnus-request-article-this-buffer):
      * lisp/gnus/gnus-bcklg.el (gnus-backlog-shutdown):
      * lisp/gnus/gnus-cus.el (gnus-group-customize)
      (gnus-agent-customize-category):
      * lisp/gnus/gnus-draft.el (gnus-draft-edit-message):
      * lisp/gnus/gnus-group.el (gnus-group-set-mode-line)
      (gnus--abort-on-unsaved-message-buffers, gnus-group-compact-group):
      * lisp/gnus/gnus-msg.el (gnus-inews-add-send-actions)
      (gnus-summary-supersede-article, gnus-copy-article-buffer):
      * lisp/gnus/gnus-score.el (gnus-score-edit-current-scores)
      (gnus-score-edit-file):
      * lisp/gnus/gnus-spec.el (gnus-update-format-specifications):
      * lisp/gnus/gnus-srvr.el (gnus-server-compact-server):
      * lisp/gnus/gnus-start.el (gnus-clear-system, gnus-dribble-enter)
      (gnus-dribble-save, gnus-dribble-clear, gnus-save-newsrc-file):
      * lisp/gnus/gnus-sum.el (gnus-summary-setup-buffer)
      (gnus-update-summary-mark-positions, gnus-summary-exit)
      (gnus-deaden-summary, gnus-kill-or-deaden-summary)
      (gnus-summary-next-group):
      * lisp/gnus/gnus-win.el (gnus-configure-frame):
      * lisp/gnus/mail-source.el (mail-source-movemail):
      * lisp/gnus/message.el (message-with-reply-buffer)
      (message-with-reply, message-send-and-exit)
      (message-send-mail-with-sendmail, message-pop-to-buffer)
      (message-do-send-housekeeping, message-forward-make-body-plain)
      (message-forward-make-body-mml):
      * lisp/gnus/mm-decode.el (mm-display-external, mm-remove-part):
      * lisp/gnus/nnbabyl.el (nnbabyl-server-opened)
      (nnbabyl-possibly-change-newsgroup, nnbabyl-read-mbox)
      (nnbabyl-check-mbox):
      * lisp/gnus/nndiary.el (nndiary-save-nov):
      * lisp/gnus/nndoc.el (nndoc-close-group)
      (nndoc-possibly-change-buffer):
      * lisp/gnus/nnfolder.el (nnfolder-close-group, nnfolder-save-nov):
      * lisp/gnus/nnimap.el (nnimap-make-process-buffer, nnimap-keepalive)
      (nnimap-find-connection):
      * lisp/gnus/nnmail.el (nnmail-cache-open, nnmail-cache-close):
      * lisp/gnus/nnmbox.el (nnmbox-close-server, nnmbox-server-opened)
      (nnmbox-possibly-change-newsgroup, nnmbox-read-mbox):
      * lisp/gnus/nnml.el (nnml-save-incremental-nov, nnml-open-nov)
      (nnml-save-nov):
      * lisp/gnus/nnoo.el (nnoo-server-opened):
      * lisp/gnus/nntp.el (nntp-kill-buffer, nntp-make-process-buffer)
      (nntp-open-connection, nntp-async-trigger):
      * lisp/net/mairix.el (mairix-gnus-fetch-field): Simplify buffer
      liveness checking and killing, replacing buffer-name with
      buffer-live-p and gnus-buffer-exists-p with gnus-buffer-live-p or
      equivalent where applicable.
      ceca1740
    • YAMAMOTO Mitsuharu's avatar
      Fix breakage of native image scaling on XRENDER by previous change · 46a17616
      YAMAMOTO Mitsuharu authored
      * src/image.c (image_create_x_image_and_pixmap_1) [HAVE_XRENDER]: Get depth if
      it is unspecified.
      46a17616
  4. 29 May, 2019 3 commits
    • Paul Eggert's avatar
      Update from Gnulib · 10582d05
      Paul Eggert authored
      This incorporates:
      2019-05-24 flexmember: update comments
      2019-05-18 pthread_sigmask: fix --enable-threads=windows compilation
      2019-05-14 close-stream, closein, closeout: simplify
      2019-05-09 verify: remove verify_true
      2019-05-09 verify: support C2X and C++17 static_assert
      * build-aux/config.guess, build-aux/config.sub:
      * doc/misc/texinfo.tex, lib/flexmember.h, lib/verify.h:
      * m4/flexmember.m4, m4/pthread_sigmask.m4:
      Copy from Gnulib
      * m4/gnulib-comp.m4: Regenerate.
      
      2019-05-26  Paul Eggert  <eggert@cs.ucla.edu>
      
      Update author/maintainer info
      This mostly updates email addresses and fixes spellings of
      author and maintainer names.
      10582d05
    • Stefan Monnier's avatar
      * lisp/subr.el (add-hook): Turn `append` into `depth` (bug#35508) · fe0cb43f
      Stefan Monnier authored
      Make it possible to control the relative ordering of functions on hooks by
      specifying `depth` in the same was as was possible with `add-function`.
      
      * lisp/electric.el (electric--sort-post-self-insertion-hook):
      Delete function.
      (electric-indent-mode, electric-layout-mode, electric-quote-mode):
      * lisp/elec-pair.el (electric-pair-mode): Use new `depth` arg instead of
      electric--sort-post-self-insertion-hook.
      
      * lisp/emacs-lisp/syntax.el (syntax-propertize, syntax-ppss):
      Use new `depth` arg to make sure noone accidentally gets added
      after syntax-ppss-flush-cache.
      
      * doc/lispref/modes.texi (Setting Hooks): Document new `depth` arg.
      
      * test/lisp/subr-tests.el (subr-tests-add-hook-depth): New test.
      fe0cb43f
    • Simen Heggestøyl's avatar
      Use lexical-binding in makesum.el and add tests · 49cdbb4a
      Simen Heggestøyl authored
      * lisp/makesum.el: Use lexical-binding.
      (make-command-summary): Replace `if..progn' with `when'.
      (double-column): Add docstring and apply trivial simplifications.
      
      * test/lisp/makesum-tests.el: New file with tests for makesum.el.
      49cdbb4a