1. 25 Jul, 2012 1 commit
  2. 21 Jul, 2012 3 commits
  3. 16 Jul, 2012 1 commit
  4. 13 Jul, 2012 1 commit
    • Jan Djärv's avatar
      Remove compiler warnings in objective-C files. · 0dc8cf50
      Jan Djärv authored
      * nsfns.m (x_set_icon_name, ns_set_name_internal)
      (ns_set_name_as_filename, ns_implicitly_set_icon_type)
      (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
      (Fns_get_resource, Fns_set_resource, Fx_open_connection)
      (Fns_font_name, Fns_perform_service)
      (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
      (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
      (ns_set_name): Remove unused variable view.
      (x_set_menu_bar_lines): Remove unused variable olines.
      (x_set_tool_bar_lines): Remove unused variable root_window.
      (Fns_list_colors): Put () around assignment in while statement.
      (Fns_perform_service): Remove unused variable len.
      (Fns_display_usable_bounds): Remove unused variable top.
      (syms_of_nsfns): Remove unused variable i.
      
      * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
      (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
      where appropriate.
      (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
      around assignment in loop statement.
      (nsfont_open): Remove unused variable i.
      (nsfont_open): Remove unused variable len.
      (nsfont_draw): Remove unused variable cs.
      
      * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
      appropriate.
      (setXBMColor): Remove unused variable len.
      (setPixmapData): Put () around assignment in loop statement.
      
      * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
      (initFromContents): Use SSDATA where appropriate.
      (ns_update_menubar): Add braces to ambigous if-else.
      (initWithTitle): Put () around assignment in if statement.
      (ns_menu_show): Remove unused variables window and keymap.
      (update_frame_tool_bar): Remove unused variable selected_p.
      (initWithContentRect): Remove unused variable this_cmd_name.
      
      * nsterm.h (menuDown): Add id as type to argument sender.
      (ns_display_info_for_name): Add Lisp_Object argument.
      (ns_term_init): Add Lisp_Object argument.
      (ns_map_event_to_object): Add void argument.
      (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
      prototype with arguments and only declare if __OBJC__.
      (nxatoms_of_nsselect): Add void argument.
      (ns_lisp_to_cursor_type): Add Lisp_Object argument.
      (ns_alloc_autorelease_pool): Add void argument.
      (ns_release_autorelease_pool): Add void* argument.
      (ns_get_defaults_value): Add const char* argument.
      
      * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
      (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
      (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
      (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
      where appropriate.
      (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
      as boolean expression.
      (x_set_window_size): Remove unused variable toolbar.
      (ns_get_color_default, ns_mod_to_lisp): Remove.
      (ns_mouse_position): Remove unused variables xchar and ychar.
      (ns_compute_glyph_string_overhangs): Remove unused variable face.
      (ns_set_vertical_scroll_bar): Remove unused variable count.
      (ns_delete_terminal): Remove unused variable i.
      (ns_term_init): Remove unused variables r, g and b.
      (mouseDown): Remove unused variable window.
      (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
      (initFrameFromEmacs): Remove unused variable vbextra.
      (mouseEntered): Remove unused variables p and dpyinfo.
      (mouseExited): Remove unused variables p and r.
      (ns_define_frame_cursor, ns_clear_frame_area)
      (ns_draw_window_cursor, ns_initialize_display_info): Make static.
      (menuDown): Assign [sender tag] to variable and cast the variable.
      0dc8cf50
  5. 12 Jul, 2012 1 commit
  6. 10 Jul, 2012 4 commits
    • Paul Eggert's avatar
      EMACS_TIME simplification (Bug#11875). · e9a9ae03
      Paul Eggert authored
      This replaces macros (which typically do not work in GDB)
      with functions, typedefs and enums, making the code easier to debug.
      The functional style also makes code easier to read and maintain.
      * lib-src/profile.c (TV2): Remove no-longer-needed static var.
      * src/systime.h: Include <sys/time.h> on all hosts, not just if
      WINDOWSNT, since 'struct timeval' is needed in general.
      (EMACS_TIME): Now a typedef, not a macro.
      (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
      not macros.
      (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
      (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
      (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
      (EMACS_TIME_LE): Now functions, not macros.
      (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
      (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
      which are not functions.  All uses rewritten to use:
      (make_emacs_time): New function.
      (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
      (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
      not functions.  All uses rewritten to use the following, respectively:
      (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
      (add_emacs_time, sub_emacs_time): New functions.
      * src/atimer.c: Don't include <sys/time.h>,	as "systime.h" does this.
      * src/fileio.c (Fcopy_file):
      * src/xterm.c (XTflash): Get the current time closer to when it's used.
      * src/makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
      e9a9ae03
    • Paul Eggert's avatar
      e99a530f
    • Glenn Morris's avatar
      40e72761
    • Glenn Morris's avatar
      Stop ns builds setting the EMACSLOADPATH environment variable · 9e059e3f
      Glenn Morris authored
      Ref bugs 4309, 6401, etc.
      This is the last environment variable (ab)used by the ns port in this way.
      
      * src/nsterm.m (ns_load_path): Rename from ns_init_paths.
      Now it does not set EMACSLOADPATH, just returns the load-path string.
      * src/nsterm.h: Update accordingly.
      
      * src/lread.c [HAVE_NS]: Include nsterm.h.
      (init_lread) [HAVE_NS]: Use ns_load_path.
      
      * src/emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
      9e059e3f
  7. 09 Jul, 2012 3 commits
  8. 06 Jul, 2012 1 commit
  9. 05 Jul, 2012 1 commit
    • Paul Eggert's avatar
      More xmalloc and related cleanup. · 38182d90
      Paul Eggert authored
      * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
      * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
      * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
      * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
      * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
      * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
      * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
      * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
      * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
      * xterm.c:
      Omit needless casts involving void * pointers and allocation.
      Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
      as the former is more robust if P's type is changed.
      Prefer xzalloc to xmalloc + memset 0.
      Simplify malloc-or-realloc to realloc.
      Don't worry about xmalloc returning a null pointer.
      Prefer xstrdup to xmalloc + strcpy.
      * editfns.c (Fmessage_box): Grow message_text by at least 80 when
      growing it.
      * keyboard.c (apply_modifiers_uncached): Prefer local array to
      alloca of a constant.
      38182d90
  10. 30 Jun, 2012 1 commit
  11. 29 Jun, 2012 1 commit
  12. 22 Jun, 2012 1 commit
  13. 17 Jun, 2012 1 commit
    • Alp Aker's avatar
      Implement wave-style variant of underlining. · 9b0e3eba
      Alp Aker authored
        * doc/lispref/display.texi: Document new face attribute.
        * lisp/cus-face.el (custom-face-attributes): Add wave-style underline
        attribute.
        * lisp/faces.el (set-face-attribute): Update docstring.
        * src/dispextern.h (face_underline_type): New enum.
        (face): Add field for underline type.
        * src/nsterm.m (ns_draw_underwave): New function.
        (ns_draw_text_decoration): Use it.
        * src/w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
        New functions.
        (x_draw_glyph_string): Use them.
        * src/xfaces.c (Qline, Qwave): New Lisp objects.
        (check_lface_attrs, merge_face_ref)
        (Finternal_set_lisp_face_attribute, realize_x_face): Handle
        wave-style underline face attributes.
        * src/xterm.c (x_draw_underwave): New function.
        (x_draw_glyph_string): Use it.
      9b0e3eba
  14. 11 Jun, 2012 1 commit
  15. 26 May, 2012 1 commit
  16. 14 May, 2012 2 commits
  17. 09 Apr, 2012 1 commit
  18. 04 Feb, 2012 1 commit
  19. 02 Feb, 2012 1 commit
    • Glenn Morris's avatar
      Native scroll-bars are not implemented for Nextstep (bug#10673) · 44f92739
      Glenn Morris authored
      * configure.in [HAVE_NS]: Error if use --without-toolkit-scroll-bars.
      
      * src/nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
      Unconditionally set to t.
      
      * src/nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
      * src/w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
      * src/xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
      44f92739
  20. 31 Jan, 2012 1 commit
    • Glenn Morris's avatar
      x-toolkit-scroll-bars doc fix. · 97897668
      Glenn Morris authored
      * src/nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
      * src/xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
      97897668
  21. 11 Jan, 2012 1 commit
  22. 05 Jan, 2012 1 commit
  23. 21 Dec, 2011 1 commit
    • Jan Djärv's avatar
      Fix biggest memory leaks in NS-port. More remain. · 204ee57f
      Jan Djärv authored
      * emacs.c (ns_pool): New variable.
      (main): Assign ns_pool.
      (Fkill_emacs): Call ns_release_autorelease_pool.
      
      * nsfns.m (x_set_background_color): Assign return value from
      ns_index_color to face-background instead of NSColor*.
      (ns_implicitly_set_icon_type): Fix indentation.
      Change assignment in for loop to comparison.
      
      * nsfont.m (ns_spec_to_descriptor): Fix indentation,
      autorelease fdesc, release fdAttrs and tdict.
      (ns_get_covering_families): Release charset.
      (ns_findfonts): Release NSFontDescriptor created with new.
      (ns_uni_to_glyphs): Fix indentation.
      (setString): Release attrStr before assigning new value.
      
      * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
      before returning.
      
      * nsterm.m (x_free_frame_resources): Release
      f->output_data.ns->miniimage
      (ns_index_color): Fix indentation.  Do not retain
      color_table->colors[i].
      204ee57f
  24. 18 Dec, 2011 1 commit
    • Jan Djärv's avatar
      Adapt code from AquaEmacs to handle occasional blank menus. · 5fecd5fc
      Jan Djärv authored
      * nsmenu.m (trackingMenu): New variable.
      (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5 and
      NS_IMPL_COCOA.
      (trackingNotification): New method (from AquaEmacs).
      (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
      from AquaEmacs.
      (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
      
      * nsterm.m (ns_term_init): Subscribe for notifications
      NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
      to method trackingNotification in EmacsMenu.
      
      Fixes: debbugs:7030
      5fecd5fc
  25. 10 Dec, 2011 1 commit
    • Jan Djärv's avatar
      Don't crash on bad user input. · f7dfe5d6
      Jan Djärv authored
      * nsfns.m (ns_get_defaults_value): New function.
      (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
      
      * nsterm.h (ns_get_defaults_value): Declare.
      
      * nsterm.m (ns_default): Call ns_get_defaults_value.
      
      Fixes: debbugs:10103
      f7dfe5d6
  26. 05 Dec, 2011 1 commit
  27. 27 Nov, 2011 1 commit
  28. 23 Nov, 2011 1 commit
  29. 15 Nov, 2011 1 commit
  30. 14 Nov, 2011 1 commit
  31. 05 Nov, 2011 1 commit
    • Jan Djärv's avatar
      * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG. · a97f8f3f
      Jan Djärv authored
      (unwind_create_frame): New function.
      (Fx_create_frame): Restructure code to be more similar to the one in
      xfns.c.  Call record_unwind_protect with unwind_create_frame (Bug#9943).
      Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
      Move terminal->reference_count++ just before making the frame official
      (Bug#9943).
      
      * nsterm.m (x_free_frame_resources): New function.
      (x_destroy_window): Move code to x_free_frame_resources.
      a97f8f3f
  32. 30 Sep, 2011 1 commit