1. 12 Aug, 2013 12 commits
    • Eli Zaretskii's avatar
      Fix build with zlib on MS-Windows. · 594a4307
      Eli Zaretskii authored
       configure.ac (LIBZ): Comment on w32 peculiarities regarding LIBZ.
      
       src/decompress.c [WINDOWSNT]: Include windows.h and w32.h.
       (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros.  Use them to
       define static variables that are pointers to zlib functions to be
       dynamically loaded.
       (init_zlib_functions) [WINDOWSNT]: New function.
       (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
       New macros.
       (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
       macros instead of invoking the zlib functions directly.
       (syms_of_decompress): DEFSYM Qzlib_dll.  Staticpro
       Szlib_available_p.
      
       lisp/term/w32-win.el (dynamic-library-alist): Add DLLs for zlib.
      594a4307
    • Glenn Morris's avatar
      Auto-commit of generated files. · 7a67e06b
      Glenn Morris authored
      7a67e06b
    • Dmitry Antipov's avatar
      Avoid looping over all frame windows to freeze and unfreeze. · d2e113bc
      Dmitry Antipov authored
      * window.h (struct window): Drop frozen_window_start_p.
      (freeze_window_starts): Drop prototype.
      * frame.h (struct frame): New frozen_window_starts flag.
      (FRAME_WINDOWS_FROZEN): New macro.
      * window.c (freeze_window_start, freeze_window_starts):
      Remove.
      (select_window, replace_window): Adjust users.
      * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
      (window_frozen_p): New function.
      (redisplay_window): Use it.
      d2e113bc
    • Paul Eggert's avatar
      Fix some fd issues when running subprocesses. · 94fcd171
      Paul Eggert authored
      Fix bugs that can leak files or file descriptors on errors.
      Don't unlink open temp files, as that's hard for users to diagnose
      when things go awry (e.g., temp disk exhausted).
      Don't bother to lock temp files.  Check for invalid recursion.
      * callproc.c (synch_process_fd): Remove.  All uses removed.
      (synch_process_tempfile): New var or macro.
      (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
      New constants.
      (record_kill_process): New arg, the temp name.  All callers changed.
      (delete_temp_file): Now just a simple wrapper around unlink.
      (call_process_kill): New arg, the call_process_fd array.
      Close them all.  Clear synch_process_pid.  Remove the temp file,
      or arrange for it to be removed.
      (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
      that's been moved to synch_process_tempfile.  Caller changed.
      Do not remove the tempfile; that's now call_process_kill's
      responsibility.
      (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
      call_process_kill; the caller now does that.
      (call_process_cleanup): Do not close the process fd; that's now
      call_process_kill's responsibility.
      (Fcall_process): Implement via new function call_process, which
      has most of the old body of Fcall_process, but with a different API.
      (call_process): New function that does not open or close filefd if
      it is nonnegative.  Record which fds need to be closed, and let
      call_process_kill close (and remove the tempfile, on MSDOS) on error.
      Signal an error if invoked recursively (could be done via a hook).
      Simplify creation of the tempfile in the MSDOS case.
      Don't create the output file until after checking for the executable.
      Report any failure to open /dev/null.
      Don't open /dev/null for writing twice; once is enough.
      Don't create pipe if all output is being discarded or sent to file.
      Don't worry about setting up the coding system or reading from the
      pipe if all output is being discarded.
      Hoist fd_error local into top level, to lessen block nesting.
      Don't record deleted pid here; now done by Fcall_process_region.
      (Fcall_process) [MSDOS]: Report mktemp failure immediately,
      and note its success in synch_process_tempfile.
      Do not leak resources when child_setup fails.
      (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
      to child_errno.  Remove unnecessary close of fd0; it's close-on-exec.
      (create_temp_file): Now returns open fd, with an additional
      Lisp_Object * argument to return the name.  All callers changed.
      Do not close the file; rewind it instead, and leave it open for
      the caller.  Do not lock the temp file.  Unwind-protect the file
      and the file-descriptor.
      (Fcall_process_region): If the input is /dev/null, unwind-protect it.
      If an asynchrounous process, record it here, not in call_process.
      (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
      * eval.c (set_unwind_protect): New function.
      * fileio.c (write_region): New function, generalized from the
      old Fwrite_region.  Do not lock temp files.
      (Fwrite_region): Use it.
      * lisp.h (set_unwind_protect, write_region): New decls.
      * process.c: Include <verify.h>.
      (make_process): Mark fds as initially closed.
      (deleted_pid_list): Now a list of pid-filename pairs.
      All uses changed.
      (close_process_fd): New function.
      (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
      (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
      New constants.  Verify that their number matches PROCESS_OPEN_FDS.
      (create_process, create_pty, Fmake_serial_process)
      (server_accept_connection): Record which fds need to be closed,
      and let deactivate_process close them.
      (Fmake_network_process): Do not discard the unwind-protect
      until it's safe to do so.
      (deactivate_process): Close the fds opened by create_process etc.
      (Fprocess_send_eof): Adjust to new way of recording open fds.
      Report an error if /dev/null can't be opened, instead of aborting.
      * process.h (PROCESS_OPEN_FDS): New constant.
      (struct Lisp_Process): New member open_fds.
      (record_kill_process, record_deleted_pid): Adjust signatures.
      (record_deleted_pid): Move decl here ...
      * syswait.h (record_deleted_pid): ... from here.
      
      Fixes: debbugs:15035
      94fcd171
    • Katsumi Yamaoka's avatar
      lisp/gnus/ChangeLog: Fix typo · 4750fd7b
      Katsumi Yamaoka authored
      4750fd7b
    • Katsumi Yamaoka's avatar
      lisp/gnus/mm-decode.el (mm-display-external): Run a timer for the temp files... · 7cfa5cec
      Katsumi Yamaoka authored
      lisp/gnus/mm-decode.el (mm-display-external): Run a timer for the temp files deletion after a viwer exits; add a deletion timer for the needsterm case, too
      7cfa5cec
    • Katsumi Yamaoka's avatar
    • Katsumi Yamaoka's avatar
    • Paul Eggert's avatar
      Merge from gnulib. · eaca0446
      Paul Eggert authored
      This incorporates:
      2013-08-11 fpending: port to recent Cygwin change to stdio_ext.h
      2013-08-10 sys_time: port to OpenBSD
      eaca0446
    • Glenn Morris's avatar
      Reduce some duplication in doc/misc/Makefile.in · 808190e6
      Glenn Morris authored
      * doc/misc/Makefile.in (ada_mode_deps, auth_deps, autotype_deps)
      (bovine_deps, calc_deps, ccmode_deps, cl_deps, dbus_deps)
      (dired_x_deps, ebrowse_deps, ede_deps, ediff_deps, edt_deps)
      (eieio_deps, emacs_gnutls_deps, emacs_mime_deps, epa_deps)
      (erc_deps, ert_deps, eshell_deps, eudc_deps, faq_deps)
      (flymake_deps, forms_deps, gnus_deps, htmlfontify_deps)
      (idlwave_deps, ido_deps, info_deps, mairix_el_deps, message_deps)
      (mh_e_deps, newsticker_deps, nxml_mode_deps, org_deps)
      (pcl_cvs_deps, pgg_deps, rcirc_deps, reftex_deps, remember_deps)
      (sasl_deps, sc_deps, semantic_deps, ses_deps, sieve_deps)
      (smtpmail_deps, speedbar_deps, srecode_deps, todo_mode_deps)
      (tramp_deps, url_deps, vip_deps, viper_deps, widget_deps)
      (wisent_deps, woman_deps): New variables.  Use throughout.
      808190e6
    • Glenn Morris's avatar
    • Glenn Morris's avatar
      Add build, install, uninstall rules for all dvi, html, pdf, ps manuals · 8496d8d7
      Glenn Morris authored
      * configure.ac (etcdocdir): Rename from docdir, to avoid confusion
      with configure's standard --docdir argument.  All uses updated.
      
      * Makefile.in (etcdocdir): Rename from docdir.  All uses updated.
      (install-etcdoc): Rename from install-doc.  All uses updated.
      (uninstall): Run uninstall-doc.
      (PSS): Add misc-ps.
      (INSTALL_DVI, INSTALL_HTML, INSTALL_PDF, INSTALL_PS)
      (INSTALL_DOC, UNINSTALL_DVI, UNINSTALL_HTML, UNINSTALL_PDF)
      (UNINSTALL_PS, UNINSTALL_DOC): New variables.
      ($(INSTALL_DOC), install-doc, install-dvi, install-html, install-pdf)
      (install-ps, $(UNINSTALL_DOC), uninstall-doc, uninstall-dvi)
      (uninstall-html, uninstall-pdf, uninstall-ps): New .PHONY rules.
      
      * doc/emacs/Makefile.in (prefix, datarootdir, datadir, PACKAGE_TARNAME)
      (docdir, dvidir, htmldir, pdfdir, psdir, GZIP_PROG, INSTALL)
      (INSTALL_DATA): New, set by configure.
      (HTML_OPTS, DVI_TARGETS, HTML_TARGETS, PDF_TARGETS, PS_TARGETS):
      New variables.
      (.SUFFIXES): Add .ps and .dvi.
      (.dvi.ps): New suffix rule.
      (dvi, html, pdf, ps): Use *_TARGETS variables.
      (emacs.ps, emacs-xtra.ps): Remove explicit rules.
      (emacs.html): Use HTML_OPTS.
      (clean): Use DVI_TARGETS, HTML_TARGETS, PDF_TARGETS, PS_TARGETS.
      (.PHONY): install-dvi, install-html, install-pdf, install-ps
      ,install-doc, uninstall-dvi, uninstall-html, uninstall-pdf,
      uninstall-ps, and uninstall-doc.
      (install-dvi, install-html, install-pdf, install-ps, install-doc)
      (uninstall-dvi, uninstall-html, uninstall-ps, uninstall-pdf)
      (uninstall-doc): New rules.
      
      * doc/lispintro/Makefile.in (prefix, datarootdir, datadir, PACKAGE_TARNAME)
      (docdir, dvidir, htmldir, pdfdir, psdir, GZIP_PROG, INSTALL)
      (INSTALL_DATA): New, set by configure.
      (HTML_OPTS, DVI_TARGETS, HTML_TARGETS, PDF_TARGETS, PS_TARGETS):
      New variables.
      (.SUFFIXES): Add .ps and .dvi.
      (.dvi.ps): New suffix rule.
      (dvi, html, pdf, ps): Use *_TARGETS variables.
      (emacs-lisp-intro.ps): Remove explicit rule.
      (emacs-lisp-intro.html): Use HTML_OPTS.
      (clean): Use DVI_TARGETS, HTML_TARGETS, PDF_TARGETS, PS_TARGETS.
      (.PHONY): install-dvi, install-html, install-pdf, install-ps
      ,install-doc, uninstall-dvi, uninstall-html, uninstall-pdf,
      uninstall-ps, and uninstall-doc.
      (install-dvi, install-html, install-pdf, install-ps, install-doc)
      (uninstall-dvi, uninstall-html, uninstall-ps, uninstall-pdf)
      (uninstall-doc): New rules.
      
      * doc/lispref/Makefile.in (prefix, datarootdir, datadir, PACKAGE_TARNAME)
      (docdir, dvidir, htmldir, pdfdir, psdir, GZIP_PROG, INSTALL)
      (INSTALL_DATA): New, set by configure.
      (HTML_OPTS, DVI_TARGETS, HTML_TARGETS, PDF_TARGETS, PS_TARGETS):
      New variables.
      (.SUFFIXES): Add .ps and .dvi.
      (.dvi.ps): New suffix rule.
      (dvi, html, pdf, ps): Use *_TARGETS variables.
      (elisp.html): Use HTML_OPTS.
      (elisp.ps): Remove explicit rule.
      (.PHONY): install-dvi, install-html, install-pdf, install-ps
      ,install-doc, uninstall-dvi, uninstall-html, uninstall-pdf,
      uninstall-ps, and uninstall-doc.
      (install-dvi, install-html, install-pdf, install-ps, install-doc)
      (uninstall-dvi, uninstall-html, uninstall-ps, uninstall-pdf)
      (uninstall-doc): New rules.
      (clean): Use DVI_TARGETS, HTML_TARGETS, PDF_TARGETS, PS_TARGETS.
      
      * doc/misc/Makefile.in (prefix, datarootdir, datadir, PACKAGE_TARNAME)
      (docdir, dvidir, htmldir, pdfdir, psdir, GZIP_PROG, INSTALL)
      (INSTALL_DATA): New, set by configure.
      (HTML_OPTS, HTML_TARGETS, PS_TARGETS, DVIPS): New variables.
      (.PHONY): Add html, ps, install-dvi, install-html, install-pdf,
      install-ps ,install-doc, uninstall-dvi, uninstall-html, uninstall-pdf,
      uninstall-ps, and uninstall-doc.
      (.SUFFIXES): Add .ps and .dvi.
      (.dvi.ps): New suffix rule.
      (html, ps, ada-mode.html, auth.html, autotype.html, bovine.html)
      (calc.html, cc-mode.html, cl.html, dbus.html, dired-x.html)
      (ebrowse.html, ede.html, ediff.html, edt.html, eieio.html)
      (emacs-gnutls.html, emacs-mime.html, epa.html, erc.html)
      (ert.html, eshell.html, eudc.html, faq.html, flymake.html)
      (forms.html, gnus.html, htmlfontify.html, idlwave.html)
      (ido.html, mairix-el.html, message.html, mh-e.html)
      (newsticker.html, nxml-mode.html, org.html, pgg.html)
      (rcirc.html, reftex.html, remember.html, sasl.html, sc.html)
      (semantic.html, sieve.html, smtpmail.html, speedbar.html)
      (srecode.html, todo-mode.html, tramp.html, url.html, vip.html)
      (viper.html, widget.html, wisent.html, woman.html, install-dvi)
      (install-html, install-pdf, install-ps, install-doc, uninstall-dvi)
      (uninstall-html, uninstall-ps, uninstall-pdf, uninstall-doc):
      New rules.
      (clean): Remove HTML_TARGETS and PS_TARGETS.
      8496d8d7
  2. 11 Aug, 2013 12 commits
    • Paul Eggert's avatar
      * decompress.c: Fix bugs with large buffers and weird inputs. · d0e615c3
      Paul Eggert authored
      Tune a bit.  Reindent as per usual Emacs style.
      (BUFFER_SIZE): Remove.
      (Fdecompress_gzipped_region): Do not mishandle input buffers with
      more than UINT_MAX bytes.  Decompress into the gap instead of into
      an auto buffer, as this should avoid copying.  Return nil if
      'inflate' returns Z_NEED_DICT, as we have no dictionary.  Do not
      set immediate_quit; we shouldn't trust zlib code that much.
      d0e615c3
    • Paul Eggert's avatar
      Add --with-zlib to 'configure'. · 8d28d0ac
      Paul Eggert authored
      * configure.ac: Add --with-zlib option to 'configure', so that Emacs
      can be built without zlib.  Don't assume that -lz is needed on
      non-PNG hosts.  Mention zlib configuration status in 'configure' output.
      8d28d0ac
    • Lars Magne Ingebrigtsen's avatar
      * net/eww.el (eww-display-html): Ignore coding system errors. · 3e41a054
      Lars Magne Ingebrigtsen authored
      One web site uses "utf-8lias" as the coding system.
      3e41a054
    • Lars Magne Ingebrigtsen's avatar
      Add Content-Transfer gzip support to url · 6edea0a5
      Lars Magne Ingebrigtsen authored
      * url-http.el (url-handle-content-transfer-encoding): Support
      decompressing gzipped content.
      
      * url-vars.el (url-mime-encoding-string): If we have built-in gzip
      support, say that we accept gzipped content.
      6edea0a5
    • Lars Magne Ingebrigtsen's avatar
      Fix decompress gap handling bug · 99a32242
      Lars Magne Ingebrigtsen authored
      * decompress.c (Fdecompress_gzipped_region): Respect all zlib
      errors, and really move the gap to where we want it.
      99a32242
    • Lars Magne Ingebrigtsen's avatar
      Add zlib support via the `decompress-gzipped-region' function · 313546eb
      Lars Magne Ingebrigtsen authored
      This adds a new file, src/decompress.c, as well as tests for the
      presence of -lz.
      313546eb
    • Jan Djärv's avatar
      Fix crash on OSX >= 10.7. · f90e3ebd
      Jan Djärv authored
      * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
      (initWithTitle:): Initialize frame to 0.
      (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
      (fillWithWidgetValue:frame:): Renamed from
      fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
      
      * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
      fillWithWidgetValue:frame:
      f90e3ebd
    • Jan Djärv's avatar
      Fix memory leak warning. · 423d3b3f
      Jan Djärv authored
      * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
      remove memory leak warnings.
      423d3b3f
    • Jan Djärv's avatar
      * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate. · d2d699ac
      Jan Djärv authored
      (x_activate_menubar): Update the whole menu.
      (trackingNotification:): Call ns_check_menu_open if tracking ends.
      (menuWillOpen:): Increment trackingMenu.  For OSX <= 10.6, exit if
      current event is not NSSystemDefined.
      Call ns_check_menu_open only if trackingMenu is 2.
      (menuDidClose:): New method, decrease trackingMenu.
      (fillWithWidgetValue:setDelegate:): New method.
      (fillWithWidgetValue:): Call the above.
      
      * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
      
      * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
      (ns_check_menu_open): Handle menu == nil.  Remove assignment to
      menu_pending_title.
      
      Fixes: debbugs:15001
      d2d699ac
    • Juanma Barranquero's avatar
    • Paul Eggert's avatar
      Omit some unnecessary casts. · 7d652d97
      Paul Eggert authored
      Many of these go back to the old pre-C89 days, when they may have
      been needed, but we've been assuming C89 or later for a while now.
      * alloc.c (live_string_p, live_cons_p, live_symbol_p)
      (live_float_p, live_misc_p, live_vector_p):
      * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
      (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
      (defvar_per_buffer):
      * callint.c (Fcall_interactively):
      * doc.c (Fsubstitute_command_keys):
      * filelock.c (get_boot_time):
      * frame.c (xrdb_get_resource):
      * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
      (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
      (xg_get_file_name_from_selector, menuitem_destroy_callback)
      (menuitem_highlight_callback, menu_destroy_callback)
      (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
      (xg_tool_bar_callback, xg_get_tool_bar_widgets)
      (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
      (xg_tool_bar_help_callback, tb_size_cb):
      * image.c (xpm_alloc_color, png_read_from_memory)
      (png_read_from_file, png_load_body, our_memory_skip_input_data)
      (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
      (syms_of_image):
      * keymap.c (describe_map):
      * nsfns.m (Fns_display_monitor_attributes_list):
      * nsmenu.m (process_dialog:):
      * nsterm.m (hold_event):
      * process.c (wait_reading_process_output):
      * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
      * scroll.c (do_direct_scrolling, scrolling_1):
      * termcap.c (tgetent):
      * window.c (check_window_containing, add_window_to_list)
      (freeze_window_starts):
      * xdisp.c (compare_overlay_entries, vmessage):
      * xfns.c (x_window, x_get_monitor_attributes_xinerama)
      (x_get_monitor_attributes_xrandr)
      (Fx_display_monitor_attributes_list, x_display_info_for_name)
      (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
      * xfont.c (xfont_match, xfont_open):
      * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
      (menubar_selection_callback, menu_position_func)
      (popup_selection_callback, create_and_show_popup_menu)
      (dialog_selection_callback, create_and_show_dialog):
      * xrdb.c (x_get_string_resource):
      (main) [TESTRM]:
      * xsmfns.c (x_session_check_input):
      * xterm.c (x_draw_glyphless_glyph_string_foreground)
      (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
      (xaw_jump_callback, xaw_scroll_callback):
      Omit unnecessary casts.
      7d652d97
    • Juanma Barranquero's avatar
      lisp/*.el: More lexical-binding warnings' cleanups. · 9a4ebc74
      Juanma Barranquero authored
      * tutorial.el (tutorial--describe-nonstandard-key): Use string-match-p.
        (tutorial--detailed-help): Remove unused local variables.
        (tutorial--save-tutorial-to): Use ignore-errors.
        (help-with-tutorial): Use looking-at-p.
      
      * view.el (view-buffer-other-window, view-buffer-other-frame):
        Mark unused arguments.
      
      * woman.el (woman-parse-colon-path, woman-parse-colon-path)
        (woman-select-symbol-fonts, woman, woman-find-file)
        (woman-insert-file-contents, woman-non-underline-faces):
        Use string-match-p.
        (woman1-unquote): Move declaration.
      
      * xml.el (xml-parse-tag-1, xml-parse-string): Use looking-at-p.
        (xml-parse-dtd): Use looking-at-p, string-match-p.  Mark unused
        argument.  Remove unused local variable.
        (xml-parse-elem-type): Use string-match-p.
        (xml-substitute-numeric-entities): Use ignore-errors.
      9a4ebc74
  3. 10 Aug, 2013 10 commits
    • Xue Fuqiao's avatar
      b41bfdd0
    • Paul Eggert's avatar
      Minor string-length refactoring. · 9acc1074
      Paul Eggert authored
      * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
      * frame.c (make_monitor_attribute_list):
      Prefer build_string to strlen + make_string.
      9acc1074
    • Juanma Barranquero's avatar
      lisp/*.el: Remove lexical-binding warnings; additional small cleanups. · 45fdb482
      Juanma Barranquero authored
      * calculator.el (calculator): Mark unused argument.
        (calculator-paste, calculator-quit, calculator-integer-p):
        Use ignore-errors.
        (calculator-string-to-number, calculator-decimal, calculator-exp)
        (calculator-op-or-exp): Use string-match-p.
      
      * dired-aux.el (dired-compress): Use ignore-errors.
        (dired-do-chxxx, dired-do-chmod, dired-trample-file-versions)
        (dired-do-async-shell-command, dired-do-shell-command)
        (dired-shell-stuff-it, dired-compress-file, dired-insert-subdir)
        (dired-insert-subdir-validate): Use string-match-p.
        (dired-map-dired-file-lines, dired-subdir-hidden-p): Use looking-at-p.
        (dired-add-entry): Use string-match-p, looking-at-p.
        (dired-insert-subdir-newpos): Remove unused local variable.
      
      * dired.el (dired-buffer-more-recently-used-p): Declare.
        (dired-insert-set-properties, dired-insert-old-subdirs):
        Use ignore-errors.
      
      * filenotify.el (file-notify-callback): Remove unused local variable.
      
      * filesets.el (filesets-error): Mark unused argument.
        (filesets-which-command-p, filesets-filter-dir-names)
        (filesets-directory-files, filesets-get-external-viewer)
        (filesets-ingroup-get-data): Use string-match-p.
      
      * find-file.el (ff-other-file-name, ff-other-file-name)
        (ff-find-the-other-file, ff-cc-hh-converter):
        Remove unused local variables.
        (ff-get-file-name): Use string-match-p.
        (ff-all-dirs-under): Use ignore-errors.
      
      * follow.el (follow-comint-scroll-to-bottom): Mark unused argument.
        (follow-select-if-visible): Remove unused local variable.
      
      * forms.el (read-file-filter): Move declaration.
        (forms--make-format, forms--make-parser, forms-insert-record):
        Quote function with #'.
        (forms--update): Use string-match-p.  Quote function with #'.
      
      * help-mode.el (help-dir-local-var-def): Mark unused argument.
        (help-make-xrefs): Use looking-at-p.
        (help-xref-on-pp): Use looking-at-p, ignore-errors.
      
      * ibuffer.el (ibuffer-ext-visible-p): Declare.
        (ibuffer-confirm-operation-on): Use string-match-p.
      
      * msb.el (msb-item-handler, msb-dired-item-handler):
        Mark unused arguments.
      
      * ses.el (ses-decode-cell-symbol)
        (ses-kill-override): Remove unused local variable.
        (ses-create-cell-variable, ses-relocate-formula): Use string-match-p.
        (ses-load): Use ignore-errors, looking-at-p.
        (ses-jump-safe): Use ignore-errors.
        (ses-export-tsv, ses-export-tsf, ses-unsafe): Mark unused arguments.
      
      * tabify.el (untabify, tabify): Mark unused arguments.
      
        * thingatpt.el (thing-at-point--bounds-of-well-formed-url):
        Mark unused argument.
        (bounds-of-thing-at-point, thing-at-point-bounds-of-list-at-point)
        (thing-at-point-newsgroup-p, form-at-point): Use ignore-errors.
      45fdb482
    • Juanma Barranquero's avatar
    • Juanma Barranquero's avatar
      lisp/completion.el: Remove stuff unused since 2013-03-15T16:06:12Z!handa@gnu.org. · 5660113b
      Juanma Barranquero authored
      (*record-cmpl-statistics-p*): Remove (was commented out ).
      (cmpl-statistics-block): Remove (body was commented out).
      All callers changed.
      (add-completions-from-buffer, load-completions-from-file):
      Remove unused variables.
      5660113b
    • Glenn Morris's avatar
      Auto-commit of generated files. · 68b8ed38
      Glenn Morris authored
      68b8ed38
    • Jan Djärv's avatar
      * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus, · 361c0eb8
      Jan Djärv authored
      don't check minor_code.
      
      Fixes: debbugs:14417
      361c0eb8
    • Eli Zaretskii's avatar
      Provide a Windows manifest for update-game-score.exe. · d4166523
      Eli Zaretskii authored
       lib-src/update-game-score.exe.manifest: New file.
       lib-src/Makefile.in (UPDATE_MANIFEST): New variable.
       (SCRIPTS): Add $(UPDATE_MANIFEST).
      
       configure.ac: Define and substitute UPDATE_MANIFEST.
      d4166523
    • Xue Fuqiao's avatar
    • Xue Fuqiao's avatar
      * doc/misc/ido.texi (Working Directories): · 33a9f380
      Xue Fuqiao authored
      (Flexible Matching, Regexp Matching, Find File At Point)
      (Ignoring, Misc Customization): Use @defopt for user options.
      33a9f380
  4. 09 Aug, 2013 6 commits
    • Juanma Barranquero's avatar
      lisp/filecache.el (file-cache-delete-file-list): Print message only when told so. · 5c5dee78
      Juanma Barranquero authored
      (file-cache-files-matching): Use #' in mapconcat argument.
      5c5dee78
    • Juanma Barranquero's avatar
    • Xue Fuqiao's avatar
    • Stefan Monnier's avatar
      * lisp/subr.el (define-error): New function. · 54bd972f
      Stefan Monnier authored
      * doc/lispref/control.texi (Signaling Errors): Refer to define-error.
      (Error Symbols): Add `define-error'.
      * doc/lispref/errors.texi (Standard Errors): Don't refer to `error-conditions'.
      * lisp/progmodes/ada-xref.el (ada-error-file-not-found): Rename from
      error-file-not-found and define with define-error.
      * lisp/emacs-lisp/cl-lib.el (cl-assertion-failed): Move here from subr.el
      and define with define-error.
      * lisp/userlock.el (file-locked, file-supersession):
      * lisp/simple.el (mark-inactive):
      * lisp/progmodes/js.el (js-moz-bad-rpc, js-js-error):
      * lisp/progmodes/ada-mode.el (ada-mode-errors):
      * lisp/play/life.el (life-extinct):
      * lisp/nxml/xsd-regexp.el (xsdre-invalid-regexp, xsdre-parse-error):
      * lisp/nxml/xmltok.el (xmltok-markup-declaration-parse-error):
      * lisp/nxml/rng-util.el (rng-error):
      * lisp/nxml/rng-uri.el (rng-uri-error):
      * lisp/nxml/rng-match.el (rng-compile-error):
      * lisp/nxml/rng-cmpct.el (rng-c-incorrect-schema):
      * lisp/nxml/nxml-util.el (nxml-error, nxml-file-parse-error):
      * lisp/nxml/nxml-rap.el (nxml-scan-error):
      * lisp/nxml/nxml-outln.el (nxml-outline-error):
      * lisp/net/soap-client.el (soap-error):
      * lisp/net/gnutls.el (gnutls-error):
      * lisp/net/ange-ftp.el (ftp-error):
      * lisp/mpc.el (mpc-proc-error):
      * lisp/json.el (json-error, json-readtable-error, json-unknown-keyword)
      (json-number-format, json-string-escape, json-string-format)
      (json-key-format, json-object-format):
      * lisp/jka-compr.el (compression-error):
      * lisp/international/quail.el (quail-error):
      * lisp/international/kkc.el (kkc-error):
      * lisp/emacs-lisp/ert.el (ert-test-failed):
      * lisp/calc/calc.el (calc-error, inexact-result, math-overflow)
      (math-underflow):
      * lisp/bookmark.el (bookmark-error-no-filename):
      * lisp/epg.el (epg-error): Define with define-error.
      54bd972f
    • Eli Zaretskii's avatar
      Fix bug #15064 with assertion violation due to mouse face. · 14ba0822
      Eli Zaretskii authored
       src/xdisp.c (draw_glyphs): Don't compare row pointers, compare row
       vertical positions instead.  This avoids calling MATRIX_ROW with
       row numbers that are possibly beyond valid limits.
      14ba0822
    • Stefan Monnier's avatar
      * lisp/time.el (display-time-event-handler) · 0ea9e53a
      Stefan Monnier authored
      (display-time-next-load-average): Don't call sit-for since it seems
      unnecessary.
      
      Fixes: debbugs:15045
      0ea9e53a