1. 12 Apr, 2011 5 commits
    • Paul Eggert's avatar
      * dispnew.c: Make symbols static if they're not exported. · 5bf46f05
      Paul Eggert authored
      * dispextern.h (redraw_garbaged_frames, scrolling):
      (increment_row_positions): Remove.
      * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
      (delayed_size_change, glyph_matrix_count, glyph_pool_count):
      Now static.
      (redraw_garbaged_frames): Remove; unused.
      5bf46f05
    • Paul Eggert's avatar
      * xfaces.c: Make symbols static if they're not exported. · 435f4c28
      Paul Eggert authored
      * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
      Remove decls.
      * xterm.h (defined_color): Remove decls.
      (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
      * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
      (menu_face_changed_default, defined_color, free_realized_face):
      (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
      (ascii_face_of_lisp_face): Remove; unused.
      435f4c28
    • Paul Eggert's avatar
      * xdisp.c: Make symbols static if they're not exported. · 8524aef3
      Paul Eggert authored
      * dispextern.h (scratch_glyph_row, window_box_edges):
      (glyph_to_pixel_coords, set_cursor_from_row):
      (get_next_display_element, set_iterator_to_next):
      (highlight_trailing_whitespace, frame_to_window_pixel_xy):
      (show_mouse_face): Remove decls
      * frame.h (message_buf_print): Likewise.
      * lisp.h (pop_message, set_message, check_point_in_composition):
      Likewise.
      * xterm.h (set_vertical_scroll_bar): Likewise.
      * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
      (message_buf_print, scratch_glyph_row, displayed_buffer):
      (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
      (get_next_display_element, show_mouse_face, window_box_edges):
      (frame_to_window_pixel_xy, check_point_in_composition):
      (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
      (glyph_to_pixel_coords): Remove; unused.
      8524aef3
    • Paul Eggert's avatar
      * dired.c (file_name_completion): Now static. · 16390cd2
      Paul Eggert authored
      * dbusbind.c (xd_in_read_queued_messages): Now static.
      16390cd2
    • Paul Eggert's avatar
      * lisp.h (circular_list_error, FOREACH): Remove; unused. · a25f4dfa
      Paul Eggert authored
      * data.c (circular_list_error): Remove.
      a25f4dfa
  2. 11 Apr, 2011 15 commits
    • Paul Eggert's avatar
      * commands.h (last_point_position, last_point_position_buffer): · 14a9c8df
      Paul Eggert authored
      (last_point_position_window): Remove decls.
      * keyboard.c: Make these variables static.
      14a9c8df
    • Paul Eggert's avatar
      * coding.h (coding, code_convert_region, encode_coding_gap): Remove · 74ab6df5
      Paul Eggert authored
      decls.
      * coding.c (Vsjis_coding_system, Vbig5_coding_system):
      (iso_code_class, detect_coding, code_convert_region): Now static.
      (encode_coding_gap): Remove; unused.
      74ab6df5
    • Paul Eggert's avatar
      38dfbee1
    • Paul Eggert's avatar
      * charset.h (charset_iso_8859_1): Remove decl. · a2cb4e63
      Paul Eggert authored
      * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
      Now static.
      a2cb4e63
    • Paul Eggert's avatar
      * ccl.h (check_ccl_update, Vccl_program_table): Remove decls. · 127198fd
      Paul Eggert authored
      * ccl.c (Vccl_program_table): Now static.
      (check_ccl_update): Remove; unused.
      127198fd
    • Paul Eggert's avatar
      * category.c (SET_CATEGORY_SET, set_category_set): Move here. · d85b608f
      Paul Eggert authored
      * category.h: ... from here.
      * category.c (check_category_table, set_category_set): Now static.
      d85b608f
    • Paul Eggert's avatar
      * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static. · 31cd66f3
      Paul Eggert authored
      * lisp.h: Remove these decls.
      31cd66f3
    • Paul Eggert's avatar
      c358e587
    • Paul Eggert's avatar
      * bidi.c (bidi_dump_cached_states): Mark as externally visible, · e78aecca
      Paul Eggert authored
      so that it's not optimized away.
      (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
      * dispextern.h (bidi_dump_cached_states): Remove, since it's
      exported only to the debugger.
      e78aecca
    • Paul Eggert's avatar
      * atimer.c (alarm_signal_handler, run_all_atimers): Now static. · e192d7d3
      Paul Eggert authored
      * atimer.h (run_all_atimers): Removed; not exported.
      e192d7d3
    • Paul Eggert's avatar
      font.c: Make copy_font_spec and merge_font_spec ordinary C functions. · 92470028
      Paul Eggert authored
      * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
      was inaccessible from Lisp.
      (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
      * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
      92470028
    • Paul Eggert's avatar
      alloc.c: Import and export fewer symbols, and remove unused items. · 244ed907
      Paul Eggert authored
      * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
      is defined.
      (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
      it's not optimized away by whole-program optimization.
      (message_enable_multibyte, free_misc): Remove.
      (catchlist, handlerlist, mark_backtrace):
      Declare only if BYTE_MARK_STACK.
      (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
      * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
      (message_enable_multibyte): Remove decl.
      (free_misc, interval_free_list, float_block, float_block_index):
      (n_float_blocks, float_free_list, cons_block, cons_block_index):
      (cons_free_list, last_marked_index):
      Now static.
      (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
      * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
      (mark_backtrace): Define only if BYTE_MARK_STACK.
      * xdisp.c (message_enable_multibyte): Now static.
      244ed907
    • Paul Eggert's avatar
      Declare Lisp_Object Q* variables to be 'static' if not exproted. · 955cbe7b
      Paul Eggert authored
      This makes it easier for human readers (and static analyzers)
      to see whether these variables are used from other modules.
      * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
      * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
      * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
      * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
      * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
      * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
      * xmenu.c, xselect.c:
      Declare Q* vars static if they are not used in other modules.
      * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
      * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
      Remove decls of unexported vars.
      * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
      955cbe7b
    • Paul Eggert's avatar
      * lisp.h (DEFINE_FUNC): Make sname 'static'. · 95c82688
      Paul Eggert authored
      95c82688
    • Paul Eggert's avatar
      Make Emacs functions such as Fatom 'static' by default. · 16a97296
      Paul Eggert authored
      This makes it easier for human readers (and static analyzers)
      to see whether these functions can be called from other modules.
      DEFUN now defines a static function.  To make the function external
      so that it can be used in other C modules, use the new macro DEFUE.
      * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
      (DEFUN): Rewrite in terms of DEFINE_FUNC.  It now generates a
      static function definition.  Use DEFUE if you want an extern one.
      (DEFUE, INFUN): New macros.
      (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
      (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
      (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
      (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
      Remove decls, since these functions are now static.
      (Funintern, Fget_internal_run_time): New decls, since these functions
      were already external.
      * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
      * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
      * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
      * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
      * keyboard.c, keymap.c, lread.c:
      * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
      * syntax.c, term.c, terminal.c, textprop.c, undo.c:
      * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
      Mark functions with DEFUE instead of DEFUN,
      if they are used in other modules.
      * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
      decls for now-static functions.
      * buffer.h (Fdelete_overlay): Remove decl.
      * callproc.c (Fgetenv_internal): Mark as internal.
      * composite.c (Fremove_list_of_text_properties): Remove decl.
      (Fcomposition_get_gstring): New forward static decl.
      * composite.h (Fcomposite_get_gstring): Remove decl.
      * dired.c (Ffile_attributes): New forward static decl.
      * doc.c (Fdocumntation_property): New forward static decl.
      * eval.c (Ffetch_bytecode): New forward static decl.
      (Funintern): Remove extern decl; now in .h file where it belongs.
      * fileio.c (Fmake_symbolic_link): New forward static decl.
      * image.c (Finit_image_library): New forward static decl.
      * insdel.c (Fcombine_after_change_execute): Make forward decl static.
      * intervals.h (Fprevious_property_change):
      (Fremove_list_of_text_properties): Remove decls.
      * keyboard.c (Fthis_command_keys): Remove decl.
      (Fcommand_execute): New forward static decl.
      * keymap.c (Flookup_key): New forward static decl.
      (Fcopy_keymap): Now static.
      * keymap.h (Flookup_key): Remove decl.
      * process.c (Fget_process): New forward static decl.
      (Fprocess_datagram_address): Mark as internal.
      * syntax.c (Fsyntax_table_p): New forward static decl.
      (skip_chars): Remove duplicate decl.
      * textprop.c (Fprevious_property_change): New forward static decl.
      * window.c (Fset_window_fringes, Fset_window_scroll_bars):
      Now internal.
      (Fset_window_margins, Fset_window_vscroll): New forward static decls.
      * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
      16a97296
  3. 10 Apr, 2011 3 commits
  4. 09 Apr, 2011 14 commits
  5. 08 Apr, 2011 3 commits
    • Paul Eggert's avatar
      * eval.c: Port to Windows vsnprintf (Bug#8435). · eb3f1cc8
      Paul Eggert authored
      Include <limits.h>.
      (SIZE_MAX): Define if the headers do not.
      (verror): Do not give up if vsnprintf returns a negative count.
      Instead, grow the buffer.  This ports to Windows vsnprintf, which
      does not conform to C99.  Problem reported by Eli Zaretskii.
      Also, simplify the allocation scheme, by avoiding the need for
      calling realloc, and removing the ALLOCATED variable.
      eb3f1cc8
    • Chong Yidong's avatar
      Fix more GCC strict-aliasing warnings. · 65969f63
      Chong Yidong authored
      * src/ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
      unsigned char, to match FcChar8 type definition.
      
      * src/xmenu.c (create_and_show_popup_menu):
      * src/xselect.c (x_decline_selection_request)
      (x_reply_selection_request): Avoid type-punned deref of X events.
      65969f63
    • Chong Yidong's avatar