1. 14 Jul, 2013 1 commit
  2. 09 Jul, 2013 1 commit
  3. 07 Jul, 2013 2 commits
    • Eli Zaretskii's avatar
      MS-Windows followup for 2013-07-07T18:00:14Z!eggert@cs.ucla.edu. · 1d442672
      Eli Zaretskii authored
       nt/inc/sys/socket.h (F_SETFD, O_CLOEXEC, F_DUPFD_CLOEXEC)
       (FD_CLOEXEC): New macros.
      
       src/w32.c (sys_dup): Declare prototype.
      
       src/filelock.c:
       src/emacs.c:
       src/callproc.c [WINDOWSNT]: Include sys/socket.h.
      1d442672
    • Paul Eggert's avatar
      Make file descriptors close-on-exec when possible. · 067428c1
      Paul Eggert authored
      This simplifies Emacs a bit, since it no longer needs to worry
      about closing file descriptors by hand in some cases.
      It also fixes some unlikely races.  Not all such races, as
      libraries often open files internally without setting
      close-on-exec, but it's an improvement.
      * admin/merge-gnulib (GNULIB_MODULES): Add fcntl, pipe2.
      (GNULIB_TOOL_FLAGS): Avoid binary-io, close.  Do not avoid fcntl.
      * configure.ac (mkostemp): New function to check for.
      (PTY_OPEN): Pass O_CLOEXEC to posix_openpt.
      * lib/fcntl.c, lib/getdtablesize.c, lib/pipe2.c, m4/fcntl.m4:
      * m4/getdtablesize.m4, m4/pipe2.m4: New files, taken from gnulib.
      * lib/gnulib.mk, m4/gnulib-comp.m4: Regenerate.
      * nt/gnulib.mk: Remove empty gl_GNULIB_ENABLED_verify section;
      otherwise, gnulib-tool complains given close-on-exec changes.
      * nt/inc/ms-w32.h (pipe): Remove.
      * nt/mingw-cfg.site (ac_cv_func_fcntl, gl_cv_func_fcntl_f_dupfd_cloexec)
      (gl_cv_func_fcntl_f_dupfd_works, ac_cv_func_pipe2): New vars.
      * src/alloc.c (valid_pointer_p) [!WINDOWSNT]:
      * src/callproc.c (Fcall_process) [!MSDOS]:
      * src/emacs.c (main) [!DOS_NT]:
      * src/nsterm.m (ns_term_init):
      * src/process.c (create_process):
      Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
      * src/emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
      * src/filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
      Prefer mkostemp with O_CLOEXEC to mkstemp.
      * src/callproc.c (relocate_fd) [!WINDOWSNT]:
      * src/emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
      No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
      now using pipe2.
      * src/filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
      Make the resulting file descriptor close-on-exec.
      * src/lisp.h, src/lread.c, src/process.c (close_load_descs, close_process_descs):
      * src/lread.c (load_descriptor_list, load_descriptor_unwind):
      Remove; no longer needed.  All uses removed.
      * src/process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
      (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
      New functions.
      (socket) [!SOCK_CLOEXEC]: Supply a substitute.
      (Fmake_network_process, Fnetwork_interface_list):
      (Fnetwork_interface_info, server_accept_connection):
      Make newly-created socket close-on-exec.
      * src/sysdep.c (emacs_open, emacs_fopen):
      Make new-created descriptor close-on-exec.
      * src/w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
      * src/w32.c, src/w32.h (pipe2): Rename from 'pipe', with new flags arg.
      
      Fixes: debbugs:14803
      067428c1
  4. 05 May, 2013 1 commit
    • Paul Eggert's avatar
      `write-region-inhibit-fsync' defaults to noninteractive. · cbee2131
      Paul Eggert authored
      * cmdargs.texi (Initial Options):
      * files.texi (Customize Save): Document this.
      * etc/NEWS: Document this.
      * src/fileio.c (syms_of_fileio): Implement this.
      * src/filelock.c (create_lock_file): If symbolic links don't work, so
      we use a regular file as a lock file, do not fsync the lock file;
      it's not needed.
      
      Fixes: debbugs:14273
      cbee2131
  5. 13 Mar, 2013 1 commit
    • Paul Eggert's avatar
      File synchronization fixes. · 47d7532e
      Paul Eggert authored
      * admin/CPP-DEFINES (BSD_SYSTEM, HAVE_FSYNC): Remove.
      * admin/merge-gnulib (GNULIB_MODULES): Add fsync, fdatasync.
      * configure.ac (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
      (fsync): Remove check; now done by gnulib.
      * lib/fdatasync.c, lib/fsync.c, m4/fdatasync.m4, m4/fsync.m4:
      New files, from gnulib.
      * lib/gnulib.mk, m4/gnulib-comp.m4: Regenerate.
      * lib-src/Makefile.in (LIB_FDATASYNC): New macro.
      (emacsclient${EXEEXT}): Use it.
      * lib-src/emacsclient.c (main): Use fdatasync, not fsync, since we don't
      care about metadata.  Keep trying if interrupted.
      * lib-src/movemail.c (main, popmail): Don't worry about BSD_SYSTEM, since
      fsync is available everywhere (or there is a substitute).  Don't
      report an error if fsync returns EINVAL.
      * nt/inc/ms-w32.h (fdatasync): New macro, suggested by Eli Zaretskii.
      * src/Makefile.in (LIB_FDATASYNC): New macro.
      (LIBES): Use it.
      * src/conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
      * src/fileio.c (Fwrite_region, write_region_inhibit_fsync):
      Don't worry about HAVE_FSYNC, since a substitute fsync is
      available if the system lacks one.
      (Fwrite_regin): Retry fsync if interrupted.
      
      Fixes: debbugs:13944
      47d7532e
  6. 05 Mar, 2013 1 commit
    • Paul Eggert's avatar
      FILE's lock is now always .#FILE and may be a regular file. · 70743157
      Paul Eggert authored
      * etc/NEWS: Document this.
      * nt/inc/unistd.h (O_NOFOLLOW): New macro.
      * src/filelock.c: Include <c-ctype.h>.
      (MAX_LFINFO): New top-level constant.
      (lock_info_type): Remove members pid, boot_time.  Add members at,
      dot, colon.  Change user member to be the entire buffer, not a
      pointer.  This allows us to handle the case where a foreign
      pid or boot time exceeds the local range.  All uses changed.
      (LINKS_MIGHT_NOT_WORK): New constant.
      (FREE_LOCK_INFO): Remove, as the pieces no longer need freeing.
      (defined_WINDOWSNT): Remove.
      (MAKE_LOCK_NAME, file_in_lock_file_name):
      Always use .#FILE (not .#-FILE) for the file lock,
      even if it is a regular file.
      (rename_lock_file): New function.
      (create_lock_file): Use it.
      (create_lock_file, read_lock_data):
      Prefer a symbolic link for the lock file, falling back on a
      regular file if symlinks don't work.  Do not try to create
      symlinks on MS-Windows, due to security hassles.  Stick with
      POSIXish functions (open, read, write, close, fchmod, readlink, symlink,
      link, rename, unlink, mkstemp) when creating locks, as a GNUish
      host may be using a Windowsish file system, and cannot use
      MS-Windows-only system calls.  Fall back on mktemp if mkstemp
      doesn't work.  Don't fail merely because of a symlink-contents
      length limit in the current file system; fall back on regular
      files.  Increase the symlink contents length limit to 8 KiB, this
      should be big enough for any real use and doesn't crunch the
      stack.
      (create_lock_file, lock_file_1, read_lock_data):
      Simplify allocation of lock file buffers now that they fit in 8 KiB.
      (lock_file_1): Return error number, not bool.  All callers changed.
      (ELOOP): New macro, if not already defined.
      (read_lock_data): Return size of lock file contents, not Lisp object.
      All callers changed.  Handle a race condition if some other process
      replaces a regular-file lock with a symlink lock or vice versa,
      while we're trying to read the lock.
      (current_lock_owner): Parse contents more carefully, to help avoid
      confusing a regular-file lock with some other application's use
      of the file.  Check for lock file contents being too long, or
      not parsing correctly.
      (current_lock_owner, lock_file):
      Allow foreign pid and boot times that exceed the local range.
      (current_lock_owner, lock_if_free, lock_file):
      Simplify allocation of lock file contents.
      * src/w32.c (sys_rename_replace): New function, containing most of
      the contents of the old sys_rename.
      (sys_rename): Use it.
      (fchmod): New dummy function.
      * src/w32.h (sys_rename_replace, fchmod): New decls.
      
      Fixes: debbugs:13807
      70743157
  7. 02 Mar, 2013 2 commits
    • Paul Eggert's avatar
      2db41375
    • Paul Eggert's avatar
      The lock for FILE is now .#FILE or .#-FILE. · b5029e23
      Paul Eggert authored
      The old approach, which fell back on DIR/.#FILE.0 through
      DIR/.#FILE.9, had race conditions that could not be easily fixed.
      If DIR/.#FILE is a non-symlink file, Emacs now does not create a
      lock file for DIR/FILE; that is, DIR/FILE is no longer partly
      protected by a lock if DIR/.#FILE is a non-symlink file ("partly"
      because the locking mechanism was never reliable in that case).
      This patch fixes this and other bugs discovered by a code
      inspection that was prompted by
      <http://lists.gnu.org/archive/html/emacs-devel/2013-02/msg00531.html>.
      Also, this patch switches to .#-FILE (not .#FILE) on MS-Windows,
      to avoid interoperability problems between the MS-Windows and
      non-MS-Windows implementations.  MS-Windows and non-MS-Windows
      instances of Emacs now ignore each others' locks.
      * etc/NEWS: Document this.
      * src/filelock.c (defined_WINDOWSNT): New constant.
      (MAKE_LOCK_NAME, fill_in_lock_file_name):
      Don't create DIR/.#FILE.0 through DIR/.#FILE.9.  Instead, create
      DIR/.#FILE symlinks on non-MS-Windows hosts, and DIR/.#-FILE
      regular files on MS-Windows hosts.
      (MAKE_LOCK_NAME, unlock_file, Ffile_locked_p):
      Use SAFE_ALLOCA to avoid problems with long file names.
      (MAX_LFINFO): Now a local constant, not a global macro.
      (IS_LOCK_FILE): Remove.
      (lock_file_1): Don't inspect errno if symlink call succeeds;
      that's not portable.
      (lock_file): Document that this function can return if lock
      creation fails.
      
      Fixes: debbugs:13807
      b5029e23
  8. 27 Feb, 2013 1 commit
  9. 25 Feb, 2013 1 commit
    • Eli Zaretskii's avatar
      Implement CLASH_DETECTION for MS-Windows. · 343a2aef
      Eli Zaretskii authored
       src/filelock.c [WINDOWSNT]: Include w32.h.
       (MAKE_LOCK_NAME): Don't use 'lock', it clashes with MS runtime
       function of that name.  Up-case the macro arguments.
       (IS_LOCK_FILE): New macro.
       (fill_in_lock_file_name): Use IS_LOCK_FILE instead of S_ISLNK.
       (create_lock_file): New function, with body extracted from
       lock_file_1.
       [WINDOWSNT]: Implement lock files by writing a regular file with
       the lock information as its contents.
       (read_lock_data): New function, on Posix platforms just calls
       emacs_readlinkat.
       [WINDOWSNT]: Read the lock info from the file.
       (current_lock_owner): Call read_lock_data instead of calling
       emacs_readlinkat directly.
       (lock_file) [WINDOWSNT]: Run the file name through
       dostounix_filename.
       src/w32proc.c (sys_kill): Support the case of SIG = 0, in which case
       just check if the process by that PID exists.
       src/w32.c (sys_open): Don't reset the _O_CREAT flag if _O_EXCL is
       also present, as doing so will fail to error out if the file
       already exists.
       src/makefile.w32-in ($(BLD)/filelock.$(O)): Depend on src/w32.h.
      
       nt/inc/ms-w32.h (BOOT_TIME_FILE): Define.
       nt/config.nt (CLASH_DETECTION): Define to 1.
      
       lisp/emacs-lisp/bytecomp.el (byte-recompile-directory): Reject files
       that match "\`\.#", to avoid compiling lock files, even if they
       are readable (as they are on MS-Windows).
      
       doc/emacs/files.texi (Interlocking): Don't refer to symlinks as the
       exclusive means of locking files.
      
       etc/NEWS: Mention support for lock files on MS-Windows.
      343a2aef
  10. 24 Feb, 2013 1 commit
  11. 01 Feb, 2013 1 commit
    • Paul Eggert's avatar
      Use fdopendir, fstatat and readlinkat, for efficiency. · 8654f9d7
      Paul Eggert authored
      On my host, this speeds up directory-files-and-attributes by a
      factor of 3, when applied to Emacs's src directory.
      These functions are standardized by POSIX and are common these
      days; fall back on a (slower) gnulib implementation if the host
      is too old to supply them.
      * .bzrignore: Add lib/dirent.h.
      * lib/Makefile.am (libgnu_a_SOURCES): Add openat-die.c, save-cwd.c.
      * lib/careadlinkat.c, lib/careadlinkat.h: Merge from gnulib,
      incorporating: 2013-01-29 careadlinkat: do not provide careadlinkatcwd.
      * lib/gnulib.mk, m4/gnulib-comp.m4: Regenerate.
      * lib/dirent.in.h, lib/fdopendir.c, lib/fstatat.c, lib/openat-priv.h:
      * lib/openat-proc.c, lib/openat.h, m4/dirent_h.m4, m4/fdopendir.m4:
      * m4/fstatat.m4: New files, from gnulib.
      * lib/openat-die.c, lib/save-cwd.c, lib/save-cwd.h: New files.
      These last three are specific to Emacs and are not copied from gnulib.
      They are simpler than the gnulib versions and are tuned for Emacs.
      * admin/merge-gnulib (GNULIB_MODULES): Add fdopendir, fstatat, readlinkat.
      (GNULIB_TOOL_FLAGS): Do not avoid at-internal, openat-h.
      Avoid dup, open, opendir.
      * nt/inc/sys/stat.h (fstatat):
      * nt/inc/unistd.h (readlinkat): New decls.
      * src/conf_post.h (GNULIB_SUPPORT_ONLY_AT_FDCWD): Remove.
      * src/dired.c: Include <fcntl.h>.
      (open_directory): New function, which uses open and fdopendir
      rather than opendir.  DOS_NT platforms still use opendir, though.
      (directory_files_internal, file_name_completion): Use it.
      (file_attributes): New function, with most of the old Ffile_attributes.
      (directory_files_internal, Ffile_attributes): Use it.
      (file_attributes, file_name_completion_stat): First arg is now fd,
      not dir name.  All uses changed.  Use fstatat rather than lstat +
      stat.
      (file_attributes): Use emacs_readlinkat rather than Ffile_symlink_p.
      * src/fileio.c: Include <allocator.h>, <careadlinkat.h>.
      (emacs_readlinkat): New function, with much of the old
      Ffile_symlink_p, but with an fd argument for speed.
      It uses readlinkat rather than careadlinkatcwd, so that it
      need not assume the working directory.
      (Ffile_symlink_p): Use it.
      * src/filelock.c (current_lock_owner): Use emacs_readlinkat
      rather than emacs_readlink.
      * src/lisp.h (emacs_readlinkat): New decl.
      (READLINK_BUFSIZE, emacs_readlink): Remove.
      * src/sysdep.c: Do not include <allocator.h>, <careadlinkat.h>.
      (emacs_norealloc_allocator, emacs_readlink): Remove.
      This stuff is moved to fileio.c.
      * src/w32.c (fstatat, readlinkat): New functions.
      (careadlinkat): Don't check that fd == AT_FDCWD.
      (careadlinkatcwd): Remove; no longer needed.
      
      Fixes: debbugs:13539
      8654f9d7
  12. 01 Jan, 2013 1 commit
  13. 15 Sep, 2012 1 commit
    • Paul Eggert's avatar
      Port better to POSIX hosts lacking _setjmp. · 0328b6de
      Paul Eggert authored
      * configure.ac (HAVE__SETJMP, HAVE_SIGSETJMP): New symbols.
      (_setjmp, _longjmp): Remove.
      * src/lisp.h: Include <setjmp.h> here, since we use its symbols here.
      All instances of '#include <setjmp.h>' removed, if the
      only reason for the instance was because "lisp.h" was included.
      (sys_jmp_buf, sys_setjmp, sys_longjmp): New symbols.
      Unless otherwise specified, replace all uses of jmp_buf, _setjmp,
      and _longjmp with the new symbols.  Emacs already uses _setjmp if
      available, so this change affects only POSIXish hosts that have
      sigsetjmp but not _setjmp, such as some versions of Solaris and
      Unixware.  (Also, POSIX-2008 marks _setjmp as obsolescent.)
      * src/image.c (_setjmp, _longjmp) [HAVE_PNG && !HAVE__SETJMP]: New macros.
      (png_load_body) [HAVE_PNG]:
      (PNG_LONGJMP) [HAVE_PNG && PNG_LIBPNG_VER < 10500]:
      (PNG_JMPBUF) [HAVE_PNG && PNG_LIBPNG_VER >= 10500]:
      Use _setjmp and _longjmp rather than sys_setjmp and sys_longjmp,
      since PNG requires jmp_buf.  This is the only exception to the
      general rule that we now use sys_setjmp and sys_longjmp.
      This exception is OK since this code does not change the signal
      mask or longjmp out of a signal handler.
      
      Fixes: debbugs:12446
      0328b6de
  14. 05 Sep, 2012 1 commit
    • Paul Eggert's avatar
      * fileio.c, filelock.c, floatfns.c, fns.c: Use bool for boolean. · f75d7a91
      Paul Eggert authored
      * fileio.c (auto_saving, auto_save_error_occurred, make_temp_name)
      (Fexpand_file_name, barf_or_query_if_file_exists, Fcopy_file)
      (file_name_absolute_p, Fsubstitute_in_file_name):
      (check_executable, check_writable, Ffile_accessible_directory_p)
      (Fset_file_selinux_context, Fdefault_file_modes)
      (Finsert_file_contents, choose_write_coding_system)
      (Fwrite_region, build_annotations, a_write, e_write)
      (Fdo_auto_save):
      * filelock.c (boot_time_initialized, get_boot_time)
      (get_boot_time_1, lock_file_1, within_one_second):
      * floatfns.c (in_float):
      * fns.c (concat, internal_equal, Frequire, base64_encode_1)
      (base64_decode_1, cmpfn_eql, cmpfn_user_defined)
      (sweep_weak_table, sweep_weak_hash_tables, secure_hash):
      * lisp.h (struct Lisp_Hash_Table.cmpfn):
      * window.c (compare_window_configurations):
      Use bool for booleans.
      * fileio.c (auto_saving_dir_umask, auto_saving_mode_bits)
      (Fdefault_file_modes): Now mode_t, not int, for modes.
      (Fdo_auto_save): Set a boolean to 1 rather than using ++.
      (internal_delete_file): Now returns void, not a (boolean) int,
      since nobody was looking at the return value.
      * lisp.h, window.h: Adjust to above API changes.
      f75d7a91
  15. 03 Aug, 2012 1 commit
    • Paul Eggert's avatar
      Remove unnecessary casts involving pointers. · 98c6f1e3
      Paul Eggert authored
      These casts are no longer needed now that we assume C89 or later,
      since they involve casting to or from void *.
      * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
      (make_pure_float, make_pure_vector):
      * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
      * macros.c (Fstart_kbd_macro):
      * menu.c (find_and_return_menu_selection):
      * minibuf.c (read_minibuf_noninteractive):
      * sysdep.c (closedir):
      * xdisp.c (x_produce_glyphs):
      * xfaces.c (compare_fonts_by_sort_order):
      * xfns.c (x_real_positions, select_visual):
      * xselect.c (x_stop_queuing_selection_requests)
      (x_get_window_property, x_get_window_property_as_lisp_data):
      * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
      Remove unnecessary pointer casts.
      * alloc.c (record_xmalloc): New function.
      * lisp.h (record_xmalloc): New decl.
      (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
      more like a function.  This is because the pointer cast is not
      needed.  All uses changed.
      * print.c (print_string, print_error_message): Avoid length recalc.
      98c6f1e3
  16. 16 Jul, 2012 1 commit
    • Dmitry Antipov's avatar
      Remove empty and useless init functions. · 6a0dd1d7
      Dmitry Antipov authored
      * lisp.h (init_character_once, init_fns, init_image)
      (init_filelock, init_sound): Remove prototype.
      * character.c (init_character_once): Remove.
      * filelock.c (init_filelock): Likewise.
      * fns.c (init_fns): Likewise.
      * image.c (init_image): Likewise.
      * sound.c (init_sound): Likewise.
      * emacs.c (main): Adjust accordingly.
      6a0dd1d7
  17. 10 Jul, 2012 1 commit
    • Dmitry Antipov's avatar
      Avoid calls to strlen in path processing functions. · c293e30c
      Dmitry Antipov authored
      * fileio.c (file_name_as_directory): Add comment.  Change to add
      srclen argument and return the length of result.  Adjust users
      accordingly.
      (directory_file_name): Fix comment.  Change to add srclen argument,
      swap 1nd and 2st arguments to obey the common convention.  Adjust
      users accordingly.
      * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
      c293e30c
  18. 09 Jul, 2012 1 commit
    • Dmitry Antipov's avatar
      Use make_formatted_string to avoid double length calculation. · a8290ec3
      Dmitry Antipov authored
      * lisp.h (make_formatted_string): New prototype.
      * alloc.c (make_formatted_string): New function.
      * buffer.c (Fgenerate_new_buffer_name): Use it.
      * dbus.c (syms_of_dbusbind): Likewise.
      * editfns.c (Fcurrent_time_zone): Likewise.
      * filelock.c (get_boot_time): Likewise.
      * frame.c (make_terminal_frame, set_term_frame_name)
      (x_report_frame_params): Likewise.
      * image.c (gs_load): Likewise.
      * minibuf.c (get_minibuffer): Likewise.
      * msdos.c (dos_set_window_size): Likewise.
      * process.c (make_process): Likewise.
      * xdisp.c (ensure_echo_area_buffers): Likewise.
      * xsettings.c (apply_xft_settings): Likewise.
      a8290ec3
  19. 05 Jul, 2012 2 commits
    • Paul Eggert's avatar
      More xmalloc and related cleanup. · 38182d90
      Paul Eggert authored
      * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
      * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
      * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
      * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
      * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
      * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
      * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
      * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
      * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
      * xterm.c:
      Omit needless casts involving void * pointers and allocation.
      Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
      as the former is more robust if P's type is changed.
      Prefer xzalloc to xmalloc + memset 0.
      Simplify malloc-or-realloc to realloc.
      Don't worry about xmalloc returning a null pointer.
      Prefer xstrdup to xmalloc + strcpy.
      * editfns.c (Fmessage_box): Grow message_text by at least 80 when
      growing it.
      * keyboard.c (apply_modifiers_uncached): Prefer local array to
      alloca of a constant.
      38182d90
    • Dmitry Antipov's avatar
      Cleanup xmalloc. · 23f86fce
      Dmitry Antipov authored
      * admin/coccinelle/xzalloc.cocci: Semantic patch to convert
      calls to xmalloc with following memset to xzalloc.
      * src/lisp.h (xzalloc): New prototype.  Omit needless casts.
      * src/alloc.c (xzalloc): New function.  Omit needless casts.
      * src/charset.c: Omit needless casts.  Convert all calls to
      malloc with following memset to xzalloc.
      * src/dispnew.c: Likewise.
      * src/fringe.c: Likewise.
      * src/image.c: Likewise.
      * src/sound.c: Likewise.
      * src/term.c: Likewise.
      * src/w32fns.c: Likewise.
      * src/w32font.c: Likewise.
      * src/w32term.c: Likewise.
      * src/xfaces.c: Likewise.
      * src/xfns.c: Likewise.
      * src/xterm.c: Likewise.
      * src/atimer.c: Omit needless casts.
      * src/buffer.c: Likewise.
      * src/callproc.c: Likewise.
      * src/ccl.c: Likewise.
      * src/coding.c: Likewise.
      * src/composite.c: Likewise.
      * src/doc.c: Likewise.
      * src/doprnt.c: Likewise.
      * src/editfns.c: Likewise.
      * src/emacs.c: Likewise.
      * src/eval.c: Likewise.
      * src/filelock.c: Likewise.
      * src/fns.c: Likewise.
      * src/gtkutil.c: Likewise.
      * src/keyboard.c: Likewise.
      * src/lisp.h: Likewise.
      * src/lread.c: Likewise.
      * src/minibuf.c: Likewise.
      * src/msdos.c: Likewise.
      * src/print.c: Likewise.
      * src/process.c: Likewise.
      * src/region-cache.c: Likewise.
      * src/search.c: Likewise.
      * src/sysdep.c: Likewise.
      * src/termcap.c: Likewise.
      * src/terminal.c: Likewise.
      * src/tparam.c: Likewise.
      * src/w16select.c: Likewise.
      * src/w32.c: Likewise.
      * src/w32reg.c: Likewise.
      * src/w32select.c: Likewise.
      * src/w32uniscribe.c: Likewise.
      * src/widget.c: Likewise.
      * src/xdisp.c: Likewise.
      * src/xmenu.c: Likewise.
      * src/xrdb.c: Likewise.
      * src/xselect.c: Likewise.
      23f86fce
  20. 16 Jun, 2012 1 commit
    • Andreas Schwab's avatar
      * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline. · e5560ff7
      Andreas Schwab authored
      (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
      * character.c (_fetch_multibyte_char_p): Remove.
      * alloc.c: Include "character.h" before "buffer.h".
      * bidi.c: Likewise.
      * buffer.c: Likewise.
      * bytecode.c: Likewise.
      * callint.c: Likewise.
      * callproc.c: Likewise.
      * casefiddle.c: Likewise.
      * casetab.c: Likewise.
      * category.c: Likewise.
      * cmds.c: Likewise.
      * coding.c: Likewise.
      * composite.c: Likewise.
      * dired.c: Likewise.
      * dispnew.c: Likewise.
      * doc.c: Likewise.
      * dosfns.c: Likewise.
      * editfns.c: Likewise.
      * emacs.c: Likewise.
      * fileio.c: Likewise.
      * filelock.c: Likewise.
      * font.c: Likewise.
      * fontset.c: Likewise.
      * fringe.c: Likewise.
      * indent.c: Likewise.
      * insdel.c: Likewise.
      * intervals.c: Likewise.
      * keyboard.c: Likewise.
      * keymap.c: Likewise.
      * lread.c: Likewise.
      * macros.c: Likewise.
      * marker.c: Likewise.
      * minibuf.c: Likewise.
      * nsfns.m: Likewise.
      * nsmenu.m: Likewise.
      * print.c: Likewise.
      * process.c: Likewise.
      * regex.c: Likewise.
      * region-cache.c: Likewise.
      * search.c: Likewise.
      * syntax.c: Likewise.
      * term.c: Likewise.
      * textprop.c: Likewise.
      * undo.c: Likewise.
      * unexsol.c: Likewise.
      * w16select.c: Likewise.
      * w32fns.c: Likewise.
      * w32menu.c: Likewise.
      * window.c: Likewise.
      * xdisp.c: Likewise.
      * xfns.c: Likewise.
      * xmenu.c: Likewise.
      * xml.c: Likewise.
      * xselect.c: Likewise.
      e5560ff7
  21. 10 May, 2012 1 commit
    • Dave Abrahams's avatar
      Add the option to not create lockfiles · 836d29b3
      Dave Abrahams authored
      * src/filelock.c (syms_of_filelock): New boolean create-lockfiles.
      (lock_file): If create_lockfiles is 0, do nothing.
      
      * lisp/cus-start.el (create-lockfiles): Add it.
      
      Fixes: debbugs:11227
      836d29b3
  22. 11 Jan, 2012 1 commit
  23. 05 Jan, 2012 1 commit
  24. 09 Sep, 2011 1 commit
  25. 29 Aug, 2011 1 commit
  26. 07 Jul, 2011 1 commit
    • Paul Eggert's avatar
      * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide): · a81d11a3
      Paul Eggert authored
      Remove, replacing with the new symbols in lisp.h.  All uses changed.
      * fileio.c (make_temp_name):
      * filelock.c (lock_file_1, lock_file):
      * xdisp.c (message_dolog):
      Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
      Use pMd etc. instead.
      * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
      replacing the pWIDE etc. symbols removed from editfns.c.
      a81d11a3
  27. 20 Jun, 2011 1 commit
    • Paul Eggert's avatar
      * filelock.c: Fix some buffer overrun and integer overflow issues. · 882f0d81
      Paul Eggert authored
      (get_boot_time): Don't assume that gzip command string fits in 100 bytes.
      Reformulate so as not to need the command string.
      Invoke gzip -cd rather than gunzip, as it's more portable.
      (lock_info_type, lock_file_1, lock_file):
      Don't assume pid_t and time_t fit in unsigned long.
      (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
      (current_lock_owner): Prefer signed type for sizes.
      Use memcpy, not strncpy, where memcpy is what is really wanted.
      Don't assume (via atoi) that time_t and pid_t fit in int.
      Check for time_t and/or pid_t out of range, e.g., via a network share.
      Don't alloca where an auto var works fine.
      882f0d81
  28. 14 Apr, 2011 1 commit
  29. 11 Apr, 2011 1 commit
    • Paul Eggert's avatar
      Make Emacs functions such as Fatom 'static' by default. · 16a97296
      Paul Eggert authored
      This makes it easier for human readers (and static analyzers)
      to see whether these functions can be called from other modules.
      DEFUN now defines a static function.  To make the function external
      so that it can be used in other C modules, use the new macro DEFUE.
      * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
      (DEFUN): Rewrite in terms of DEFINE_FUNC.  It now generates a
      static function definition.  Use DEFUE if you want an extern one.
      (DEFUE, INFUN): New macros.
      (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
      (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
      (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
      (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
      Remove decls, since these functions are now static.
      (Funintern, Fget_internal_run_time): New decls, since these functions
      were already external.
      * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
      * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
      * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
      * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
      * keyboard.c, keymap.c, lread.c:
      * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
      * syntax.c, term.c, terminal.c, textprop.c, undo.c:
      * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
      Mark functions with DEFUE instead of DEFUN,
      if they are used in other modules.
      * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
      decls for now-static functions.
      * buffer.h (Fdelete_overlay): Remove decl.
      * callproc.c (Fgetenv_internal): Mark as internal.
      * composite.c (Fremove_list_of_text_properties): Remove decl.
      (Fcomposition_get_gstring): New forward static decl.
      * composite.h (Fcomposite_get_gstring): Remove decl.
      * dired.c (Ffile_attributes): New forward static decl.
      * doc.c (Fdocumntation_property): New forward static decl.
      * eval.c (Ffetch_bytecode): New forward static decl.
      (Funintern): Remove extern decl; now in .h file where it belongs.
      * fileio.c (Fmake_symbolic_link): New forward static decl.
      * image.c (Finit_image_library): New forward static decl.
      * insdel.c (Fcombine_after_change_execute): Make forward decl static.
      * intervals.h (Fprevious_property_change):
      (Fremove_list_of_text_properties): Remove decls.
      * keyboard.c (Fthis_command_keys): Remove decl.
      (Fcommand_execute): New forward static decl.
      * keymap.c (Flookup_key): New forward static decl.
      (Fcopy_keymap): Now static.
      * keymap.h (Flookup_key): Remove decl.
      * process.c (Fget_process): New forward static decl.
      (Fprocess_datagram_address): Mark as internal.
      * syntax.c (Fsyntax_table_p): New forward static decl.
      (skip_chars): Remove duplicate decl.
      * textprop.c (Fprevious_property_change): New forward static decl.
      * window.c (Fset_window_fringes, Fset_window_scroll_bars):
      Now internal.
      (Fset_window_margins, Fset_window_vscroll): New forward static decls.
      * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
      16a97296
  30. 01 Apr, 2011 1 commit
  31. 15 Mar, 2011 2 commits
  32. 22 Feb, 2011 1 commit
    • Paul Eggert's avatar
      [ChangeLog] · f68c809d
      Paul Eggert authored
      Assume S_ISLNK etc. work, since gnulib supports this.
      * Makefile.in (GNULIB_MODULES): Add sys_stat.
      * configure.in: Check for lstat and set HAVE_LSTAT=0 if not.
      Pretend to be using the gnulib lstat module for benefit of sys/stat.h.
      * configure, lib/Makefile.in, lib/gnulib.mk: Regenerate.
      [lib-src/ChangeLog]
      Assume S_ISLNK etc. work, since gnulib supports this.
      * etags.c (S_ISREG): Remove.
      [src/ChangeLog]
      Assume S_ISLNK etc. work, since gnulib supports this.
      * config.in: Regenerate.
      * dired.c (lstat): Remove.
      (file_name_completion): Assume S_ISDIR works.
      (file_name_completion_stat): Assume S_ISLNK works.
      Do not bother calling stat unless lstat says it's a symlink.
      * fileio.c (S_ISLNK, S_ISFIFO, S_ISREG, lstat): Remove.
      (Fcopy_file): Assume S_ISREG and S_ISLNK work.
      (check_writable, Ffile_writable_p, Fset_file_times):
      Assume S_ISDIR works.
      (Ffile_readable_p): Use S_IFIFO, not S_ISFIFO, to guess whether
      fifos exist.
      (Ffile_regular_p, Finsert_file_contents): Assumes S_ISREG works.
      * filelock.c (S_ISLNK): Remove.
      * lread.c (openp): Assume S_ISDIR works.
      * xrdb.c (S_ISDIR): Remove.
      f68c809d
  33. 16 Feb, 2011 1 commit
    • Tom Tromey's avatar
      Change B_ to BVAR · 4b4deea2
      Tom Tromey authored
      	* xfns.c (x_create_tip_frame, Fx_show_tip): Replace B_ with BVAR.
      	* xfaces.c (compute_char_face): Replace B_ with BVAR.
      	* xdisp.c (pos_visible_p, init_iterator, reseat_1)
      	(message_dolog, update_echo_area, ensure_echo_area_buffers)
      	(with_echo_area_buffer, setup_echo_area_for_printing)
      	(set_message_1, update_menu_bar, update_tool_bar)
      	(text_outside_line_unchanged_p, redisplay_internal)
      	(try_scrolling, try_cursor_movement, redisplay_window)
      	(try_window_reusing_current_matrix, row_containing_pos)
      	(try_window_id, get_overlay_arrow_glyph_row, display_line)
      	(Fcurrent_bidi_paragraph_direction, display_mode_lines)
      	(decode_mode_spec_coding, decode_mode_spec, display_count_lines)
      	(get_window_cursor_type, note_mouse_highlight): Replace B_ with
      	BVAR.
      	* window.c (window_display_table, unshow_buffer, window_loop)
      	(window_min_size_2, set_window_buffer, Fset_window_buffer)
      	(select_window, Fforce_window_update, temp_output_buffer_show)
      	(Fset_window_configuration, save_window_save): Replace B_ with
      	BVAR.
      	* w32fns.c (x_create_tip_frame, Fx_show_tip, Fw32_shell_execute):
      	Replace B_ with BVAR.
      	* undo.c (record_point, record_insert, record_delete)
      	(record_marker_adjustment, record_first_change)
      	(record_property_change, Fundo_boundary, truncate_undo_list)
      	(Fprimitive_undo): Replace B_ with BVAR.
      	* syntax.h (Vstandard_syntax_table, CURRENT_SYNTAX_TABLE)
      	(SETUP_BUFFER_SYNTAX_TABLE): Replace B_ with BVAR.
      	* syntax.c (update_syntax_table, dec_bytepos, Fsyntax_table)
      	(Fset_syntax_table, Fmodify_syntax_entry, skip_chars)
      	(skip_syntaxes, scan_lists): Replace B_ with BVAR.
      	* search.c (compile_pattern_1, compile_pattern, looking_at_1)
      	(string_match_1, fast_looking_at, newline_cache_on_off)
      	(search_command, search_buffer, simple_search, boyer_moore)
      	(Freplace_match): Replace B_ with BVAR.
      	* process.c (get_process, list_processes_1, Fstart_process)
      	(Fmake_serial_process, Fmake_network_process)
      	(read_process_output, send_process, exec_sentinel)
      	(status_notify, setup_process_coding_systems): Replace B_ with
      	BVAR.
      	* print.c (PRINTDECLARE, PRINTPREPARE, PRINTFINISH, printchar)
      	(strout, print_string, temp_output_buffer_setup, print_object):
      	Replace B_ with BVAR.
      	* msdos.c (IT_frame_up_to_date): Replace B_ with BVAR.
      	* minibuf.c (read_minibuf, get_minibuffer, Fread_buffer): Replace
      	B_ with BVAR.
      	* marker.c (Fmarker_buffer, Fset_marker, set_marker_restricted)
      	(set_marker_both, set_marker_restricted_both, unchain_marker):
      	Replace B_ with BVAR.
      	* lread.c (readchar, unreadchar, openp, readevalloop)
      	(Feval_buffer, Feval_region): Replace B_ with BVAR.
      	* lisp.h (DOWNCASE_TABLE, UPCASE_TABLE): Replace B_ with BVAR.
      	* keymap.c (Flocal_key_binding, Fuse_local_map)
      	(Fcurrent_local_map, push_key_description)
      	(Fdescribe_buffer_bindings): Replace B_ with BVAR.
      	* keyboard.c (command_loop_1, read_char_minibuf_menu_prompt)
      	(read_key_sequence): Replace B_ with BVAR.
      	* intervals.h (TEXT_PROP_MEANS_INVISIBLE): Replace B_ with BVAR.
      	* intervals.c (set_point_both, get_local_map): Replace B_ with
      	BVAR.
      	* insdel.c (check_markers, insert_char, insert_1_both)
      	(insert_from_string_1, insert_from_gap, insert_from_buffer_1)
      	(adjust_after_replace, replace_range, del_range_2)
      	(modify_region, prepare_to_modify_buffer)
      	(Fcombine_after_change_execute): Replace B_ with BVAR.
      	* indent.c (buffer_display_table, recompute_width_table)
      	(width_run_cache_on_off, current_column, scan_for_column)
      	(Findent_to, position_indentation, compute_motion, vmotion):
      	Replace B_ with BVAR.
      	* fringe.c (get_logical_cursor_bitmap)
      	(get_logical_fringe_bitmap, update_window_fringes): Replace B_
      	with BVAR.
      	* frame.c (make_frame_visible_1): Replace B_ with BVAR.
      	* font.c (font_at): Replace B_ with BVAR.
      	* fns.c (Fbase64_encode_region, Fbase64_decode_region, Fmd5):
      	Replace B_ with BVAR.
      	* filelock.c (unlock_all_files, Flock_buffer, Funlock_buffer)
      	(unlock_buffer): Replace B_ with BVAR.
      	* fileio.c (Fexpand_file_name, Ffile_directory_p)
      	(Ffile_regular_p, Ffile_selinux_context)
      	(Fset_file_selinux_context, Ffile_modes, Fset_file_modes)
      	(Fset_file_times, Ffile_newer_than_file_p, decide_coding_unwind)
      	(Finsert_file_contents, choose_write_coding_system)
      	(Fwrite_region, build_annotations, Fverify_visited_file_modtime)
      	(Fset_visited_file_modtime, auto_save_error, auto_save_1)
      	(Fdo_auto_save, Fset_buffer_auto_saved): Replace B_ with BVAR.
      	* editfns.c (region_limit, Fmark_marker, save_excursion_save)
      	(save_excursion_restore, Fprevious_char, Fchar_before)
      	(general_insert_function, Finsert_char, Finsert_byte)
      	(make_buffer_string_both, Finsert_buffer_substring)
      	(Fcompare_buffer_substrings, subst_char_in_region_unwind)
      	(subst_char_in_region_unwind_1, Fsubst_char_in_region)
      	(Ftranslate_region_internal, save_restriction_restore)
      	(Fchar_equal): Replace B_ with BVAR.
      	* dispnew.c (Fframe_or_buffer_changed_p): Replace B_ with BVAR.
      	* dispextern.h (WINDOW_WANTS_MODELINE_P)
      	(WINDOW_WANTS_HEADER_LINE_P): Replace B_ with BVAR.
      	* dired.c (directory_files_internal): Replace B_ with BVAR.
      	* data.c (swap_in_symval_forwarding, set_internal)
      	(Fmake_local_variable, Fkill_local_variable, Flocal_variable_p):
      	Replace B_ with BVAR.
      	* composite.c (fill_gstring_header)
      	(composition_compute_stop_pos, composition_adjust_point)
      	(Ffind_composition_internal): Replace B_ with BVAR.
      	* coding.c (decode_coding, encode_coding)
      	(make_conversion_work_buffer, decode_coding_gap)
      	(decode_coding_object, encode_coding_object)
      	(Fdetect_coding_region, Ffind_coding_systems_region_internal)
      	(Funencodable_char_position, Fcheck_coding_systems_region):
      	Replace B_ with BVAR.
      	* cmds.c (Fself_insert_command, internal_self_insert): Replace B_
      	with BVAR.
      	* charset.c (Ffind_charset_region): Replace B_ with BVAR.
      	* character.h (FETCH_CHAR_ADVANCE, INC_BOTH, DEC_BOTH)
      	(ASCII_CHAR_WIDTH): Replace B_ with BVAR.
      	* character.c (chars_in_text, Fget_byte): Replace B_ with BVAR.
      	* category.h (Vstandard_category_table): Replace B_ with BVAR.
      	* category.c (check_category_table, Fcategory_table)
      	(Fset_category_table, char_category_set): Replace B_ with BVAR.
      	* casetab.c (Fcurrent_case_table, set_case_table): Replace B_ with
      	BVAR.
      	* casefiddle.c (casify_object, casify_region): Replace B_ with
      	BVAR.
      	* callproc.c (Fcall_process, Fcall_process_region): Replace B_
      	with BVAR.
      	* callint.c (check_mark, Fcall_interactively): Replace B_ with
      	BVAR.
      	* bytecode.c (Fbyte_code): Replace B_ with BVAR.
      	* buffer.h (FETCH_CHAR, FETCH_CHAR_AS_MULTIBYTE, BVAR): Replace B_
      	with BVAR.
      	* buffer.c (Fbuffer_live_p, Fget_file_buffer)
      	(get_truename_buffer, Fget_buffer_create)
      	(clone_per_buffer_values, Fmake_indirect_buffer, reset_buffer)
      	(reset_buffer_local_variables, Fbuffer_name, Fbuffer_file_name)
      	(Fbuffer_local_value, buffer_lisp_local_variables)
      	(Fset_buffer_modified_p, Frestore_buffer_modified_p)
      	(Frename_buffer, Fother_buffer, Fbuffer_enable_undo)
      	(Fkill_buffer, Fset_buffer_major_mode, set_buffer_internal_1)
      	(set_buffer_temp, Fset_buffer, set_buffer_if_live)
      	(Fbarf_if_buffer_read_only, Fbury_buffer, Ferase_buffer)
      	(Fbuffer_swap_text, swapfield_, Fbuffer_swap_text)
      	(Fset_buffer_multibyte, swap_out_buffer_local_variables)
      	(record_overlay_string, overlay_strings, init_buffer_once)
      	(init_buffer, syms_of_buffer): Replace B_ with BVAR.
      4b4deea2
  34. 14 Feb, 2011 1 commit
    • Tom Tromey's avatar
      Hide implementation of `struct buffer' · 5d8ea120
      Tom Tromey authored
      	* composite.c (fill_gstring_header)
      	(composition_compute_stop_pos, composition_adjust_point)
      	(Ffind_composition_internal): Use B_.
      	* intervals.c (set_point_both, get_local_map): Use B_.
      	* callproc.c (Fcall_process, Fcall_process_region): Use B_.
      	* process.c (get_process, list_processes_1, Fstart_process)
      	(Fmake_serial_process, Fmake_network_process)
      	(read_process_output, send_process, exec_sentinel)
      	(status_notify, setup_process_coding_systems): Use B_.
      	* bytecode.c (Fbyte_code): Use B_.
      	* syntax.c (update_syntax_table, dec_bytepos, Fsyntax_table)
      	(Fset_syntax_table, Fmodify_syntax_entry, skip_chars)
      	(skip_syntaxes, scan_lists): Use B_.
      	* lread.c (readchar, unreadchar, openp, readevalloop)
      	(Feval_buffer, Feval_region): Use B_.
      	* print.c (printchar, strout, print_string, PRINTDECLARE)
      	(PRINTPREPARE, PRINTFINISH, temp_output_buffer_setup)
      	(print_object): Use B_.
      	* font.c (font_at): Use B_.
      	* fns.c (Fbase64_encode_region, Fbase64_decode_region, Fmd5): Use
      	B_.
      	* callint.c (check_mark, Fcall_interactively): Use B_.
      	* editfns.c (region_limit, Fmark_marker, save_excursion_save)
      	(save_excursion_restore, Fprevious_char, Fchar_before)
      	(general_insert_function, Finsert_char, Finsert_byte)
      	(make_buffer_string_both, Finsert_buffer_substring)
      	(Fcompare_buffer_substrings, subst_char_in_region_unwind)
      	(subst_char_in_region_unwind_1, Fsubst_char_in_region)
      	(Ftranslate_region_internal, save_restriction_restore)
      	(Fchar_equal): Use B_.
      	* data.c (swap_in_symval_forwarding, set_internal)
      	(Fmake_local_variable, Fkill_local_variable, Flocal_variable_p):
      	Use B_.
      	* undo.c (record_point, record_insert, record_delete)
      	(record_marker_adjustment, record_first_change)
      	(record_property_change, Fundo_boundary, truncate_undo_list)
      	(Fprimitive_undo): Use B_.
      	* search.c (compile_pattern_1, compile_pattern, looking_at_1)
      	(string_match_1, fast_looking_at, newline_cache_on_off)
      	(search_command, search_buffer, simple_search, boyer_moore)
      	(Freplace_match): Use B_.
      	* indent.c (buffer_display_table, recompute_width_table)
      	(width_run_cache_on_off, current_column, scan_for_column)
      	(Findent_to, position_indentation, compute_motion, vmotion): Use
      	B_.
      	* casefiddle.c (casify_object, casify_region): Use B_.
      	* casetab.c (Fcurrent_case_table, set_case_table): Use B_.
      	* cmds.c (Fself_insert_command, internal_self_insert): Use B_.
      	* fileio.c (Fexpand_file_name, Ffile_directory_p)
      	(Ffile_regular_p, Ffile_selinux_context)
      	(Fset_file_selinux_context, Ffile_modes, Fset_file_modes)
      	(Fset_file_times, Ffile_newer_than_file_p, decide_coding_unwind)
      	(Finsert_file_contents, choose_write_coding_system)
      	(Fwrite_region, build_annotations, Fverify_visited_file_modtime)
      	(Fset_visited_file_modtime, auto_save_error, auto_save_1)
      	(Fdo_auto_save, Fset_buffer_auto_saved): Use B_.
      	* minibuf.c (read_minibuf, get_minibuffer, Fread_buffer): Use B_.
      	* marker.c (Fmarker_buffer, Fset_marker, set_marker_restricted)
      	(set_marker_both, set_marker_restricted_both, unchain_marker): Use
      	B_.
      	* insdel.c (check_markers, insert_char, insert_1_both)
      	(insert_from_string_1, insert_from_gap, insert_from_buffer_1)
      	(adjust_after_replace, replace_range, del_range_2)
      	(modify_region, prepare_to_modify_buffer)
      	(Fcombine_after_change_execute): Use B_.
      	* filelock.c (unlock_all_files, Flock_buffer, Funlock_buffer)
      	(unlock_buffer): Use B_.
      	* keymap.c (Flocal_key_binding, Fuse_local_map)
      	(Fcurrent_local_map, push_key_description)
      	(Fdescribe_buffer_bindings): Use B_.
      	* keyboard.c (command_loop_1, read_char_minibuf_menu_prompt)
      	(read_key_sequence): Use B_.
      	* fringe.c (get_logical_cursor_bitmap)
      	(get_logical_fringe_bitmap, update_window_fringes): Use B_.
      	* xfns.c (x_create_tip_frame, Fx_show_tip): Use B_.
      	* xfaces.c (compute_char_face): Use B_.
      	* character.c (chars_in_text, Fget_byte): Use B_.
      	* category.c (check_category_table, Fcategory_table)
      	(Fset_category_table, char_category_set): Use B_.
      	* coding.c (decode_coding, encode_coding)
      	(make_conversion_work_buffer, decode_coding_gap)
      	(decode_coding_object, encode_coding_object)
      	(Fdetect_coding_region, Ffind_coding_systems_region_internal)
      	(Funencodable_char_position, Fcheck_coding_systems_region): Use
      	B_.
      	* charset.c (Ffind_charset_region): Use B_.
      	* window.c (window_display_table, unshow_buffer, window_loop)
      	(window_min_size_2, set_window_buffer, Fset_window_buffer)
      	(select_window, Fforce_window_update, temp_output_buffer_show)
      	(Fset_window_configuration, save_window_save): Use B_.
      	* xdisp.c (pos_visible_p, init_iterator, reseat_1)
      	(message_dolog, update_echo_area, ensure_echo_area_buffers)
      	(with_echo_area_buffer, setup_echo_area_for_printing)
      	(set_message_1, update_menu_bar, update_tool_bar)
      	(text_outside_line_unchanged_p, redisplay_internal)
      	(try_scrolling, try_cursor_movement, redisplay_window)
      	(try_window_reusing_current_matrix, row_containing_pos)
      	(try_window_id, get_overlay_arrow_glyph_row, display_line)
      	(Fcurrent_bidi_paragraph_direction, display_mode_lines)
      	(decode_mode_spec_coding, decode_mode_spec, display_count_lines)
      	(get_window_cursor_type, note_mouse_highlight): Use B_.
      	* frame.c (make_frame_visible_1): Use B_.
      	* dispnew.c (Fframe_or_buffer_changed_p): Use B_.
      	* dispextern.h (WINDOW_WANTS_HEADER_LINE_P)
      	(WINDOW_WANTS_MODELINE_P): Use B_.
      	* syntax.h (Vstandard_syntax_table): Update.
      	(CURRENT_SYNTAX_TABLE, SETUP_BUFFER_SYNTAX_TABLE): Use B_.
      	* intervals.h (TEXT_PROP_MEANS_INVISIBLE): Update.
      	(TEXT_PROP_MEANS_INVISIBLE): Use B_.
      	* character.h (FETCH_CHAR_ADVANCE): Update.
      	(INC_BOTH, ASCII_CHAR_WIDTH, DEC_BOTH): Use B_.
      	* category.h (Vstandard_category_table): Update.
      	* lisp.h (DEFVAR_BUFFER_DEFAULTS): Update for change to field
      	names.
      	(DOWNCASE_TABLE, UPCASE_TABLE): Use B_.
      	* buffer.c (swapfield_): New macro.
      	(Fbuffer_swap_text): Use swapfield_ where appropriate.
      	(Fbuffer_live_p, Fget_file_buffer, get_truename_buffer)
      	(Fget_buffer_create, clone_per_buffer_values)
      	(Fmake_indirect_buffer, reset_buffer)
      	(reset_buffer_local_variables, Fbuffer_name, Fbuffer_file_name)
      	(Fbuffer_local_value, buffer_lisp_local_variables)
      	(Fset_buffer_modified_p, Frestore_buffer_modified_p)
      	(Frename_buffer, Fother_buffer, Fbuffer_enable_undo)
      	(Fkill_buffer, Fset_buffer_major_mode, set_buffer_internal_1)
      	(set_buffer_temp, Fset_buffer, set_buffer_if_live)
      	(Fbarf_if_buffer_read_only, Fbury_buffer, Ferase_buffer)
      	(Fbuffer_swap_text, Fset_buffer_multibyte)
      	(swap_out_buffer_local_variables, record_overlay_string)
      	(overlay_strings, init_buffer_once, init_buffer, syms_of_buffer):
      	Use B_.
      	* buffer.h (struct buffer): Rename all Lisp_Object fields.
      	(BUFFER_INTERNAL_FIELD, B_): New macro.
      	(FETCH_CHAR, FETCH_CHAR_AS_MULTIBYTE): Use B_.
      5d8ea120
  35. 30 Jan, 2011 1 commit
    • Paul Eggert's avatar
      Use SSDATA when the context wants char *. · 42a5b22f
      Paul Eggert authored
      * alloc.c, buffer.c, bytecode.c, callproc.c, dired.c:
      * dispnew.c, doc.c, editfns.c, emacs.c, fileio.c, filelock.c:
      * fns.c, font.c, frame.c, image.c, indent.c, keyboard.c:
      * lread.c, minibuf.c, print.c, process.c, search.c, widget.c:
      * xdisp.c, xfaces.c, xfns.c, xml.c, xselect.c, xterm.c:
      Use SSDATA (not SDATA) when the context of the expression wants
      char * (not unsigned char *).
      42a5b22f
  36. 25 Jan, 2011 1 commit