1. 23 Nov, 2018 1 commit
    • Paul Eggert's avatar
      emacsclient: tidy socket failure cleanup · 5daba9d8
      Paul Eggert authored
      * lib-src/emacsclient.c (set_tcp_socket, set_local_socket):
      Close socket (instead of leaking it) when ‘connect’ fails.
      (socket_status): Return errno if stat fails and -1 if we don’t own.
      (set_local_socket): Simplify based on socket_status change.
      5daba9d8
  2. 22 Nov, 2018 5 commits
    • Juri Linkov's avatar
      Add Isearch commands for going to absolute occurrence of matches (bug#29321) · 4dc73269
      Juri Linkov authored
      * lisp/isearch.el (isearch-mode-map): Bind 'M-s M-<' to
      'isearch-beginning-of-buffer' and 'isearch-end-of-buffer' to 'M-s M->'.
      (isearch-beginning-of-buffer, isearch-end-of-buffer): New commands.
      4dc73269
    • Paul Eggert's avatar
      emacsclient: coalesce WINDOWSNT-specific code · 7a85753d
      Paul Eggert authored
      * lib-src/emacsclient.c (sock_err_message) [WINDOWSNT]:
      Do nothing if w32_window_app () && alternate_editor.
      Both callers changed.
      7a85753d
    • Paul Eggert's avatar
      emacsclient: sockaddr portability fixes · 5773470f
      Paul Eggert authored
      * lib-src/emacsclient.c (get_server_config, set_tcp_socket)
      (set_local_socket): Initialize any platform-specific extensions
      of struct to zero, just in case.
      (set_tcp_socket, set_local_socket): Don’t assume struct
      layout details that POSIX does not specify.
      Use union to sidestep some problems with strict aliasing.
      Remove unnecessary casts.
      5773470f
    • Michael Albinus's avatar
      Some minor Tramp cleanups · a344d993
      Michael Albinus authored
      * lisp/net/tramp-adb.el (tramp-adb-file-name-p):
      * lisp/net/tramp-ftp.el (tramp-ftp-file-name-p):
      * lisp/net/tramp-smb.el (tramp-smb-file-name-p): Make it more robust.
      
      * lisp/net/tramp.el (tramp-handle-file-truename): Cache only the
      localname.
      a344d993
    • Paul Eggert's avatar
      emacsclient: getopt minor cleanup · ad063d25
      Paul Eggert authored
      * lib-src/emacsclient.c (shortopts): New constant.
      (decode_options): Use it.  Do not assume EOF == -1.
      ad063d25
  3. 21 Nov, 2018 10 commits
    • Paul Eggert's avatar
      emacsclient: omit EXTRA_SPACE guesswork · 0f22bf09
      Paul Eggert authored
      * lib-src/emacsclient.c: Include <intprops.h>.
      (EXTRA_SPACE): Remove; code no longer guesses this is enough.
      (open_config): New function.
      (get_server_config): Use it.
      (set_local_socket): Compute upper bound of buffer size
      instead of guessing via EXTRA_SPACE.
      0f22bf09
    • Juri Linkov's avatar
      Add prefix arg to isearch-forward-symbol-at-point (bug#29321) · cdb0d080
      Juri Linkov authored
      * lisp/isearch.el (isearch-forward-symbol-at-point): Add optional arg.
      cdb0d080
    • Paul Eggert's avatar
      emacsclient: take more care with int width · 8f49cb00
      Paul Eggert authored
      * lib-src/emacsclient.c: Include inttypes.h, stddef.h.
      (emacs_pid, main): Don’t assume pid fits in int.
      (fail): Don’t assume pointer difference fits in int.
      (set_local_socket): Don’t assume uid fits in long.
      8f49cb00
    • Paul Eggert's avatar
      emacsclient.c: use C99 to avoid {} · c0870736
      Paul Eggert authored
      * lib-src/emacsclient.c (set_local_socket):
      Assume C99 decl-after-statement and reindent.
      c0870736
    • Paul Eggert's avatar
      emacsclient: improve use of locals · 3fe110d3
      Paul Eggert authored
      * lib-src/emacsclient.c (main):
      Use smaller scopes for some locals.
      3fe110d3
    • Paul Eggert's avatar
      emacsclient: fix unlikely crash with "&" · 7a85a40e
      Paul Eggert authored
      * lib-src/emacsclient.c (quote_argument):
      Mention *DATA in comment so it’s clear DATA must be non-null.
      (quote_argument, unquote_argument): Simplify.
      (unquote_argument): Don’t crash if the string ends in "&".
      7a85a40e
    • Eric Abrahamsen's avatar
      Fix "Allow use of Gnus search groups as notmuch path: search term" · e01d0307
      Eric Abrahamsen authored
      * lisp/gnus/nnir.el (nnir-notmuch-filter-group-names-function):
        Default to nil -- getting correct behavior requires user
        intervention too often to have this enabled by default.
      * lisp/gnus/nnir.el (nnir-run-notmuch): If the user has turned this
        on, then also hardcode `gnus-group-short-name' as a filter -- things
        will never work without it. Also move leading space to before the
        opening parenthesis.
      * doc/misc/gnus.texi: Document option.
      
      (Bug#33122)
      e01d0307
    • Eric Abrahamsen's avatar
      Check Gnus group names when reading from browse server · d15d72b2
      Eric Abrahamsen authored
      * lisp/gnus/gnus-srvr.el (gnus-browse-read-group): If the group in
        question belongs to the native server, the name has to be shortened
        before we check it with `gnus-get-info'. It might work otherwise
        with nntp, but for backends like nnmaildir that have their own
        accounting system, creating an ephemeral group won't work.
      d15d72b2
    • Michael Albinus's avatar
      * doc/misc/tramp.texi: Fix last commit. · e0799e67
      Michael Albinus authored
      e0799e67
    • Michael Albinus's avatar
      Let Tramp sudo sessions expire after a timeout · fb200f3e
      Michael Albinus authored
      * doc/misc/tramp.texi (Inline methods) <sudo, doas>: Both methods expire
      the underlying session per default.
      (Predefined connection information): Explain "session-timeout".
      
      * etc/NEWS: Mention Tramp session expiration.
      
      * lisp/net/tramp-sh.el (tramp-methods) <sudo, doas>:
      Add `tramp-session-timeout'.
      (tramp-timeout-session): New defun.
      (tramp-maybe-open-connection): Handle session timeout.
      
      * lisp/net/tramp.el (tramp-methods): Adapt docstring.
      (tramp-equal-remote): Extend.
      fb200f3e
  4. 20 Nov, 2018 7 commits
    • Juri Linkov's avatar
      Add prefix arg to isearch-repeat-forward/backward (bug#14563, bug#29321) · 166f6274
      Juri Linkov authored
      * lisp/isearch.el (isearch-repeat): Add optional arg COUNT.
      Add a while-loop that calls `isearch-search' COUNT times.
      (isearch-repeat-forward, isearch-repeat-backward):
      Add optional prefix ARG passed down to `isearch-repeat'.
      Handle reversed directions.
      166f6274
    • Stefan Monnier's avatar
      calc.el, calc-(ext|poly), calccomp: Use lexical-binding · 11c9343f
      Stefan Monnier authored
      * lisp/calc/calc-ext.el: Use lexical-binding, silence warnings.
      (calc-init-extensions): Remove a few functions which can't be called
      directly since they depend on dynamically scoped vars.
      (calc-embedded-quiet): Declare.
      (math-defcache): Use 'declare'.
      (math-normalize-a): Remove declaration.
      (math-normalize-nonstandard): Receive 'a' as arg instead.
      (math-defintegral): Use 'declare'.
      (math-exp-pos, math-exp-old-pos, math-exp-keep-spaces, math-rb-h2)
      (math-read-big-baseline, math-read-big-h2, math-read-big-err-msg)
      (math-exp-token, math-expr-data, math-exp-str): Declare.
      (math-map-tree, math-read-expr): Avoid dynvars as formal arguments.
      
      * lisp/calc/calc-poly.el: Use lexical-binding, silence warnings.
      Turn some comments into docstrings.
      (math-poly-div): Avoid dynvars as formal arguments.
      (math-poly-base-top-expr): Move declaration before first use.
      (calcFunc-factors, math-factor-expr, math-factor-expr-try)
      (calcFunc-factor): Avoid dynvars as formal arguments.
      
      * lisp/calc/calc.el: Use lexical-binding, silence warnings.
      (math-normalize-a): Remove.
      (math-normalize): Use lexical var 'a' instead.
      (math-svo-c): Remove.
      (math-stack-value-offset): Pass 'c' explicitly as arg to
      math-stack-value-offset-fancy instead.
      
      * lisp/calc/calccomp.el: Use lexical-binding, silence warnings.
      (math-svo-c): Remove.
      (math-stack-value-offset-fancy): Use new arg 'c' instead.
      (math-comp-to-string-flat): Avoid dynvars as formal arguments.
      11c9343f
    • Glenn Morris's avatar
      Merge from origin/emacs-26 · 336681f3
      Glenn Morris authored
      d667318a (origin/emacs-26) Fix two Edebug defcustoms (bug#33428)
      336681f3
    • Glenn Morris's avatar
      ; Merge from origin/emacs-26 · feea5c64
      Glenn Morris authored
      The following commit was skipped:
      
      b8b42c23 Fix Bug#33141
      feea5c64
    • Glenn Morris's avatar
      Merge from origin/emacs-26 · bb7b75d7
      Glenn Morris authored
      070e82b9 ; * src/window.c (window_scroll): Improve commentary.
      60457d7a Improve documentation of the window tree
      ea1a0149 Fix window scrolling on TTY frames when there's no mode line
      df7ed10e Fix decoding XML files encoded in ISO-8859
      7851ae8b (tag: emacs-26.1.90) ; ChangeLog.3 update
      19588083 * etc/AUTHORS: Update.
      72525076 Fix description of some window hooks
      88762b40 Run 'window--adjust-process-windows' when frame size changes ...
      d6542ea0 Avoid errors in zone.el when there's overlay at EOB
      bb7b75d7
    • Stefan Monnier's avatar
      * lisp/calc/calc-alg.el: Use lexical-binding and silence warnings · e1b2c21b
      Stefan Monnier authored
      * lisp/calc/calc-alg.el: Use lexical-binding and silence warnings.
      (math-defsimplify): Let-bind 'expr' instead of math-simplify-expr.
      Adjust all users.
      (math-simplify-expr): Don't declare any more.
      (math--simplify-divide-expr): New dynbound var.
      (math-simplify-divide): Bind it when needed.
      (math-simplify-divisor): Use it instead of math-simplify-expr.
      (math-simplify-divisor): Only bind math-simplify-divisor-[nd]over
      around the calls to math-simplify-one-divisor.
      (math-expr-subst, math-is-polynomial): Don't use dynbound vars as
      formal arguments.
      (math-polynomial-base): Move binding of math-poly-base-pred.
      Don't bind math-poly-base-top-expr any more...
      * lisp/calc/calc-poly.el (math-total-polynomial-base): Bind it here instead!
      
      * lisp/calc/calc-units.el: Use lexical-binding and silence warnings.
      Adjust to the new 'expr' name in math-defsimplify.
      (math-find-base-units, math-to-standard-units, math-convert-units):
      Don't use dynbound vars as formal arguments.
      (math-simplify-expr): Don't declare any more.
      e1b2c21b
    • Robert Pluim's avatar
      Remove space from end of coding cookie · 5007c23a
      Robert Pluim authored
      * lisp/bookmark.el (bookmark-insert-file-format-version-stamp):
      Remove unnecessary space from end of coding cookie.
      5007c23a
  5. 19 Nov, 2018 17 commits
    • Stephen Berman's avatar
      Fix two Edebug defcustoms (bug#33428) · d667318a
      Stephen Berman authored
      * lisp/emacs-lisp/edebug.el (edebug-print-length)
      (edebug-print-level): Fix customization type to allow setting
      the documented valid value nil via the Customize interface.
      d667318a
    • Michael Albinus's avatar
      Fix Bug#33141 · b8b42c23
      Michael Albinus authored
      * lisp/net/tramp.el (tramp-make-tramp-file-name): Avoid check for
      empty method with simplified `tramp-syntax'.  (Bug#33141)
      b8b42c23
    • Eli Zaretskii's avatar
      Fix last change · 008bc1cb
      Eli Zaretskii authored
      * lib-src/emacsclient.c (start_daemon_and_retry_set_socket)
      [!WINDOWSNT]: Condition usage of socket_name on
      NO_SOCKETS_IN_FILE_SYSTEM being undefined.
      008bc1cb
    • Eli Zaretskii's avatar
      Avoid compiler warning in emacsclient.c · 57d5c14d
      Eli Zaretskii authored
      * lib-src/emacsclient.c (socket_name): Define only if
      NO_SOCKETS_IN_FILE_SYSTEM is not defined, to avoid a compiler
      warning.
      57d5c14d
    • Paul Eggert's avatar
      emacsclient.c: file name component fixes · 0e3b2458
      Paul Eggert authored
      * lib-src/emacsclient.c: Include <dosname.h>.
      (file_name_absolute_p): Remove, as a code duplicate.
      All uses replaced by IS_ABSOLUTE_FILE_NAME.
      (set_local_socket): Don’t treat \ as a file name separator
      on GNU and POSIX hosts.
      0e3b2458
    • Paul Eggert's avatar
      emacsclient.c: reindent to fit in 80 · 736f1b36
      Paul Eggert authored
      * lib-src/emacsclient.c: Reindent slightly.
      736f1b36
    • Paul Eggert's avatar
      emacsclient.c: use C99 better · b944e886
      Paul Eggert authored
      * lib-src/emacsclient.c (get_current_dir_name)
      (send_to_emacs, set_tcp_socket, set_local_socket, main):
      Take advantage of C99 stmt before decl.
      b944e886
    • Paul Eggert's avatar
      emacsclient.c: use STDOUT_FILENO · 95ea5c25
      Paul Eggert authored
      * lib-src/emacsclient.c (find_tty, handle_sigcont, main):
      Use STDOUT_FILENO instead of fileno (stdout) or magic 1.
      95ea5c25
    • Paul Eggert's avatar
      emacsclient.c: use bool for boolean · 51f9c5a6
      Paul Eggert authored
      * lib-src/emacsclient.c (nowait, quiet, suppress_output, eval, tty)
      (decode_options, file_name_absolute_p, get_server_config)
      (strprefix, find_tty, set_socket, main):
      Use bool for boolean.
      (create_frame): New static var, replacing the old current_frame
      and with inverted sense, as this is clearer.
      51f9c5a6
    • Paul Eggert's avatar
      emacsclient.c: make identifiers more local · 9f47bb22
      Paul Eggert authored
      * lib-src/emacsclient.c (progname, main_argc, main_argv):
      (nowait, quiet, suppress_output, eval, current_frame, display):
      (alt_display, parent_id, tty, alternate_editor, socket_name):
      (server_file, tramp_prefix, emacs_pid, frame_parameters):
      (longopts, xstrdup, send_bufffer, sblen, emacs_socket):
      Now static.
      (SEND_BUFFER_SIZE, send_buffer, sblen):
      Now local to send_to_emacs.
      9f47bb22
    • Paul Eggert's avatar
      emacsclient.c: clean up preprocessing directives · 4a5034d8
      Paul Eggert authored
      * lib-src/emacsclient.c [WINDOWSNT]: Omit duplicate stdlib.h include.
      Include min-max.h.
      (EXIT_SUCCESS, EXIT_FAILURE, min): Remove; no longer needed.
      (AUTH_KEY_LENGTH, SEND_BUFFER_SIZE): Now constants instead of macros.
      4a5034d8
    • Eli Zaretskii's avatar
      070e82b9
    • Eli Zaretskii's avatar
      Improve documentation of the window tree · 60457d7a
      Eli Zaretskii authored
      * doc/lispref/windows.texi (Windows and Frames): More accurate
      wording regarding the relation of a mini-window to its frame's
      window tree.
      
      * src/window.h (struct window): Improve commentary to some
      fields.
      60457d7a
    • Eli Zaretskii's avatar
      Fix window scrolling on TTY frames when there's no mode line · ea1a0149
      Eli Zaretskii authored
      * src/window.c (window_internal_height): Remove tests for
      next, prev, and parent pointers, as they are unrelated to
      whether a window has a mode line.  (Bug#33363)
      ea1a0149
    • Eli Zaretskii's avatar
      Fix decoding XML files encoded in ISO-8859 · df7ed10e
      Eli Zaretskii authored
      * lisp/international/mule.el (sgml-xml-auto-coding-function):
      Avoid signaling an error from coding-system-equal when the XML
      encoding tag specifies an encoding whose type is 'charset'.
      (Bug#33429)
      df7ed10e
    • Ulrich Müller's avatar
      Update the calc units table · d3b1d5d2
      Ulrich Müller authored
      On 2018-11-16, the 26th meeting of the General Conference on Weights
      and Measures (CGPM) has redefined the International System of Units by
      adopting fixed values for the Planck constant, the elementary charge,
      the Boltzmann constant, and the Avogadro constant:
      https://www.bipm.org/utils/en/pdf/CGPM/Draft-Resolution-A-EN.pdf
      * lisp/calc/calc-units.el (math-standard-units): Update according
      to redefinition of the SI in 2018.
      d3b1d5d2
    • NicolasPetton's avatar
      ; ChangeLog.3 update · 7851ae8b
      NicolasPetton authored
      7851ae8b