GitLab

(calc-Need-calc-arith): Remove it.

(calc-Need-calc-alg, math-need-std-simps): Remove them.
(math-defsimplify): Move from calc-ext.el.

(calc-Need-calc-aent): Remove it.

(calc-info-filename, calc-autoload-directory, calc-extensions-loaded):
Remove unnecessary variable.
(calc-do-dispatch, calc-mode, calc-check-defines, calc-create-buffer)
(calc, calc-keypad, full-calc-keypad, calc-do, calc-normalize)
(calc-binary-op, calc-unary-op, calcDigit-start, calcDigit-key)
(math-normalize, math-add, math-mul, math-div,
(math-format-stack-value, math-stack-value-offset, math-format-value)
(math-format-flat-expr, math-format-number, math-format-bignum)
(math-read-number, calc-grab-region, calc-grab-rectangle)
(calc-grab-sum-down, calc-grab-sum-across, calc-embedded, defmath)
(calc-check-defines): Replace calc-need-macros by appropriate require.

appropriate require.

(calc-shift-Y-prefix-help, math-concat, math-trunc, math-floor)
(calcFunc-inv, math-mod, math-pow): Replace calc-extensions by
appropriate require.
(calc-power): Replace calc-extensions-loaded by appropriate featurep.

(calc-need-macros): Remove unnecessary function.

(calc-do-quick-calc, calc-do-calc-eval, calc-alg-entry)
(math-read-expr-level, calc-check-user-syntax, math-read-factor):
Replace calls to calc-extensions by appropriate require,
replace calc-extensions-loaded by appropriate featurep.

Remove redundant loading of calc.
(calc-extensions-loaded): Remove unnecessary variable.
(calc-extensions): Remove unnecessary function.
(calc-load-everything): Replace calc-need-macros by appropriate require.

(math-double-roots): Declare them (for real this time).

(math-exp-keep-spaces, math-expr-data): Declare them.

(math-normalize-a, math-integral-cache): Declare them.

(calc-eval-error): Don't check if the variable calc-eval-error is
bound.
(calc-buffer, calc-digit-value, math-expr-data): Declare them.
(math-alg-inequalities): Move declaration to earlier in the file.

(math-format-radix-float): Remove unnecessary setq.
(math-radix-float-cache): Declare it.

(calc-embed-outer-top, calc-embed-outer-bot, calc-embed-top)
(calc-embed-bot): New variables.
(calc-do-embedded, calc-embedded-mark-formula)
(calc-embedded-find-bounds, calc-embedded-duplicate)
(calc-embedded-new-formula, calc-embedded-make-info):
Replace variables outer-top, outer-bot, bot and top by declared
variables.
(calc-embed-prev-modes): New variable.
(calc-embedded-set-modes, calc-embedded-update): Replace variable
prev-modes with declared variable.
(calc-embed-vars-used): New variable.
(calc-embedded-make-info, calc-embedded-evaluate-expr)
(calc-embedded-update, calc-embedded-find-vars): Replace variable
vars-used by declared variable.

(calc-describe-key): Make calc-summary-indentation a local variable.
(calc-help-long-names): Move declaration to earlier in file.

(math-multi-subst, math-multi-subst-rec): Replace variables temp and
arg by declared variables.

(calcFunc-reducer): Fixed incorrect variable.

(math-inner-mul-func, math-inner-add-func): New variables.
(calcFunc-inner, math-inner-mats): Replace variables mul-func
and add-func by declared variables.

(math-det-raw, math-det-step): Replace variable lu by declared
variable.

(calc-var-name-map): Move declaration to earlier in the file.

(calc-pv-pos): New variable.
(calc-permanent-variable, calc-insert-permanent-variable):
Replace variable pos by declared variable.

(math-lud-cache, math-log2-cache, math-radix-digits-cache)
(math-radix-float-cache-tag, math-random-cache, math-max-digits-cache)
(math-integral-cache, math-units-table, math-format-date-cache)
(math-holidays-cache-tag): Declare them.

(math-moc-func): New variable.
(math-map-over-constants, math-map-over-constants-rec):
Replace variable func by declared variable.

(calc-edit-handler, calc-restore-trail, calc-allow-ret): Declare them.

(calcFunc-grade, calcFunc-rgrade, math-grade-beforep): Replace
variable grade-vec by declared variable.
(math-rb-close): New variable.
(math-read-brackets, math-read-vector): Replace variable close by
declared variable.

(calc-num-units, calc-den-units): New variables.
(calc-explain-units, calc-explain-units-rec): Replace variables
num-units and den-units by declared variables.
(math-cu-unit-list): New variable.
(math-build-units-table, math-compare-unit-names)
(math-convert-units, math-convert-units-rec): Replace variable
unit-list by declared variable.
(math-fbu-base, math-fbu-entry): New variables.
(math-find-base-units, math-find-base-units-rec): Replace variables
base and entry by declared variables.
(math-which-standard): New variable.
(math-to-standard-units, math-to-standard-rec): Replace variable
which-standard by declared variable.
(math-fcu-u): New variable.
(math-find-compatible-unit, math-find-compatible-unit-rec):
Replace variable u by declared variable.
(math-cu-new-units, math-cu-pure): New variables.
(math-convert-units, math-convert-units-rec): Replace variables
new-units and pure by declared variables.
(math-try-cancel-units): New variable.
(math-simplify-units-quotient): Replace variable try-cancel-units by
declared variable.

(math-polynomial-p1): Replace variable mpb-top-expr by declared
variable.
(math-poly-base-total-base): New variable.
(math-total-polynomial-base, math-polynomial-p1): Replace variable
mpb-total-base by declared variable.
(math-factored-vars, math-to-list): Declare it.
(math-fact-expr): New variable.
(calcFunc-factors, calcFunc-factor, math-factor-expr,
math-factor-expr-try, math-factor-expr-part): Replace variable expr by
declared variable.
(math-fet-x): New variable.
(math-factor-expr-try, math-factor-poly-coefs): Replace variable x by
declared variable.
(math-factor-poly-coefs): Make temp a local variable.

(math-polynomial-base): Replace variable mpb-top-expr by
math-poly-base-top-expr.

(math-floor): Replace variable prec by math-floor-prec.

(math-scalar-if-args-functions, math-real-functions)
(math-positive-functions, math-nonnegative-functions)
(math-real-scalar-functions, math-real-if-arg-functions)
(math-integer-functions, math-num-integer-functions)
(math-rounding-functions, math-float-rounding-functions)
(math-integer-if-args-functions, math-super-types):
Move declarations to earlier in file.

(math-unit-prefixes): Declared it.

(math-floor-prec, math-trunc-prec): New variables.
(math-trunc-fancy): Replace variable prec by declared variable.
(math-floor-fancy): Replace variable prec by declared variable.

(math-com-bterms): New variable.
(math-commutative-equal, math-commutative-collect): Replace variable
bterms by declared variable.

(calc-gnuplot-print-device, calc-gnuplot-print-output)
(calc-gnuplot-geometry, calc-graph-default-resolution)
(calc-graph-default-resolution-3d): Remove redundant initial values.

(calc-show-banner): Removed redundant declaration.

(math-nth-root-float, math-nth-root-float-iter): Replace variables
n, nf and nfm1 by declared variables.

(math-nri-n): New variable.
(math-nth-root-int, math-nth-root-int-iter): Replace variable n by
declared variable.

(calcFunc-log): Removed misplaced condition.