1. 23 Oct, 2017 1 commit
    • Paul Eggert's avatar
      Port to OpenIndiana · 63606114
      Paul Eggert authored
      Problem reported by Nelson H. F. Beebe (Bug#28893).
      Also see Bug#23748, Bug#9736, and Bug#5735.
      * configure.ac (tputs_library): Prefer libcurses to libtermcap,
      since OpenIndiana libtermcap lacks tparm.
  2. 22 Oct, 2017 4 commits
    • Alexander Gramiak's avatar
      Don't fill keywords after Emacs Lisp docstring · a012ec76
      Alexander Gramiak authored
      This approach does mean that keywords that have spaces before them
      inside of docstrings aren't filled, but I think this is should be fine
      until Bug#28937 is fixed.
      * lisp/emacs-lisp/lisp-mode.el (lisp-fill-paragraph): Add a colon to
      paragraph-start unconditionally, but require that it follows at least
      one space.  (Bug#24622)
      * test/lisp/emacs-lisp/lisp-tests.el: New tests for Bug#24622 and
    • Alan Mackenzie's avatar
      Refactor c-forward-token-2 with new function c-forward-over-token-and-ws. · b7c4aa95
      Alan Mackenzie authored
      Use the new function directly in several places where c-forward-token-2
      wouldn't move over the last token in the buffer.  This caused an infinite loop
      in c-restore-<>-properties.
      * lisp/progmodes/cc-engine.el (c-forward-over-token-and-ws): New function,
      extracted from c-forward-token-2.
      (c-forward-token-2): Refactor, calling the new function.
      (c-restore-<>-properties): Fix infinite loop.
      (c-forward-<>-arglist-recur, c-in-knr-argdecl)
      (c-looking-at-or-maybe-in-bracelist): Call the new function directly in place
      of c-forward-token-2.
      * lisp/progmodes/cc-cmds.el (c-defun-name) Call the new function directly in
      place of c-forward-token-2.
      * lisp/progmodes/cc-fonts.el (c-font-lock-enclosing-decls): Call the new
      function directly in place of c-forward-token-2.
    • Paul Eggert's avatar
      Avoid unnecessary rounding errors in timestamps · 3aee7be6
      Paul Eggert authored
      Avoid the rounding errors of float-time when it’s easy.  E.g.,
      replace (< (float-time a) (float-time b)) with (time-less-p a b).
      * lisp/desktop.el (desktop-save):
      * lisp/ecomplete.el (ecomplete-add-item):
      * lisp/epg.el (epg-wait-for-completion):
      * lisp/files.el (dir-locals-find-file, dir-locals-read-from-dir):
      * lisp/image-dired.el (image-dired-get-thumbnail-image)
      * lisp/info.el (info-insert-file-contents):
      * lisp/ls-lisp.el (ls-lisp-format-time):
      * lisp/net/ange-ftp.el (ange-ftp-file-newer-than-file-p)
      * lisp/net/rcirc.el (rcirc-ctcp-sender-PING):
      * lisp/textmodes/remember.el (remember-store-in-mailbox):
      * lisp/url/url-cookie.el (url-cookie-expired-p):
      Bypass float-time to avoid rounding errors.
      * lisp/files.el (dir-locals-find-file):
    • Paul Eggert's avatar
      Fix xdg timestamp error on 32-bit Emacs · 2bfa4285
      Paul Eggert authored
      * lisp/xdg.el (xdg-thumb-mtime): Return an Emacs timestamp,
      not an integer.  This avoids signaling an error on 32-bit
      Emacs, where timestamps typically do not fit into fixnums
  3. 21 Oct, 2017 15 commits
    • John Williams's avatar
      Test that advice doesn't trigger bytecomp warnings (Bug#28803) · 237e96bc
      John Williams authored
      * test/lisp/emacs-lisp/bytecomp-tests.el
      (bytecomp-tests--test-no-warnings-with-advice): New test.
      Copyright-paperwork-exempt: yes
    • Noam Postavsky's avatar
      Another fix for unsafe directory error message (Bug#865) · d719ea6a
      Noam Postavsky authored
      * lisp/server.el (server-ensure-safe-dir): Put file owner's uid, not
      current user's for the wrong owner case.  Show expanded file name in
      error message.
    • Noam Postavsky's avatar
      Handle https url for debbugs mbox (Bug#28831) · b060e091
      Noam Postavsky authored
      In 2017-09-13 "Prefer HTTPS to FTP and HTTP in documentation",
      gnus-bug-group-download-format-alist was updated to use https for the
      debbugs.gnu.org mbox links, but gnus-read-ephemeral-bug-group assumed
      http links.
      * lisp/gnus/gnus-group.el (gnus-read-ephemeral-bug-group): Use
      url-parse functions to get the host name, instead of ad-hoc regexps.
    • Noam Postavsky's avatar
      Ignore string properties when saving eshell history (Bug#28700) · 9e4265ef
      Noam Postavsky authored
      * lisp/eshell/em-hist.el (eshell-write-history): Remove properties
      before inserting history strings.
      (eshell-read-history): Remove obsolete comment.
      * test/lisp/eshell/em-hist-tests.el (eshell-write-readonly-history):
      New test.
    • Michael Albinus's avatar
      Fix Bug#28889 · 0f286ca8
      Michael Albinus authored
      * lisp/net/tramp.el: Change autoload cookie to tramp-autoload cookie.
      (tramp-completion-file-name-handler): Remove autoload cookie.
      (tramp-initial-completion-file-name-regexp): Remove.
      (tramp-autoload-file-name-regexp): New defconst.
      (tramp-register-autoload-file-name-handlers): Use it.
      (with-parsed-tramp-file-name): Adapt docstring.  Compute
      `tramp-file-name' slots.  (Bug#28889)
    • Glenn Morris's avatar
      Update describe-function for recent Fdocumentation change · 888e51f2
      Glenn Morris authored
      * lisp/help-fns.el (describe-function-1):
      Handle Fdocumentation returning either void or invalid.
    • Charles A. Roelli's avatar
      Make flymake's mouse-wheel interaction portable (Bug#28732) · 75bb4827
      Charles A. Roelli authored
      * lisp/progmodes/flymake.el (flymake--mode-line-format): Bind
      'mouse-wheel-down-event' and 'mouse-wheel-up-event' instead of
      'mouse-4' and 'mouse-5'.  Update the tooltip text accordingly, and
      remove a stray newline in it.
    • Nick Helm's avatar
      Prevent eldoc from changing the mode line · 035d7ac7
      Nick Helm authored
      * lisp/emacs-lisp/eldoc.el (eldoc-minibuffer-message): Don't
      change the mode line if it is not displayed.  (Bug#28697)
    • Eli Zaretskii's avatar
      Fix doc strings in simple.el · c9d71b31
      Eli Zaretskii authored
      * lisp/simple.el (shell-command-saved-pos)
      (region-extract-function, region-bounds): Doc fixes.  (Bug#28609)
    • Phil Sainty's avatar
      Avoid creating inconsistent buffer states in term-char-mode · 0d8e4f45
      Phil Sainty authored
      * lisp/term.el (term-mode, term-char-mode, term-line-mode)
      (term-emulate-terminal): Make buffer read-only in 'term-char-mode',
      except for the process filter's output.  Use 'read-only-mode-hook' to
      track and restore the user-set state of 'buffer-read-only' for
      'term-line-mode'.  (Bug#24837)
      (term-char-mode-buffer-read-only): New user option.
      (term-line-mode-buffer-read-only): New buffer-local variable.
      (term-line-mode-buffer-read-only-update): New function.
      (term-char-mode, term-line-mode): Use 'term-set-goto-process-mark'
      in pre-command-hook, and 'term-goto-process-mark-maybe' in
      post-command-hook to counter-act unexpected changes to point when
      using 'term-char-mode'.
      (term-char-mode-point-at-process-mark): New user option.
      (term-goto-process-mark): New buffer-local variable.
      (term-set-goto-process-mark): New function.
      (term-goto-process-mark-maybe): New function.
      (term-process-mark): New function.
      * etc/NEWS: Mention the new behavior and user options.
    • Bahodir Mansurov's avatar
      New input method 'usbek-cyrillic' · 79d57f4b
      Bahodir Mansurov authored
      * lisp/leim/quail/cyrillic.el (uzbek-cyrillic): New input method.
      * etc/NEWS: Mention the new input method.
      Copyright-paperwork-exempt: yes
    • Eli Zaretskii's avatar
      Document 'minibuffer-with-setup-hook' · 4587d8e0
      Eli Zaretskii authored
      * doc/lispref/minibuf.texi (Minibuffer Misc): Document
      minibuffer-with-setup-hook.  (Bug#28877)
    • Paul Eggert's avatar
      Simplify make-progress-reporter vs float-time · 868eb74f
      Paul Eggert authored
      * lisp/subr.el (make-progress-reporter): Remove no-longer-needed
      doc and code for the case where float-time is not supported,
      since float-time is always present now.
    • Paul Eggert's avatar
      Fix two more minor Gnus typos · 83db9a1b
      Paul Eggert authored
      * lisp/gnus/mail-source.el (mail-source-delete-old-incoming):
      The old code had two minor bugs: first, it multiplied by 1/65536
      instead of by 1/86400.  Second, it called current-time twice and
      glued part of the two results together, resulting in a race.
      Fix both bugs by simplifying the code and using
    • Paul Eggert's avatar
      Fix two minor Gnus typos · e655946c
      Paul Eggert authored
      * lisp/gnus/gnus-sum.el (gnus-summary-import-article):
      Remove unused local, and fix use of local that was never assigned to.
  4. 20 Oct, 2017 9 commits
    • Glenn Morris's avatar
      Tweak Fdocumentation's error for an undefined function · 6a00914d
      Glenn Morris authored
      * src/doc.c (Fdocumentation): Restore the pre-25 behavior
      of signalling a void-function error for an undefined function.
      This seems cleaner than Emacs 25's "invalid-function: nil" error,
      which was (probably) an unintended consequence of changes to
    • Glenn Morris's avatar
      Tweak format of list of old files in NEWS header · 7c63655e
      Glenn Morris authored
      * etc/NEWS: Stop list of old NEWS files growing without limit.
      * admin/admin.el (set-version): Handle either NEWS header format.
    • Stefan Monnier's avatar
      * lisp/help-fns.el (describe-function-1): · ef3d8505
      Stefan Monnier authored
      Fix help-fns-test-dangling-alias.  (Bug#28918)
      (cherry picked from commit e1d42f8f)
    • Glenn Morris's avatar
      Fix flymake's loading of subr-x · 11bd8aa2
      Glenn Morris authored
      * lisp/progmodes/flymake.el, test/lisp/progmodes/flymake-tests.el:
      No need to load subr-x at run-time.
    • Michael Albinus's avatar
      Fix Bug#28896 · b500e06f
      Michael Albinus authored
      * lisp/net/tramp-adb.el (tramp-adb-handle-rename-file):
      * lisp/net/tramp-gvfs.el (tramp-gvfs-do-copy-or-rename-file):
      * lisp/net/tramp-sh.el (tramp-do-copy-or-rename-file): Handle FILENAME
      being a directory.  (Bug#28896)
      * test/lisp/net/tramp-tests.el (tramp-test11-copy-file)
      (tramp-test12-rename-file): Test also FILENAME being a directory.
    • João Távora's avatar
      Skip a Flymake test for old gcc versions · d815de01
      João Távora authored
      Fixes: 28906
      * test/lisp/progmodes/flymake-tests.el
      (different-diagnostic-types): Skip this test for gcc versions
      < 5.
    • Eli Zaretskii's avatar
      Make :align-to account for display-line-numbers · fd3d8610
      Eli Zaretskii authored
      These changes also update the various bundled packages to use
      new feature, and better support customizations of the line-number
      * src/xdisp.c (calc_pixel_width_or_height): Improve commentary.
      Make :align-to count from the end of the line-number display when
      the offset or the width form reference that of the text area.
      * src/indent.c (Fline_number_display_width): Implement support for
      the PIXELWISE argument being 'columns'.  Update the doc string.
      (syms_of_indent): New symbol 'columns'.
      * lisp/ruler-mode.el (ruler-mode-window-col, ruler-mode-ruler):
      Call line-number-display-width with last argument 'columns'.
      * lisp/proced.el (proced-header-line): Call
      line-number-display-width with 2nd arg 'columns', which also fixes
      a problem when display-line-numbers is nil.
      * lisp/emacs-lisp/tabulated-list.el
      (tabulated-list-line-number-width): Call line-number-display-width
      with 2nd arg 'columns.
      (tabulated-list-entry-lnum-width): Remove unneeded defvar.
      (tabulated-list-print, tabulated-list-print-entry): No need to
      account for the value of tabulated-list-entry-lnum-width.
      (tabulated-list--current-lnum-width): New defvar.
      (tabulated-list-watch-line-number-width): New function.
      (tabulated-list-mode): Bind tabulated-list--current-lnum-width
      locally, and set up tabulated-list-watch-line-number-width as
      pre-redisplay-functions hook.
      * doc/lispref/display.texi (Size of Displayed Text): Document the
      'columns' value of the PIXELWISE argument.
      (Pixel Specification): Update and improve the documentation of the
      supported forms.
    • João Távora's avatar
      Augment Flymake API for third-party extensions · 831eafc8
      João Távora authored
      * doc/misc/flymake.texi (Flymake error types): Rewrite
      (Flymake utility functions): Augment with new API.
      * lisp/progmodes/flymake.el (flymake-diagnostics): New function.
      (flymake--diag-accessor): New helper macro.
      (flymake-diagnostic-buffer, flymake-diagnostic-text)
      (flymake-diagnostic-beg, flymake-diagnostic-end)
      (flymake-diagnostic-backend): Accessors for diagnostic objects.
      (flymake--overlays): Use flymake-diagnostic property.
      (flymake--highlight-line): Simplify.  Only set
      flymake-diagnostic property.
      (flymake--handle-report, flymake-goto-next-error): Use
      flymake-diagnostic property.
      (flymake-show-diagnostic): Use diagnostic object.
      (flymake--diagnostics-buffer-entries): Use
    • Glenn Morris's avatar
      Improve treatment of Fortran's "class default" · ddd547fa
      Glenn Morris authored
      * lisp/progmodes/f90.el (f90-start-block-re, f90-no-block-limit):
      Handle "class default".  (Bug#28786)
      * test/automated/f90.el (f90-test-bug25039): Add "class default".
  5. 19 Oct, 2017 5 commits
  6. 18 Oct, 2017 6 commits
    • Bastian Beischer's avatar
      Use pop-to-buffer-same-window instead of switch-to-buffer · b8433b09
      Bastian Beischer authored
      * lisp/cedet/semantic/decorate/include.el
      Use pop-to-buffer-same-window instead of switch-to-buffer
      * lisp/cedet/semantic/analyze/refs.el
      (semantic-analyze-proto-impl-toggle): Same.
      * lisp/cedet/semantic/senator.el (senator-go-to-up-reference):
      * lisp/cedet/semantic/mru-bookmark.el (semantic-mrub-visit):
      * lisp/cedet/semantic/complete.el (semantic-complete-jump):
      Copyright-paperwork-exempt: yes
    • Eli Zaretskii's avatar
      Fix the MSDOS build. · 2f7163fb
      Eli Zaretskii authored
      * msdos/sed1v2.inp (GETADDRINFO_A_LIBS, LIBLCMS2, XDBE_LIBS)
      (LIBSYSTEMD_LIBS): Edit to empty.
      (PRE_EDIT_LDFLAGS, POST_EDIT_LDFLAGS): Remove editing.
      Remove editing of lines that are no longer present in
      * msdos/sed2v2.inp (NEED_MKTIME_INTERNAL)
      (NEED_MKTIME_WORKING): Define to 1.
      (HAVE_STRUCT_DIRENT_D_TYPE): Define to 1 for
      DJGPP >= 2.05.
      (FLEXIBLE_ARRAY_MEMBER): Define to empty.
      (HAVE_DECL_*_UNLOCKED): Define to 0.
      (HAVE___BUILTIN_FRAME_ADDRESS): Define to 1.
      (PENDING_*): Don't define, as Gnulib no longer supports that.
      Instead, define _IOERR as it is in libc/file.h.
      * msdos/sed3v2.inp: Use $(CURDIR) instead of $(shell cd) to
      determine the current directory.
      * msdos/sedlisp.inp (FIND_DELETE): Edit to "-delete".
      * msdos/sedlibmk.inp (AUTO_DEPEND): Define to yes.
      (HYBRID_MALLOC): Edit to empty.
      (am__cd): Don't edit.
      (../config.status): Replaces $(top_builddir)/config.status.
      Define OMIT_GNULIB_MODULE_foo = true for modules not built for
      MS-DOS.  Convert GL_GENERATE_xxx_H_TRUE and
      GL_GENERATE_xxx_H_FALSE into values of GL_GENERATE_xxx_H.
      * msdos/mainmake.v2 (src): Use 'compile-one-process', and make
      the command line shorter to fit into 126-char limit of
      * config.bat: Generate src/deps/*.d files.  Rename more files
      like djtar on plain DOS would.
      Don't rename src/dir.h: it is long gone.  Edit
      lib/gnulib.mk.in using the same scripts as for
      * msdos/depfiles.bat: Create *.d files, not *.Po.
      * src/thread.c (Fmake_thread) [!THREADS_ENABLED]: Improve the
      error message.
      * src/thread.h [MSDOS]: Include <signal.h>.
      * src/sysselect.h (select) [MSDOS]: Undefine, to avoid
      compilation errors.
      * src/sysdep.c (block_interrupt_signal, restore_signal_mask):
      Expose to MSDOS build.
      * src/process.c (update_processes_for_thread_death)
      [!subprocess]: No-op implementation.
      [HAVE_SETRLIMIT]: Move inclusion of sys/resource.h and
      declaration of nofile_limit outside "#ifdef subprocesses", as
      it's needed for MSDOS.
      * src/msdos.c (faccessat): Declare fullname[].
      * src/msdos.h (ENOTSUP): Define to be identical to ENOSYS.
      Include termhooks.h.
      * src/conf_post.h [WINDOWSNT]: Include ms-w32.h only on
      WINDOWSNT, not DOS_NT.
      * admin/admin.el (set-version): Set version on PACKAGE_VERSION.
    • Eli Zaretskii's avatar
      Fix line number display after 'widen' · 2551d28f
      Eli Zaretskii authored
      * src/xdisp.c (maybe_produce_line_number): Don't use data cached
      by line-number-mode on the first redisplay after the buffer is
      widened.  (Bug#28879)
    • Alan Third's avatar
      Remove resizable attribute on macOS undecorated frames (bug#28512) · dc881282
      Alan Third authored
      * src/nsterm.m (FRAME_DECORATED_FLAGS): Remove Cocoa specific #define.
      (initFrameFromEmacs): Remove Cocoa specific window style attributes.
    • Martin Rudalics's avatar
      Fix handling of `border-width' in `frameset--restore-frame' (Bug#28873) · b970a4a5
      Martin Rudalics authored
      * lisp/frameset.el (frameset--restore-frame): Don't process
      `border-width' parameter via ‘modify-frame-parameters’
    • Tino Calancha's avatar
      Mention how to send CC to > 1 address in a bug report · 445e9265
      Tino Calancha authored
      * admin/notes/bugtracker (* More detailed information):
      mention how to CC to more than 1 address (Bug#28833).