1. 17 Nov, 2017 4 commits
  2. 16 Nov, 2017 1 commit
  3. 15 Nov, 2017 2 commits
  4. 14 Nov, 2017 6 commits
  5. 13 Nov, 2017 6 commits
    • Katsumi Yamaoka's avatar
      Fix cookie handling (bug#29282) · caa39f49
      Katsumi Yamaoka authored
      * lisp/url/url-cookie.el (url-cookie-handle-set-cookie):
      Regard a Set-Cookie header as it contains a single cookie;
      prefer Max-Age to Expires and convert it to Expires;
      remove support for old time string styles (bug#29282).
      caa39f49
    • Gemini Lasswell's avatar
      Improve documentation of Edebug and macros · 93304e31
      Gemini Lasswell authored
      * doc/lispref/edebug.texi (Instrumenting Macro Calls): Improve
      discussion of when it might be necessary to find and evaluate macro
      specifications before instrumenting.
      (Specification List): Clarify what "defining form" means to Edebug
      and when 'def-form' or 'def-body' should be used instead of 'form'
      or 'body'.
      93304e31
    • Paul Eggert's avatar
      Port to IBM xlc 12.01 · 79108894
      Paul Eggert authored
      Work around a compiler bug by using a separate enum for alignment.
      * src/alloc.c (roundup_size): Declare in a separate enum.
      79108894
    • Paul Eggert's avatar
      Simplify by removing HAVE_STRUCT_ATTRIBUTE_ALIGNED · d1495609
      Paul Eggert authored
      * configure.ac (HAVE_STRUCT_ATTRIBUTE_ALIGNED): Remove.  No longer
      needed, since we no longer rely on __attribute__ ((aligned (8))).
      All uses removed.
      * src/emacs-module.c (HAVE_STRUCT_ATTRIBUTE_ALIGNED): Remove.
      (lisp_to_value): Simplify now that we no longer need to worry
      whether HAVE_STRUCT_ATTRIBUTE_ALIGNED is false.
      d1495609
    • Paul Eggert's avatar
      Use alignas to fix GCALIGN-related bugs · b1573a97
      Paul Eggert authored
      Use alignas and unions to specify alignments of objects needing
      addresses that are at least a multiple of GCALIGNMENT.  Using
      these standard C facilities should be safer than relying on ad hoc
      and poorly-understood features like GCC’s __attribute__
      ((aligned (N))), the root cause for recent porting bugs like
      Bug#29040.  The alignas macro was standardized by C11 and Gnulib
      supports alignas for pre-C11 platforms.  I have tested this on Sun
      Studio 12 sparc (2007) and GCC 4.4.7 x86-64 (2012) as well as on
      more recent platforms like GCC 7.2.1 (2017) on Fedora 26 (both
      x86-64 and x86).
      * lib-src/make-docfile.c (close_emacs_globals): lispsym is now
      just an array of struct Lisp_Symbol, since struct Lisp_Symbol is
      now properly aligned.  All uses changed.
      * src/alloc.c (NEXT_FREE_LISP_STRING): Just use the new u.next
      member; this is simpler and safer than casting a pointer that
      might not be aligned properly.
      (aligned_Lisp_Symbol): Remove.  No longer needed, now that struct
      Lisp_Symbol is aligned properly.  All uses replaced with struct
      Lisp_Symbol.
      * src/lisp.h (GCALIGNED): Remove, as it does not work as expected:
      it can cause the natural alignment to be ignored.  All uses
      replaced by unions with a ‘char alignas (GCALIGNMENT)’ member as
      described below.
      (struct Lisp_Symbol, struct Lisp_Cons, struct Lisp_String):
      Change definition from ‘struct TAG { MEMBERS };’ to
      ‘struct TAG { union { struct { MEMBERS } s; char alignas
      (GCALIGNMENT) gcaligned; } u; };’.  This guarantees ‘struct TAG’
      to have an alignment that at least max (GCALIGNMENT, N) where N is
      its old alignment.  All uses like ‘PTR->MEMBER’ changed to
      ‘PTR->u.s.MEMBER’; these uses were supposed to be mostly private
      anyway.  Verify that the resulting ‘struct TAG’ is properly
      aligned for Emacs.
      (union vectorlike_header): New member ‘gcaligned’ to guarantee
      that this type, and its containing types like ‘struct Lisp_Subr’,
      ‘struct buffer’ and ‘struct thread_state’, are all properly
      aligned for Emacs.
      (struct Lisp_String): New union member ‘next’, for the benefit
      of NEXT_FREE_LISP_STRING.
      (union Aligned_Cons, union Aligned_String): Remove.  All uses
      replaced by struct Lisp_Cons and struct Lisp_String, since they
      are now properly aligned.
      (USE_STACK_CONS, USE_STACK_STRING): Simplify now that we can
      assume struct Lisp_Cons and struct Lisp_String are properly
      aligned.
      b1573a97
    • Paul Eggert's avatar
      Change vectorlike from struct to union · 5d68dc9a
      Paul Eggert authored
      * src/lisp.h (vectorlike_headed): Change from struct to union.
      All uses changed.  Since it has only one member, this does not
      change semantics.  This is designed to simplify future changes
      needed to fix bugs like Bug#29040.  All uses changed.
      5d68dc9a
  6. 12 Nov, 2017 8 commits
    • Tom Tromey's avatar
      Don't enable cursor-sensor-mode in mhtml-mode · 6aa0a26b
      Tom Tromey authored
      * lisp/textmodes/mhtml-mode.el (mhtml--last-submode): Update doc
      string.
      (mhtml-mode): Don't call cursor-sensor-mode.
      6aa0a26b
    • Eli Zaretskii's avatar
    • João Távora's avatar
      Unbreak interactive run of a flymake test (bug#29267) · fe85ce1e
      João Távora authored
      See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=19657#20 for the
      technique used here.
      
      * test/lisp/progmodes/flymake-tests.el (ruby-backend):
      Let-bind abbreviated-home-dir.
      fe85ce1e
    • Michael Albinus's avatar
      Fix Bug#29225 · 48ad0039
      Michael Albinus authored
      * src/fileio.c (Fset_file_acl): Report error only when
      acl_errno_valid returns true.  (Bug#29225)
      
      * test/lisp/net/tramp-tests.el (tramp-test24-file-acl)
      (tramp-test25-file-selinux): New tests.
      (tramp-test26-file-name-completion, tramp-test27-load)
      (tramp-test28-process-file, tramp-test29-start-file-process)
      (tramp-test30-interrupt-process, tramp-test31-shell-command)
      (tramp-test32-environment-variables)
      (tramp-test32-environment-variables-and-port-numbers)
      (tramp-test33-explicit-shell-file-name)
      (tramp-test34-vc-registered)
      (tramp-test35-make-auto-save-file-name)
      (tramp-test36-find-backup-file-name)
      (tramp-test37-make-nearby-temp-file)
      (tramp-test38-special-characters)
      (tramp-test38-special-characters-with-stat)
      (tramp-test38-special-characters-with-perl)
      (tramp-test38-special-characters-with-ls, tramp-test39-utf8)
      (tramp-test39-utf8-with-stat, tramp-test39-utf8-with-perl)
      (tramp-test39-utf8-with-ls, tramp-test40-file-system-info)
      (tramp-test41-asynchronous-requests)
      (tramp-test42-recursive-load, tramp-test43-remote-load-path)
      (tramp-test44-delay-load, tramp-test45-unload): Rename.
      48ad0039
    • Alan Mackenzie's avatar
      CC Mode: Fix defun-open being recognized as brace-list-open at EOB. · 42daf83f
      Alan Mackenzie authored
      * lisp/progmodes/cc-engine.el (c-looking-at-statement-block): Add handling
      for an open brace at EOB and nested braces inside an unclosed brace block.
      42daf83f
    • Paul Eggert's avatar
      Merge from Gnulib · 7775c472
      Paul Eggert authored
      This incorporates:
      2017-11-11 faccessat: port to macOS (Bug#29231)
      2017-11-05 fstatat: pacify GCC on unusual platform
      * build-aux/config.guess, build-aux/config.sub:
      * doc/misc/texinfo.tex, lib/faccessat.c, lib/fstatat.c:
      * lib/unistd.in.h, m4/faccessat.m4, m4/unistd_h.m4:
      Copy from Gnulib.
      * lib/gnulib.mk.in, m4/gnulib-comp.m4: Regenerate.
      7775c472
    • Paul Eggert's avatar
      Pacify GCC when configured --with-x-toolkit=no · e470d164
      Paul Eggert authored
      Without these changes, Emacs does not build on Fedora 26 x86-64
      when configured --with-x-toolkit=no --enable-gcc-warnings.
      * oldXMenu/Activate.c (XMenuActivate): Add FALLTHROUGH.
      * src/xterm.c (x_dispatch_event): Define only if
      USE_X_TOOLKIT || USE_MOTIF || USE_GTK.
      e470d164
    • Eli Zaretskii's avatar
  7. 11 Nov, 2017 7 commits
  8. 10 Nov, 2017 6 commits
    • Paul Eggert's avatar
      Fix off-by-1 bug in --enable-checking=stringbytes · 05aa6d4a
      Paul Eggert authored
      Evidently nobody builds Emacs with --enable-checking=all,
      which is no surprise as it is so slow as to be unusable nowadays.
      Perhaps we should remove the slowest checks, or move them into
      another category, or speed them up, or something.
      * src/alloc.c (SDATA_SIZE) [GC_CHECK_STRING_BYTES]: Fix off-by-one
      error in size calculation, which caused a failure when
      --enable-checking=stringbytes was used.  I introduced this bug in
      2016-09-08T01:08:45!eggert@cs.ucla.edu "Port flexible array
      members to GCC + valgrind".
      05aa6d4a
    • Alan Mackenzie's avatar
      Correct the indentation of C99's compound literals. · 096f638d
      Alan Mackenzie authored
      * lisp/progmodes/cc-engine.el (c-looking-at-statement-block): Amend so that
      if there is only syntactic whitespace in a brace block, it is regarded as a
      statement block.  Also, if there is no semicolon or comma delimiter, treat as
      a statement block when there is a keyword.
      (c-guess-basic-syntax): CASE 9 test: Regard a brace as starting a brace block
      when its contents indicate a brace block.
      096f638d
    • Eli Zaretskii's avatar
      Improve the doc string of 'dired-isearch-filter-filenames' · c52a2aa8
      Eli Zaretskii authored
      * lisp/dired-aux.el (dired-isearch-filter-filenames): Doc fix.
      (Bug#29215)
      c52a2aa8
    • Eli Zaretskii's avatar
    • Eli Zaretskii's avatar
      Fix display of line numbers in GTK builds · f3e69a80
      Eli Zaretskii authored
      * src/xdisp.c (should_produce_line_number) [USE_GTK]: Make sure
      tip_frame is indeed a tooltip frame, before disabling line numbers
      on it.  (Bug#27647)
      
      * src/dispextern.h (tip_frame): Add commentary describing the
      kludgey usage of this variable in GTK builds.
      f3e69a80
    • João Távora's avatar
      Fix previous change to flymake-diag-region (bug#29174) · e6f1fd40
      João Távora authored
      * lisp/progmodes/flymake.el (flymake-diag-region):
      Pass line and col to commit.
      e6f1fd40