1. 18 Sep, 2013 14 commits
  2. 17 Sep, 2013 26 commits
    • Katsumi Yamaoka's avatar
      [Gnus] Silence the byte compiler · 9ab16aab
      Katsumi Yamaoka authored
      * gnus-icalendar.el (gnus-icalendar-event--find-attendee)
      (gnus-icalendar-event-from-ical)
      (gnus-icalendar-event--build-reply-event-body)
      (gnus-icalendar-event-reply-from-buffer)
      (gnus-icalendar-find-org-event-file)
      (gnus-icalendar-event->gnus-calendar, gnus-icalendar-reply)
      (gnus-icalendar-mm-inline): Use gmm-labels instead of labels or flet.
      
      * mm-util.el (mm-special-display-p): Isolate XEmacs stuff.
      9ab16aab
    • Glenn Morris's avatar
      2b42da98
    • Stefan Monnier's avatar
      * lisp/help-mode.el (help-mode-finish): Use derived-mode-p. · 9c0ad4f7
      Stefan Monnier authored
      Remove obsolete highlighting.
      9c0ad4f7
    • Stefan Monnier's avatar
      * lisp/play/life.el (life-mode): Use define-derived-mode. Derive from · 7a806dfb
      Stefan Monnier authored
      special-mode.
      (life): Let-bind inhibit-read-only.
      (life-setup): Avoid `setq'.  Use `life-mode'.
      7a806dfb
    • Stefan Monnier's avatar
      * lisp/gnus/gnus-agent.el (gnus-category-mode): Use define-derived-mode. · c2e9e9ef
      Stefan Monnier authored
      (gnus-agent-mode): Use derived-mode-p.
      (gnus-agent-rename-group, gnus-agent-delete-group): Don't bind
      gnus-command-method and *-command-method to nil, but bind
      gnus-command-method to *-command-method instead!
      (gnus-agent-fetch-articles): Remove unused var `id'.
      (gnus-agent-fetch-headers): Remove unused arg `force'.
      (gnus-agent-braid-nov): Remove unused arg `group'.  Adjust callers.
      (gnus-agent-save-alist, gnus-agent-save-local): Remove unused `item'.
      (gnus-agent-short-article, gnus-agent-long-article)
      (gnus-agent-low-score, gnus-agent-high-score): Move declaration before
      first use.
      (gnus-agent-fetch-group-1): Remove unused vars `arts', `category',
      `score-param'.
      (gnus-tmp-name, gnus-tmp-groups): Defvar them.
      (gnus-get-predicate): Push in front of the cache, rather than end.
      (gnus-agent-expire-current-dirs, gnus-agent-expire-stats): Defvar them.
      (gnus-agent-expire-group-1): Use push.  Don't abuse dyn-binding.
      (gnus-agent-expire-unagentized-dirs): Don't rebind
      gnus-agent-expire-current-dirs since the defvar silences the warning.
      (gnus-agent-retrieve-headers): Remove unused var `cached-articles'.
      (gnus-agent-regenerate-group): Remove unused vars `point' and `dl'.
      (gnus-agent-regenerate): Simplify interactive spec and doc.
      
      * lisp/gnus/gnus-eform.el (gnus-edit-form-mode): Use define-derived-mode.
      
      * lisp/gnus/gnus-salt.el (gnus-tree-mode): Use define-derived-mode.
      Use save-current-buffer.
      (gnus-tree-mode-map): Initialize in the declaration.
      (gnus-pick-mouse-pick-region): Remove unused var `fun'.
      (scroll-in-place): Defvar it.
      (gnus-tmp-*): Defvar them.
      (gnus-get-tree-buffer): Use derived-mode-p.
      (gnus--let-eval): New macro.
      (gnus-tree-highlight-node): Use it to avoid dynamic binding of
      non-prefixed variables.
      (gnus-tree-open, gnus-tree-close): Remove unused arg `group'.
      
      * lisp/gnus/gnus-sum.el (gnus-summary-highlight): Remove `below' from the list of
      vars since it doesn't seem to be available.
      (gnus-set-global-variables, gnus-summary-read-group-1)
      (gnus-select-newsgroup, gnus-handle-ephemeral-exit)
      (gnus-summary-display-article, gnus-summary-select-article)
      (gnus-summary-next-article, gnus-offer-save-summaries)
      (gnus-summary-generic-mark): Use derived-mode-p.
      (gnus-summary-read-group-1, gnus-summary-exit)
      (gnus-summary-exit-no-update, gnus-kill-or-deaden-summary):
      Adjust calls to gnus-tree-close and gnus-tree-open.
      c2e9e9ef
    • Dmitry Antipov's avatar
      * w32term.c (w32_read_socket): Avoid temporary · 0791d107
      Dmitry Antipov authored
      variables in a call to x_real_positions.
      * xterm.c (handle_one_xevent): Likewise.
      0791d107
    • Stefan Monnier's avatar
      * lisp/emacs-lisp/package.el (package-generate-autoloads): Remove `require' · 96dbf5a8
      Stefan Monnier authored
      which should not be needed any more.
      (package-menu-refresh, package-menu-describe-package): Use user-error.
      96dbf5a8
    • Stefan Monnier's avatar
      * lisp/cedet/semantic/symref/list.el (semantic-symref-results-mode): · 049c405a
      Stefan Monnier authored
      Use define-derived-mode.
      (semantic-symref-produce-list-on-results): Set up the results here
      instead of in semantic-symref-results-mode.  Move after
      semantic-symref-current-results's defvar now that it refers to that var.
      (semantic-symref-auto-expand-results)
      (semantic-symref-results-summary-function)
      (semantic-symref-results-mode-hook): Remove redundant :group arg.
      (semantic-symref, semantic-symref-symbol, semantic-symref-regexp):
      Initialize directly in the let.
      049c405a
    • Stefan Monnier's avatar
      * lisp/eshell/esh-cmd.el (eshell-post-rewrite-command-function): New var. · e8b66a6a
      Stefan Monnier authored
      (eshell-post-rewrite-command-hook): Make obsolete.
      (eshell-parse-command): Simplify.
      (eshell-structure-basic-command): Remove unused arg `vocal-test'.
      (eshell--cmd): Declare.
      (eshell-parse-pipeline): Remove unused var `final-p'.
      Pass a dynvar to eshell-post-rewrite-command-hook.
      Implement the new eshell-post-rewrite-command-function.
      (eshell-invoke-directly): Remove unused arg `input'.
      * lisp/eshell/esh-io.el (eshell-io-initialize):
      Use eshell-post-rewrite-command-function.
      (eshell--apply-redirections): Rename from eshell-apply-redirections;
      adjust to new calling convention.
      (eshell-create-handles): Rename args to avoid clashing with dynvar
      `standard-output'.
      
      Fixes: debbugs:15399
      e8b66a6a
    • Katsumi Yamaoka's avatar
      4e0bf886
    • Dmitry Antipov's avatar
      * frame.h (x_set_bitmap_icon) [!HAVE_NS]: New function. · 2cd98812
      Dmitry Antipov authored
      (x_icon_type): Remove prototype.
      (x_bitmap_icon) [!HAVE_NS]: Declare as such.
      * frame.c (x_icon_type): Remove.
      * w32term.c (x_make_frame_visible, x_iconify_frame):
      * xterm.c (x_make_frame_visible, x_iconify_frame):
      Use x_set_bitmap_icon to factor out common code.
      2cd98812
    • Dmitry Antipov's avatar
      * dispextern.h (check_x_display_info, x_get_string_resource): · a6c2ee1b
      Dmitry Antipov authored
      Declare here just once and unify the latter.
      * frame.c (check_x_display_info, x_get_string_resource):
      * nsterm.h (check_x_display_info):
      * xrdb.c (x_get_string_resource):
      * xterm.h (check_x_display_info): Remove prototypes.
      * nsfns.m (x_get_string_resource): Likewise.  Adjust definition.
      * w32reg.c (x_get_string_resource): Likewise.
      (w32_get_rdb_resource): Adjust user.
      a6c2ee1b
    • Katsumi Yamaoka's avatar
    • Glenn Morris's avatar
      Auto-commit of generated files. · 5cf10af8
      Glenn Morris authored
      5cf10af8
    • Katsumi Yamaoka's avatar
      4a8bb694
    • Dmitry Antipov's avatar
      * xterm.h (struct x_display_info): New member · baed3603
      Dmitry Antipov authored
      x_pending_autoraise_frame, going to replace...
      * xterm.c (pending_autoraise_frame): ...static variable.
      (x_new_focus_frame, XTread_socket): Adjust users.
      * w32term.h (struct w32_display_info): New member
      w32_pending_autoraise_frame, going to replace...
      * w32term.c (pending_autoraise_frame): ...global variable.
      (x_new_focus_frame, w32_read_socket): Adjust users.
      baed3603
    • Glenn Morris's avatar
      Fix ChangeLog typos · f804aa63
      Glenn Morris authored
      f804aa63
    • Glenn Morris's avatar
      ChangeLog whitespace fixes · 3696fe8a
      Glenn Morris authored
      3696fe8a
    • Glenn Morris's avatar
      Commentary update · 16bda969
      Glenn Morris authored
      16bda969
    • Glenn Morris's avatar
      Add a major-mode for the *Messages* buffer · 90582f05
      Glenn Morris authored
      Ref: http://lists.gnu.org/archive/html/emacs-devel/2010-02/msg00135.html
      
      * lisp/simple.el (messages-buffer-mode): New major mode.
      (messages-buffer): New function.
      
      * lisp/startup.el (normal-top-level): Switch mode of *Messages* buffer.
      
      * src/xdisp.c (message_dolog): If we create *Messages*,
      switch it to messages-buffer-mode.
      
      * lisp/emacs-lisp/ert.el (ert--force-message-log-buffer-truncation)
      (ert-run-test): Use `message-buffer' function.
      (ert--force-message-log-buffer-truncation): Ignore read-only.
      
      * lisp/help.el (view-echo-area-messages): Use `message-buffer' function.
      
      * lisp/mail/emacsbug.el (report-emacs-bug): Use `message-buffer' function.
      
      * lisp/gnus/gnus-util.el (gnus-message-with-timestamp-1):
      Use `message-buffer' function if available.  Ignore read-only.
      
      * etc/NEWS: Mention this.
      90582f05
    • Dmitry Antipov's avatar
    • Glenn Morris's avatar
      ChangeLog whitespace fixes · e36b2d20
      Glenn Morris authored
      e36b2d20
    • Glenn Morris's avatar
    • Paul Eggert's avatar
      Don't overuse 'const' in types of locals. · b7ad2f74
      Paul Eggert authored
      * bidi.c (bidi_count_bytes):
      * gtkutil.c, gtkutil.h (xg_event_is_for_menubar)
      (xg_event_is_for_scrollbar):
      * xselect.c (x_handle_property_notify)
      (x_handle_selection_notify, x_handle_dnd_message):
      * xsettings.c, xsettings.h (xft_settings_event):
      * xterm.c (x_handle_net_wm_state, handle_one_event)
      (x_menubar_window_to_frame, x_detect_focus_change)
      (construct_mouse_click, note_mouse_movement)
      (x_scroll_bar_to_input_event, x_scroll_bar_expose)
      (x_scroll_bar_handle_click, x_scroll_bar_note_movement)
      (handle_one_xevent, x_handle_net_wm_state):
      * xterm.h (x_handle_property_notify, x_handle_selection_notify)
      (x_handle_dnd_message):
      Avoid unnecessary 'const', typically the second 'const' in
      'const foo * const arg', a 'const' that does not affect the API
      and doesn't significantly help the human reader.
      b7ad2f74
    • Dmitry Antipov's avatar
      * xterm.c (handle_one_xevent): Do not call to x_clear_area · 1893694e
      Dmitry Antipov authored
      if GTK >= 2.7.0.
      1893694e
    • Dmitry Antipov's avatar
      * configure.ac: Do not check for g_type_init because we · 19452b86
      Dmitry Antipov authored
      require glib >= 2.28 for GTK3, glib >= 2.10 for GTK2,
      glib >= 2.26 for GSettings and glib >= 2.7.0 for GConf, so
      suitable glib should provide g_type_init unconditionally.
      * src/image.c (fn_g_type_init) [WINDOWSNT]: Define and load
      only if Glib < 2.36.0.
      (fn_g_type_init) [!WINDOWSNT]: Define only if Glib < 2.36.0.
      * src/xsettings.c (init_gconf, init_gsettings): Do not check
      for g_type_init.
      19452b86