1. 11 Jul, 2013 16 commits
    • Glenn Morris's avatar
      ChangeLog fixes · 6e0e82a0
      Glenn Morris authored
      6e0e82a0
    • Glenn Morris's avatar
      Remove some reimplementations of cl-gensym · 4582a01c
      Glenn Morris authored
      * lisp/thumbs.el: Require cl-lib at run-time too.
      (thumbs-gensym-counter, thumbs-gensym):
      Remove reimplementation of cl-gensym.
      (thumbs-temp-file): Use cl-gensym.
      
      * lisp/emacs-lisp/edebug.el: Require cl-lib at run-time too.
      (edebug-gensym-index, edebug-gensym):
      Remove reimplementation of cl-gensym.
      (edebug-make-enter-wrapper, edebug-make-form-wrapper): Use cl-gensym.
      4582a01c
    • Glenn Morris's avatar
      a3d4dd87
    • Glenn Morris's avatar
      Stop reimplementing a bunch of cl- functions in ert · a19b3c2d
      Glenn Morris authored
      * lisp/emacs-lisp/ert.el: Require cl-lib at runtime too.
      (ert--cl-do-remf, ert--remprop, ert--remove-if-not)
      (ert--intersection, ert--set-difference, ert--set-difference-eq)
      (ert--union, ert--gensym-counter, ert--gensym-counter)
      (ert--coerce-to-vector, ert--remove*, ert--string-position)
      (ert--mismatch, ert--subseq): Remove reimplementations of cl funcs.
      (ert-make-test-unbound, ert--expand-should-1)
      (ert--expand-should, ert--should-error-handle-error)
      (should-error, ert--explain-equal-rec)
      (ert--plist-difference-explanation, ert-select-tests)
      (ert--make-stats, ert--remove-from-list, ert--string-first-line):
      Use cl-lib functions rather than reimplementations.
      
      * test/automated/ert-tests.el: Require cl-lib at runtime too.
      (ert-test-special-operator-p): Use cl-gensym rather than ert-- version.
      (ert-test-remprop, ert-test-remove-if-not, ert-test-remove*)
      (ert-test-set-functions, ert-test-gensym)
      (ert-test-coerce-to-vector, ert-test-string-position)
      (ert-test-mismatch): Remove tests.
      
      * test/automated/cl-lib.el: New, split from ert-tests.el.
      a19b3c2d
    • Glenn Morris's avatar
    • Glenn Morris's avatar
      Quieten ruby-mode-tests.el compilation · d2e1542a
      Glenn Morris authored
      * test/automated/ruby-mode-tests.el (ruby-deftest-move-to-block):
      Goto point-min.
      (works-on-do, zero-is-noop, ok-with-three, ok-with-minus-two)
      (ruby-move-to-block-skips-percent-literal)
      (ruby-move-to-block-skips-heredoc)
      (ruby-move-to-block-moves-from-else-to-if)
      (ruby-beginning-of-defun-does-not-fold-case)
      (ruby-end-of-defun-skips-to-next-line-after-the-method):
      Replace goto-line with forward-line/goto-char.
      (ruby-move-to-block-does-not-fold-case): Remove unneeded end-of-buffer.
      d2e1542a
    • Glenn Morris's avatar
      Silence package-test.el compilation · 03d01981
      Glenn Morris authored
      * test/automated/package-test.el (makeinfo-buffer): Autoload.
      (compilation-in-progress, tar-parse-info, tar-header-name): Declare.
      (package-test-install-texinfo): Don't require makeinfo.
      03d01981
    • Glenn Morris's avatar
    • Glenn Morris's avatar
    • Glenn Morris's avatar
      Silence icalendar-tests.el compilation · a550ba33
      Glenn Morris authored
      * test/automated/icalendar-tests.el (icalendar-tests--do-test-cycle):
      Use with-current-buffer.
      a550ba33
    • Glenn Morris's avatar
    • Michael Albinus's avatar
      * net/tramp.el (tramp-methods): Extend docstring. · 88f6a933
      Michael Albinus authored
      (tramp-connection-timeout): New defcustom.
      (tramp-error-with-buffer): Reset timestamp only when appropriate.
      (with-tramp-progress-reporter): Simplify.
      (tramp-process-actions): Improve messages.
      
      * net/tramp-gvfs.el (tramp-gvfs-maybe-open-connection):
      * net/tramp-sh.el (tramp-maybe-open-connection):
      Use `tramp-connection-timeout'.
      (tramp-methods) [su, sudo, ksu]: Add method specific timeouts.  (Bug#14808)
      88f6a933
    • Paul Eggert's avatar
      * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE. · 9c203066
      Paul Eggert authored
      This is for .gdbinit xbacktrace.
      9c203066
    • Leo Liu's avatar
      * ido.el (ido-read-file-name): Conform to the requirements of · a43d577e
      Leo Liu authored
      read-file-name. 
      (ido-read-directory-name): Conform to the requirements of
      read-directory-name.
      
      Fixes: debbugs:11861
      a43d577e
    • Paul Eggert's avatar
      * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes. · 653d4f43
      Paul Eggert authored
      * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
      (emacs_set_tty): Now static.
      * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
      * term.c (tty_capable_p, tty_default_color_capabilities)
      (get_tty_terminal, term_mouse_movement)
      (handle_one_term_event, init_tty, maybe_fatal):
      * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
      (tgetent, scan_file, name_match, compare_contin):
      * terminal.c (get_terminal):
      Use bool for boolean.
      * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
      Prefer char to unsigned char if either will do.
      * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
      (tty_write_glyphs): Prefer int to unsigned.
      (produce_glyphless_glyph): Remove 2nd (unused) int arg.
      All callers changed.
      * termcap.c (tprint, main) [TEST]: Remove non-working test.
      653d4f43
    • Juanma Barranquero's avatar
      d77974bf
  2. 10 Jul, 2013 14 commits
    • Paul Eggert's avatar
      Port to C89. · 29abe551
      Paul Eggert authored
      * lib-src/ebrowse.c (USAGE): Remove macro with too-long string literal ...
      (usage_message): ... and replace it with this new static constant
      containing multiple literals.  All uses changed.
      * lib-src/emacsclient.c (print_help_and_exit):
      Rewrite to avoid string literals longer than the C89 limits.
      (start_daemon_and_retry_set_socket):
      Rewrite to avoid non-constant array initializer.
      * lib-src/make-docfile.c (enum global_type): Omit trailing comma.
      * src/bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
      (B__dummy__): New dummy symbol, to pacify C89.
      * src/dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
      they can't grok varargs macros.
      * src/dispnew.c (add_window_display_history)
      (add_frame_display_history):
      * src/print.c (print_object):
      * src/xdisp.c (debug_method_add):
      Use %p printf format only for void pointers.
      * src/emacs.c (usage_message): New constant, replacing ...
      (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
      (main): Adjust to usage reorg.
      * src/fns.c (syms_of_fns):
      * src/profiler.c (syms_of_profiler):
      Don't use non-constant struct initializers.
      * src/gnutls.h (gnutls_initstage_t):
      * src/lisp.h (enum Lisp_Fwd_Type):
      * src/lread.c (lisp_file_lexically_bound_p):
      * src/xsettings.c (anonymous enum):
      Remove trailing comma.
      * src/xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
      * src/lisp.h (ENUM_BF): Use unsigned if pedantic.
      (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
      (DEFUN): Use it.
      * src/regex.c (const_re_char): New type, to pacify strict C89.
      All uses of 'const re_char' replaced to use it.
      * src/regex.h (_Restrict_): Rename from __restrict, to avoid clash
      with glibc when strict C89.  This change is imported from gnulib.
      All uses changed.
      (_Restrict_arr_): Rename from __restrict_arr, similarly.
      * src/sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
      Omit GNU_LINUX implementation, since it requires long long.
      * src/xterm.c (x_draw_underwave):
      Do not assume the traditional order of struct's members.
      (x_term_init): Rewrite to avoid the need for non-constant structure
      initializers.
      29abe551
    • David Engster's avatar
      gnus-start.el (gnus-clean-old-newsrc): Always remove 'unexist' marks if... · 3d70c5cf
      David Engster authored
      gnus-start.el (gnus-clean-old-newsrc): Always remove 'unexist' marks if `gnus-newsrc-file-version' does not match `gnus-version'.  This fixes a bug in Emacs trunk where the 'unexist' marks were always removed at startup because "Gnus v5.13" was considered smaller than "Ma Gnus v0.03".
      3d70c5cf
    • Tassilo Horn's avatar
      gnus.el (gnus-summary-line-format): Docfix · 4647c173
      Tassilo Horn authored
      4647c173
    • Eli Zaretskii's avatar
      Improve scrolling when line-spacing != 0 and scroll-step = 1. · 35cb8a3e
      Eli Zaretskii authored
       lisp/simple.el (default-line-height): New function.
       (line-move-partial, line-move): Use it instead of computing the
       line height inline.
       (line-move-partial): Always compute ROWH.  If the last line is
       partially-visible, but its text is completely visible, allow
       cursor to enter such a partially-visible line.
      35cb8a3e
    • Paul Eggert's avatar
      Syntax cleanup, mostly replacing macros with functions. · 45b683a1
      Paul Eggert authored
      This removes the need for the syntax_temp hack.
      * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
      * syntax.c (SYNTAX_INLINE): New macro.
      (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
      (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
      (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
      (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
      (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
      (SYNTAX_COMEND_FIRST): Now functions, not macros.
      (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
      Now constants, not macros.
      (syntax_temp) [!__GNUC__]: Remove.
      (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
      (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
      (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
      (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
      Move here from syntax.h; now functions, not macros.  Except for the
      last function, these are static since only syntax.c uses them.
      (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
      All uses changed.  Now a function, not a macro; use this fact
      to simplify the code.
      (scan_lists, scan_sexps_forward): Remove workarounds for ancient
      compiler bugs; no longer relevant.
      * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
      (SYNTAX_INLINE): New macro.
      (struct gl_state_s, gl_state): Move earlier, so that it's in scope
      for the new functions.  Use bool for boolean member.
      (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
      (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
      (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
      (SETUP_BUFFER_SYNTAX_TABLE):
      Now extern inline functions, not macros.
      (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
      Remove; all uses replaced by implementation.
      (syntax_temp) [!__GNUC__]: Remove decl.
      (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
      45b683a1
    • Michael Albinus's avatar
      Fix last patch. · 500dd7a3
      Michael Albinus authored
      500dd7a3
    • Michael Albinus's avatar
      Improve error messages. (Bug#14808) · 525c5c77
      Michael Albinus authored
      * net/tramp.el (tramp-current-connection): New defvar, moved from
      tramp-sh.el.
      (tramp-message-show-progress-reporter-message): Removed, not
      needed anymore.
      (tramp-error-with-buffer): Show message in minibuffer.  Discard
      input before waiting.  Reset connection timestamp.
      (with-tramp-progress-reporter): Improve messages.
      (tramp-process-actions): Use progress reporter.  Delete process in
      case of error.  Improve messages.
      
      * net/tramp-sh.el (tramp-barf-if-no-shell-prompt): Use
      condition-case.  Call `tramp-error-with-buffer' with vector and buffer.
      (tramp-current-connection): Removed.
      (tramp-maybe-open-connection): The car of
      `tramp-current-connection' are the first 3 slots of the vector.
      525c5c77
    • Ted Zlatanov's avatar
    • Michael Albinus's avatar
      Add comment. · 12580a07
      Michael Albinus authored
      12580a07
    • Jan Djärv's avatar
      * emacs.c (main): Fix syntax error. · 29be4a50
      Jan Djärv authored
      29be4a50
    • Glenn Morris's avatar
      Auto-commit of generated files. · 20c9c1dc
      Glenn Morris authored
      20c9c1dc
    • Paul Eggert's avatar
      * Makefile.in (removenullpaths): Remove adjacent null paths. · c6e7fc0e
      Paul Eggert authored
      Fixes: debbugs:14835
      c6e7fc0e
    • Paul Eggert's avatar
      Timestamp fixes for undo. · 954b166e
      Paul Eggert authored
      * doc/lispref/text.texi (Undo):
      Document (t . 0) and (t . -1) in buffer-undo-list.
      * etc/NEWS: Changes to visited-file-modtime, set-visited-file-modtime.
      * lisp/files.el (clear-visited-file-modtime): Move here from fileio.c.
      * src/atimer.c (schedule_atimer):
      * src/fileio.c (Ffile_newer_than_file_p):
      Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
      * src/buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
      * src/fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
      (syms_of_fileio): Remove Sclear_visited_file_name.
      (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
      file doesn't exist; this avoids an ambiguity with negative timestamps.
      (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
      * src/systime.h (make_emacs_time, invalid_emacs_time):
      Don't assume struct timespec layout; POSIX doesn't guarantee it.
      (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
      * src/undo.c (record_first_change): Push (visited-file-modtime) onto
      undo list rather than reimplementing it by hand, incorrectly.
      
      Fixes: debbugs:14824
      954b166e
    • Leo Liu's avatar
      * files.el (require-final-newline): Allow safe local value. · 56973319
      Leo Liu authored
      Fixes: debbugs:14834
      56973319
  3. 09 Jul, 2013 10 commits