1. 24 Oct, 2009 1 commit
    • Dan Nicolaescu's avatar
      * keymap.c (Fmake_sparse_keymap): Purecopy the name. · 905a9ed3
      Dan Nicolaescu authored
      * eval.c (Fautoload): Purecopy the filename.  Simplify.
      
      * category.c (Fdefine_category): Purecopy docstring.
      
      * international/mule-cmds.el (set-language-info-alist): Purecopy lang-env.
      (leim-list-header, leim-list-entry-regexp): Change defvars to defconst.
      (charset): Purecopy the name.
      (define-char-code-property): Purecopy string arguments.
      
      * emacs-lisp/byte-run.el (make-obsolete, make-obsolete-variable):
      Purecopy string arguments.
      
      * emacs-lisp/lisp-mode.el (emacs-lisp-mode-map):
      * ediff-hook.el (menu-bar-ediff-menu):
      * buff-menu.el (Buffer-menu-mode-map): Purecopy names and tooltips.
      * bookmark.el (menu-bar-bookmark-map): Add :help and purecopy the name.
      905a9ed3
  2. 10 Oct, 2009 2 commits
    • Karl Fogel's avatar
      * bookmark.el · 6d6a5b7e
      Karl Fogel authored
        (bookmark-yank-word, bookmark-insert-current-bookmark): Update
        documentation to refer to variables documented in r1.135.
      6d6a5b7e
    • Karl Fogel's avatar
      * bookmark.el · 67b70de9
      Karl Fogel authored
        (Info-suffix-list): Remove this completely unused variable.
        (bookmark-current-point): Remove this obsolete variable.
        (bookmark-set, bookmark-rename, bookmark-send-edited-annotation):
        Adjust for removal of bookmark-current-point.
      
        (bookmarks-already-loaded, bookmark-current-buffer, bookmark-yank-point):
        Document.  (Bug#4188)
      67b70de9
  3. 09 Oct, 2009 3 commits
  4. 05 Oct, 2009 4 commits
    • Karl Fogel's avatar
      * bookmark.el (bookmark-handle-bookmark): If bookmark has no file, · 5feb1ba7
      Karl Fogel authored
          don't do anything related to relocating, just return nil.
        (bookmark-error-no-filename): New error.
        (bookmark-default-handler): Signal `bookmark-error-no-filename' if
          bookmark has no file.  Don't even attempt to handle things that
          are not files; the whole point of custom handlers is to keep that
          knowledge elsewhere anyway.  Tighten some comments.
        (bookmark-file-or-variation-thereof): Remove now-unused function.
        (bookmark-location): Doc string fix.
      
      (Bug#4250)
      5feb1ba7
    • Karl Fogel's avatar
      * bookmark.el (bookmark-handle-bookmark): When relocating a bookmark, · 1bd49952
      Karl Fogel authored
        don't use a file dialog, because they usually don't know how to read
        a directory target from the user.  (Bug#4230)
        Also, make sure the prompt can display directories as well as files.
      1bd49952
    • Karl Fogel's avatar
      825382c0
    • Karl Fogel's avatar
      * bookmark.el · 13901bcb
      Karl Fogel authored
        (bookmark-get-bookmark, bookmark-get-bookmark-record,
         bookmark-set-name, bookmark-prop-get, bookmark-prop-set,
         bookmark-get-annotation, bookmark-set-annotation, bookmark-get-filename,
         bookmark-set-filename, bookmark-get-position, bookmark-set-position,
         bookmark-get-front-context-string, bookmark-set-front-context-string,
         bookmark-get-rear-context-string, bookmark-set-rear-context-string,
         bookmark-location, bookmark-jump, bookmark-jump-other-window,
         bookmark-handle-bookmark, bookmark-relocate, bookmark-insert-location,
         bookmark-rename, bookmark-insert, bookmark-delete, bookmark-time-to-save-p,
         bookmark-edit-annotation-mode, bookmark-edit-annotation): Improve doc
         strings to say whether bookmark can be a string or a record or both,
         and make other consistency and clarity fixes.
        (bookmark-get-handler, bookmark--jump-via, bookmark-write-file,
         bookmark-default-annotation-text, bookmark-yank-word,
         bookmark-maybe-load-default-file, bookmark-maybe-sort-alist,
         bookmark-import-new-list, bookmark-maybe-rename,
         bookmark-bmenu-show-filenames, bookmark-bmenu-hide-filenames,
         bookmark-bmenu-bookmark): Give these doc strings.
        (bookmark-bmenu-check-position): Give this a doc string, but also
         add a FIXME comment about how the function may be pointless.
        (bookmark-default-handler): Rework doc string and change a parameter
         name, to clarify that this takes a bookmark record not a bookmark name.
        (bookmark-set): Change a parameter name to indicate its meaning,
         and improve the doc string a bit.
      (Bug#4188)
      13901bcb
  5. 04 Oct, 2009 1 commit
  6. 02 Oct, 2009 1 commit
  7. 20 Sep, 2009 1 commit
  8. 05 Jan, 2009 1 commit
  9. 03 Dec, 2008 1 commit
    • Lute Kamstra's avatar
      * align.el: · 9201cc28
      Lute Kamstra authored
      * allout.el:
      * apropos.el:
      * arc-mode.el:
      * autoinsert.el:
      * avoid.el:
      * battery.el:
      * bookmark.el:
      * buff-menu.el:
      * calculator.el:
      * chistory.el:
      * cmuscheme.el:
      * comint.el:
      * compare-w.el:
      * dabbrev.el:
      * delim-col.el:
      * desktop.el:
      * diff-mode.el:
      * diff.el:
      * dired-aux.el:
      * dired-x.el:
      * dired.el:
      * dos-vars.el:
      * ediff-diff.el:
      * ediff-help.el:
      * ediff-init.el:
      * ediff-merg.el:
      * ediff-mult.el:
      * ediff-ptch.el:
      * ediff-vers.el:
      * ediff-wind.el:
      * ediff.el:
      * emerge.el:
      * facemenu.el:
      * faces.el:
      * ffap.el:
      * filecache.el:
      * find-dired.el:
      * font-core.el:
      * font-lock.el:
      * forms.el:
      * fringe.el:
      * help-at-pt.el:
      * hippie-exp.el:
      * ido.el:
      * image-file.el:
      * imenu.el:
      * indent.el:
      * info.el:
      * isearchb.el:
      * iswitchb.el:
      * jit-lock.el:
      * jka-compr.el:
      * log-edit.el:
      * lpr.el:
      * ls-lisp.el:
      * man.el:
      * menu-bar.el:
      * midnight.el:
      * mouse-sel.el:
      * mouse.el:
      * msb.el:
      * outline.el:
      * paren.el:
      * pcmpl-cvs.el:
      * pcmpl-gnu.el:
      * pcomplete.el:
      * pcvs-info.el:
      * pcvs-parse.el:
      * printing.el:
      * ps-mule.el:
      * ps-print.el:
      * replace.el:
      * ruler-mode.el:
      * saveplace.el:
      * sb-image.el:
      * scroll-bar.el:
      * sha1.el:
      * shadowfile.el:
      * shell.el:
      * sort.el:
      * speedbar.el:
      * strokes.el:
      * tempo.el:
      * term.el:
      * terminal.el:
      * time-stamp.el:
      * time.el:
      * tree-widget.el:
      * type-break.el:
      * vc-cvs.el:
      * vc-hg.el:
      * vc-mcvs.el:
      * vc-rcs.el:
      * vc-sccs.el:
      * vc.el:
      * view.el:
      * w32-vars.el:
      * whitespace.el:
      * wid-edit.el: Remove leading * from docstrings of defcustoms,
      deffaces, defconsts and defuns.
      9201cc28
  10. 21 Nov, 2008 3 commits
  11. 19 Nov, 2008 1 commit
  12. 29 Oct, 2008 2 commits
  13. 06 Oct, 2008 1 commit
  14. 30 Jun, 2008 1 commit
  15. 25 Jun, 2008 1 commit
    • Stefan Monnier's avatar
      * bookmark.el (bookmark-alist): Allow the 2 slightly different formats · 43f8b275
      Stefan Monnier authored
      used until now in bookmark.el's code.
      (bookmark-get-bookmark): Accept bookmark names or bookmark records.
      (bookmark-get-bookmark-record): Allow the 2 slightly different formats
      used until now in bookmark.el's code.
      (bookmark-set-filename): Remove special code, moved to its only caller.
      (bookmark-store): Use the newer format.
      (bookmark-make-record-default): Add arg `point-only'.
      Rename from bookmark-make-record-for-text-file.
      (bookmark--jump-via): New function.
      (bookmark-jump, bookmark-jump-other-window, bookmark-bmenu-2-window)
      (bookmark-bmenu-other-window, bookmark-bmenu-switch-other-window):
      Use it.
      (bookmark-jump-noselect, bookmark-default-handler):
      Don't return an alist, instead return the data implicitly by changing
      current buffer and point.  Signal an error if the file doesn't exist.
      * info.el (Info-bookmark-make-record):
      Use bookmark-make-record-default.
      (Info-bookmark-jump): Use bookmark-default-handler.
      * image-mode.el (image-bookmark-make-record):
      Use bookmark-make-record-default.
      (image-bookmark-jump): Use bookmark-default-handler.
      * doc-view.el (doc-view-bookmark-make-record):
      Use bookmark-make-record-default.
      (doc-view-bookmark-jump): Use bookmark-default-handler.
      43f8b275
  16. 06 May, 2008 1 commit
  17. 05 Apr, 2008 1 commit
  18. 13 Mar, 2008 1 commit
  19. 09 Mar, 2008 4 commits
    • Stefan Monnier's avatar
      * bookmark.el (bookmark-make-record-function): Change expected return value · 136894c8
      Stefan Monnier authored
      to include a suggested bookmark name.
      (bookmark-make): Split into bookmark-make-record and bookmark-store.
      Fix reversed `overwrite' semantics.
      (bookmark-set): Call bookmark-make-record before prompting the user.
      Then pass the result to bookmark-store later on.
      (bookmark-make-name-function): Remove.
      (bookmark-buffer-file-name, bookmark-buffer-name): Don't use it.
      * info.el (bookmark-make-name-function): Remove.
      (Info-mode): Don't set it.
      (Info-bookmark-make-name): Remove.
      (Info-bookmark-make-record): Use Info-current-node as suggested default
      bookmark name.
      136894c8
    • Stefan Monnier's avatar
      (bookmark-set): Make the bookmark before reading annotations. · a7e83b26
      Stefan Monnier authored
      I.e. use bookmark-edit-annotation rather than bookmark-read-annotation.
      (bookmark-read-annotation-mode-map, bookmark-annotation-paragraph)
      (bookmark-annotation-buffer, bookmark-annotation-file)
      (bookmark-annotation-point, bookmark-send-annotation)
      (bookmark-read-annotation-mode, bookmark-read-annotation): Remove.
      (bookmark-edit-annotation-text-func): Rename from
      bookmark-read-annotation-text-func.  Keep old name as an obsolete alias.
      (bookmark-edit-annotation-mode-map): Move initialization into declaration.
      a7e83b26
    • Stefan Monnier's avatar
      Add spurious * in docstrings. · fc22668d
      Stefan Monnier authored
      (bookmark-minibuffer-read-name-map): New var.
      (bookmark-set): Use it.  Also pass the default value as it should.
      (bookmark-send-edited-annotation): Take no chances with text properties.
      (bookmark-insert-current-bookmark): Inline bookmark-insert-buffer-name.
      (bookmark-insert-buffer-name): Remove.
      (bookmark-buffer-file-name): Signal an error rather than returning nil.
      fc22668d
    • Stefan Monnier's avatar
      * bookmark.el (bookmark-make): Don't pass the `annotation' to the · 32a091dd
      Stefan Monnier authored
      make-record function, instead paste it in afterwards.
      (bookmark-make-record-for-text-file):
      * doc-view.el (doc-view-bookmark-make-record):
      * info.el (Info-bookmark-make-record): Don't mess with annotations.
      32a091dd
  20. 08 Mar, 2008 1 commit
    • Stefan Monnier's avatar
      * bookmark.el (bookmark-prop-get, bookmark-prop-set): New funs. · 02a5ba27
      Stefan Monnier authored
      (bookmark-get-annotation, bookmark-set-annotation)
      (bookmark-get-filename, bookmark-set-filename, bookmark-get-position)
      (bookmark-set-position, bookmark-get-front-context-string)
      (bookmark-set-front-context-string, bookmark-get-rear-context-string)
      (bookmark-set-rear-context-string, bookmark-get-handler): Use them.
      * info.el (Info-bookmark-make-record): Don't bother recording point.
      (bookmark-get-filename, bookmark-get-front-context-string)
      (bookmark-get-rear-context-string, bookmark-get-position): Don't declare.
      (bookmark-get-info-node): Remove.
      (bookmark-prop-get): Declare.
      (Info-bookmark-jump): Use it.
      02a5ba27
  21. 07 Mar, 2008 4 commits
    • Bastien Guerry's avatar
      * bookmark.el (bookmark-set): Don't check for · f9bf6950
      Bastien Guerry authored
      `bookmark-make-name-function' since `bookmark-buffer-file-name'
      already takes care of this.
      (bookmark-buffer-name): Removed Info-mode specific code.
      (bookmark-buffer-file-name): Removed Info-mode specific code.
      
      * info.el (bookmark-get-info-node): Define this function in
      info.el, not in bookmark.el.
      (Info-mode): Set `bookmark-make-name-function' to
      `Info-bookmark-make-name' locally.
      (Info-bookmark-make-name): New function.
      
      * bookmark.el (bookmark-make-name-function): New variable.
      f9bf6950
    • Karl Fogel's avatar
      * emacs-cvs/lisp/bookmark.el · 9dfcb52e
      Karl Fogel authored
        (bookmark-set): Make `bookmark-make-record-function' buffer-local,
        not `bookmark-make-cell-function' (the old name).
      9dfcb52e
    • Karl Fogel's avatar
      Change a return type, for greater extensibility. See · e0385bf4
      Karl Fogel authored
      http://lists.gnu.org/archive/html/emacs-devel/2007-12/msg01077.html
      and its thread for discussion leading to this change.
      
      * emacs-cvs/lisp/bookmark.el:
      (bookmark-jump-noselect): Return an alist instead of a dotted pair.
      (bookmark-jump, bookmark-jump-other-window, bookmark-insert)
      (bookmark-bmenu-2-window, bookmark-bmenu-other-window)
      (bookmark-bmenu-switch-other-window): Adjust accordingly.
      (bookmark-make-cell-function): Adjust documentation accordingly.
      
      * emacs-cvs/lisp/image-mode.el
      (image-bookmark-jump): Adjust return type accordingly; document.
      
      * emacs-cvs/lisp/doc-view.el
      (doc-view-bookmark-jump): Adjust return type accordingly; document.
      e0385bf4
    • Stefan Monnier's avatar
      * bookmark.el (bookmark-map, bookmark-read-annotation-mode-map): · 79363d93
      Stefan Monnier authored
      Move initialization into declaration.
      (bookmark-get-info-node, bookmark-set-info-node): Remove.
      (bookmark-make, bookmark-make-cell-for-text-file): Remove `info-node' arg.
      (bookmark-info-current-node): Remove.
      (bookmark-jump-noselect): Rename from bookmark-jump-internal.
      Add relocation fallback.  Set bookmark-current-bookmark.
      (bookmark-default-handler): Rename from bookmark-jump-noselect.
      Remove relocation fallback.  Don't set bookmark-current-bookmark.
      (bookmark-set): Let it be used even if there's no buffer-file-name
      as long as there is a bookmark-make-cell-function.
      * info.el (Info-bookmark-jump): Remove relocation fallback.
      Don't set bookmark-current-bookmark.
      79363d93
  22. 07 Jan, 2008 1 commit
  23. 04 Jan, 2008 1 commit
  24. 02 Jan, 2008 1 commit
    • Karl Fogel's avatar
      Change a return type, for greater extensibility. See · 03e26a79
      Karl Fogel authored
      http://lists.gnu.org/archive/html/emacs-devel/2007-12/msg01077.html
      and its thread for discussion leading to this change.
      
      * emacs-cvs/lisp/bookmark.el:
      (bookmark-jump-noselect): Return an alist instead of a dotted pair.
      (bookmark-jump, bookmark-jump-other-window, bookmark-insert)
      (bookmark-bmenu-2-window, bookmark-bmenu-other-window)
      (bookmark-bmenu-switch-other-window): Adjust accordingly.
      (bookmark-make-cell-function): Adjust documentation accordingly.
      
      * emacs-cvs/lisp/image-mode.el
      (image-bookmark-jump): Adjust return type accordingly; document.
      
      * emacs-cvs/lisp/doc-view.el
      (doc-view-bookmark-jump): Adjust return type accordingly; document.
      03e26a79
  25. 26 Dec, 2007 1 commit
    • Tassilo Horn's avatar
      2007-12-26 Tassilo Horn <tassilo@member.fsf.org> · 1666a6b3
      Tassilo Horn authored
      	* bookmark.el (bookmark-make-cell-function): New variable.
      	(bookmark-make): Call bookmark-make-cell-function's function
      	instead of bookmark-make-cell.
      	(bookmark-get-handler, bookmark-jump-internal): New functions.
      	(bookmark-jump, bookmark-jump-other-window, bookmark-insert)
      	(bookmark-bmenu-2-window, bookmark-bmenu-other-window): Use
      	bookmark-jump-internal.
      	(bookmark-make-cell-for-text-file): Renamed from
      	bookmark-make-cell.
      
      	* doc-view.el (doc-view-bookmark-make-cell)
      	(doc-view-bookmark-jump): New functions.
      	(doc-view-mode): Set bookmark-make-cell-function buffer-locally.
      1666a6b3