1. 13 Dec, 2016 28 commits
    • Reuben Thomas's avatar
      Remove unused variable · 94834bdf
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (current-ispell-directory): Remove.
      94834bdf
    • Reuben Thomas's avatar
      Remove XEmacs-specific ispell-with-no-warnings · 6b5ac583
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (ispell-with-no-warnings): Remove this
      defmacro, needed only for XEmacs.
      (ispell-command-loop, ispell-message): Use with-no-warnings directly.
      6b5ac583
    • Reuben Thomas's avatar
      Remove meaningless defconst ispell-version · 8af9cb22
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (ispell-version): Since ispell.el is now
      firmly part of Emacs, and the version hasn’t changed since 2003, and
      isn’t used anywhere, remove it.  3rd-party code can better use the
      Emacs version, or feature or function checks.
      (ispell-check-version): No longer report ispell.el version.
      8af9cb22
    • Reuben Thomas's avatar
      Remove boundp test for always-bound symbol · e1aa7888
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (ispell-message): mail-yank-prefix is
      defvar’d at the top of the file, so remove a test to see if it is
      bound.
      e1aa7888
    • Reuben Thomas's avatar
      Remove support for ispell < 3.1.12 · db6e1f82
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (ispell-offset): Remove.
      (ispell-check-version): Require ispell >= 3.1.12, released in 1994.
      (ispell-process-line): No longer use ispell-offset.
      db6e1f82
    • Reuben Thomas's avatar
      Remove unused constant · 3affed01
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (ispell-required-version): Remove.
      3affed01
    • Reuben Thomas's avatar
      Remove support for old versions of supercite and GNUS from ispell.el · 8315d50b
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (ispell-message): Require supercite >= 3.0
      and GNUS >= 5.  Not exactly the bleeding edge!
      8315d50b
    • Reuben Thomas's avatar
      Remove remaining mentions of XEmacs from ispell.el · b989c415
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (ispell-valid-dictionary-list):
      (ispell-add-per-file-word-list): Remove mentions of XEmacs from
      comments.
      b989c415
    • Reuben Thomas's avatar
      Remove XEmacs-specific minibuffer handling code from ispell.el · 8886f156
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (ispell-init-process): Assume we are not in
      XEmacs.
      8886f156
    • Reuben Thomas's avatar
      Remove XEmacs-specific horizontal scrollbar handling in ispell.el · 6e88249c
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (ispell-command-loop): Remove
      XEmacs-specific code.
      6e88249c
    • Reuben Thomas's avatar
      Remove XEmacs-specific code dealing with enable-multibyte-characters · 8245e5b9
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (ispell-decode-string):
      (ispell-init-process):  Remove XEmacs-specific guard.
      8245e5b9
    • Reuben Thomas's avatar
      Remove XEmacs-specific code from ispell.el · ff5deddc
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (ispell-menu-xemacs): Remove
      (ispell-menu-map-needed): Remove XEmacs-specific check.
      (ispell-word): Remove XEmacs-specific extent code.
      (ispell-init-process): Remove XEmacs workaround for local add-hook.
      Assume we have set-process-query-on-exit-flag.
      (ispell-kill-ispell, ispell-change-dictionary): Remove XEmacs
      workaround for called-interactively-p.
      ff5deddc
    • Reuben Thomas's avatar
      Remove some commented-out code · ada717ef
      Reuben Thomas authored
      lisp/textmodes/ispell.el (ispell-process)
      ispell-valid-dictionary-list): Remove commented-out code.
      ada717ef
    • Reuben Thomas's avatar
      Remove XEmacs and old Emacs highlighting code · c89dc9d8
      Reuben Thomas authored
      * lisp/textmodes/ispell.el
      (ispell-highlight-spelling-error-xemacs): Remove.
      (ispell-highlight-spelling-error): Assume display-color-p exists.
      c89dc9d8
    • Reuben Thomas's avatar
      Assume Emacs supports [:alpha:] in regexps · 854ed8a6
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (ispell-emacs-alpha-regexp): Remove.
      (ispell-set-spellchecker-params): Remove tests of
      ispell-emacs-alpha-regexp.
      854ed8a6
    • Reuben Thomas's avatar
      Remove some XEmacs-specific code from ispell.el · 3ac94b99
      Reuben Thomas authored
      * lisp/textmodes/ispell.el: Remove XEmacs menubar setup.
      (ispell-int-char): Remove.
      3ac94b99
    • Reuben Thomas's avatar
      Generalise over-specific documentation · 028249eb
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (ispell-personal-dictionary): Rather than
      document precise personal wordlist filenames for only two supported
      spelling checkers, simply say that the default personal dictionary
      depends on the chosen spelling checker.  The user can check the
      spelling checker’s documentation if necessary.  This is simpler, and
      works for other supported (and future, or unknown) spelling checkers.
      028249eb
    • Reuben Thomas's avatar
      Remove tests for built-in functions · 51d011d6
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (buffer-substring-no-properties): Remove
      back-up definition.
      (ispell-add-per-file-word-list): Remove tests for comment-padright and
      comment-normalize-vars.
      51d011d6
    • Reuben Thomas's avatar
      Remove unused ispell-looking-back · a3ca97e7
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (ispell-looking-back): Remove unused alias.
      a3ca97e7
    • Reuben Thomas's avatar
      Assume we have version<= for checking ispell version · 8edf0eb4
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (ispell-check-minver): Remove.
      (ispell-check-version): Use version<= directly.
      8edf0eb4
    • Reuben Thomas's avatar
      Remove ispell.el pre-GNU Emacs comments · f25c8b34
      Reuben Thomas authored
      * lisp/textmodes/ispell.el (Commentary): Remove original maintainer
        details, as Emacs version, bug report address and so forth should be
        used instead for this version.  Remove in-line change history; use
        git instead.
      f25c8b34
    • Mark Oteiza's avatar
      More small fixes for image-dired · aacb20c0
      Mark Oteiza authored
      * lisp/image-dired.el: Fix commentary to refer to correct Emacs manual
      node.
      (image-dired--with-db-file): Add declare forms.
      (image-dired-hidden-p): Rewrite with cl-loop.  It's not necessary to
      run through the whole list.
      aacb20c0
    • Mark Oteiza's avatar
      Remove image-dired-kill-buffer-and-window · 86762eb1
      Mark Oteiza authored
      This breaks window layout, especially when quitting a
      image-dired-display-image-mode buffer.
      * lisp/image-dired.el (image-dired-thumbnail-mode-map):
      (image-dired-display-image-mode-map): Replace in keymap and menu items
      bindings to image-dired-kill-buffer-and-window with quit-window.
      (image-dired-kill-buffer-and-window): Remove.
      86762eb1
    • Mark Oteiza's avatar
      Replace image-dired-setup-dired-keybindings with a minor mode · bed03738
      Mark Oteiza authored
      * lisp/image-dired.el (image-dired-thumbnail-mode): Fix docstring to
      remove mention of nonexistent image-dired-dired and to refer to the
      new minor mode.
      (image-dired-minor-mode-map): New keymap assimilated from
      image-dired-setup-dired-keybindings.  In the future, the keymap parent
      should be removed, and perhaps also the duplicate bindings that
      already exist in dired-mode-map.
      (image-dired-setup-dired-keybindings): Remove.  Replace with an
      obsolete function alias.
      (image-dired-minor-mode): New minor mode, assuming the role of
      image-dired-setup-dired-keybindings.
      bed03738
    • Paul Eggert's avatar
      dc833039
    • Noam Postavsky's avatar
      Clarify thread-signal semantics · c78f872a
      Noam Postavsky authored
      * doc/lispref/threads.texi (Basic Thread Functions): Explain that the
      thread will be signaled as soon as possible.
      c78f872a
    • Noam Postavsky's avatar
      Clean up var watcher disabling on thread switching · f66174a1
      Noam Postavsky authored
      * src/data.c (Fset_default): Move code into new C level function,
      `set_default_internal'.
      (set_default_internal): New function, like `Fset_default' but also takes
      additional bindflag parameter.
      (set_internal): Only call `notify_variable_watchers' if bindflag is not
      SET_INTERNAL_THREAD_SWITCH.
      * src/eval.c (do_specbind, do_one_unbind): Add bindflag parameter,
      passed on to set_internal and set_default_internal.  Adjust callers.
      (rebind_for_thread_switch, unbind_for_thread_switch): Pass
      SET_INTERNAL_THREAD_SWITCH to do_specbind, do_one_unbind instead of
      temporarily adjusting symbol's trapped_write field.
      f66174a1
    • Glenn Morris's avatar
      Minor fix for define-derived-mode · 8db7b65d
      Glenn Morris authored
      * lisp/emacs-lisp/derived.el (define-derived-mode):
      Do not let eg eval-defun reset the values of syntax or abbrev tables,
      since they might have been defined externally.  (Bug#16160)
      8db7b65d
  2. 12 Dec, 2016 12 commits
    • Paul Eggert's avatar
      3e651e3c
    • Clément Pit--Claudel's avatar
      Move backtrace to ELisp using a new mapbacktrace primitive · 27cada03
      Clément Pit--Claudel authored
      * src/eval.c (get_backtrace_starting_at, backtrace_frame_apply)
      (Fmapbacktrace, Fbacktrace_frame_internal): New functions.
      (get_backtrace_frame, Fbacktrace_debug): Use `get_backtrace_starting_at'.
      
      * lisp/subr.el (backtrace--print-frame): New function.
      (backtrace): Reimplement using `backtrace--print-frame' and `mapbacktrace'.
      (backtrace-frame): Reimplement using `backtrace-frame--internal'.
      
      * lisp/emacs-lisp/debug.el (debugger-setup-buffer): Pass a base to
      `mapbacktrace' instead of searching for "(debug" in the output of
      `backtrace'.
      
      * test/lisp/subr-tests.el (subr-test-backtrace-simple-tests)
      (subr-test-backtrace-integration-test): New tests.
      
      * doc/lispref/debugging.texi (Internals of Debugger): Document
      `mapbacktrace' and missing argument BASE of `backtrace-frame'.
      27cada03
    • Paul Eggert's avatar
      Use C99 syntax for font drivers · a41ded87
      Paul Eggert authored
      Problem reported by Daniel Colascione in:
      http://lists.gnu.org/archive/html/emacs-devel/2016-12/msg00515.html
      * src/ftcrfont.c (ftcrfont_driver):
      * src/ftfont.c (ftfont_driver):
      * src/ftxfont.c (ftxfont_driver):
      * src/macfont.m (macfont_driver):
      * src/nsfont.m (nsfont_driver):
      * src/xfont.c (xfont_driver):
      * src/xftfont.c (xftfont_driver):
      Use C99 syntax, not the old GNU C syntax.
      a41ded87
    • Glenn Morris's avatar
      Obsolete gs.el · 3c655230
      Glenn Morris authored
      * lisp/gs.el: Move to lisp/obsolete.  (Bug#1524)
      * doc/lispref/display.texi (Image Formats): Remove postscript.
      (PostScript Images): Remove section.
      * doc/lispref/elisp.texi: Update menu.
      3c655230
    • Glenn Morris's avatar
      Un-revert recent Ffset change · ffb13021
      Glenn Morris authored
      * src/data.c (Ffset): Reinstate the check for "nil".
      ffb13021
    • Glenn Morris's avatar
      Minor advice.el fix · 61f8c238
      Glenn Morris authored
      * lisp/emacs-lisp/advice.el (ad-preactivate-advice):
      Avoid setting the function definition of nil.
      This was happening during bootstrap of org-compat.el,
      apparently due to eager macro expansion of code behind
      a (featurep 'xemacs) test.
      61f8c238
    • Eli Zaretskii's avatar
      Make etags-tests work in out-of-tree builds · 940df477
      Eli Zaretskii authored
      * test/lisp/progmodes/etags-tests.el (etags-bug-158)
      (etags-bug-23164): Make them work in an out-of-tree build.
      Reported by Ken Brown <kbrown@cornell.edu>.
      940df477
    • Eli Zaretskii's avatar
      Avoid crashing if a new thread is signaled right away · 825f4dd4
      Eli Zaretskii authored
      * src/thread.c (post_acquire_global_lock): Don't raise the pending
      signal if the thread's handlers were not yet set up, as that will
      cause Emacs to exit with a fatal error.  This can happen if a
      thread is signaled as soon as make-thread returns, before the new
      thread had an opportunity to acquire the global lock, set up the
      handlers, and call the thread function.
      
      * test/src/thread-tests.el (thread-signal-early): New test.
      825f4dd4
    • Eli Zaretskii's avatar
      Fix point motion in cloned buffers · a416e1d6
      Eli Zaretskii authored
      * src/thread.c (post_acquire_global_lock): Call
      set_buffer_internal_2 instead of tricking set_buffer_internal_1
      into resetting the current buffer even if it didn't change.  This
      avoids bug#25165, caused by failing to record the modified values
      of point and mark, because current_buffer was set to NULL.  Also,
      don't bother re-setting the buffer if there was no thread switch,
      as that just wastes cycles.
      * src/buffer.c (set_buffer_internal_2): New function, with most of
      the body of set_buffer_internal_1, but without the test for B
      being identical to the current buffer.
      (set_buffer_internal_1): Call set_buffer_internal_2 if B is not
      identical to the current buffer.
      * src/buffer.h (set_buffer_internal_2): Add prototype.
      
      * test/src/thread-tests.el (thread-sticky-point): New test.
      a416e1d6
    • Michael Albinus's avatar
      Further improvements in Tramp's file name unquoting · 00d4ba27
      Michael Albinus authored
      * lisp/net/tramp-adb.el (tramp-adb-handle-file-local-copy)
      (tramp-adb-handle-write-region): Unquote localname.
      (tramp-adb-handle-copy-file): Implement direct copy on remote device.
      (tramp-adb-handle-rename-file): Quote arguments, add "-f" to force.
      
      * lisp/net/tramp.el (tramp-file-name-unquote-localname): New defun.
      (tramp-handle-file-name-case-insensitive-p):
      * lisp/net/tramp-gvfs.el (tramp-gvfs-get-file-attributes)
      (tramp-gvfs-connection-mounted-p, tramp-gvfs-mount-spec)
      (tramp-gvfs-maybe-open-connection):
      * lisp/net/tramp-sh.el (tramp-make-copy-program-file-name):
      * lisp/net/tramp-smb.el (tramp-smb-get-share)
      (tramp-smb-get-localname): Use it.
      
      * test/lisp/net/tramp-tests.el (tramp--test-docker-p): New defun.
      (tramp--test-special-characters, tramp-test34-utf8)
      (tramp-test34-utf8-with-stat, tramp-test34-utf8-with-perl)
      (tramp-test34-utf8-with-ls): Use it.
      00d4ba27
    • Martin Rudalics's avatar
      Strengthen conditions for resizing sibling windows (Bug#25169) · 184ed361
      Martin Rudalics authored
      * lisp/window.el (window-resize, delete-window): Resize other siblings
      only if `window-combination-resize' equals t (Bug#25169).
      184ed361
    • Noam Postavsky's avatar
      Quote filenames containing '~' in prompts · a92a027d
      Noam Postavsky authored
      When in a directory named '~', the default value given by
      `read-file-name' should be quoted by prepending '/:', in order to
      prevent it from being interpreted as referring to the $HOME
      directory (Bug#16984).
      
      * lisp/minibuffer.el (minibuffer-maybe-quote-filename): New function.
      (completion--sifn-requote, read-file-name-default): Use it instead of
      `minibuffer--double-dollars'.
      * test/lisp/files-tests.el (files-test-read-file-in-~): Test it.
      a92a027d