1. 13 Feb, 2013 1 commit
    • Juri Linkov's avatar
      Add more keymaps where S-SPC scrolls in the opposite direction to SPC. · 9cec74cf
      Juri Linkov authored
      * lisp/image-mode.el (image-mode-map):
      * lisp/doc-view.el (doc-view-mode-map):
      * lisp/vc/ediff-util.el (ediff-setup-keymap):
      Make S-SPC scroll in the opposite sense to SPC. 
      
      * lisp/gnus/gnus-art.el (gnus-article-mode-map):
      * lisp/gnus/gnus-sum.el (gnus-summary-mode-map, gnus-summary-article-map):
      Make S-SPC scroll in the opposite sense to SPC.  (Bug#2145)
      9cec74cf
  2. 12 Feb, 2013 2 commits
  3. 11 Feb, 2013 1 commit
  4. 09 Feb, 2013 1 commit
    • Tassilo Horn's avatar
      * doc-view.el: Use (and prefer) soffice as default ODF->PDF · f63f9398
      Tassilo Horn authored
      converter (Bug#13622).  Patch provided by Jambunathan K
      <kjambunathan@gmail.com>.
      (doc-view-unoconv-program): Make obsolete variable.
      (doc-view-odf->pdf-converter-program): New variable.
      (doc-view-odf->pdf-converter-function): New variable.
      (doc-view-mode-p): Use it.
      (doc-view-odf->pdf-converter-unoconv): Rename from
      `doc-view-odf->pdf-converter-unoconv'.
      (doc-view-odf->pdf-converter-soffice): New function.
      (doc-view-convert-current-doc): Use
      `doc-view-odf->pdf-converter-function'.
      f63f9398
  5. 24 Jan, 2013 1 commit
  6. 10 Jan, 2013 2 commits
    • Elias Pipping's avatar
      * lisp/files.el (auto-mode-alist): Use doc-view for djvu files. · 72781fef
      Elias Pipping authored
      * lisp/doc-view.el (doc-view-document->bitmap):
      Use doc-view-single-page-converter-function instead of
      single-page-converter arg; adjust callers.
      
      Fixes: debbugs:13164
      72781fef
    • Stefan Monnier's avatar
      * lisp/doc-view.el (doc-view-pdfdraw-program): Allow "pdfdraw" name. · bbc7ff25
      Stefan Monnier authored
      (doc-view-pdf->png-converter-function): Use mupdf if available.
      (doc-view-djvu->png-converter-function)
      (doc-view-ps->png-converter-function): Remove.
      (doc-view--image-file-pattern): Replace doc-view--image-file-extension.
      (doc-view-goto-page, doc-view-convert-current-doc, doc-view-display)
      (doc-view-already-converted-p): Adjust accordingly.
      (doc-view-mode-p): Simplify.
      (doc-view-enlarge): Use setq-local.
      (doc-view-pdf->png-converter-ghostscript)
      (doc-view-djvu->png-converter-ddjvu)
      (doc-view-pdf->png-converter-mupdf): Rework to call
      doc-view-start-process directly.
      (doc-view-pdf/ps->png): Simplify accordingly.
      (doc-view-pdf->png-1, doc-view-djvu->png-1): Remove.
      (doc-view-document->bitmap): Rename from doc-view-document->png.
      (doc-view-convert-current-doc): Merge pdf and djvu cases.
      (doc-view-set-slice-from-bounding-box): Fix completion table.
      (doc-view-mode): Use add-hook for after-revert-hook.
      bbc7ff25
  7. 09 Jan, 2013 2 commits
    • Elias Pipping's avatar
      * lisp/doc-view.el: Add support for DjVu. · 2b541f9a
      Elias Pipping authored
      (doc-view-djvu->png-converter-function): New config var.
      (doc-view-single-page-converter-function, doc-view--image-type)
      (doc-view--image-file-extension): New vars.
      (doc-view-mode): Initialize them.
      (doc-view-goto-page): Use them.
      (doc-view-mode-p): Add support for ddjvu.
      (doc-view-djvu->png-converter-ddjvu, doc-view-djvu->png-1)
      (doc-view-set-up-single-converter): New funs.
      (doc-view-pdf/ps->png): Extend for djvu.
      (doc-view-document->png): Rename from doc-view-pdf->png.
      (doc-view-convert-current-doc): Handle djvu.
      (doc-view-insert-image, doc-view-display)
      (doc-view-already-converted-p): Don't hardcode png.
      (doc-view-set-doc-type): Recognize djvu docs.
      
      Fixes: debbugs:13164
      2b541f9a
    • Elias Pipping's avatar
      * lisp/doc-view.el: Add support for mupdf converter. · 85f17e35
      Elias Pipping authored
      (doc-view-pdfdraw-program, doc-view-pdf->png-converter-function)
      (doc-view-ps->png-converter-function): New config vars.
      (doc-view-pdf->png-converter-ghostscript)
      (doc-view-ps->png-converter-ghostscript)
      (doc-view-pdf->png-converter-mupdf): New functions.
      (doc-view-pdf/ps->png, doc-view-pdf->png-1): Use them.
      
      Fixes: debbugs:13164
      85f17e35
  8. 04 Jan, 2013 1 commit
  9. 01 Jan, 2013 1 commit
  10. 28 Sep, 2012 1 commit
  11. 27 Sep, 2012 1 commit
    • Stefan Monnier's avatar
      * lisp/image-mode.el: Use lexical-binding. · 83600dc8
      Stefan Monnier authored
      (image-mode-winprops): Use t to stand for the window of a buffer that's
      not displayed.
      * lisp/doc-view.el (doc-view-new-window-function): Handle t in winprops.
      (doc-view-enlarge): Make it a real nop if the size is not changed.
      (doc-view-display): Handle the case where the buffer is not (yet?)
      displayed in any window.
      (doc-view-saved-settings): New var.
      (doc-view-mode): Use it.
      (doc-view-fallback-mode): Set it.
      83600dc8
  12. 20 Sep, 2012 1 commit
  13. 19 Sep, 2012 2 commits
    • Stefan Monnier's avatar
      * lisp/doc-view.el (doc-view-guess-paper-size) · 46624b4f
      Stefan Monnier authored
      (doc-view-scale-bounding-box): Fix unbound `caddr'.
      46624b4f
    • Tassilo Horn's avatar
      New feature: set optimal slice from BoundingBox information. · db8a5a18
      Tassilo Horn authored
      * doc-view.el (doc-view-mode-map): Add keybinding.
      (doc-view-menu): Add menu entry.
      (doc-view-set-slice): Adapt docstring.
      (doc-view-get-bounding-box, doc-view-guess-paper-size)
      (doc-view-scale-bounding-box)
      (doc-view-set-slice-from-bounding-box): New functions.
      (doc-view-paper-sizes): New defvar.
      
      * doc/emacs/misc.texi (DocView Slicing): Document new slice from
      BoundingBox feature.
      db8a5a18
  14. 10 Jul, 2012 1 commit
    • Stefan Monnier's avatar
      Reduce use of (require 'cl). · f58e0fd5
      Stefan Monnier authored
      * admin/bzrmerge.el: Use cl-lib.
      * leim/quail/hangul.el: Don't require CL.
      * leim/quail/ipa.el: Use cl-lib.
      * vc/smerge-mode.el, vc/pcvs.el, vc/pcvs-util.el, vc/pcvs-info.el:
      * vc/diff-mode.el, vc/cvs-status.el, uniquify.el, scroll-bar.el:
      * register.el, progmodes/sh-script.el, net/gnutls.el, net/dbus.el:
      * msb.el, mpc.el, minibuffer.el, international/ucs-normalize.el:
      * international/quail.el, info-xref.el, imenu.el, image-mode.el:
      * font-lock.el, filesets.el, edmacro.el, doc-view.el, bookmark.el:
      * battery.el, avoid.el, abbrev.el: Use cl-lib.
      * vc/pcvs-parse.el, vc/pcvs-defs.el, vc/log-view.el, vc/log-edit.el:
      * vc/diff.el, simple.el, pcomplete.el, lpr.el, comint.el, loadhist.el:
      * jit-lock.el, international/iso-ascii.el, info.el, frame.el, bs.el:
      * emulation/crisp.el, electric.el, dired.el, cus-dep.el, composite.el:
      * calculator.el, autorevert.el, apropos.el: Don't require CL.
      * emacs-bytecomp.el (byte-recompile-directory, display-call-tree)
      (byte-compile-unfold-bcf, byte-compile-check-variable):
      * emacs-byte-opt.el (byte-compile-trueconstp)
      (byte-compile-nilconstp):
      * emacs-autoload.el (make-autoload): Use pcase.
      * face-remap.el (text-scale-adjust): Simplify pcase patterns.
      f58e0fd5
  15. 26 Jun, 2012 1 commit
    • Sam Steingold's avatar
      * lisp/files.el (file-name-base): New convenience function. · d2c32364
      Sam Steingold authored
      * lisp/autoinsert.el, lisp/cus-dep.el, lisp/doc-view.el, lisp/image-dired.el,
      * lisp/woman.el, lisp/eshell/esh-cmd.el, lisp/progmodes/ada-xref.el,
      * lisp/progmodes/cc-defs.el, lisp/progmodes/cperl-mode.el,
      * lisp/progmodes/flymake.el, lisp/progmodes/gud.el, lisp/progmodes/idlwave.el,
      * lisp/textmodes/ispell.el, lisp/textmodes/reftex-ref.el,
      * lisp/textmodes/tex-mode.el: Use it.
      Did not touch cedet and org because they are maintained elsewhere.
      d2c32364
  16. 26 Apr, 2012 1 commit
    • Stefan Monnier's avatar
      Replace lexical-let by lexical-binding (except Gnus, CEDET, ERT). · e95a67dc
      Stefan Monnier authored
      * lisp/term/ns-win.el (ns-define-service):
      * lisp/progmodes/pascal.el (pascal-goto-defun):
      * lisp/progmodes/js.el (js--read-tab):
      * lisp/progmodes/etags.el (tags-lazy-completion-table):
      * lisp/emacs-lisp/syntax.el (syntax-propertize-via-font-lock):
      * lisp/emacs-lisp/ewoc.el (ewoc--wrap):
      * lisp/emacs-lisp/assoc.el (aput, adelete, amake):
      * lisp/doc-view.el (doc-view-convert-current-doc):
      * lisp/url/url.el (url-retrieve-synchronously):
      * lisp/vc/diff.el (diff-no-select): Replace lexical-let by lexical-binding.
      e95a67dc
  17. 11 Feb, 2012 1 commit
    • Glenn Morris's avatar
      Add missing :version tags to new defgroups and defcustoms · 2bed3f04
      Glenn Morris authored
      * window.el (window-sides-slots):
      * tool-bar.el (tool-bar-position):
      * term/xterm.el (xterm-extra-capabilities):
      * ses.el (ses-self-reference-early-detection):
      * progmodes/verilog-mode.el (verilog-auto-declare-nettype)
      (verilog-auto-wire-type)
      (verilog-auto-delete-trailing-whitespace)
      (verilog-auto-reset-blocking-in-non, verilog-auto-inst-sort)
      (verilog-auto-tieoff-declaration):
      * progmodes/sql.el (sql-login-hook, sql-ansi-statement-starters)
      (sql-oracle-statement-starters, sql-oracle-scan-on):
      * progmodes/prolog.el (prolog-align-comments-flag)
      (prolog-indent-mline-comments-flag, prolog-object-end-to-0-flag)
      (prolog-left-indent-regexp, prolog-paren-indent-p)
      (prolog-paren-indent, prolog-parse-mode, prolog-keywords)
      (prolog-types, prolog-mode-specificators)
      (prolog-determinism-specificators, prolog-directives)
      (prolog-electric-newline-flag, prolog-hungry-delete-key-flag)
      (prolog-electric-dot-flag)
      (prolog-electric-dot-full-predicate-template)
      (prolog-electric-underscore-flag, prolog-electric-tab-flag)
      (prolog-electric-if-then-else-flag, prolog-electric-colon-flag)
      (prolog-electric-dash-flag, prolog-old-sicstus-keys-flag)
      (prolog-program-switches, prolog-prompt-regexp)
      (prolog-debug-on-string, prolog-debug-off-string)
      (prolog-trace-on-string, prolog-trace-off-string)
      (prolog-zip-on-string, prolog-zip-off-string)
      (prolog-use-standard-consult-compile-method-flag)
      (prolog-use-prolog-tokenizer-flag, prolog-imenu-flag)
      (prolog-imenu-max-lines, prolog-info-predicate-index)
      (prolog-underscore-wordchar-flag, prolog-use-sicstus-sd)
      (prolog-char-quote-workaround):
      * progmodes/cc-vars.el (c-defun-tactic):
      * net/tramp.el (tramp-encoding-command-interactive)
      (tramp-local-end-of-line):
      * net/soap-client.el (soap-client):
      * net/netrc.el (netrc-file):
      * net/gnutls.el (gnutls):
      * minibuffer.el (completion-category-overrides)
      (completion-cycle-threshold)
      (completion-pcm-complete-word-inserts-delimiters):
      * man.el (Man-name-local-regexp):
      * mail/feedmail.el (feedmail-display-full-frame):
      * international/characters.el (glyphless-char-display-control):
      * eshell/em-ls.el (eshell-ls-date-format):
      * emacs-lisp/cl-indent.el (lisp-lambda-list-keyword-alignment)
      (lisp-lambda-list-keyword-parameter-indentation)
      (lisp-lambda-list-keyword-parameter-alignment):
      * doc-view.el (doc-view-image-width, doc-view-unoconv-program):
      * dired-x.el (dired-omit-verbose):
      * cus-theme.el (custom-theme-allow-multiple-selections):
      * calc/calc.el (calc-highlight-selections-with-faces)
      (calc-lu-field-reference, calc-lu-power-reference)
      (calc-note-threshold):
      * battery.el (battery-mode-line-limit):
      * arc-mode.el (archive-7z-extract, archive-7z-expunge)
      (archive-7z-update):
      * allout.el (allout-prefixed-keybindings)
      (allout-unprefixed-keybindings)
      (allout-inhibit-auto-fill-on-headline)
      (allout-flattened-numbering-abbreviation):
      * allout-widgets.el (allout-widgets-auto-activation)
      (allout-widgets-icons-dark-subdir)
      (allout-widgets-icons-light-subdir, allout-widgets-icon-types)
      (allout-widgets-theme-dark-background)
      (allout-widgets-theme-light-background)
      (allout-widgets-item-image-properties-emacs)
      (allout-widgets-item-image-properties-xemacs)
      (allout-widgets-run-unit-tests-on-load)
      (allout-widgets-time-decoration-activity)
      (allout-widgets-hook-error-post-time)
      (allout-widgets-track-decoration):
      * gnus/sieve-manage.el (sieve-manage-default-stream):
      * gnus/shr.el (shr):
      * gnus/nnir.el (nnir-ignored-newsgroups, nnir-summary-line-format)
      (nnir-retrieve-headers-override-function)
      (nnir-imap-default-search-key, nnir-notmuch-program)
      (nnir-notmuch-additional-switches, nnir-notmuch-remove-prefix)
      (nnir-method-default-engines):
      * gnus/message.el (message-cite-reply-position):
      * gnus/gssapi.el (gssapi-program):
      * gnus/gravatar.el (gravatar):
      * gnus/gnus-sum.el (gnus-refer-thread-use-nnir):
      * gnus/gnus-registry.el (gnus-registry-unfollowed-addresses)
      (gnus-registry-max-pruned-entries):
      * gnus/gnus-picon.el (gnus-picon-inhibit-top-level-domains):
      * gnus/gnus-int.el (gnus-after-set-mark-hook)
      (gnus-before-update-mark-hook):
      * gnus/gnus-async.el (gnus-async-post-fetch-function):
      * gnus/auth-source.el (auth-source-cache-expiry):
      Add missing :version tags to new defcustoms and defgroups.
      2bed3f04
  18. 11 Jan, 2012 1 commit
  19. 05 Jan, 2012 1 commit
  20. 23 Nov, 2011 1 commit
  21. 29 Oct, 2011 1 commit
    • Stefan Monnier's avatar
      * lisp/doc-view.el: Avoid ugly errors about not finding nil. · d0af9f77
      Stefan Monnier authored
      (doc-view-ghostscript-program, doc-view-dvipdfm-program)
      (doc-view-dvipdf-program, doc-view-unoconv-program)
      (doc-view-ps2pdf-program, doc-view-pdftotext-program):
      Avoid nil or absolute file name as default value.
      (doc-view-pdf->txt, doc-view-ps->pdf): Use executable-find here.
      d0af9f77
  22. 19 Oct, 2011 1 commit
    • Chong Yidong's avatar
      Fix minor mode docstrings for the new meaning of a nil ARG. · 06e21633
      Chong Yidong authored
      * abbrev.el (abbrev-mode):
      * allout.el (allout-mode):
      * autoinsert.el (auto-insert-mode):
      * autoarg.el (autoarg-mode, autoarg-kp-mode):
      * autorevert.el (auto-revert-mode, auto-revert-tail-mode)
      (global-auto-revert-mode):
      * battery.el (display-battery-mode):
      * composite.el (global-auto-composition-mode)
      (auto-composition-mode):
      * delsel.el (delete-selection-mode):
      * desktop.el (desktop-save-mode):
      * dired-x.el (dired-omit-mode):
      * dirtrack.el (dirtrack-mode):
      * doc-view.el (doc-view-minor-mode):
      * double.el (double-mode):
      * electric.el (electric-indent-mode, electric-pair-mode):
      * emacs-lock.el (emacs-lock-mode):
      * epa-hook.el (auto-encryption-mode):
      * follow.el (follow-mode):
      * font-core.el (font-lock-mode):
      * frame.el (auto-raise-mode, auto-lower-mode, blink-cursor-mode):
      * help.el (temp-buffer-resize-mode):
      * hilit-chg.el (highlight-changes-mode)
      (highlight-changes-visible-mode):
      * hi-lock.el (hi-lock-mode):
      * hl-line.el (hl-line-mode, global-hl-line-mode):
      * icomplete.el (icomplete-mode):
      * ido.el (ido-everywhere):
      * image-file.el (auto-image-file-mode):
      * image-mode.el (image-minor-mode):
      * iswitchb.el (iswitchb-mode):
      * jka-cmpr-hook.el (auto-compression-mode):
      * linum.el (linum-mode):
      * longlines.el (longlines-mode):
      * master.el (master-mode):
      * mb-depth.el (minibuffer-depth-indicate-mode):
      * menu-bar.el (menu-bar-mode):
      * minibuf-eldef.el (minibuffer-electric-default-mode):
      * mouse-sel.el (mouse-sel-mode):
      * msb.el (msb-mode):
      * mwheel.el (mouse-wheel-mode):
      * outline.el (outline-minor-mode):
      * paren.el (show-paren-mode):
      * recentf.el (recentf-mode):
      * reveal.el (reveal-mode, global-reveal-mode):
      * rfn-eshadow.el (file-name-shadow-mode):
      * ruler-mode.el (ruler-mode):
      * savehist.el (savehist-mode):
      * scroll-all.el (scroll-all-mode):
      * scroll-bar.el (scroll-bar-mode):
      * server.el (server-mode):
      * shell.el (shell-dirtrack-mode):
      * simple.el (auto-fill-mode, transient-mark-mode)
      (visual-line-mode, overwrite-mode, binary-overwrite-mode)
      (line-number-mode, column-number-mode, size-indication-mode)
      (auto-save-mode, normal-erase-is-backspace-mode, visible-mode):
      * strokes.el (strokes-mode):
      * time.el (display-time-mode):
      * t-mouse.el (gpm-mouse-mode):
      * tool-bar.el (tool-bar-mode):
      * tooltip.el (tooltip-mode):
      * type-break.el (type-break-mode-line-message-mode)
      (type-break-query-mode):
      * view.el (view-mode):
      * whitespace.el (whitespace-mode, whitespace-newline-mode)
      (global-whitespace-mode, global-whitespace-newline-mode):
      * xt-mouse.el (xterm-mouse-mode): Doc fix.
      
      * emacs-lisp/easy-mmode.el (define-globalized-minor-mode): Fix
      autogenerated docstring.
      06e21633
  23. 16 Jul, 2011 1 commit
  24. 09 Jun, 2011 1 commit
    • Glenn Morris's avatar
      Allow/recommend explicit args for minor-modes in file local eval:s. · f0da764a
      Glenn Morris authored
      * lisp/files.el (hack-one-local-variable-eval-safep):
      Allow minor-modes with explicit +/-1 arguments.
      
      * doc/emacs/custom.texi (Specifying File Variables):
      Recommend explicit arguments for minor modes.
      
      * etc/NEWS: Likewise.
      
      * lisp/doc-view.el, lisp/net/soap-client.el: Update file locals.
      f0da764a
  25. 05 Jun, 2011 1 commit
  26. 10 May, 2011 1 commit
    • Glenn Morris's avatar
      Deprecate using "mode:" to enable minor modes (bug#8613) · b8f82dc1
      Glenn Morris authored
      * lisp/files.el (hack-one-local-variable-eval-safep):
      Consider "eval: (foo-mode)" to be safe.
      
      * doc/emacs/custom.texi (Specifying File Variables):
      Deprecate using mode: for minor modes.
      
      * etc/NEWS: Mention this.
      
      * lisp/doc-view.el, lisp/net/soap-client.el:
      Change "mode:" minor-mode file local variables to use "eval:".
      b8f82dc1
  27. 08 Apr, 2011 1 commit
    • Tassilo Horn's avatar
      Fit contents to emacs window support for doc-view by Sho Nakatani. · d7b89879
      Tassilo Horn authored
      2011-03-28  Sho Nakatani <lay.sakura <at> gmail.com>
      
      	* doc-view.el (doc-view-fit-width-to-window)
      	(doc-view-fit-height-to-window, doc-view-fit-page-to-window): New
      	functions for fitting the shown image to the Emacs window size.
      	(doc-view-mode-map): Add bindings for the new functions.
      d7b89879
  28. 17 Feb, 2011 1 commit
    • Stefan Monnier's avatar
      Various compiler bug-fixes. MPC seems to run correctly now. · b38b1ec0
      Stefan Monnier authored
      * lisp/files.el (lexical-binding): Add a safe-local-variable property.
      
      * lisp/emacs-lisp/byte-opt.el (byte-inline-lapcode): Check how many elements
      are added to the stack.
      (byte-compile-splice-in-already-compiled-code): Don't touch lexical nor
      byte-compile-depth now that byte-inline-lapcode does it for us.
      (byte-compile-inline-expand): Don't inline dynbind byte code into
      lexbind code, since it has to be done differently.
      
      * lisp/emacs-lisp/bytecomp.el (byte-compile-arglist-warn):
      Correctly extract arglist from `closure's.
      (byte-compile-cl-warn): Compiler-macros are run earlier now.
      (byte-compile-top-level): Bind byte-compile-lexical-environment to nil,
      except for lambdas.
      (byte-compile-form): Don't run the compiler-macro expander here.
      (byte-compile-let): Merge with byte-compile-let*.
      Don't preserve-body-value if the body's value was discarded.
      
      * lisp/emacs-lisp/cconv.el (cconv--set-diff, cconv--set-diff-map)
      (cconv--map-diff, cconv--map-diff-elem, cconv--map-diff-set): New funs.
      (cconv--env-var): New constant.
      (cconv-closure-convert-rec): Use it and use them.  Fix a typo that
      ended up forgetting to remove entries from lmenvs in `let'.
      For `lambda' use the outer `fvrs' when building the closure and don't
      forget to remove `vars' from the `emvrs' and `lmenvs' of the body.
      
      * lisp/emacs-lisp/cl-macs.el (cl-byte-compile-block): Disable optimization
      in lexbind, because it needs a different implementation.
      
      * src/bytecode.c (exec_byte_code): Fix handling of &rest.
      
      * src/eval.c (Vinternal_interpreter_environment): Remove.
      (syms_of_eval): Do declare Vinternal_interpreter_environment as
      a global lisp var, but unintern it to hide it.
      (Fcommandp):
      * src/data.c (Finteractive_form): Understand `closure's.
      b38b1ec0
  29. 10 Feb, 2011 1 commit
    • Igor Kuzmin's avatar
      * lisp/emacs-lisp/cconv.el: New file. · 94d11cb5
      Igor Kuzmin authored
      * lisp/emacs-lisp/bytecomp.el: Use cconv.
      (byte-compile-file-form, byte-compile):
      Call cconv-closure-convert-toplevel when requested.
      * lisp/server.el:
      * lisp/mpc.el:
      * lisp/emacs-lisp/pcase.el:
      * lisp/doc-view.el:
      * lisp/dired.el: Use lexical-binding.
      94d11cb5
  30. 25 Jan, 2011 1 commit
  31. 15 Jan, 2011 1 commit
  32. 13 Jan, 2011 2 commits
  33. 08 Jan, 2011 1 commit
  34. 05 Jan, 2011 2 commits