1. 21 Jun, 2013 22 commits
    • Andreas Schwab's avatar
    • Paul Eggert's avatar
    • Paul Eggert's avatar
      Use C99-style flexible array members if available. · fbe9e0b9
      Paul Eggert authored
      This avoids some subtle aliasing issues, which typically
      aren't a problem with GCC but may be a problem elsewhere.
      * lib-src/ebrowse.c (struct member, struct alias, struct sym):
      (add_sym, add_member, make_namespace, register_namespace_alias):
      Use offsetof (struct, flex_array_member), not sizeof (struct), as
      that ports better to pre-C99 non-GCC.
      * src/alloc.c (sdata): New typedef, replacing the old struct sdata.
      It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
      In either case, it uses a flexible array member rather than
      the old struct hack.  All uses changed.
      (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
      Adjust to sdata reorganization.
      * src/alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
      Use offsetof (struct, flex_array_member), not sizeof (struct), as
      that ports better to pre-C99 non-GCC.
      * src/chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
      Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
      as the latter has changed.
      * src/conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
      and port better to pre-C99 GCC.
      * src/image.c (struct xpm_cached_color):
      * src/lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
      (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
      * src/lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
      Move decl to top level so it gets checked against implementation.
      (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
      * src/w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
    • Glenn Morris's avatar
      Use cookie functions in yow · cad5d1cb
      Glenn Morris authored
      * play/cookie1.el (cookie-apropos): Add optional display argument.
      * obsolete/yow.el (apropos-zippy): Use cookie-apropos.
      (psychoanalyze-pinhead): Use cookie-doctor.
    • Juanma Barranquero's avatar
    • Eduard Wiebe's avatar
      Extend flymake's warning predicate to be a function. Test suite for flymake. · c5b0993e
      Eduard Wiebe authored
      * lisp/progmodes/flymake.el (flymake-warning-predicate): New.
      (flymake-parse-line): Use it.
      (flymake-warning-re): Make obsolete alias to
      * doc/misc/flymake.texi (Parsing the output, Customizable variables):
      Add reference to `flymake-warning-predicate'.
      * test/automated/flymake-tests.el:
      * test/automated/flymake/warnpred/Makefile
      * test/automated/flymake/warnpred/test.c
      * test/automated/flymake/warnpred/test.pl: New files.
      Fixes: debbugs:14217
    • Stefan Monnier's avatar
      * lisp/emacs-lisp/package.el (package-alist): Include obsolete packages. · a7d2d465
      Stefan Monnier authored
      (package-obsolete-list): Remove.
      (package-activate): Remove min-version argument.  Add `force' argument.
      Adjust to new package-alist format.
      (package-mark-obsolete): Remove.
      (package-unpack): Force reload of the package's autoloads.
      (package-installed-p): Check builtins if the installed package is not
      recent enough.
      (package-initialize): Don't reset package-obsolete-list.
      Don't specify which package version to activate.
      (package-process-define-package, describe-package-1)
      (package-menu--generate): Adjust to new package-alist format.
    • Juanma Barranquero's avatar
      leim/quail/*.el: Fix typos. · e67e483f
      Juanma Barranquero authored
      * leim/quail/croatian.el ("croatian-prefix"):
      * leim/quail/czech.el ("czech", "czech-qwerty"):
      * leim/quail/ipa-praat.el ("ipa-praat"):
      * leim/quail/ipa.el ("ipa-x-sampa"):
      * leim/quail/tibetan.el ("tibetan-wylie", "tibetan-tibkey"):
      * leim/quail/uni-input.el (ucs-input-activate): Fix typos in docstrings.
    • Juanma Barranquero's avatar
      lisp/*.el: Fix typos; use string-match-p, looking-at-p, setq-local, defvar-local. · cedf5c9d
      Juanma Barranquero authored
      * lisp/allout-widgets.el (allout-widgets-mode-off)
        (allout-widgets-mode-on, allout-widgets-pre-command-business)
        (allout-widgets-after-undo-function, allout-test-range-overlaps)
        (allout-graphics-modification-handler): Fix typos in docstrings.
        (allout-get-or-create-parent-widget): Use `looking-at-p'.
      * lisp/cmuscheme.el (scheme-start-file): Doc fix.
        (inferior-scheme-mode, switch-to-scheme): Fix typos in docstrings.
        (scheme-input-filter): Use `string-match-p'.
      * lisp/composite.el (compose-gstring-for-terminal): Fix typo in docstring.
      * lisp/dired-x.el: Use Dired consistently in docstrings.
      * lisp/dired.el: Use Dired consistently in docstrings.
        (dired-readin, dired-mode): Use `setq-local'.
        (dired-switches-alist): Make defvar-local.
        (dired-buffers-for-dir): Use `zerop'.
        (dired-safe-switches-p, dired-switches-escape-p)
        (dired-insert-old-subdirs, dired-move-to-end-of-filename)
        (dired-glob-regexp, dired-in-this-tree, dired-goto-file-1)
        (dired-sort-set-mode-line, dired-sort-toggle, dired-sort-R-check):
        (dired-goto-next-nontrivial-file): Use `string-match-p'.
        (dired-align-file, dired-insert-directory, dired-mark-files-in-region)
        (dired-toggle-marks, dired-mark-files-containing-regexp)
        (dired-mark-symlinks, dired-mark-directories, dired-mark-executables)
        (dired-flag-auto-save-files, dired-flag-backup-files):
        Use `looking-at-p'.
        (dired-mark-files-regexp, dired-build-subdir-alist):
        Use `string-match-p', `looking-at-p'.
      * lisp/dos-w32.el (untranslated-canonical-name, untranslated-file-p)
        (direct-print-region-helper): Use `string-match-p'.
    • Glenn Morris's avatar
      Auto-commit of generated files. · 4628c0bf
      Glenn Morris authored
    • Leo Liu's avatar
      * comint.el (comint-redirect-results-list-from-process): Fix · aed838b5
      Leo Liu authored
      infinite loop.
    • Lars Magne Ingebrigtsen's avatar
    • Glenn Morris's avatar
      ChangeLog fix for previous change · 7f8e3b22
      Glenn Morris authored
    • Glenn Morris's avatar
      cookie1.el small cleanup · e7a526e3
      Glenn Morris authored
      Make some funcs interactive, copy some functionality from yow.el.
      * lisp/play/cookie1.el (cookie): New custom group.
      (cookie-file): New option.
      (cookie-check-file): New function.
      (cookie): Make it interactive.  Make start and end messages optional.
      Interactively, display the result.  Default to cookie-file.
      (cookie-insert): Default to cookie-file.
      (cookie-snarf): Make start and end messages optional.
      Default to cookie-file.  Use with-temp-buffer.
      (cookie-read): Rename from read-cookie.
      Make start and end messages optional.  Default to cookie-file.
      (cookie-shuffle-vector): Rename from shuffle-vector.  Use dotimes.
      (cookie-apropos, cookie-doctor): New functions, copied from yow.el
      * lisp/obsolete/yow.el (read-zippyism): Use new name for read-cookie.
    • Leo Liu's avatar
    • Glenn Morris's avatar
    • Glenn Morris's avatar
      * lisp/url/url-future.el (url-future-call): Remove useless value call. · 6bfd7cd0
      Glenn Morris authored
      An earlier version of this function returned the value, ref
      but now it returns the function (see commentary).
    • Stefan Monnier's avatar
      * lisp/emacs-lisp/package.el: Use tar-mode rather than tar executable. · fd846ab4
      Stefan Monnier authored
      Consolidate the single-file vs tarball code.
      (package-desc-suffix): New function.
      (package-desc-full-name): Don't bother inlining it.
      (package-load-descriptor): Return the new package-desc.
      (package-mark-obsolete): Remove unused arg `package'.
      (package-unpack): Make it work for single files as well.
      Make it update package-alist.
      (package--make-autoloads-and-stuff): Rename from
      package--make-autoloads-and-compile.  Don't compile any more.
      (package--compile): New function.
      (package-generate-description-file): New function, extracted from
      (package-unpack-single): Remove.
      (package--with-work-buffer): Add indentation and debugging info.
      (package-download-single): Remove.
      (package-install-from-archive): Rename from package-download-tar, make
      it take a pkg-desc, and make it work for single files as well.
      (package-download-transaction): Simplify.
      (package-tar-file-info): Remove `file' arg.  Rewrite not to use an
      external tar program.
      (package-install-from-buffer): Remove `pkg-desc' argument.
      Use package-tar-file-info for tar-mode buffers.
      (package-install-file): Simplify accordingly.
      (package-archive-base): Change to take a pkg-desc.
      * lisp/tar-mode.el (tar--check-descriptor): New function, extracted from
      (tar-get-descriptor): Use it.
      (tar-get-file-descriptor): New function.
      (tar--extract): New function, extracted from tar-extract.
      (tar--extract): Use it.
      * lisp/emacs-lisp/package-x.el (package-upload-file): Decode the file, in
      case the summary uses non-ascii.  Adjust to new calling convention of
    • Glenn Morris's avatar
    • Leo Liu's avatar
      * comint.el (comint-redirect-results-list-from-process): Fix · b7deae5e
      Leo Liu authored
      random delay.
      Fixes: debbugs:14681
    • YAMAMOTO Mitsuharu's avatar
    • Juanma Barranquero's avatar
  2. 20 Jun, 2013 14 commits
    • Juanma Barranquero's avatar
    • Stefan Monnier's avatar
      * lisp/emacs-lisp/cl-loaddefs.el: Don't version-control any more. · aff6371e
      Stefan Monnier authored
      * lisp/emacs-lisp/cl-lib.el: Load cl-macs when cl-loaddefs is not
      yet available.
      * lisp/Makefile.in (AUTOGEN_VCS): Move cl-loaddefs.el...
      (AUTOGENEL): ... here.
      * lisp/emacs-lisp/cl-macs.el (cl--sublis): New function.
      (cl--defsubst-expand): Use it.
      * .bzrignore: Don't unignore cl-loaddefs.el.
    • Paul Eggert's avatar
      * syntax.c: Integer cleanups. · 1fc71008
      Paul Eggert authored
      (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
      All uses that need 0-or-2 changed to:
      (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
      (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
      (char_quoted, prev_char_comend_first, back_comment)
      (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
      (in_classes, forw_comment, scan_lists, scan_sexps_forward):
      Use bool for boolean.
      (update_syntax_table, skip_chars, skip_syntaxes):
      Prefer int to unsigned when either will do.
      (back_comment): Return boolean success flag, like forw_comment,
      instead of positive-or-minus-1 (which might have overflowed int anyway).
      Don't stuff ptrdiff_t into int.
      (syntax_spec_code, syntax_code_spec): Now const.
      (Fmatching_paren, scan_lists, scan_sexps_forward):
      Use enum syntaxcode for syntax code.
      (Fmatching_paren): Check that arg is a character, not just an integer.
      (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
      (Finternal_describe_syntax_value): Omit no-longer-needed
      comparison to 0.
      (skip_chars): Use char, not unsigned char, when the distinction
      doesn't matter.
      (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
      * bytecode.c (exec_byte_code):
      * syntax.c (syntax_spec_code, Fchar_syntax)
      (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
      * syntax.h (SYNTAX_WITH_FLAGS):
      Omit unnecessary casts.
    • Eli Zaretskii's avatar
      Yet another attempt at fixing bugs #14602, 14630, 14669. · b932cad7
      Eli Zaretskii authored
       src/w32fns.c (w32_wnd_proc): Don't compute the header line and mode
       line dimensions here, to avoid race conditions with the main
       src/w32term.c (w32_draw_window_cursor): Compute the header line and
       mode line dimensions here.
       <w32_system_caret_window, w32_system_caret_hdr_height>:
       <w32_system_caret_mode_height>: New variables.
       src/w32term.h: Declare them.
    • Paul Eggert's avatar
      * alloc.c (die): Move "assertion failed" string here ... · 5013fc08
      Paul Eggert authored
      * lisp.h (eassert): ... from here.  Also, suppress evaluation of
      COND when SUPPRESS_CHECKING.  This shrinks the executable text
      size by 0.8% to 2.2% when configured with --enable-checking,
      depending on optimization flags (GCC 4.8.1 x86-64).
    • Paul Eggert's avatar
      Add log2 support and make log10 obsolete for consistency. · 89561f72
      Paul Eggert authored
      * configure.ac (log2): Check for this function.
      * doc/lispref/numbers.texi (Math Functions): Remove obsolete function log10.
      * lisp/subr.el (log10): Move here from C code, and declare as obsolete.
      All uses of (log10 X) replaced with (log X 10).
      * src/floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
      base is 2; this is more accurate.
      (Flog10): Move to Lisp (marked obsolete there).
    • Juanma Barranquero's avatar
      lisp/emacs-lisp/tabulated-list.el: Use defvar-local, setq-local. · 47199123
      Juanma Barranquero authored
      (tabulated-list-format): Fix typo.  Declare with `defvar-local'.
      (tabulated-list-use-header-line, tabulated-list-entries)
      (tabulated-list-padding, tabulated-list-printer)
      (tabulated-list-sort-key): Declare with `defvar-local'.
      (tabulated-list-init-header, tabulated-list-print-fake-header):
      Use `setq-local'.
    • Michael Albinus's avatar
      Fix ChangeLog entry. · 40e90e48
      Michael Albinus authored
    • Michael Albinus's avatar
      * arc-mode.el (archive-mode): Add `archive-write-file' also for · 4a172eab
      Michael Albinus authored
      remote files.  (Bug#14652)
    • Juanma Barranquero's avatar
      lisp/(cus-edit,custom).el: Fix typos; use setq-local, string-match-p, looking-at-p. · d5b27848
      Juanma Barranquero authored
      * lisp/cus-edit.el:
        (custom-commands): Fix typos.
        (custom-display): Fix tooltip text.
        (custom-magic-alist, custom-filter-face-spec, custom-group-members):
        Fix typos in docstrings.
        (custom--initialize-widget-variables, Custom-mode): Use `setq-local'.
        (custom-unlispify-menu-entry, custom-magic-value-create)
        (custom-add-see-also, custom-group-value-create): Use ?\s.
        (custom-guess-type, customize-apropos, editable-field)
        (custom-face-value-create): Use `string-match-p'.
        (custom-save-variables, custom-save-faces): Use `looking-at-p'.
      * lisp/custom.el (custom-load-symbol): Use `string-match-p'.
    • Juanma Barranquero's avatar
    • Paul Eggert's avatar
      * floatfns.c: Add commentary re C99 and C11. · 33cbd259
      Paul Eggert authored
    • Juanma Barranquero's avatar
      lisp/ansi-color.el: Convert to lexical binding. · a5c581d8
      Juanma Barranquero authored
      (ansi-colors): Fix URL.
      (ansi-color-context, ansi-color-context-region): Use defvar-local.
      (ansi-color-apply-sequence, ansi-color-map): Fix typos in docstrings.
      (ansi-color-make-color-map): Rename local var ansi-color-map to map.
    • Juanma Barranquero's avatar
  3. 19 Jun, 2013 4 commits
    • Gnus developers's avatar
      Merge changes made in Gnus master · 970ad972
      Gnus developers authored
      2013-06-19  Lars Magne Ingebrigtsen  <larsi@gnus.org>
      * net/eww.el (eww-process-text-input): Display passwords as asterisks.
      * net/shr.el (shr-make-table-1): Protect against invalid column-spans.
      2013-06-19  Tom Tromey  <tromey@redhat.com>
      * net/eww.el (eww-top-url): Remove.
      (eww-home-url, eww-start-url, eww-contents-url): New defvars.
      (eww-render): Set new variables.  Don't set eww-top-url.
      (eww-handle-link): Handle "prev", "home", and "contents".
      Downcase the rel text.
      (eww-top-url): Choose best top URL.
      2013-06-19  Lars Magne Ingebrigtsen  <larsi@gnus.org>
      * net/eww.el: Rewrite to implement form elements "by hand" instead of
      relying in widget.el.  Using widget.el leads to too many
      user interface inconsistencies.
      (eww-self-insert): Implement entering commands in text fields.
      (eww-process-text-input): New function to make text input field editing
      (eww-submit): Rewrite to use the new-style form methods.
      (eww-select-display): Display the correct selected item.
      (eww-change-select): Implement changing the select value.
      (eww-toggle-checkbox): Implement radio/checkboxes.
      (eww-update-field): Fix compilation error.
      (eww-tag-textarea): Implement <textarea>.
      * net/shr.el (shr-urlify): Use `keymap' instead of `local-map' so that we
      don't shadow mode-specific bindings.
      * net/eww.el (eww-browse-url): Don't push stuff onto history if there's
      nothing to push.
      * net/shr.el (shr-map): Bind [down-mouse-1] to browse URLs.
    • Glenn Morris's avatar
      * lisp/cedet/semantic/idle.el (define-semantic-idle-service): · c5803bd7
      Glenn Morris authored
      No need to use eval-and-compile, progn will do.
      (eval-and-compile ends up causing spurious warnings.)
    • Glenn Morris's avatar
    • Juanma Barranquero's avatar
      Fix typos in ChangeLogs. · 4f405069
      Juanma Barranquero authored