1. 25 Mar, 2019 11 commits
    • Eric Abrahamsen's avatar
      Don't save Gnus' dummy.group to the .newsrc.eld file · a09306d5
      Eric Abrahamsen authored
      * lisp/gnus/gnus-start.el (gnus-gnus-to-quick-newsrc-format): Remove
        the "dummy.group" element.
      a09306d5
    • Eric Abrahamsen's avatar
      Handle multiple possible types for Gnus group names · a8efdd4c
      Eric Abrahamsen authored
      * lisp/gnus/gnus-start.el (gnus-active-to-gnus-format): Numbers,
        symbols, and strings.
      a8efdd4c
    • Paul Eggert's avatar
      Fix a dns-mode reentrancy bug · 6d0f7f70
      Paul Eggert authored
      * lisp/textmodes/dns-mode.el (dns-mode-ipv6-to-nibbles):
      Don’t assume kill-new does no matching.
      6d0f7f70
    • Basil L. Contovounesios's avatar
      Fix non_local_exit_get signature in Elisp manual · 04a228f4
      Basil L. Contovounesios authored
      * doc/lispref/internals.texi (Module Nonlocal): Fix typo in return
      type of non_local_exit_get.
      04a228f4
    • Michael Albinus's avatar
      Explain messages with patches in CONTRIBUTE · ace29fcb
      Michael Albinus authored
      * CONTRIBUTE: A message shall contain the string "[PATCH]" in the
      subject if there's a patch in the message.
      ace29fcb
    • Paul Eggert's avatar
      Support ./configure --with-gif=ifavailable etc. · 97a793cb
      Paul Eggert authored
      Suggested by Stefan Monnier in:
      https://lists.gnu.org/r/emacs-devel/2019-03/msg00789.html
      * INSTALL, etc/NEWS: Document this.
      * configure.ac: Implement this.
      97a793cb
    • Stefan Monnier's avatar
      * lisp/vc/diff-mode.el: Better handle empty lines in context diffs · 49188503
      Stefan Monnier authored
      (diff-end-of-hunk): Obey diff-valid-unified-empty-line for context style.
      (diff--refine-hunk): Don't look further than the end.
      49188503
    • Paul Eggert's avatar
      Fix some integer issues in regex-emacs · b7a98993
      Paul Eggert authored
      Also, remove some duplicate comments related to thread.h.
      * src/regex-emacs.h (struct re_registers):
      * src/regex-emacs.c (SIGN_EXTEND_CHAR): Remove.
      (TALLOC, RETALLOC): Remove.  All uses replaced by usual
      allocators, which check for integer overflow.
      (extract_number): Redo without using ‘unsigned’.
      (CHARSET_RANGE_TABLE_EXISTS_P): Clearly return a boolean.
      (print_fastmap, print_partial_compiled_pattern, CHECK_INFINITE_LOOP)
      (regex_compile, analyze_first, bcmp_translate, mutually_exclusive_p)
      (re_match_2_internal):
      Use bool for booleans.
      (print_fastmap, regex_compile, execute_charset):
      Prefer int to unsigned where either will do.
      (print_double_string): Prefer ptrdiff_t to ssize_t, since the
      latter can in theory be narrower than the former.  Use fwrite
      instead of repeated putchar.
      (emacs_re_max_failures, fail_stack_type, compile_stack_type)
      (re_wctype_parse, regex_compile, re_search, re_search_2)
      (re_match_2, re_match_2_internal, re_compile_pattern):
      Prefer ptrdiff_t to size_t where either will do.
      (union fail_stack_elt, PUSH_FAILURE_REG, POP_FAILURE_REG_OR_COUNT):
      Make the integer an intptr_t, not long.
      (GET_BUFFER_SPACE, EXTEND_BUFFER, regex_compile):
      Use xpalloc to simplify allocation.
      (regex_compile): Check for integer overflow when calculating
      register numbers.
      * src/regex-emacs.c (re_set_registers, re_match_2_internal):
      * src/regex-emacs.h (struct re_registers, struct re_pattern_buffer):
      * src/search.c (Freplace_match):
      Prefer ptrdiff_t to unsigned where either will do.
      * src/regex-emacs.h (struct re_pattern_buffer):
      Prefer bool_bf to unsigned where either will do.
      b7a98993
    • Paul Eggert's avatar
      176ababa
    • João Távora's avatar
      Avoid occasional confusion of Flymake C/C++ backend · 67c3a3af
      João Távora authored
      The regexp would sometimes match non-errors and create a diagnostic
      with nil severity, which would have consequences for the Flymake
      engine (these should eventually be addressed, too).
      
      * lisp/progmodes/flymake-cc.el (flymake-cc--make-diagnostics):
      Tighten regexp.
      67c3a3af
    • João Távora's avatar
      Make bundled Flymake C backend work for C++, too · 8cac2bf0
      João Távora authored
      * lisp/progmodes/flymake-cc.el (flymake-cc-use-special-make-target):
      Pass -x flag according to major-mode.
      8cac2bf0
  2. 24 Mar, 2019 5 commits
  3. 23 Mar, 2019 4 commits
    • Eli Zaretskii's avatar
    • Michael Albinus's avatar
      Fix Bug#34943 · a3194e7b
      Michael Albinus authored
      * lisp/files-x.el (cl-lib): Require when compiling.
      (hack-connection-local-variables): Regard connection-local
      variables as safe.  (Bug#34943)
      
      * lisp/shell.el (shell): Use `with-connection-local-variables' for
      the whole code block.  (Bug#34943)
      
      * lisp/net/tramp-adb.el (tramp-connection-local-safe-shell-file-names):
      Do not set values.
      
      * lisp/net/tramp-integration.el
      (tramp-connection-local-safe-shell-file-names): Remove.
      (shell-file-name, shell-command-switch): Do not add safe-local-variable
      property.
      
      * lisp/net/tramp.el (tramp-handle-shell-command): Use proper
      buffer name.
      
      * test/lisp/net/tramp-tests.el (tramp-test34-explicit-shell-file-name):
      Tag it :unstable.
      a3194e7b
    • Eli Zaretskii's avatar
      Avoid compiler warning in w32proc.c · 86c3cd99
      Eli Zaretskii authored
      * src/w32proc.c (w32_executable_type): Avoid compiler warnings
      about potential NULL pointer dereferencing.
      86c3cd99
    • Michael R. Mauger's avatar
      * lisp/progmodes/sql.el Bug#25424 · 068cbed3
      Michael R. Mauger authored
      (sql-end-of-statement): default terminator as semicolon.
      068cbed3
  4. 22 Mar, 2019 10 commits
    • Stephen Leake's avatar
      Fix bug in delete-indentation when region is inactive · b515edb9
      Stephen Leake authored
      * test/lisp/simple-tests.el: Add tests for delete-indentation.
      (simple-delete-indentation-no-region): Works with no region.
      (simple-delete-indentation-inactive-region): Was broken with inactive
      region; now fixed.
      
      * lisp/simple.el (delete-indentation): Check (use-region-p) before using BEG.
      b515edb9
    • Eric Abrahamsen's avatar
      Change Gnus hash tables into real hash tables · c1b63af4
      Eric Abrahamsen authored
      Gnus has used obarrays as makeshift hash tables for groups: group
      names are coerced to unibyte and interned in custom obarrays, and
      their symbol-value set to whatever value needs to be stored. This
      patch replaces those obarrays with actual hash tables.
      
      * lisp/gnus/gnus-util.el (gnus-intern-safe, gnus-create-hash-size):
        Remove functions.
        (gnus-make-hashtable): Change to return a real hash table.
        (gnus-text-property-search): Utility similar to `text-property-any',
        but compares on `equal'. Needed because the 'gnus-group text
        property is now a string.
      * lisp/gnus/gnus.el (gnus-gethash, gnus-gethash-safe, gnus-sethash):
        Remove macros.
        (gnus-group-list): New variable holding all group names as an
        ordered list. Used because `gnus-newsrc-hashtb' used to preserve
        `gnus-newsrc-alist' ordering, but now doesn't.
      * lisp/gnus/nnmaildir.el (nnmaildir--servers): Change from obarray to
        alist.
        (nnmaildir--up2-1): Remove function.
      * lisp/thingatpt.el (thing-at-point-newsgroup-p): This was making use
        of Gnus obarrays, replace with a cond that can handle many different
        possibilities.
      * lisp/gnus/gnus-bcklg.el (gnus-backlog-articles): Remove
        gnus-backlog-hashtb, which wasn't doing anything. Just keep a list
        of ident strings in gnus-backlog-articles.
        (gnus-backlog-setup): Delete unnecessary function.
        (gnus-backlog-enter-article, gnus-backlog-remove-oldest-article,
        gnus-backlog-remove-article, gnus-backlog-request-article): Alter
        calls accordingly.
      * lisp/gnus/gnus-dup.el (gnus-duplicate-list-max-length): Rename from
        `gnus-duplicate-list-length', for accuracy.
      * lisp/gnus/gnus-start.el (gnus-active-to-gnus-format,
        gnus-groups-to-gnus-format, gnus-newsrc-to-gnus-format): Read group
        names as strings.
        (gnus-gnus-to-quick-newsrc-format): Write `gnus-newsrc-alist' using
        the ordering in `gnus-group-list'.
      * lisp/gnus/gnus-agent.el:
      * lisp/gnus/gnus-async.el:
      * lisp/gnus/gnus-cache.el:
      * lisp/gnus/gnus-group.el:
      * lisp/gnus/gnus-score.el:
      * lisp/gnus/gnus-sum.el:
      * lisp/gnus/gnus-topic.el:
      * lisp/gnus/message.el:
      * lisp/gnus/mml.el:
      * lisp/gnus/nnagent.el:
      * lisp/gnus/nnbabyl.el:
      * lisp/gnus/nnvirtual.el:
      * lisp/gnus/nnweb.el: In all files, change obarrays to hash-tables,
        and swap `gnus-sethash' for `puthash', `gnus-gethash' for `gethash',
        `mapatoms' for `maphash', etc.
      * test/lisp/gnus/gnus-test-headers.el (gnus-headers-make-dependency-table,
        gnus-headers-loop-dependencies): New tests to make sure we're
        building `gnus-newsgroup-dependencies' correctly.
      c1b63af4
    • Michael Albinus's avatar
      Fix Bug#24394, Bug#34172 · 3375d082
      Michael Albinus authored
      * lisp/subr.el (process-file-shell-command):
      Use `with-connection-local-variables'.  Do not set "/bin/sh" for
      remote buffers, trust settings of `shell-file-name'.
      
      * lisp/net/tramp-adb.el (tramp-methods) <adb>:
      * lisp/net/tramp-smb.el (tramp-methods) <smb>:
      Remove `tramp-remote-shell' and `tramp-remote-shell-args'.
      
      * lisp/net/tramp-sh.el (tramp-sh-handle-file-notify-add-watch)
      (tramp-maybe-open-connection): Use proper read syntax for function
      names.
      
      * lisp/net/tramp.el (tramp-handle-shell-command): Do not use shell
      file names from `tramp-methods'.
      Respect `async-shell-command-buffer'.  (Bug#24394, Bug#34172)
      Use `start-file-process-shell-command' and `process-file-shell-command'.
      
      * test/lisp/net/tramp-tests.el (tramp-test32-shell-command):
      Let it run partly for tramp-adb.
      3375d082
    • NicolasPetton's avatar
      Fix the error message when modifying maps in-place (Bug#34941) · 4174409c
      NicolasPetton authored
      * lisp/emacs-lisp/map.el (map-not-inplace): Fix the message of the
      error.
      (map-put!): When signaling map-no-inplace error, output the map that
      cannot be updated inplace.
      4174409c
    • Eli Zaretskii's avatar
      Minor fixes for the last change · 09c220a5
      Eli Zaretskii authored
      * lisp/simple.el (delete-indentation):
      * doc/emacs/indent.texi (Indentation Commands):
      * etc/NEWS: Fix last change.  (Bug#34796)
      09c220a5
    • Łukasz Stelmach's avatar
      If the region is active, join all the lines it spans · 8fa94a1e
      Łukasz Stelmach authored
      * lisp/simple.el (delete-indentation): Join lines in the active region.
      (Bug#34796)
      
      * doc/misc/org.texi: Describe the arguments of delete-indentation.
      
      * etc/NEWS: Mention region support in delete-indentation.
      8fa94a1e
    • Eli Zaretskii's avatar
      Revert "Revert "Revert "Rely on conservative stack scanning to find "emacs_value"s""" · 09d746da
      Eli Zaretskii authored
      This reverts commit 093d3e78,
      which reverted ee7ad83f,
      which reverted 3eb93c07.
      09d746da
    • Federico Tedin's avatar
      Correctly handle packages without description in describe-package · 89fa7c45
      Federico Tedin authored
      * lisp/emacs-lisp/package.el (describe-package-1): Do not call insert
        if package description is nil (Bug#34147).
      89fa7c45
    • Federico Tedin's avatar
      Make edebug-eval-expression support code completion · a0b1c402
      Federico Tedin authored
      * lisp/emacs-lisp/edebug.el (edebug-eval-expression): Use
        read--expression instead of read-from-minibuffer. (Bug#34065)
      a0b1c402
    • Stefan Monnier's avatar
      Fix misuses of NULL when talking about the NUL character · 76fea1eb
      Stefan Monnier authored
      * lisp/subr.el (inhibit-null-byte-detection): Make it an obsolete alias.
      
      * src/coding.c (setup_coding_system): Use new name.
      (detect_coding): Rename null_byte_found => nul_byte_found.
      (detect_coding_system): Use new name.
      Rename null_byte_found => nul_byte_found.
      (Fdefine_coding_system_internal): Use new name.
      (syms_of_coding): Rename inhibit-null-byte-detection to
      inhibit-nul-byte-detection.
      * src/w16select.c (get_clipboard_data): null_char => nul_char.
      * src/json.c (check_string_without_embedded_nuls): Rename from
      check_string_without_embedded_nulls.
      (Fjson_parse_string): Adjust accordingly.
      * src/coding.h (enum define_coding_undecided_arg_index)
      (enum coding_attr_index): ...null_byte... => ...nul_byte....
      * lisp/info.el (info-insert-file-contents, Info-insert-dir):
      * lisp/international/mule.el (define-coding-system):
      * lisp/vc/vc-git.el (vc-git--call):
      * doc/lispref/nonascii.texi (Lisp and Coding Systems): Use the new name.
      76fea1eb
  5. 21 Mar, 2019 8 commits
  6. 20 Mar, 2019 2 commits
    • Glenn Morris's avatar
      Merge from origin/emacs-26 · 1fc6afbd
      Glenn Morris authored
      24b6e6ed (origin/emacs-26) * etc/AUTHORS: Update.
      2f22a179 * ; ChangeLog.3 update
      0f523dee Improve indexing of the user manual
      bd5795e0 Fix url-copy-file arglist
      eaa188a6 ; * admin/notes/bugtracker: Minor additions and updates.
      5ed05fbf Fix downloading updates for packages with non-ASCII descriptions
      e9f2d1f9 * etc/NEWS: Remove temporary markers.
      24fc1337 * doc/misc/cc-mode.texi (Config Basics): in @itemize, @asis -...
      0f325d19 Don't clobber 'comint-input-autoexpand' in 'read-shell-command'
      bc75589b Document restrictions when setting window margins, fringes or...
      cc4cebf5 More improvements for 'read-buffer's doc string
      d026d9ad * lisp/progmodes/cc-defs.el: Update c-version to 5.33.2 for E...
      5dbf08bf * src/minibuf.c (Fread_buffer): Minor doc fixes.  (Bug#34749)
      
      # Conflicts:
      #	etc/NEWS
      #	lisp/url/url-handlers.el
      1fc6afbd
    • Stefan Monnier's avatar
      Eshell: Mostly cosmetic changes to be more explicit about dynbind · 99b3d64e
      Stefan Monnier authored
      * lisp/eshell/em-dirs.el (eshell-dirs-initialize): Reveal the lambdas.
      (eshell-expand-multiple-dots): Fix ^+$ => \`+\' in the regexp.
      
      * lisp/eshell/esh-cmd.el (eshell-this-command-hook): Declare as
      dynamically scoped.
      (eshell-trap-errors): Use `mapc funcall` since this can't have
      global/local settings like a true hook.
      (eshell-do-eval): Split the `let` case from the rest so we can use
      `cl-progv` rather than `eval` for it.
      (eshell/which): Use `fboundp` test instead of ugly
      gymnastics to try and hide the function call from the compiler.
      
      * lisp/eshell/esh-var.el (eshell-variable-aliases-list): Reveal the lambdas.
      (eshell-parse-variable-ref): Use backquotes.
      99b3d64e