1. 28 Jun, 2019 11 commits
    • Mattias Engdegård's avatar
      Correct regexp matching of raw bytes · a1f76adf
      Mattias Engdegård authored
      Make regexp matching of raw bytes work in all combination of unibyte
      and multibyte patterns and targets, as exact strings and in character
      alternatives (bug#3687).
      
      * src/regex-emacs.c (analyze_first):
      Include raw byte in fastmap when pattern is a multibyte exact string.
      Include leading byte in fastmap for raw bytes in character alternatives.
      (re_match_2_internal):
      Decrement the byte count by the number of bytes in the pattern character,
      not 1.
      * test/src/regex-emacs-tests.el (regexp-unibyte-unibyte)
      (regexp-multibyte-unibyte, regexp-unibyte-mutibyte)
      (regexp-multibyte-multibyte): New tests.
      a1f76adf
    • Michael Albinus's avatar
      Tramp requires Emacs 24.4 · aae5bf44
      Michael Albinus authored
      * doc/misc/tramp.texi (Frequently Asked Questions):
      Use `with-eval-after-load'. in example.
      
      * doc/misc/trampver.texi: Set variable emacsver.
      
      * lisp/net/tramp.el (tramp-send-string, tramp-call-process)
      (tramp-call-process-region, tramp-process-lines):
      * lisp/net/tramp-adb.el (tramp-adb-handle-file-truename)
      (tramp-adb-sh-fix-ls-output, tramp-adb-maybe-open-connection):
      * lisp/net/tramp-gvfs.el (tramp-gvfs-get-directory-attributes)
      (tramp-gvfs-handle-file-notify-add-watch)
      * lisp/net/tramp-sh.el (tramp-sh-handle-file-truename)
      (tramp-do-copy-or-rename-file-out-of-band)
      (tramp-sh-handle-file-notify-add-watch, tramp-find-executable)
      (tramp-set-remote-path)
      (tramp-open-connection-setup-interactive-shell)
      (tramp-maybe-open-connection, tramp-send-command):
      * lisp/net/tramp-smb.el (tramp-smb-handle-copy-directory)
      (tramp-smb-handle-file-acl, tramp-smb-handle-process-file)
      (tramp-smb-handle-set-file-acl)
      (tramp-smb-handle-start-file-process)
      (tramp-smb-maybe-open-connection):
      * lisp/net/tramp-sudoedit.el (tramp-sudoedit-handle-set-file-acl):
      (tramp-sudoedit-send-command): Use `string-join' and `string-empty-p'.
      
      * lisp/net/tramp-adb.el:
      * lisp/net/tramp-archive.el:
      * lisp/net/tramp-integration.el:
      * lisp/net/tramp-ftp.el: Use `with-eval-after-load'.
      
      * lisp/net/tramp-cmds.el (tramp-cleanup-connection)
      (tramp-cleanup-all-connections): Cancel timer.
      
      * lisp/net/tramp-compat.el (subr-x): Require.
      (default-toplevel-value): Don't make it a defalias.
      
      * lisp/net/tramp-gvfs.el: Use `dbus-event-error-functions'.  Do
      not special handle `split-string'.
      
      * lisp/net/tramp.el: Require Emacs 24.4.
      (tramp-password-prompt-regexp): Use `password-word-equivalents'.
      (tramp-user-error): Use `user-error'.
      (tramp-replace-environment-variables): Use `substitute-env-vars'.
      (tramp-wait-for-regexp): Rearrange `with-current-buffer' call.
      (tramp-get-local-gid): Use `group-gid'.
      
      * lisp/net/trampver.el: Check for Emacs 24.4.
      
      * test/lisp/net/tramp-tests.el (tramp-test02-file-name-dissect)
      (tramp-test02-file-name-dissect-simplified)
      (tramp-test02-file-name-dissect-separate)
      (tramp-test03-file-name-host-rules)
      (tramp-test03-file-name-method-rules): Don't check for `user-error'.
      aae5bf44
    • Lars Ingebrigtsen's avatar
      Doc fix for Gnus "very wide" reply commands · c534a4a3
      Lars Ingebrigtsen authored
      * lisp/gnus/gnus-msg.el (gnus-summary-very-wide-reply-with-original)
      (gnus-summary-very-wide-reply): Clarify what a "very wide reply" is.
      c534a4a3
    • Lars Ingebrigtsen's avatar
      Revert "Fontify _emphasis_ in info nodes" · 86b28cbb
      Lars Ingebrigtsen authored
      This reverts commit 72963b4e.
      
      The change incorrectly fontified whole sentences as emphasis.
      86b28cbb
    • Lars Ingebrigtsen's avatar
      Include To and Cc headers when forwarding with Message · cfabacae
      Lars Ingebrigtsen authored
      * lisp/gnus/message.el (message-forward-included-headers): Include
      more of the important headers when forwarded: To and Cc.
      cfabacae
    • Michael Albinus's avatar
      * lisp/gnus/gnus-art.el (gnus-article-stop-animations): · 9fec778c
      Michael Albinus authored
      Use `cancel-function-timers'.
      9fec778c
    • Mattias Engdegård's avatar
      More readable regexp debug output · 24a32960
      Mattias Engdegård authored
      * src/regex-emacs.c (debug_putchar): New.
      (print_fastmap, print_partial_compiled_pattern, print_double_string)
      (regex_compile): Use debug_putchar.
      (re_match_2_internal): Add newline.
      24a32960
    • Mattias Engdegård's avatar
      Consistently use stderr for debug output in regexp code · 82172558
      Mattias Engdegård authored
      * src/regex-emacs.c (DEBUG_PRINT, print_fastmap, print_compiled_pattern)
      (print_double_string, regex_compile): Print to stderr instead of stdout.
      82172558
    • Lars Ingebrigtsen's avatar
      Don't inhibit quit in Gnus when prefetching articles · a7682bce
      Lars Ingebrigtsen authored
      * lisp/gnus/gnus-async.el (gnus-async-prefetch-next): Don't
      inhibit quit when running `gnus-async-prefetch-article'.
      a7682bce
    • Alex Branham's avatar
      cb182ce6
    • Ola Nilsson's avatar
      Allow underscore in defun-prompt-regex names for sh-script · fa3af359
      Ola Nilsson authored
      * lisp/progmodes/sh-script.el (defun-prompt-regexp):
      Allow underscore in function names.
      fa3af359
  2. 27 Jun, 2019 24 commits
    • Paul Eggert's avatar
      Improve ‘equal’ and array doc · bdbb390f
      Paul Eggert authored
      * doc/lispref/objects.texi (Array Type): Array sizes are
      nonnegative fixnums, not arbitrary integers.
      (Equality Predicates): Do not say that ‘eq’ equals ‘=’ on bignums.
      Do not imply that ‘equal’ must signal an error on circular lists.
      bdbb390f
    • Paul Eggert's avatar
      2212ab50
    • Pip Cet's avatar
      Remove unnecessary tortoise checks. · 01d6349b
      Pip Cet authored
      * src/fns.c (Fplist_get, Fplist_put, Flax_plist_get)
      (Flax_plist_put, Fplist_member): Remove unnecessary check.
      * src/json.c (lisp_to_json_toplevel_1): Remove unnecessary check.
      01d6349b
    • Paul Eggert's avatar
      Work around Cygwin bug with O_PATH · 4f2b2559
      Paul Eggert authored
      Problem reported by Ken Brown (Bug#36405).
      * src/dired.c, src/fileio.c (O_PATH) [__CYGWIN__]: Undef.
      4f2b2559
    • Paul Eggert's avatar
      Omit a few minor unnecessary range checks · 06d2eb33
      Paul Eggert authored
      Based on Pip Cet’s review (Bug#36370#19).
      * src/fileio.c (Fdo_auto_save):
      * src/image.c (lookup_image):
      * src/textprop.c (Fnext_single_char_property_change):
      Prefer XFIXNUM to XFIXNAT for clarity and consistency with
      neighboring code, and to avoid unnecessary range checks.
      * src/image.c (lookup_image): Omit unnecessary range checks.
      06d2eb33
    • Paul Eggert's avatar
      Improve XFIXNUM cleanup a bit · f59a3f3d
      Paul Eggert authored
      Based on Pip Cet’s review (Bug#36370#13).
      * src/ccl.c (Fccl_execute_on_string): Use clearer indexing.
      * src/dosfns.c (Fint86, Fdos_memput):
      Avoid runtime checks for negative fixnums when debugging.
      This restores the earlier machine code.
      * src/lisp.h (XFIXNUM, XUFIXNUM): Use eassert, not eassume.
      (XFIXNAT): At the start, merely eassert FIXNUMP rather
      than eassuming FIXNATP.  At the end, eassume that the
      result is nonnegative.  This restores help to the compiler
      that the previous patch mistakenly removed.
      f59a3f3d
    • Paul Eggert's avatar
      Clean up use of XFIXNUM etc. · 4893a09c
      Paul Eggert authored
      A few bits of the code were relying on the fact that XFIXNUM,
      XFIXNAT, and XUFIXNUM do something even with arguments that
      are not fixnums/fixnats.  Separate these rare uses out into
      XFIXNUM_RAW and XUFIXNUM_RAW.
      Problem and original patch reported by Pip Cet (Bug#36370).
      * src/ccl.c (Fccl_execute_on_string):
      * src/fileio.c (Finsert_file_contents, a_write)
      (Fdo_auto_save):
      * src/process.c (conv_lisp_to_sockaddr):
      * src/textprop.c (Fnext_single_char_property_change)
      (Fprevious_single_char_property_change)
      (Fnext_property_change, Fnext_single_property_change)
      (Fprevious_property_change)
      (Fprevious_single_property_change):
      Don’t assume fixnums are nonnegative.
      * src/ccl.c (Fccl_execute_on_string):
      Fix range-checking bug if AREF (status, i) is out of int range.
      * src/data.c (arith_driver): Use XFIXNUM_RAW as we want
      efficient garbage if the value is not a fixnum.
      * src/dosfns.c (Fint86, Fdos_memput):
      Check that args are nonnegative.
      * src/image.c (lookup_image): Check that args are in range.
      * src/lisp.h (lisp_h_XHASH): Use XUFIXNUM_RAW, since this
      is for hashing.
      (lisp_h_XFIXNAT, XFIXNAT) [USE_LSB_TAG]: Remove macros.
      (lisp_h_XFIXNUM_RAW, XFIXNUM_RAW) [USE_LSB_TAG]: New macros, with
      the semantics of the old macros without _RAW.
      (XFIXNUM_RAW, XUFIXNUM_RAW): New inline functions, with the
      semantics of the old functions without _RAW.
      (FIXNUMP): Move definition up to avoid forward use.
      (XFIXNUM, XFIXNAT, XUFIXNUM): Use eassume to add a runtime
      check (when debugging) that the argument has the proper form.
      (XFIXNUM, XFIXNAT): Now inline functions only, since they
      refer to their arguments more than once now that they use eassume.
      * src/textprop.c (Fprevious_single_char_property_change):
      Avoid fixnum overflow with invalid input.
      (set_text_properties): Fix unlikely failure
      to validate arguments, by using EQ instead of XFIXNAT.
      * src/w32term.c (w32_draw_glyph_string):
      * src/xterm.c (x_draw_glyph_string):
      Treat negative minimums as 0 rather than as garbage patterns.
      4893a09c
    • Paul Eggert's avatar
      Catch duplicate keywords in image specs · 3502d4c1
      Paul Eggert authored
      * src/image.c (struct image_keyword.count): Now bool, not int,
      since it is either 0 or 1.
      (parse_image_spec, xpm_image_p): Use bool for boolean.
      (parse_image_spec): Fix a bug introduced in
      2011-09-21T17:41:20!eggert@cs.ucla.edu that reported only
      triplicate (or more) keywords, not duplicates.
      3502d4c1
    • Lars Ingebrigtsen's avatar
      a91bdeb1
    • Lars Ingebrigtsen's avatar
      emacsclient: ignore --eval parameters when starting alternate editor · 6fe66134
      Lars Ingebrigtsen authored
      * lib-src/emacsclient.c (fail): If the user said --eval, don't
      pass those arguments to the alternate editor as file names.
      Suggested by a patch from Scott Turner (bug#11474).
      6fe66134
    • Vasilij Schneidermann's avatar
      Allow for retrieving profiler logs after stopping · 9997429c
      Vasilij Schneidermann authored
      * lisp/profiler.el (profiler-cpu-log, profiler-memory-log): New
      variables.
      (profiler-cpu-profile): Work even if the profiler is no longer
      running (bug#22114).
      (profiler-memory-profile): Ditto.
      (profiler-stop): Save the data.
      (profiler-reset): Clear the saved data.
      (profiler-report-cpu, profiler-report-memory): Report on the saved
      data.
      (profiler-report): Save the data here, too.
      9997429c
    • Dan Nicolaescu's avatar
      Include the date in the bzr annotation buffer · b93e5463
      Dan Nicolaescu authored
      * lisp/vc/vc-bzr.el (vc-bzr-annotate-command)
      (vc-bzr-annotate-time)
      (vc-bzr-annotate-extract-revision-at-line): Include a date in the
      bzr annotation buffer (bug#5428).
      b93e5463
    • Stefan Kangas's avatar
      Add new ispell-change-dictionary-hook (Bug#1110) · b98b843a
      Stefan Kangas authored
      * lisp/textmodes/ispell.el (ispell-change-dictionary-hook): New hook.
      (ispell-change-dictionary): Call new hook (bug#1110).
      b98b843a
    • Thierry Volpiatto's avatar
      Add a new regexp variable to control boring winner buffers · f9744d23
      Thierry Volpiatto authored
      * doc/emacs/windows.texi (Window Convenience): Mention it.
      
      * lisp/winner.el (winner-boring-buffers-regexp): New variable.
      
      * lisp/winner.el (winner-set): Use it (bug#11151).
      f9744d23
    • Ken Brown's avatar
      Fix invoking Emacs via a symlink on Cygwin · e51f3284
      Ken Brown authored
      * src/emacs.c (load_pdump) [CYGWIN]: Strip ".exe" suffix.
      e51f3284
    • Lennart Borgman's avatar
      Add more fontification to regexp builder mode · c1234ca9
      Lennart Borgman authored
      * lisp/emacs-lisp/re-builder.el (reb-copy): Work in the presence
      of newlines in the regexps.
      (reb-change-syntax): Use a dedicated history variable.
      (reb-fontify-string-re): Fontify sub-matches.
      (reb-regexp-grouping-backslash, reb-regexp-grouping-construct):
      New faces.
      (reb-string-font-lock-keywords): New variable.
      (reb-mark-non-matching-parenthesis): Match parenthesis.
      (reb-restart-font-lock): New function.
      
      * lisp/emacs-lisp/re-builder.el (reb-mode-map): Add divider some
      dividers (bug#6347).
      c1234ca9
    • Lars Ingebrigtsen's avatar
      Rename displayor to displayer in CEDET · 2fbcda71
      Lars Ingebrigtsen authored
      * doc/misc/sem-user.texi (Idle Completions Mode): Rename
      displayor->displayer throughout.
      (Idle Completions Mode): Ditto.
      
      * lisp/cedet/semantic/complete.el: Rename displayor->displayer
      throughout and add aliases for all the methods that used that name.
      2fbcda71
    • Dmitry Gutov's avatar
      Use `default-indent-new-line' instead of `indent-new-comment-line' · 8a11e430
      Dmitry Gutov authored
      * lisp/simple.el (default-indent-new-line): Doc string fix.
      
      * lisp/textmodes/refill.el (refill-post-command-function): Make
      default-indent-new-line work as indent-new-comment-line.
      
      * lisp/textmodes/refill.el (refill-post-command-function): Bind
      `M-C-j' and `M-j' to default-indent-new-line instead of
      indent-new-comment-line to allow overriding via
      `comment-line-break-function' (bug#12413).
      8a11e430
    • Lars Ingebrigtsen's avatar
      Revert "Apply font-lock in hexl-mode buffers" · 50ade7af
      Lars Ingebrigtsen authored
      This reverts commit 573de396.
      
      The change wasn't necessary -- the hexl-mode buffer is automatically fontified.
      50ade7af
    • Aaron S. Hawley's avatar
      Allow generating wiki and mediawiki tables · d64c72f5
      Aaron S. Hawley authored
      * lisp/textmodes/table.el (table--generate-source-prologue)
      (table--generate-source-epilogue)
      (table--generate-source-scan-rows)
      (table--generate-source-cells-in-a-row): Insert the wiki/mediawiki
      separators.
      
      * lisp/textmodes/table.el (table-source-languages): Add support
      for wiki and mediawiki tables (bug#13287).
      
      2019-06-27  Lars Ingebrigtsen  <larsi@gnus.org>
      
      	* doc/emacs/text.texi (Table Misc): Mention the new wiki and
      	mediawiki formats.
      d64c72f5
    • Wilfred Hughes's avatar
      Apply font-lock in hexl-mode buffers · 573de396
      Wilfred Hughes authored
      * lisp/hexl.el (hexl-mode): After setting font-lock-defaults, we
      need to call `font-lock-ensure' to apply hexl-mode faces
      (bug#24645).
      573de396
    • Juanma Barranquero's avatar
      Add :local specifier to defcustom · e3b70e6b
      Juanma Barranquero authored
      * lisp/custom.el (custom-declare-variable): Allow the new :local
      parameter (bug#14591).
      (defcustom): Document it.
      e3b70e6b
    • Paul Eggert's avatar
      Tweak ‘error’ and ‘user-error’ doc strings · 1d9bb2ff
      Paul Eggert authored
      * lisp/net/tramp.el (tramp-user-error):
      * lisp/subr.el (user-error):
      Say that user errors are sometimes called pilot errors.
      * lisp/subr.el (error, user-error):
      Reorder wording to discuss mechanism first, then formatting advice,
      rather than going back and forth between the two topics.
      Tighten up the wording a bit.
      1d9bb2ff
    • Stefan Kangas's avatar
      Clarify error and user-error docstrings · f90e0c56
      Stefan Kangas authored
      * lisp/subr.el (error, user-error)
      * lisp/net/tramp.el (tramp-user-error): Change "pilot error" to "user
      error" and improve documentation.
      f90e0c56
  3. 26 Jun, 2019 5 commits