1. 27 Dec, 2015 3 commits
    • Deniz Dogan's avatar
      Clear erc user list upon disconnection · a36c8880
      Deniz Dogan authored
      * lisp/erc/erc-backend.el (erc-process-sentinel): Clear channel user
      lists upon disconnection.  This prevents invalid channel
      user lists when reconnecting (bug#10947).
      a36c8880
    • Lars Ingebrigtsen's avatar
      Don't bug out in erc after waking from sleep · ff5f37e5
      Lars Ingebrigtsen authored
      * erc-backend.el (erc-server-send-ping): If the server has
      closed connection, this may already have been detected and
      `erc-server-last-received-time' has been set to nil (bug#13608).
      ff5f37e5
    • Dima Kogan's avatar
      Ensure that we don't have several timers in erc · 2cd894dc
      Dima Kogan authored
      * lisp/erc/erc-backend.el (erc-server-setup-periodical-ping): Checks
      for existing timers in the alist before adding new ones.  If a
      timer already exists, it is cancelled and
      overwritten. (bug#19292).
      2cd894dc
  2. 17 Nov, 2015 1 commit
    • Paul Eggert's avatar
      Fix docstring quoting problems with ‘ '’ · ac16149b
      Paul Eggert authored
      Problem reported by Artur Malabarba in:
      http://lists.gnu.org/archive/html/emacs-devel/2015-11/msg01513.html
      Most of these fixes are to documentation; many involve fixing
      longstanding quoting glitches that are independent of the
      recent substitute-command-keys changes.  The changes to code are:
      * lisp/cedet/mode-local.el (mode-local-augment-function-help)
      (describe-mode-local-overload):
      Substitute docstrings before displaying them.
      * lisp/emacs-lisp/cl-macs.el (cl--transform-lambda):
      Quote the generated docstring for later substitution.
      ac16149b
  3. 13 Nov, 2015 1 commit
  4. 17 Sep, 2015 1 commit
    • Paul Eggert's avatar
      Backslash cleanup in Elisp source files · 284c470e
      Paul Eggert authored
      This patch should not change behavior.  It typically omits backslashes
      where they are redundant (e.g., in the string literal "^\$").
      In a few places, insert backslashes where they make regular
      expressions clearer: e.g., replace "^\*" (equivalent to "^*") with
      "^\\*", which has the same effect as a regular expression.
      Also, use ‘\ %’ instead of ‘\%’ when avoiding confusion with SCCS IDs,
      and similarly use ‘\ $’ instead of ‘\$’ when avoiding confusion with
      RCS IDs, as that makes it clearer that the backslash is intended.
      284c470e
  5. 03 Sep, 2015 1 commit
    • Paul Eggert's avatar
      Fix some more docstring etc. quoting problems · 26bd978d
      Paul Eggert authored
      Mostly these fixes prevent the transliteration of apostrophes
      that should stay apostrophes.  Also, prefer curved quotes in
      Bahá’í proper names, as that’s the preferred Bahá’í style and
      these names are chock-full of non-ASCII characters anyway.
      * lisp/emacs-lisp/eieio-core.el (eieio-defclass-autoload)
      (eieio-defclass-internal):
      * lisp/emacs-lisp/eieio.el (defclass):
      * lisp/hi-lock.el (hi-lock-mode):
      Don’t transliterate Lisp apostrophes when generating a
      doc string or diagnostic.
      * lisp/international/mule-diag.el (list-coding-systems-1):
      * lisp/international/ogonek.el (ogonek-jak, ogonek-how):
      * lisp/mail/sendmail.el (sendmail-query-user-about-smtp):
      * lisp/vc/ediff-mult.el (ediff-redraw-registry-buffer):
      * lisp/vc/ediff-ptch.el (ediff-fixup-patch-map):
      Substitute quotes before putting them in the help buffer.
      26bd978d
  6. 02 Sep, 2015 1 commit
    • Paul Eggert's avatar
      Escape ` and ' in doc · 19532d14
      Paul Eggert authored
      Escape apostrophes and grave accents in docstrings if they are
      are supposed to stand for themselves and are not quotes.  Remove
      apostrophes from docstring examples like ‘'(calendar-nth-named-day
      -1 0 10 year)’ that confuse source code with data.  Do some other
      minor docstring fixups as well, e.g., insert a missing close
      quote.
      19532d14
  7. 31 Aug, 2015 1 commit
    • Paul Eggert's avatar
      Quoting fixes in ERC and Eshell · 244c417a
      Paul Eggert authored
      * lisp/erc/erc-autoaway.el (erc-autoaway-set-away):
      * lisp/erc/erc-backend.el (define-erc-response-handler):
      * lisp/erc/erc-fill.el (erc-fill-static-center):
      * lisp/eshell/em-dirs.el (eshell-save-some-last-dir):
      * lisp/eshell/em-glob.el (eshell-glob-entries):
      * lisp/eshell/em-hist.el (eshell-save-some-history):
      * lisp/eshell/em-unix.el (eshell-remove-entries, eshell/rm)
      (eshell-shuffle-files):
      * lisp/eshell/esh-cmd.el (eshell-do-eval):
      * lisp/eshell/esh-proc.el (eshell-process-interact)
      (eshell-query-kill-processes):
      Respect ‘text-quoting-style’ in diagnostics and doc strings.
      244c417a
  8. 19 May, 2015 1 commit
    • Paul Eggert's avatar
      Fix minor quoting problems in doc strings · 9d35bb8d
      Paul Eggert authored
      These were glitches regardless of how or whether we tackle the
      problem of grave accent in doc strings.
      * lisp/calc/calc-aent.el (math-restore-placeholders):
      * lisp/ido.el (ido-ignore-buffers, ido-ignore-files):
      * lisp/leim/quail/cyrillic.el ("bulgarian-alt-phonetic"):
      * lisp/leim/quail/hebrew.el ("hebrew-new")
      ("hebrew-biblical-sil"):
      * lisp/leim/quail/thai.el ("thai-kesmanee"):
      * lisp/progmodes/idlw-shell.el (idlwave-shell-file-name-chars):
      Used curved quotes to avoid ambiguities like ‘`''’ in doc strings.
      * lisp/calendar/calendar.el (calendar-month-abbrev-array):
      * lisp/cedet/semantic/mru-bookmark.el (semantic-mrub-cache-flush-fcn):
      * lisp/cedet/semantic/symref.el (semantic-symref-tool-baseclass):
      * lisp/cedet/semantic/tag.el (semantic-tag-copy)
      (semantic-tag-components):
      * lisp/cedet/srecode/cpp.el (srecode-semantic-handle-:cpp):
      * lisp/cedet/srecode/texi.el (srecode-texi-texify-docstring):
      * lisp/emacs-lisp/byte-opt.el (byte-optimize-all-constp):
      * lisp/emacs-lisp/checkdoc.el (checkdoc-message-text-engine):
      * lisp/emacs-lisp/generator.el (iter-next):
      * lisp/gnus/gnus-art.el (gnus-treat-strip-list-identifiers)
      (gnus-article-mode-syntax-table):
      * lisp/net/rlogin.el (rlogin-directory-tracking-mode):
      * lisp/net/soap-client.el (soap-wsdl-get):
      * lisp/net/telnet.el (telnet-mode):
      * lisp/org/org-compat.el (org-number-sequence):
      * lisp/org/org.el (org-remove-highlights-with-change)
      (org-structure-template-alist):
      * lisp/org/ox-html.el (org-html-link-org-files-as-html):
      * lisp/play/handwrite.el (handwrite-10pt, handwrite-11pt)
      (handwrite-12pt, handwrite-13pt):
      * lisp/progmodes/f90.el (f90-mode, f90-abbrev-start):
      * lisp/progmodes/idlwave.el (idlwave-mode, idlwave-check-abbrev):
      * lisp/progmodes/verilog-mode.el (verilog-tool)
      (verilog-string-replace-matches, verilog-preprocess)
      (verilog-auto-insert-lisp, verilog-auto-insert-last):
      * lisp/textmodes/makeinfo.el (makeinfo-options):
      * src/font.c (Ffont_spec):
      Fix minor quoting problems in doc strings, e.g., missing quote,
      ``x'' where `x' was meant, etc.
      * lisp/erc/erc-backend.el (erc-process-sentinel-2):
      Fix minor quoting problem in other string.
      * lisp/leim/quail/ethiopic.el ("ethiopic"):
      * lisp/term/tvi970.el (tvi970-set-keypad-mode):
      Omit unnecessary quotes.
      * lisp/faces.el (set-face-attribute, set-face-underline)
      (set-face-inverse-video, x-create-frame-with-faces):
      * lisp/gnus/gnus-group.el (gnus-group-nnimap-edit-acl):
      * lisp/mail/supercite.el (sc-attribs-%@-addresses)
      (sc-attribs-!-addresses, sc-attribs-<>-addresses):
      * lisp/net/tramp.el (tramp-methods):
      * lisp/recentf.el (recentf-show-file-shortcuts-flag):
      * lisp/textmodes/artist.el (artist-ellipse-right-char)
      (artist-ellipse-left-char, artist-vaporize-fuzziness)
      (artist-spray-chars, artist-mode, artist-replace-string)
      (artist-put-pixel, artist-text-see-thru):
      * lisp/vc/ediff-util.el (ediff-submit-report):
      * lisp/vc/log-edit.el (log-edit-changelog-full-paragraphs):
      Use double-quotes rather than TeX markup in doc strings.
      * lisp/skeleton.el (skeleton-pair-insert-maybe):
      Reword to avoid the need for grave accent and apostrophe.
      * lisp/xt-mouse.el (xterm-mouse-tracking-enable-sequence):
      Don't use grave and acute accents to quote.
      9d35bb8d
  9. 14 Jan, 2015 1 commit
  10. 01 Jan, 2015 2 commits
  11. 10 Nov, 2014 1 commit
  12. 09 Nov, 2014 2 commits
  13. 29 Oct, 2014 1 commit
    • Paul Eggert's avatar
      Simplify use of current-time and friends. · 123ddec7
      Paul Eggert authored
      * doc/misc/org.texi (Dynamic blocks):
      * lisp/allout-widgets.el (allout-widgets-hook-error-handler):
      * lisp/calendar/appt.el (appt-display-message):
      * lisp/calendar/icalendar.el (icalendar--convert-float-to-ical):
      * lisp/calendar/timeclock.el (timeclock-in, timeclock-when-to-leave)
      (timeclock-last-period, timeclock-day-base):
      * lisp/eshell/em-ls.el (eshell-ls-file):
      * lisp/eshell/esh-util.el (eshell-parse-ange-ls):
      * lisp/generic-x.el (named-database-print-serial):
      * lisp/net/newst-backend.el (newsticker--get-news-by-url-callback)
      (newsticker-get-news, newsticker--sentinel-work)
      (newsticker--image-get, newsticker--image-sentinel):
      * lisp/net/tramp-sh.el (tramp-get-remote-touch):
      * lisp/progmodes/opascal.el (opascal-debug-log):
      * lisp/textmodes/remember.el (remember-mail-date)
      (remember-store-in-files):
      * lisp/vc/vc-annotate.el (vc-annotate-display-autoscale)
      (vc-default-annotate-current-time):
      * lisp/vc/vc-bzr.el (vc-bzr-shelve-snapshot):
      * lisp/vc/vc-cvs.el (vc-cvs-annotate-current-time):
      * lisp/vc/vc-rcs.el (vc-rcs-annotate-current-time):
      * lisp/url/url-util.el (url-get-normalized-date):
      * lisp/erc/erc-backend.el (TOPIC):
      * lisp/gnus/gnus-delay.el (gnus-delay-article):
      * lisp/gnus/gnus-sum.el (gnus-summary-read-document):
      * lisp/gnus/gnus-util.el (gnus-seconds-today, gnus-seconds-month):
      * lisp/gnus/message.el (message-make-expires-date):
      * lisp/org/org-archive.el (org-archive-subtree)
      (org-archive-to-archive-sibling):
      * lisp/org/org-clock.el (org-resolve-clocks, org-clock-get-sum-start)
      (org-clock-special-range):
      * lisp/org/org-timer.el (org-timer-seconds):
      * lisp/org/org.el (org-read-date-analyze, org-get-cursor-date):
      * lisp/org/ox-html.el (org-html-format-spec):
      * lisp/org/ox-icalendar.el (org-icalendar--vtodo):
      Omit unnecessary call to current-time.
      * lisp/calendar/time-date.el (time-to-seconds) [!float-time]:
      * lisp/calendar/timeclock.el (timeclock-time-to-date):
      * lisp/vc/vc-annotate.el (vc-annotate-convert-time):
      Use current time if arg is nil, to be compatible with float-time.
      (time-date--day-in-year): New function, with most of the guts of
      the old time-to-day-in-year.
      (time-to-day-in-year): Use it.
      (time-to-days): Use it, to avoid decoding the same time stamp twice.
      * lisp/calendar/timeclock.el (timeclock-update-mode-line):
      * lisp/cedet/srecode/args.el (srecode-semantic-handle-:time):
      * lisp/gnus/gnus-util.el (gnus-seconds-year):
      * lisp/org/org.el (org-get-cursor-date):
      Don't call current-time twice to get the current time stamp,
      as this can lead to inconsistent results.
      * lisp/completion.el (cmpl-hours-since-origin):
      * lisp/erc/erc.el (erc-emacs-time-to-erc-time):
      * lisp/ido.el (ido-time-stamp):
      * lisp/vc/vc-annotate.el (vc-annotate-convert-time):
      Simplify by using float-time.
      * lisp/completion.el (save-completions-to-file):
      * lisp/url/url-cache.el (url-cache-prune-cache):
      Rename local var to avoid confusion.
      * lisp/gnus/gnus-util.el (gnus-float-time):
      * lisp/net/rcirc.el (rcirc-float-time):
      * lisp/org/org-compat.el (org-float-time):
      Simplify to an alias because time-to-seconds now behaves like float-time
      with respect to nil arg.
      * lisp/subr.el (progress-reporter-do-update):
      Don't call float-time unless needed.
      * lisp/erc/erc.el (erc-current-time): Simplify by using erc-emacs-time-to-erc-time.
      * lisp/org/org-clock.el (org-clock-get-table-data): Omit unnecessary, lossy
      conversion from floating point to Emacs time and back.
      (org-resolve-clocks): Prefer two-argument floor.
      123ddec7
  14. 19 Jun, 2014 1 commit
  15. 10 Feb, 2014 1 commit
  16. 01 Jan, 2014 1 commit
  17. 19 Sep, 2013 1 commit
    • Glenn Morris's avatar
      Address some "unused lexical argument" warnings in erc · a022856b
      Glenn Morris authored
      * erc/erc.el (erc-open-server-buffer-p): Actually use the `buffer' arg.
      * erc/erc-backend.el (erc-server-process-alive): Take optional `buffer' arg.
      
      * erc/erc-button.el (erc-button-click-button, erc-button-press-button):
      Mark unused arguments.
      a022856b
  18. 30 May, 2013 1 commit
  19. 04 Jan, 2013 1 commit
  20. 01 Jan, 2013 1 commit
  21. 23 Nov, 2012 1 commit
  22. 19 Nov, 2012 1 commit
    • Stefan Monnier's avatar
      Use cl-lib instead of cl, and interactive-p => called-interactively-p. · 19dc7206
      Stefan Monnier authored
      * lisp/erc/erc-track.el, lisp/erc/erc-networks.el, lisp/erc/erc-netsplit.el:
      * lisp/erc/erc-dcc.el, lisp/erc/erc-backend.el: Use cl-lib, nth, pcase, and
      called-interactively-p instead of cl.
      * lisp/erc/erc-speedbar.el, lisp/erc/erc-services.el:
      * lisp/erc/erc-pcomplete.el, lisp/erc/erc-notify.el, lisp/erc/erc-match.el:
      * lisp/erc/erc-log.el, lisp/erc/erc-join.el, lisp/erc/erc-ezbounce.el:
      * lisp/erc/erc-capab.el: Don't require cl since we don't use it.
      * lisp/erc/erc.el: Use cl-lib, nth, pcase, and called-interactively-p i.s.o cl.
      (erc-lurker-ignore-chars, erc-common-server-suffixes): Move before first use.
      * lisp/json.el: Don't require cl since we don't use it.
      * lisp/color.el: Don't require cl.
      (color-complement): `caddr' -> `nth 2'.
      * test/automated/ert-x-tests.el: Use cl-lib.
      * test/automated/ert-tests.el: Use lexical-binding and cl-lib.
      19dc7206
  23. 28 Oct, 2012 1 commit
  24. 18 Oct, 2012 2 commits
  25. 15 Oct, 2012 1 commit
  26. 07 Oct, 2012 1 commit
  27. 06 Oct, 2012 1 commit
  28. 15 Aug, 2012 1 commit
  29. 14 May, 2012 1 commit
  30. 13 May, 2012 1 commit
  31. 09 Apr, 2012 1 commit
  32. 08 Feb, 2012 1 commit
    • Glenn Morris's avatar
      Add missing :version tags for new erc defcustoms. · c4077254
      Glenn Morris authored
      * lisp/erc/erc-backend.el (erc-coding-system-precedence):
      * lisp/erc/erc-join.el (erc-autojoin-delay, erc-autojoin-timing):
      Add missing :version settings.
      
      * etc/NEWS: We don't need to duplicate the doc-strings of variables.
      c4077254
  33. 11 Jan, 2012 1 commit
  34. 05 Jan, 2012 1 commit
  35. 14 Dec, 2011 1 commit