1. 09 Mar, 2008 3 commits
    • Stefan Monnier's avatar
      (bookmark-set): Make the bookmark before reading annotations. · a7e83b26
      Stefan Monnier authored
      I.e. use bookmark-edit-annotation rather than bookmark-read-annotation.
      (bookmark-read-annotation-mode-map, bookmark-annotation-paragraph)
      (bookmark-annotation-buffer, bookmark-annotation-file)
      (bookmark-annotation-point, bookmark-send-annotation)
      (bookmark-read-annotation-mode, bookmark-read-annotation): Remove.
      (bookmark-edit-annotation-text-func): Rename from
      bookmark-read-annotation-text-func.  Keep old name as an obsolete alias.
      (bookmark-edit-annotation-mode-map): Move initialization into declaration.
      a7e83b26
    • Stefan Monnier's avatar
      Add spurious * in docstrings. · fc22668d
      Stefan Monnier authored
      (bookmark-minibuffer-read-name-map): New var.
      (bookmark-set): Use it.  Also pass the default value as it should.
      (bookmark-send-edited-annotation): Take no chances with text properties.
      (bookmark-insert-current-bookmark): Inline bookmark-insert-buffer-name.
      (bookmark-insert-buffer-name): Remove.
      (bookmark-buffer-file-name): Signal an error rather than returning nil.
      fc22668d
    • Stefan Monnier's avatar
      * bookmark.el (bookmark-make): Don't pass the `annotation' to the · 32a091dd
      Stefan Monnier authored
      make-record function, instead paste it in afterwards.
      (bookmark-make-record-for-text-file):
      * doc-view.el (doc-view-bookmark-make-record):
      * info.el (Info-bookmark-make-record): Don't mess with annotations.
      32a091dd
  2. 08 Mar, 2008 1 commit
    • Stefan Monnier's avatar
      * bookmark.el (bookmark-prop-get, bookmark-prop-set): New funs. · 02a5ba27
      Stefan Monnier authored
      (bookmark-get-annotation, bookmark-set-annotation)
      (bookmark-get-filename, bookmark-set-filename, bookmark-get-position)
      (bookmark-set-position, bookmark-get-front-context-string)
      (bookmark-set-front-context-string, bookmark-get-rear-context-string)
      (bookmark-set-rear-context-string, bookmark-get-handler): Use them.
      * info.el (Info-bookmark-make-record): Don't bother recording point.
      (bookmark-get-filename, bookmark-get-front-context-string)
      (bookmark-get-rear-context-string, bookmark-get-position): Don't declare.
      (bookmark-get-info-node): Remove.
      (bookmark-prop-get): Declare.
      (Info-bookmark-jump): Use it.
      02a5ba27
  3. 07 Mar, 2008 4 commits
    • Bastien Guerry's avatar
      * bookmark.el (bookmark-set): Don't check for · f9bf6950
      Bastien Guerry authored
      `bookmark-make-name-function' since `bookmark-buffer-file-name'
      already takes care of this.
      (bookmark-buffer-name): Removed Info-mode specific code.
      (bookmark-buffer-file-name): Removed Info-mode specific code.
      
      * info.el (bookmark-get-info-node): Define this function in
      info.el, not in bookmark.el.
      (Info-mode): Set `bookmark-make-name-function' to
      `Info-bookmark-make-name' locally.
      (Info-bookmark-make-name): New function.
      
      * bookmark.el (bookmark-make-name-function): New variable.
      f9bf6950
    • Karl Fogel's avatar
      * emacs-cvs/lisp/bookmark.el · 9dfcb52e
      Karl Fogel authored
        (bookmark-set): Make `bookmark-make-record-function' buffer-local,
        not `bookmark-make-cell-function' (the old name).
      9dfcb52e
    • Karl Fogel's avatar
      Change a return type, for greater extensibility. See · e0385bf4
      Karl Fogel authored
      http://lists.gnu.org/archive/html/emacs-devel/2007-12/msg01077.html
      and its thread for discussion leading to this change.
      
      * emacs-cvs/lisp/bookmark.el:
      (bookmark-jump-noselect): Return an alist instead of a dotted pair.
      (bookmark-jump, bookmark-jump-other-window, bookmark-insert)
      (bookmark-bmenu-2-window, bookmark-bmenu-other-window)
      (bookmark-bmenu-switch-other-window): Adjust accordingly.
      (bookmark-make-cell-function): Adjust documentation accordingly.
      
      * emacs-cvs/lisp/image-mode.el
      (image-bookmark-jump): Adjust return type accordingly; document.
      
      * emacs-cvs/lisp/doc-view.el
      (doc-view-bookmark-jump): Adjust return type accordingly; document.
      e0385bf4
    • Stefan Monnier's avatar
      * bookmark.el (bookmark-map, bookmark-read-annotation-mode-map): · 79363d93
      Stefan Monnier authored
      Move initialization into declaration.
      (bookmark-get-info-node, bookmark-set-info-node): Remove.
      (bookmark-make, bookmark-make-cell-for-text-file): Remove `info-node' arg.
      (bookmark-info-current-node): Remove.
      (bookmark-jump-noselect): Rename from bookmark-jump-internal.
      Add relocation fallback.  Set bookmark-current-bookmark.
      (bookmark-default-handler): Rename from bookmark-jump-noselect.
      Remove relocation fallback.  Don't set bookmark-current-bookmark.
      (bookmark-set): Let it be used even if there's no buffer-file-name
      as long as there is a bookmark-make-cell-function.
      * info.el (Info-bookmark-jump): Remove relocation fallback.
      Don't set bookmark-current-bookmark.
      79363d93
  4. 07 Jan, 2008 1 commit
  5. 04 Jan, 2008 1 commit
  6. 02 Jan, 2008 1 commit
    • Karl Fogel's avatar
      Change a return type, for greater extensibility. See · 03e26a79
      Karl Fogel authored
      http://lists.gnu.org/archive/html/emacs-devel/2007-12/msg01077.html
      and its thread for discussion leading to this change.
      
      * emacs-cvs/lisp/bookmark.el:
      (bookmark-jump-noselect): Return an alist instead of a dotted pair.
      (bookmark-jump, bookmark-jump-other-window, bookmark-insert)
      (bookmark-bmenu-2-window, bookmark-bmenu-other-window)
      (bookmark-bmenu-switch-other-window): Adjust accordingly.
      (bookmark-make-cell-function): Adjust documentation accordingly.
      
      * emacs-cvs/lisp/image-mode.el
      (image-bookmark-jump): Adjust return type accordingly; document.
      
      * emacs-cvs/lisp/doc-view.el
      (doc-view-bookmark-jump): Adjust return type accordingly; document.
      03e26a79
  7. 26 Dec, 2007 1 commit
    • Tassilo Horn's avatar
      2007-12-26 Tassilo Horn <tassilo@member.fsf.org> · 1666a6b3
      Tassilo Horn authored
      	* bookmark.el (bookmark-make-cell-function): New variable.
      	(bookmark-make): Call bookmark-make-cell-function's function
      	instead of bookmark-make-cell.
      	(bookmark-get-handler, bookmark-jump-internal): New functions.
      	(bookmark-jump, bookmark-jump-other-window, bookmark-insert)
      	(bookmark-bmenu-2-window, bookmark-bmenu-other-window): Use
      	bookmark-jump-internal.
      	(bookmark-make-cell-for-text-file): Renamed from
      	bookmark-make-cell.
      
      	* doc-view.el (doc-view-bookmark-make-cell)
      	(doc-view-bookmark-jump): New functions.
      	(doc-view-mode): Set bookmark-make-cell-function buffer-locally.
      1666a6b3
  8. 25 Sep, 2007 1 commit
  9. 22 Sep, 2007 1 commit
  10. 25 Jul, 2007 1 commit
  11. 17 Jul, 2007 2 commits
  12. 16 Jul, 2007 2 commits
  13. 15 Jul, 2007 1 commit
  14. 13 Jul, 2007 3 commits
  15. 21 Jan, 2007 1 commit
  16. 15 Jan, 2007 1 commit
  17. 06 Feb, 2006 1 commit
  18. 12 Nov, 2005 2 commits
  19. 19 Oct, 2005 1 commit
  20. 18 Oct, 2005 2 commits
  21. 18 Sep, 2005 1 commit
  22. 25 Aug, 2005 1 commit
  23. 24 Aug, 2005 1 commit
  24. 09 Aug, 2005 1 commit
  25. 06 Aug, 2005 1 commit
  26. 26 Jul, 2005 1 commit
    • Juanma Barranquero's avatar
      (bookmark-automatically-show-annotations, bookmark-read-annotation-text-func): Doc fixes. · d32ff76a
      Juanma Barranquero authored
      (bookmark-save): Improve argument/docstring consistency.
      (bookmark-get-bookmark, bookmark-get-bookmark-record,
      bookmark-alist-from-buffer, bookmark-upgrade-file-format-from-0,
      bookmark-grok-file-format-version, bookmark-maybe-upgrade-file-format,
      bookmark-kill-line, bookmark-read-annotation-mode,
      bookmark-insert-current-bookmark, bookmark-jump, bookmark-exit-hook):
      Fix typos in docstrings.
      (bookmark-exit-hooks): Define as obsolete alias.
      (bookmark-exit-hook-internal): Run `bookmark-exit-hook',
      not `bookmark-exit-hooks'.  Fix docstring.
      (bookmark-bmenu-select): "?\ " -> "?\s".
      d32ff76a
  27. 04 Jul, 2005 1 commit
  28. 03 Jul, 2005 1 commit
  29. 26 May, 2005 1 commit