GitLab

 src/xdisp.c (try_window_reusing_current_matrix): Under bidi
 reordering, locate the cursor by calling set_cursor_from_row; if
 that fails, clear the desired glyph matrix before returning a
 failure indication to the caller.  Fixes leaving garbled display
 when fast scrolling with a down-key when scroll-margin is non-zero.

 src/xdisp.c (handle_stop): Detect whether we have overlay strings
 loaded by testing it->current.overlay_string_index to be
 non-negative, instead of checking whether n_overlay_strings is
 positive.

 src/xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
 state after an additional call to move_it_in_display_line_to, keep
 the values of it->max_ascent and it->max_descent found for the
 entire line.
 (pos_visible_p): Revert the comparison against bottom_y to what it
 was in 2012-05-13T18:22:35Z!eliz@gnu.org.

 src/xdisp.c (pos_visible_p): Fix last change.

 src/xdisp.c (pos_visible_p): Don't report a position visible when move_it_to
 stopped at the last line of window, which happens to be scanned
 backwards by the bidi iteration.

 src/xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
 already have overlays loaded.
 (handle_single_display_spec): Before returning without displaying
 fringe bitmap, synchronize the bidi iterator with the main display
 iterator, by calling iterate_out_of_display_property.
 (iterate_out_of_display_property): Detect buffer iteration by
 testing that it->string is a Lisp string.
 (get_next_display_element): When the current object is exhausted,
 and there's something on it->stack, call set_iterator_to_next to
 proceed with what's on the stack, instead of returning zero.
 (set_iterator_to_next): If called at the end of a Lisp string,
 proceed to consider_string_end without incrementing string
 position.  Don't increment display vector index past the end of
 the display vector.

 src/xdisp.c (handle_single_display_spec): Return 1 for left-margin
 and right-margin display specs even if the spec is invalid or we
 are on a TTY, and thus unable to display on the fringes.  That's
 because the text with the property will not be displayed anyway,
 so we need to signal to the caller that this is a "replacing"
 display spec.  This fixes display when the spec is invalid or we
 are on a TTY.

 src/xdisp.c (pos_visible_p): If already at a newline from the
 display string before the 'while' loop, don't walk back the glyphs
 from it3.glyph_row.  Solves assertion violation when the display
 string begins with a newline (egg.el).

 src/xdisp.c (pos_visible_p): If the window start position is beyond
 ZV, start the display from buffer beginning.  Prevents assertion
 violation in init_iterator when the minibuffer window is scrolled
 via the scroll bar.
 src/window.c (window_scroll_pixel_based): Likewise.

 src/xdisp.c (string_buffer_position_lim): Limit starting position to BEGV.
 (set_cursor_from_row): If called for a mode-line or header-line
 row, return zero immediately.
 (try_cursor_movement): If inside continuation line, don't back up
 farther than the first row after the header line, if any.  Don't
 consider the header-line row as "partially visible", even if
 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero.

 src/xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
 "unchanged" if its end.pos is beyond ZV.

 src/xdisp.c (move_it_by_lines): When DVPOS is positive, and the
 position we get to after a call to move_it_to fails the
 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
 only if we wind up in a string from display property.

 src/xdisp.c (move_it_by_lines): Remove the assertion that
 "it->current_x == 0 && it->hpos == 0" which can be legitimately
 violated when there's a before-string at the beginning of a line.
 (Bug#11063)

 src/xdisp.c (set_cursor_from_row): If `cursor' property on a display
 string comes from a `display' text property, use the buffer
 position of that property as if we actually saw that position in
 the row's glyphs.

 src/xdisp.c (append_space_for_newline): If the default face was
 remapped, use the remapped face for the appended newline.
 (extend_face_to_end_of_line): Use the remapped default face for
 extending the face to the end of the line.
 (display_line): Call extend_face_to_end_of_line when the default
 face was remapped.

characters.

* src/dispextern.h (struct it): New member string_from_prefix_prop_p.

* src/xdisp.c (push_prefix_prop): Renamed from push_display_prop.
Mark string as coming from a prefix property.
(handle_face_prop): Use default face for prefix strings.
(pop_it, reseat_1): Save and restore string_from_prefix_prop_p.

Fixes: debbugs:4281

 src/xdisp.c (cursor_row_p): Even if the glyph row ends in a string
 that is not from display property, accept the row as a "cursor
 row" if one of the string's character has a non-nil `cursor'
 property.  Fixes cursor positioning when there are newlines in
 overlay strings, e.g. in icomplete.el.

  src/xdisp.c (redisplay_window): Pass to move_it_vertically the margin in
 pixels, not in screen lines.

 src/xdisp.c (redisplay_window, next_element_from_string): Fix typos in
 comments.

 src/xdisp.c (try_window_reusing_current_matrix): Don't move cursor
 position past the first glyph_row that ends at ZV.

 src/xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
 push_it before setting up the iterator for the first overlay
 string, even if we have an empty string loaded.
 (next_overlay_string): If there's an empty string on the iterator
 stack, pop the stack.

* src/xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
as that creates a dangerous corner case.

 src/xdisp.c (rows_from_pos_range): Handle the case where the
 highlight ends on a newline.
 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
 he end column for display of highlight that ends on a newline
 before a R2L line.

 src/xdisp.c (rows_from_pos_range): Accept additional argument
 DISP_STRING, and accept any glyph in a row whose object is that
 string as eligible for mouse highlight.  Fixes mouse highlight of
 display strings from overlays.

* xdisp.c (note_mouse_highlight): Initialize `area'.  (Bug#9947)

* xdisp.c (fill_composite_glyph_string): Always set s->face, to
avoid a crash (bug#9496).

* xdisp.c (note_mouse_highlight): Fix use of uninitialized var.

* xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
possible random value that matches one of those tested as
condition to clear the mouse face.

 src/xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
 to the doc string advising against its use for altering the way
 windows are scrolled.

 src/xdisp.c (handle_invisible_prop): Handle correctly an invisible
 property that ends at ZV, so that the bidi iteration could be
 resumed from there (after widening).