GitLab

(WORDCHAR_P): Likewise.  This one is never needed, but is used
only in a comment talking about a compiler bug, so put inside
the #if 0 of that comment.
(CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
(PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
Remove; unused.

which gcc can warn about.

Remove unused local vars.

Rename locals to avoid shadowing.
(regex_compile, re_match_2_internal): Move locals to avoid shadowing.

* character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE): Likewise.

* lisp.h: ... to here, so that it can be checked.
(struct re_registers): New forward decl.

All uses changed.
(MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
Rename locals to avoid shadowing.

Rename locals to avoid shadowing.

An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
dired.c's scmp function, had undefined behavior.
* lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
(NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
* buffer.h: ... to here, because these macros use current_buffer,
and the new implementation with inline functions needs to have
current_buffer in scope now, rather than later when the macros
are used.
(downcase, upcase1): New static inline functions.
(DOWNCASE, UPCASE1): Reimplement using these functions.
This avoids undefined behavior in expressions like
DOWNCASE (x) == DOWNCASE (y), which previously suffered
from race conditions in accessing the global variables
case_temp1 and case_temp2.
* casetab.c (case_temp1, case_temp2): Remove; no longer needed.
* lisp.h (case_temp1, case_temp2): Remove their decls.
* character.h (ASCII_CHAR_P): Move from here ...
* lisp.h: ... to here, so that the inline functions mentioned
above can use them.

Rename locals to avoid shadowing.

signedness issues.

(Fexpand_file_name): Likewise.  In particular, newdir might
point at constant storage, so make it a const pointer.

(barf_or_query_if_file_exists, auto_save_error, auto_save_1):
Now static.

to avoid shadowing.

so that gcc does not warn that these functions aren't declared.

(reset_var_on_error, Fcombine_after_change_execute_1): Now static.

(fix_start_end_in_overlays): Likewise.  This function should be
simplified by using pointers-to-pointers, but that's a different
matter.

(report_overlay_modification): Rename locals to avoid shadowing.

to suppress a gcc -Wclobbered warning that does not seem to be right.