1. 22 Mar, 2019 9 commits
    • Eric Abrahamsen's avatar
      Change Gnus hash tables into real hash tables · c1b63af4
      Eric Abrahamsen authored
      Gnus has used obarrays as makeshift hash tables for groups: group
      names are coerced to unibyte and interned in custom obarrays, and
      their symbol-value set to whatever value needs to be stored. This
      patch replaces those obarrays with actual hash tables.
      
      * lisp/gnus/gnus-util.el (gnus-intern-safe, gnus-create-hash-size):
        Remove functions.
        (gnus-make-hashtable): Change to return a real hash table.
        (gnus-text-property-search): Utility similar to `text-property-any',
        but compares on `equal'. Needed because the 'gnus-group text
        property is now a string.
      * lisp/gnus/gnus.el (gnus-gethash, gnus-gethash-safe, gnus-sethash):
        Remove macros.
        (gnus-group-list): New variable holding all group names as an
        ordered list. Used because `gnus-newsrc-hashtb' used to preserve
        `gnus-newsrc-alist' ordering, but now doesn't.
      * lisp/gnus/nnmaildir.el (nnmaildir--servers): Change from obarray to
        alist.
        (nnmaildir--up2-1): Remove function.
      * lisp/thingatpt.el (thing-at-point-newsgroup-p): This was making use
        of Gnus obarrays, replace with a cond that can handle many different
        possibilities.
      * lisp/gnus/gnus-bcklg.el (gnus-backlog-articles): Remove
        gnus-backlog-hashtb, which wasn't doing anything. Just keep a list
        of ident strings in gnus-backlog-articles.
        (gnus-backlog-setup): Delete unnecessary function.
        (gnus-backlog-enter-article, gnus-backlog-remove-oldest-article,
        gnus-backlog-remove-article, gnus-backlog-request-article): Alter
        calls accordingly.
      * lisp/gnus/gnus-dup.el (gnus-duplicate-list-max-length): Rename from
        `gnus-duplicate-list-length', for accuracy.
      * lisp/gnus/gnus-start.el (gnus-active-to-gnus-format,
        gnus-groups-to-gnus-format, gnus-newsrc-to-gnus-format): Read group
        names as strings.
        (gnus-gnus-to-quick-newsrc-format): Write `gnus-newsrc-alist' using
        the ordering in `gnus-group-list'.
      * lisp/gnus/gnus-agent.el:
      * lisp/gnus/gnus-async.el:
      * lisp/gnus/gnus-cache.el:
      * lisp/gnus/gnus-group.el:
      * lisp/gnus/gnus-score.el:
      * lisp/gnus/gnus-sum.el:
      * lisp/gnus/gnus-topic.el:
      * lisp/gnus/message.el:
      * lisp/gnus/mml.el:
      * lisp/gnus/nnagent.el:
      * lisp/gnus/nnbabyl.el:
      * lisp/gnus/nnvirtual.el:
      * lisp/gnus/nnweb.el: In all files, change obarrays to hash-tables,
        and swap `gnus-sethash' for `puthash', `gnus-gethash' for `gethash',
        `mapatoms' for `maphash', etc.
      * test/lisp/gnus/gnus-test-headers.el (gnus-headers-make-dependency-table,
        gnus-headers-loop-dependencies): New tests to make sure we're
        building `gnus-newsgroup-dependencies' correctly.
      c1b63af4
    • Michael Albinus's avatar
      Fix Bug#24394, Bug#34172 · 3375d082
      Michael Albinus authored
      * lisp/subr.el (process-file-shell-command):
      Use `with-connection-local-variables'.  Do not set "/bin/sh" for
      remote buffers, trust settings of `shell-file-name'.
      
      * lisp/net/tramp-adb.el (tramp-methods) <adb>:
      * lisp/net/tramp-smb.el (tramp-methods) <smb>:
      Remove `tramp-remote-shell' and `tramp-remote-shell-args'.
      
      * lisp/net/tramp-sh.el (tramp-sh-handle-file-notify-add-watch)
      (tramp-maybe-open-connection): Use proper read syntax for function
      names.
      
      * lisp/net/tramp.el (tramp-handle-shell-command): Do not use shell
      file names from `tramp-methods'.
      Respect `async-shell-command-buffer'.  (Bug#24394, Bug#34172)
      Use `start-file-process-shell-command' and `process-file-shell-command'.
      
      * test/lisp/net/tramp-tests.el (tramp-test32-shell-command):
      Let it run partly for tramp-adb.
      3375d082
    • NicolasPetton's avatar
      Fix the error message when modifying maps in-place (Bug#34941) · 4174409c
      NicolasPetton authored
      * lisp/emacs-lisp/map.el (map-not-inplace): Fix the message of the
      error.
      (map-put!): When signaling map-no-inplace error, output the map that
      cannot be updated inplace.
      4174409c
    • Eli Zaretskii's avatar
      Minor fixes for the last change · 09c220a5
      Eli Zaretskii authored
      * lisp/simple.el (delete-indentation):
      * doc/emacs/indent.texi (Indentation Commands):
      * etc/NEWS: Fix last change.  (Bug#34796)
      09c220a5
    • Łukasz Stelmach's avatar
      If the region is active, join all the lines it spans · 8fa94a1e
      Łukasz Stelmach authored
      * lisp/simple.el (delete-indentation): Join lines in the active region.
      (Bug#34796)
      
      * doc/misc/org.texi: Describe the arguments of delete-indentation.
      
      * etc/NEWS: Mention region support in delete-indentation.
      8fa94a1e
    • Eli Zaretskii's avatar
      Revert "Revert "Revert "Rely on conservative stack scanning to find "emacs_value"s""" · 09d746da
      Eli Zaretskii authored
      This reverts commit 093d3e78,
      which reverted ee7ad83f,
      which reverted 3eb93c07.
      09d746da
    • Federico Tedin's avatar
      Correctly handle packages without description in describe-package · 89fa7c45
      Federico Tedin authored
      * lisp/emacs-lisp/package.el (describe-package-1): Do not call insert
        if package description is nil (Bug#34147).
      89fa7c45
    • Federico Tedin's avatar
      Make edebug-eval-expression support code completion · a0b1c402
      Federico Tedin authored
      * lisp/emacs-lisp/edebug.el (edebug-eval-expression): Use
        read--expression instead of read-from-minibuffer. (Bug#34065)
      a0b1c402
    • Stefan Monnier's avatar
      Fix misuses of NULL when talking about the NUL character · 76fea1eb
      Stefan Monnier authored
      * lisp/subr.el (inhibit-null-byte-detection): Make it an obsolete alias.
      
      * src/coding.c (setup_coding_system): Use new name.
      (detect_coding): Rename null_byte_found => nul_byte_found.
      (detect_coding_system): Use new name.
      Rename null_byte_found => nul_byte_found.
      (Fdefine_coding_system_internal): Use new name.
      (syms_of_coding): Rename inhibit-null-byte-detection to
      inhibit-nul-byte-detection.
      * src/w16select.c (get_clipboard_data): null_char => nul_char.
      * src/json.c (check_string_without_embedded_nuls): Rename from
      check_string_without_embedded_nulls.
      (Fjson_parse_string): Adjust accordingly.
      * src/coding.h (enum define_coding_undecided_arg_index)
      (enum coding_attr_index): ...null_byte... => ...nul_byte....
      * lisp/info.el (info-insert-file-contents, Info-insert-dir):
      * lisp/international/mule.el (define-coding-system):
      * lisp/vc/vc-git.el (vc-git--call):
      * doc/lispref/nonascii.texi (Lisp and Coding Systems): Use the new name.
      76fea1eb
  2. 21 Mar, 2019 8 commits
  3. 20 Mar, 2019 13 commits
  4. 19 Mar, 2019 10 commits
    • Juri Linkov's avatar
      * lisp/vc/vc.el (vc-diff-build-argument-list-internal): Add arg fileset. · b2dd61ff
      Juri Linkov authored
      (vc-root-version-diff): Set vc-diff-build-argument-list-internal's
      optional arg 'fileset' to the root directory.  (Bug#34532)
      b2dd61ff
    • Juri Linkov's avatar
      * lisp/frame.el (frame-monitor-attributes): Fall back to the last monitor · ded3c8de
      Juri Linkov authored
      when frames monitor attributes is still uninitialized.  (Bug#34680)
      ded3c8de
    • Juri Linkov's avatar
      * lisp/frame.el (make-frame-on-monitor): Don't set height and width. · 2c541d84
      Juri Linkov authored
      Don't use x-parse-geometry.  Delete nil from completions (Bug#34516)
      2c541d84
    • Paul Eggert's avatar
      Use ‘const’ to clarify GC marking · 53914a10
      Paul Eggert authored
      Add ‘const’ to make the GC marking code a bit clearer.
      This can also help the compiler in some cases, I think because
      GCC can now determine more often that the value of a static C
      variable can be cached when its address is now converted to
      ‘Lisp Object const *’ before escaping.
      * src/alloc.c (staticvec, mark_maybe_objects, mark_memory)
      (mark_stack, staticpro, mark_object_root_visitor)
      (garbage_collect_1):
      * src/pdumper.c (dump_ptr_referrer, dump_emacs_reloc_to_lv)
      (dump_emacs_reloc_to_emacs_ptr_raw, dump_root_visitor):
      * src/lisp.h (vcopy, struct gc_root_visitor):
      * src/sysdep.c (stack_overflow):
      * src/thread.c (mark_one_thread):
      * src/thread.h (struct thread_state):
      Use pointer-to-const instead of plain pointer in some
      GC-related places where either will do.
      53914a10
    • Mattias Engdegård's avatar
      Disallow reversed char ranges in `rx' · 3ed1621d
      Mattias Engdegård authored
      (any "a-Z0-9") generated "[0-9]", and (any (?9 . ?0)) generated "[9-0]".
      Reversed ranges are either mistakes or abuse.  Neither should be allowed.
      
      etc/NEWS: Explain the change.
      lisp/emacs-lisp/rx.el (rx): Document.
      (rx-check-any-string, rx-check-any): Add error checks for reversed ranges.
      test/lisp/emacs-lisp/rx-tests.el (rx-char-any-range-bad): New test.
      3ed1621d
    • Basil L. Contovounesios's avatar
      Fix url-copy-file arglist · bd5795e0
      Basil L. Contovounesios authored
      * lisp/url/url-handlers.el: Silence byte-compiler.
      (url-copy-file): Add 6th argument following change to copy-file in
      2012-12-16T19:22:27+01:00!romain@orebokech.com. (bug#4410)
      bd5795e0
    • Eli Zaretskii's avatar
      eaa188a6
    • Eli Zaretskii's avatar
      Fix downloading updates for packages with non-ASCII descriptions · 5ed05fbf
      Eli Zaretskii authored
      * lisp/emacs-lisp/package.el (package--download-one-archive):
      Make sure archive contents are written using UTF-8 encoding.
      (Bug#34909)
      (list-packages): Set buffer's encoding to UTF-8.
      5ed05fbf
    • Paul Eggert's avatar
      Remove buggy regexp use in comint-output-filter · c0936672
      Paul Eggert authored
      This reverts commit 2012-07-02T16:18:02!monnier@iro.umontreal.ca
      which perhaps could be rethought and recommitted, and perhaps
      it’s no longer needed now that comint-use-prompt-regexp
      is almost always nil.
      * lisp/comint.el (comint-output-filter): Don’t try to skip
      repeated prompts, since comint-prompt-regexp typically begins
      with "^" and the resulting "^^" in the regular expression does
      not have the desired effect.  Noted by Mattias Engdegård in:
      https://lists.gnu.org/r/emacs-devel/2019-03/msg00380.html
      c0936672
    • Paul Eggert's avatar
      Fix more regular expression typos · bc2a93d5
      Paul Eggert authored
      Problem reported by Mattias Engdegård in:
      https://lists.gnu.org/r/emacs-devel/2019-03/msg00548.html
      except that I didn’t address the issues involving Hebrew,
      or involving comint-prompt-regexp.
      * lisp/align.el (align-rules-list, align-exclude-rules-list):
      * lisp/auth-source-pass.el (auth-source-pass--parse-secret)
      (auth-source-pass--parse-data):
      * lisp/cedet/data-debug.el (data-debug-next)
      (data-debug-prev, data-debug-expand-or-contract):
      * lisp/comint.el (comint-within-quotes):
      * lisp/emacs-lisp/checkdoc.el (checkdoc-this-string-valid-engine):
      * lisp/emulation/viper-ex.el (ex-cmd-complete):
      * lisp/gnus/gnus-cite.el (gnus-message-search-citation-line):
      * lisp/gnus/nnir.el (nnir-imap-end-of-input):
      * lisp/mail/mail-extr.el (mail-extr-all-letters):
      * lisp/minibuffer.el (minibuffer-maybe-quote-filename):
      * lisp/nxml/rng-nxml.el (rng-complete-tag)
      (rng-complete-end-tag, rng-complete-attribute-name):
      * lisp/obsolete/vip.el (vip-get-ex-token, vip-get-ex-pat):
      * lisp/org/org-pcomplete.el (org-thing-at-point):
      * lisp/org/org.el (org-set-tags)
      (org-increase-number-at-point)
      (org-fill-line-break-nobreak-p):
      * lisp/pcomplete.el (pcomplete-parse-comint-arguments):
      * lisp/progmodes/ada-mode.el (ada-compile-goto-error):
      * lisp/progmodes/cperl-mode.el (cperl-highlight-charclass)
      (cperl-find-pods-heres, cperl-not-bad-style-regexp)
      (cperl-regext-to-level-start):
      * lisp/progmodes/ebnf-yac.el (ebnf-yac-skip-spaces):
      * lisp/progmodes/flymake-proc.el (flymake-proc-master-tex-init):
      * lisp/progmodes/flymake.el (flymake-diag-region):
      * lisp/progmodes/fortran.el (fortran-current-line-indentation):
      * lisp/progmodes/idlw-complete-structtag.el:
      (idlwave-complete-structure-tag):
      * lisp/progmodes/idlwave.el (idlwave-complete-sysvar-or-tag):
      * lisp/progmodes/prolog.el (prolog-pred-end)
      (prolog-clause-info):
      * lisp/progmodes/ruby-mode.el (ruby-forward-sexp)
      (ruby-backward-sexp):
      * lisp/progmodes/verilog-mode.el (verilog-repair-open-comma):
      * lisp/term.el (term-within-quotes):
      * lisp/textmodes/bib-mode.el (bib-capitalize-title-stop-words):
      * lisp/textmodes/refbib.el (r2b-capitalize-title-stop-words):
      * lisp/textmodes/reftex-parse.el (reftex-nth-arg):
      * lisp/textmodes/rst.el (rst-svn-rev):
      * lisp/url/url-http.el (url-http-parse-response):
      * test/lisp/progmodes/f90-tests.el (f90-test-bug3730):
      Fix regular expression typos.
      bc2a93d5