1. 25 Apr, 2019 3 commits
    • Stephen Leake's avatar
      Add new file completion tables, change project.el to allow using them · d2a5283a
      Stephen Leake authored
      * lisp/file-complete-root-relative.el: New file.
      
      * lisp/uniquify-files.el: New file.
      
      * test/lisp/progmodes/uniquify-files-resources/: New directory
      containing files for testing uniquify-files.
      
      * test/lisp/progmodes/uniquify-files-test.el: New file; test
      uniquify-files.
      
      * lisp/files.el (path-files): New function; useful with new completion
      tables.
      
      * lisp/progmodes/project.el (project-file-completion-table): Use
      file-complete-root-relative completion table.
      (project-find-file): Add optional FILENAME parameter.
      (project--completing-read-strict): Rewrite to just use the given
      completion table; extracting the common directory is now done by
      file-complete-root-relative. This also allows using the new
      uniquify-files completion table.
      
      * lisp/minibuffer.el (completion-category-defaults): Add
      uniquify-file.
      (completing-read-default): Add final step to call completion table
      with 'alist action if supported.
      d2a5283a
    • Stephen Berman's avatar
      Make wdired-mode ignore ls file indicators · 6d8e0fc5
      Stephen Berman authored
      * lisp/wdired.el (wdired--restore-dired-filename-prop): When
      dired-listing-switches includes "F" or "classify", don't treat
      appended indicator characters as part of the file name (bug#34915).
      
      * test/lisp/wdired-tests.el (wdired-test-bug34915): New test.
      6d8e0fc5
    • Michael R. Mauger's avatar
      * lisp/progmodes/sql.el · a1386fa6
      Michael R. Mauger authored
      (sql-is-sqli-buffer-p): New function.
      (sql-generate-unique-sqli-buffer-name): Refactor and use it.
      (sql-product-interactive): Simplify name logic.
      * test/lisp/progmodes/sql-tests.el
      (sql-tests-placeholder-filter-harness): New macro.
      (sql-tests-placeholder-filter-simple)
      (sql-tests-placeholder-filter-ampersand)
      (sql-tests-placeholder-filter-period): Refactored tests and use macro.
      (sql-tests-buffer-naming-harness): New macro.
      (sql-tests-buffer-naming-default)
      (sql-tests-buffer-naming-multiple)
      (sql-tests-buffer-naming-explicit)
      (sql-tests-buffer-naming-universal-argument)
      (sql-tests-buffer-naming-existing): New tests.
      a1386fa6
  2. 22 Apr, 2019 1 commit
    • Michael Albinus's avatar
      Some changes in tramp-tests · 02894982
      Michael Albinus authored
      * test/lisp/net/tramp-tests.el (tramp-test32-shell-command):
      Check for backward compatibility.
      (tramp-test33-environment-variables): Apply a better check for
      unset variable.
      02894982
  3. 21 Apr, 2019 1 commit
    • Michael R. Mauger's avatar
      * lisp/progmodes.sql.el · 23d8cfb9
      Michael R. Mauger authored
      (sql-product-alist): Corrected :terminator defns.
      (sql-debug-send): New variable.
      (sql-send-string): Use it and correct buffer context.
      (sql-send-magic-terminator): Use `sql-input-sender'.
      (sql-placeholders-filter): Bug#11481 Don't recursively replace placeholders
      * test/lisp/progmodes/sql-tests.el
      (sql-test-placeholder-filter): Test placeholder functionality.
      23d8cfb9
  4. 20 Apr, 2019 1 commit
  5. 19 Apr, 2019 4 commits
    • Philipp Stephani's avatar
      Make warning about unescaped character literals more helpful. · 0b4b380c
      Philipp Stephani authored
      See Bug#31676.
      
      * lisp/emacs-lisp/byte-run.el
      (byte-run--unescaped-character-literals-warning): New defun.
      
      * src/lread.c (load_warn_unescaped_character_literals): Use new defun.
      (syms_of_lread): Define symbol for new defun.
      
      * lisp/emacs-lisp/bytecomp.el (byte-compile-from-buffer): Use new
      defun.
      
      * test/src/lread-tests.el (lread-tests--unescaped-char-literals):
      test/lisp/emacs-lisp/bytecomp-tests.el
      (bytecomp-tests--unescaped-char-literals): Adapt unit tests.
      0b4b380c
    • Michael Albinus's avatar
      ; Remove instrumentation in tramp-tests · 0eb47c25
      Michael Albinus authored
      0eb47c25
    • Michael Albinus's avatar
      Adapt tramp-test32-shell-command · 3ff7d732
      Michael Albinus authored
      * test/lisp/net/tramp-tests.el (tramp-test32-shell-command):
      Check "tput" before running `shell-command-width' test.
      3ff7d732
    • Philipp Stephani's avatar
      Add a new user option 'ido-big-directories'. · f5e3c2cc
      Philipp Stephani authored
      This provides an alternative to 'ido-max-directory-size', for
      directories that are statically known to be too big for Ido
      completion.
      
      * lisp/ido.el (ido-big-directories): New user option.
      (ido-directory-too-big-p): Use it.
      
      * test/lisp/ido-tests.el (ido-directory-too-big-p): New unit test.
      f5e3c2cc
  6. 18 Apr, 2019 2 commits
  7. 17 Apr, 2019 7 commits
  8. 14 Apr, 2019 1 commit
  9. 13 Apr, 2019 2 commits
    • Michael Albinus's avatar
      Fix last patch · bfa9e745
      Michael Albinus authored
      bfa9e745
    • Michael Albinus's avatar
      Replace (skip-unless nil) by tag :unstable in test packages · ae21fb3d
      Michael Albinus authored
      * test/lisp/filenotify-tests.el (file-notify--deftest-remote):
      Use tag :unstable if SKIP is non-nil.
      
      * test/lisp/net/tramp-tests.el (tramp-test36-vc-registered):
      Use ert-skip instead of (skip-unless nil).
      
      * test/lisp/progmodes/python-tests.el
      (python-tests--python-nav-end-of-statement--infloop): Use tag
      :unstable instead of (skip-unless nil).
      ae21fb3d
  10. 12 Apr, 2019 1 commit
    • Basil L. Contovounesios's avatar
      Move proper-list-p tests to fns-tests.el · 0c4c96d7
      Basil L. Contovounesios authored
      This follows the move of proper-list-p from lisp/subr.el to
      src/fns.c in 2018-07-24T15:58:46-07:00!eggert@cs.ucla.edu.
      * test/lisp/subr-tests.el (subr-tests--proper-list-p): Move from
      here...
      * test/src/fns-tests.el (test-proper-list-p): ...to here.
      0c4c96d7
  11. 10 Apr, 2019 1 commit
  12. 07 Apr, 2019 1 commit
    • Basil L. Contovounesios's avatar
      Distinguish buttons from widgets (bug#34506) · 08235af3
      Basil L. Contovounesios authored
      * lisp/button.el (button-at):
      * lisp/wid-edit.el (widget-at): Avoid returning a false positive
      when looking for a button and finding a widget, or vice versa.
      * test/lisp/button-tests.el:
      * test/lisp/wid-edit-tests.el: New files.
      08235af3
  13. 05 Apr, 2019 1 commit
    • Michael Albinus's avatar
      Adapt tramp-tests.el · f2d22273
      Michael Albinus authored
      * test/lisp/net/tramp-tests.el (tramp-test30-make-process):
      Instrument test.  Adapt check string.
      (tramp-test34-explicit-shell-file-name)
      (tramp-test43-asynchronous-requests): Skip tests for tramp-adb
      with older Emacsen.
      f2d22273
  14. 04 Apr, 2019 1 commit
  15. 03 Apr, 2019 3 commits
    • Michael Albinus's avatar
      Work on asynchronous processes for tramp-adb.el · 8147d3c2
      Michael Albinus authored
      * lisp/net/tramp-adb.el (tramp-adb-handle-make-process):
      Simplify.  Remove echoed first line.
      (tramp-adb-send-command): Add NEVEROPEN and NOOUTPUT.
      
      * lisp/net/tramp-sh.el (tramp-process-sentinel): Remove.
      (tramp-sh-handle-make-process): Simplify.
      
      * lisp/net/tramp.el (tramp-process-sentinel): New defun, taken from
      tramp-sh.el.  Delete trailing shell prompt.
      
      * test/lisp/net/tramp-tests.el (tramp-test29-start-file-process)
      (tramp-test30-make-process): Run also for tramp-adb.
      (tramp-test32-shell-command): Remove tramp-adb restrictions.
      (tramp-test34-explicit-shell-file-name): Rework.  Remove :unstable tag.
      8147d3c2
    • Glenn Morris's avatar
      * test/lisp/progmodes/flymake-tests.el (different-diagnostic-types): · ce9490cb
      Glenn Morris authored
      Expect failure on hydra.nixos.
      ce9490cb
    • Glenn Morris's avatar
      ; Copyright years and license copyedits · 39c0795e
      Glenn Morris authored
      39c0795e
  16. 31 Mar, 2019 1 commit
    • Basil L. Contovounesios's avatar
      Fix recently extended delete-indentation behavior · 0cd250e9
      Basil L. Contovounesios authored
      * doc/lispref/text.texi (User-Level Deletion): Document new optional
      arguments of delete-indentation.
      
      * lisp/simple.el (delete-indentation): Do not barf if called
      interactively when region is inactive. (bug#35021)
      Do not skip blank lines. (bug#35036)
      Consistently deactivate mark even when no text was changed.
      Handle active region spanning a single line.
      
      * test/lisp/simple-tests.el (simple-test--buffer-substrings):
      New convenience function.
      (simple-test--dummy-buffer, simple-test--transpositions): Use it.
      (simple-delete-indentation-no-region)
      (simple-delete-indentation-inactive-region): Update commentary.
      Call delete-indentation interactively when testing for behavior with
      inactive region and region is not explicitly defined.
      (simple-delete-indentation-blank-line)
      (simple-delete-indentation-boundaries)
      (simple-delete-indentation-region)
      (simple-delete-indentation-prefix): New tests.
      0cd250e9
  17. 29 Mar, 2019 1 commit
  18. 28 Mar, 2019 1 commit
    • Mattias Engdegård's avatar
      Use memql instead of memq in pcase · eb6bbd9f
      Mattias Engdegård authored
      * lisp/emacs-lisp/pcase.el (pcase--u1):
      Use memql instead of memq to work with bignums (Bug#34781).
      * test/lisp/emacs-lisp/pcase-tests.el (pcase-tests-member): Test the above.
      eb6bbd9f
  19. 27 Mar, 2019 1 commit
  20. 23 Mar, 2019 1 commit
    • Michael Albinus's avatar
      Fix Bug#34943 · a3194e7b
      Michael Albinus authored
      * lisp/files-x.el (cl-lib): Require when compiling.
      (hack-connection-local-variables): Regard connection-local
      variables as safe.  (Bug#34943)
      
      * lisp/shell.el (shell): Use `with-connection-local-variables' for
      the whole code block.  (Bug#34943)
      
      * lisp/net/tramp-adb.el (tramp-connection-local-safe-shell-file-names):
      Do not set values.
      
      * lisp/net/tramp-integration.el
      (tramp-connection-local-safe-shell-file-names): Remove.
      (shell-file-name, shell-command-switch): Do not add safe-local-variable
      property.
      
      * lisp/net/tramp.el (tramp-handle-shell-command): Use proper
      buffer name.
      
      * test/lisp/net/tramp-tests.el (tramp-test34-explicit-shell-file-name):
      Tag it :unstable.
      a3194e7b
  21. 22 Mar, 2019 3 commits
    • Stephen Leake's avatar
      Fix bug in delete-indentation when region is inactive · b515edb9
      Stephen Leake authored
      * test/lisp/simple-tests.el: Add tests for delete-indentation.
      (simple-delete-indentation-no-region): Works with no region.
      (simple-delete-indentation-inactive-region): Was broken with inactive
      region; now fixed.
      
      * lisp/simple.el (delete-indentation): Check (use-region-p) before using BEG.
      b515edb9
    • Eric Abrahamsen's avatar
      Change Gnus hash tables into real hash tables · c1b63af4
      Eric Abrahamsen authored
      Gnus has used obarrays as makeshift hash tables for groups: group
      names are coerced to unibyte and interned in custom obarrays, and
      their symbol-value set to whatever value needs to be stored. This
      patch replaces those obarrays with actual hash tables.
      
      * lisp/gnus/gnus-util.el (gnus-intern-safe, gnus-create-hash-size):
        Remove functions.
        (gnus-make-hashtable): Change to return a real hash table.
        (gnus-text-property-search): Utility similar to `text-property-any',
        but compares on `equal'. Needed because the 'gnus-group text
        property is now a string.
      * lisp/gnus/gnus.el (gnus-gethash, gnus-gethash-safe, gnus-sethash):
        Remove macros.
        (gnus-group-list): New variable holding all group names as an
        ordered list. Used because `gnus-newsrc-hashtb' used to preserve
        `gnus-newsrc-alist' ordering, but now doesn't.
      * lisp/gnus/nnmaildir.el (nnmaildir--servers): Change from obarray to
        alist.
        (nnmaildir--up2-1): Remove function.
      * lisp/thingatpt.el (thing-at-point-newsgroup-p): This was making use
        of Gnus obarrays, replace with a cond that can handle many different
        possibilities.
      * lisp/gnus/gnus-bcklg.el (gnus-backlog-articles): Remove
        gnus-backlog-hashtb, which wasn't doing anything. Just keep a list
        of ident strings in gnus-backlog-articles.
        (gnus-backlog-setup): Delete unnecessary function.
        (gnus-backlog-enter-article, gnus-backlog-remove-oldest-article,
        gnus-backlog-remove-article, gnus-backlog-request-article): Alter
        calls accordingly.
      * lisp/gnus/gnus-dup.el (gnus-duplicate-list-max-length): Rename from
        `gnus-duplicate-list-length', for accuracy.
      * lisp/gnus/gnus-start.el (gnus-active-to-gnus-format,
        gnus-groups-to-gnus-format, gnus-newsrc-to-gnus-format): Read group
        names as strings.
        (gnus-gnus-to-quick-newsrc-format): Write `gnus-newsrc-alist' using
        the ordering in `gnus-group-list'.
      * lisp/gnus/gnus-agent.el:
      * lisp/gnus/gnus-async.el:
      * lisp/gnus/gnus-cache.el:
      * lisp/gnus/gnus-group.el:
      * lisp/gnus/gnus-score.el:
      * lisp/gnus/gnus-sum.el:
      * lisp/gnus/gnus-topic.el:
      * lisp/gnus/message.el:
      * lisp/gnus/mml.el:
      * lisp/gnus/nnagent.el:
      * lisp/gnus/nnbabyl.el:
      * lisp/gnus/nnvirtual.el:
      * lisp/gnus/nnweb.el: In all files, change obarrays to hash-tables,
        and swap `gnus-sethash' for `puthash', `gnus-gethash' for `gethash',
        `mapatoms' for `maphash', etc.
      * test/lisp/gnus/gnus-test-headers.el (gnus-headers-make-dependency-table,
        gnus-headers-loop-dependencies): New tests to make sure we're
        building `gnus-newsgroup-dependencies' correctly.
      c1b63af4
    • Michael Albinus's avatar
      Fix Bug#24394, Bug#34172 · 3375d082
      Michael Albinus authored
      * lisp/subr.el (process-file-shell-command):
      Use `with-connection-local-variables'.  Do not set "/bin/sh" for
      remote buffers, trust settings of `shell-file-name'.
      
      * lisp/net/tramp-adb.el (tramp-methods) <adb>:
      * lisp/net/tramp-smb.el (tramp-methods) <smb>:
      Remove `tramp-remote-shell' and `tramp-remote-shell-args'.
      
      * lisp/net/tramp-sh.el (tramp-sh-handle-file-notify-add-watch)
      (tramp-maybe-open-connection): Use proper read syntax for function
      names.
      
      * lisp/net/tramp.el (tramp-handle-shell-command): Do not use shell
      file names from `tramp-methods'.
      Respect `async-shell-command-buffer'.  (Bug#24394, Bug#34172)
      Use `start-file-process-shell-command' and `process-file-shell-command'.
      
      * test/lisp/net/tramp-tests.el (tramp-test32-shell-command):
      Let it run partly for tramp-adb.
      3375d082
  22. 21 Mar, 2019 1 commit
    • NicolasPetton's avatar
      New seq-contains-p predicate (Bug#34852) · 287cc58f
      NicolasPetton authored
      * lisp/emacs-lisp/seq.el (seq-contains-p): New predicate function.  It
      is a replacement for seq-contains which cannot be used as a predicate
      when a sequence contains nil values as it returns the element found.
      (seq-contains): Make obsolete.
      
      * test/lisp/emacs-lisp/seq-tests.el (test-seq-contains-p):
      (test-seq-intersection-with-nil, test-seq-set-equal-p-with-nil,
      test-difference-with-nil): Add regression tests.
      
      * doc/lispref/sequences.texi (Sequence Functions): Document
      seq-contains-p.
      287cc58f
  23. 20 Mar, 2019 1 commit