1. 30 May, 2017 16 commits
  2. 29 May, 2017 10 commits
    • Dmitry Gutov's avatar
      Turn global-eldoc-mode into a globalized minor mode · 2349f1df
      Dmitry Gutov authored
      * lisp/emacs-lisp/eldoc.el (global-eldoc-mode):
      Turn into globalized mode (bug#19853).
      (turn-on-eldoc-mode): Make it into a wrapper instead of alias.
      (eldoc-mode): Only show the message when called interactively.
      2349f1df
    • Dmitry Gutov's avatar
      Use regexp matching instead of checking exit status · 4886b2ed
      Dmitry Gutov authored
      * lisp/progmodes/xref.el (xref-collect-matches):
      See if the output buffer contents look like Grep output
      instead of checking exit status (bug#23451).
      4886b2ed
    • Stephen Berman's avatar
      Add initial tests for todo-mode.el · 299a96c7
      Stephen Berman authored
      *test/lisp/calendar/todo-mode-tests.el:
      *test/lisp/calendar/todo-mode-resources/todo-test-1.toda:
      *test/lisp/calendar/todo-mode-resources/todo-test-1.todo: New files.
      
      * .gitattributes: Ignore trailing whitespace in todo-mode test
      data files, since it is part of the todo-mode file format.
      299a96c7
    • Stephen Berman's avatar
      Make `todo-toggle-item-highlighting' work on multiline items (bug#27133) · ed222c50
      Stephen Berman authored
      * lisp/calendar/todo-mode.el (todo-hl-line-range): New named function,
      replacing an anonymous function for the sake of `describe-variable'.
      (todo-modes-set-2): Use it as buffer-local value of hl-line-range-function
      and remove boundp test of this variable, so its value is available on
      invoking `todo-toggle-item-highlighting'.
      ed222c50
    • Alan Third's avatar
      Fix build error on macOS 10.6 · c503188f
      Alan Third authored
      * src/nsfns.m (compute_tip_xy): Cast NSRect to CGRect and NSPoint to
      CGPoint.
      c503188f
    • Noam Postavsky's avatar
      ; Fix backslashes in python-tests · 443f3716
      Noam Postavsky authored
      * test/lisp/progmodes/python-tests.el (python-indent-after-backslash-1)
      (python-indent-after-backslash-2)
      (python-indent-after-backslash-3)
      (python-indent-after-backslash-4)
      (python-indent-after-backslash-5)
      (python-nav-beginning-of-statement-1)
      (python-nav-end-of-statement-1)
      (python-nav-forward-statement-1)
      (python-nav-backward-statement-1)
      (python-nav-backward-statement-2)
      (python-info-statement-starts-block-p-2)
      (python-info-statement-ends-block-p-2)
      (python-info-beginning-of-statement-p-2)
      (python-info-end-of-statement-p-2)
      (python-info-beginning-of-block-p-2)
      (python-info-end-of-block-p-2)
      (python-info-line-ends-backslash-p-1)
      (python-info-beginning-of-backslash-1)
      (python-info-continuation-line-p-1)
      (python-info-block-continuation-line-p-1)
      (python-info-assignment-statement-p-1)
      (python-info-assignment-continuation-line-p-1): Backslashes in
      literals should be doubled only once to produce one backslash in the
      buffer.  If there backslashes inside a Python string literal in a Lisp
      literal, that would need to be doubled twice, but there are no such
      cases.  Note that `python-tests-looking-at' takes a plain string, not
      a regexp.
      443f3716
    • Noam Postavsky's avatar
      ; Update test for previous change · eafc985f
      Noam Postavsky authored
      * test/lisp/progmodes/python-tests.el
      (python-indent-after-backslash-4): Indent after backslash is now
      python-indent-offset.
      eafc985f
    • Jules Tamagnan's avatar
      Comply with pep 8 style guide for backslash in assignment (Bug#24809) · c9097e9b
      Jules Tamagnan authored
      * lisp/progmodes/python.el (python-indent--calculate-indentation):
      Increase indent by `python-indent-offset' after
      `:after-backslash-assignment-continuation'.
      
      Copyright-paperwork-exempt: yes
      c9097e9b
    • Wilfred Hughes's avatar
      Add suggestion to docstring · c5cde97b
      Wilfred Hughes authored
      * lisp/subr.el (interactive-p): Mention commandp, as this is often
        what users are actually looking for.
      c5cde97b
    • Wilfred Hughes's avatar
      Ensure button-get works in any buffer · f7c4bad1
      Wilfred Hughes authored
      * lisp/button.el (button-get): Previously we assumed that button-get
        was called in the buffer containing the button.  In other buffers,
        button-get always returned nil.  Fix this by passing the relevant
        buffer from the marker.
      f7c4bad1
  3. 28 May, 2017 4 commits
    • Dmitry Gutov's avatar
      Signal error if find-grep returns a nonzero status · 3bc3dc40
      Dmitry Gutov authored
      * lisp/progmodes/xref.el (xref-collect-matches): Signal error
      if find-grep returns a nonzero status (bug#23451).  Remove the
      comment: even if some output is present, a non-zero status
      means something went wrong and it can't be relied upon.
      3bc3dc40
    • Stephen Berman's avatar
      Make sure exiting todo-mode buffer buries it (bug#27121) · d76c0078
      Stephen Berman authored
      This failed due to commit ea3ae33b from 2013-05-16, which prevented
      quitting todo-mode buffer after visiting todo-archive buffer from
      making the archive buffer current again.  Avoid this now by simply
      killing the archive buffer, since there's no need to keep it a live
      buffer.  Consequently, quitting a todo-mode buffer can now use
      bury-buffer without an argument, which ensures that is will not
      becomes current on quitting the buffer that replaced it in the window.
      
      * lisp/calendar/todo-mode.el (todo-quit): Kill todo-archive-mode
      buffer instead of burying it.  This now allows exiting the
      todo-mode buffer by bury-buffer without an argument, so do that.
      d76c0078
    • Michael Albinus's avatar
      Some tweaks, almost all for Tramp adb method · e7bb7cc2
      Michael Albinus authored
      * lisp/net/tramp-adb.el (tramp-adb-parse-device-names):
      Use `make-tramp-file-name'.
      (tramp-adb-get-device): Use `tramp-file-name-port-or-default'.
      (tramp-adb-maybe-open-connection): Set "prompt" property.
      (tramp-adb-wait-for-output): Use it.
      
      * lisp/net/tramp-cache.el (tramp-cache-print): Use `elt'.
      (tramp-dump-connection-properties): Check also that there are
      properties to be saved.  Don't save "started" property of
      "ftp" method.
      
      * lisp/net/tramp-gvfs.el (tramp-gvfs-handle-expand-file-name):
      Use `make-tramp-file-name'.
      
      * lisp/net/tramp.el (tramp-remote-file-name-spec-regexp):
      Host could be empty.
      (tramp-file-name-port-or-default): New defun.
      (tramp-dissect-file-name): Simplify `make-tramp-file-name' call.
      (tramp-handle-file-name-case-insensitive-p): Use a progress reporter.
      (tramp-call-process, tramp-call-process-region):
      Use `make-tramp-file-name'.
      
      * test/lisp/net/tramp-tests.el (tramp-test03-file-name-defaults):
      Revert change from 2017-05-24.
      (tramp-test05-expand-file-name-relative): Let it also pass for
      "adb" method.
      e7bb7cc2
    • Jürgen Hötzel's avatar
      Fix Tramp for Android 7 · 288b3ca2
      Jürgen Hötzel authored
      * tramp-adb.el (tramp-adb-ls-toolbox-regexp):
      Username part of prompt is empty on Android 7.
      (tramp-adb-ls-toolbox-regexp):
      Ignore addition links column on Android 7.
      (tramp-adb-get-ls-command):
      Dont use --color=none when using toybox (Android 7).  It's not
      possible to disable coloring explicitly for toybox ls.
      288b3ca2
  4. 27 May, 2017 10 commits
    • Svante Carl v. Erichsen's avatar
      Fix cl-indent for `loop' with :keywords (Bug#15543) · 527a7cc9
      Svante Carl v. Erichsen authored
      * lisp/emacs-lisp/cl-indent.el (lisp-extended-loop-p): Allow for
      ":keywords".
      
      Copyright-paperwork-exempt: yes
      527a7cc9
    • Paul Eggert's avatar
      Depromiscuify inotify with IN_MASK_ADD · d3873050
      Paul Eggert authored
      Use IN_MASK_ADD instead of using a no-longer-promiscuous-enough
      mask.  This simplifies the code and restores the ability to
      use IN_ACCESS, IN_CLOSE_WRITE, IN_CLOSE_NOWRITE, and IN_OPEN
      in some cases (Bug#26973).
      * src/inotify.c (INOTIFY_DEFAULT_MASK): Remove.
      (Finotify_add_watch): Use IN_MASK_ADD instead.
      d3873050
    • Paul Eggert's avatar
      Restore inotify onlydir support · ad656a72
      Paul Eggert authored
      There was no need to remove it in the 2017-03-26 inotify change,
      as it is like IN_DONT_FOLLOW and does not affect other watchers
      for the same file.
      * src/inotify.c (symbol_to_inotifymask, Finotify_add_watch)
      (syms_of_inotify): Bring back onlydir.
      ad656a72
    • Paul Eggert's avatar
      Simplify computation of inotify mask · 8f59ff24
      Paul Eggert authored
      * src/inotify.c (add_watch): Accept uint32_t imask instead
      of Lisp_Object aspect.  Caller changed.
      (Finotify_add_watch): Use aspect_to_inotifymask earlier, to
      simplify the code.
      8f59ff24
    • Philipp Stephani's avatar
      Don't attempt to recover from undefined behavior in some cases · ebe0bdae
      Philipp Stephani authored
      These functions can only be run in batch mode and exit Emacs on
      return, so nothing can be recovered.  Disable unsafe recover
      mechanisms so that we get real failures and good stack traces on
      fatal signals.
      
      * lisp/emacs-lisp/bytecomp.el (batch-byte-compile)
      (batch-byte-recompile-directory):
      * lisp/emacs-lisp/ert.el (ert-run-tests-batch-and-exit)
      (ert-summarize-tests-batch-and-exit): Don't attempt to recover
      from undefined behavior.
      ebe0bdae
    • Philipp Stephani's avatar
      Avoid another compiler warning on macOS · a3a3ea07
      Philipp Stephani authored
      When configured with --without-ns, HAVE_NS is not defined on macOS,
      thus 'memory-limit' calls the deprecated sbrk(2) function.  Avoid that
      by using the pre-defined __APPLE__ preprocessor macro.
      
      * src/alloc.c (Fmemory_limit): Never use sbrk(2) on macOS.
      a3a3ea07
    • Luke Yen-Xun Lee's avatar
      Fix ruler-mode text-scaling issues · b0177da7
      Luke Yen-Xun Lee authored
      * lisp/ruler-mode.el (ruler-mode-text-scaled-width): New function
      for computing scaled text width.
      (ruler-mode-text-scaled-window-hscroll)
      (ruler-mode-text-scaled-window-width): Compute text scaled
      `window-width' value.
      (ruler-mode-mouse-grab-any-column, ruler-mode-mouse-add-tab-stop)
      (ruler-mode-ruler): Change `window-hscroll' into
      `ruler-mode-text-scaled-window-hscroll', and change `window-width'
      into `ruler-mode-text-scaled-window-width'.
      b0177da7
    • Martin Rudalics's avatar
      Minor doc and doc-string fixes (Bug#27091) · 704fea97
      Martin Rudalics authored
      * src/window.c (Fset_window_scroll_bars): Fix doc-string.
      
      * doc/lispref/display.texi (Fringe Size/Pos, Scroll Bars)
      (Display Margins): Mention that `set-window-buffer' may override
      settings made by `set-window-fringes', `set-window-scroll-bars'
      and `set-window-margins'.
      * doc/lispref/windows.texi (Buffers and Windows): Fix doc of
      `set-window-buffer'.
      704fea97
    • Eli Zaretskii's avatar
      Avoid args-out-of-range errors on fringe clicks after "C-h k" · 3fc36f42
      Eli Zaretskii authored
      * src/keyboard.c (echo_truncate): Don't call Ftruncate if the echo
      message is already shorter than NCHARS.  (Bug#27040)
      3fc36f42
    • Eli Zaretskii's avatar
      Fix GUD "Stop" display when running pdb · 4b17214a
      Eli Zaretskii authored
      * lisp/progmodes/gud.el (gud-menu-map): Don't call gdb-show-stop-p
      when GUD mode is 'pdb'.  (Bug#27024)
      4b17214a