1. 04 Aug, 2013 1 commit
    • Paul Eggert's avatar
      Fix some minor races in hosts lacking mkostemp. · e0fdb694
      Paul Eggert authored
      Gnulib's emulation of mkostemp doesn't have races that Emacs's does.
      * configure.ac (mkostemp): Remove check for this function;
      gnulib does the check now.
      (mkstemp): Remove check for this no-longer-used function.
      * lib/mkostemp.c, lib/secure_getenv.c, lib/tempname.c, lib/tempname.h:
      * m4/mkostemp.m4, m4/secure_getenv.m4, m4/tempname.m4:
      New files, copied from Gnulib.
      * lib/gnulib.mk, m4/gnulib-comp.m4: Regenerate.
      * admin/merge-gnulib (GNULIB_MODULES): Add mkostemp.
      * lib-src/movemail.c (main):
      * lib-src/update-game-score.c (write_scores):
      Use mkostemp (which now works on all platforms, due to changes
      in the portability layer) rather than mktemp (which has a race)
      or mkstemp (which we no longer bother with).
      * src/callproc.c (create_temp_file):
      * src/filelock.c (create_lock_file):
      Assume mkostemp, since it's now provided by Gnulib.
      
      Fixes: debbugs:15015
      e0fdb694
  2. 30 Mar, 2013 1 commit
  3. 01 Jan, 2013 1 commit
  4. 17 Nov, 2012 1 commit
    • Paul Eggert's avatar
      Assume POSIX 1003.1-1988 or later for fcntl.h. · 49cdacda
      Paul Eggert authored
      * admin/CPP-DEFINES (O_RDONLY, O_RDWR, HAVE_FCNTL_H): Remove.
      * admin/merge-gnulib (GNULIB_MODULES): Add fcntl-h.
      * configure.ac: Do not check for fcntl.h.
      * lib/gnulib.mk: Regenerate.
      * lib-src/movemail.c, lib-src/update-game-score.c: Assume <fcntl.h> exists.
      * nt/inc/sys/socket.h (O_NONBLOCK): Rename from O_NDELAY, since the
      POSIX name for this flag is O_NONBLOCK.  All uses changed.
      * nt/inc/unistd.h (O_RDWR, O_NOCTTY): New macros.  Like AT_FDCWD etc.
      these really should be moved to a replacement <fcntl.h> if and
      when that gets implemented.  In the meantime, include <fcntl.h>
      to make sure we don't override its definitions.
      * src/callproc.c (relocate_fd): Assume F_DUPFD.
      * src/emacs.c, src/term.c (O_RDWR): Remove.
      * src/keyboard.c (tty_read_avail_input): Use O_NONBLOCK rather than
      O_NDELAY, since O_NONBLOCK is the standard name for this flag.
      * src/nsterm.m: Assume <fcntl.h> exists.
      * src/process.c (NON_BLOCKING_CONNECT, allocate_pty, create_process)
      (create_pty, Fmake_network_process, server_accept_connection)
      (wait_reading_process_output, init_process_emacs):
      Assume O_NONBLOCK.
      (wait_reading_process_output): Put in a special case for WINDOWSNT
      to mimick the older behavior where it had O_NDELAY but not O_NONBLOCK.
      It's not clear this is needed, but it's a more-conservative change.
      (create_process): Assume FD_CLOEXEC.
      (create_process, create_pty): Assume O_NOCTTY.
      * src/sysdep.c (init_sys_modes, reset_sys_modes): Assume F_SETFL.
      (reset_sys_modes): Use O_NONBLOCK rather than O_NDELAY.
      Omit if not DOS_NT, since F_GETFL is not defined there.
      (serial_open): Assume O_NONBLOCK and O_NOCTTY.
      * src/term.c: Include <fcntl.h>, for flags like O_NOCTTY.
      (O_NOCTTY): Remove.
      (init_tty): Assume O_IGNORE_CTTY is defined to 0 on platforms that
      lack it, since gnulib guarantees this.
      * src/w32.c (fcntl): Test for O_NONBLOCK rather than O_NDELAY.
      
      Fixes: debbugs:12881
      49cdacda
  5. 11 Jul, 2012 1 commit
  6. 24 Jun, 2012 1 commit
  7. 16 Apr, 2012 1 commit
  8. 11 Jan, 2012 1 commit
  9. 05 Jan, 2012 1 commit
  10. 17 Nov, 2011 1 commit
  11. 28 Aug, 2011 1 commit
  12. 09 Jul, 2011 1 commit
  13. 07 Jul, 2011 1 commit
  14. 21 Mar, 2011 1 commit
    • Paul Eggert's avatar
      update-game-score: fix bug with -r · f0d80d43
      Paul Eggert authored
      * update-game-score.c (main): Don't set 'scores' to garbage when
      -r is specified and scorecount != MAX_SCORES.  This bug was
      introduced in the 2002-04-10 change, and was found with gcc
      -Wstrict-overflow (GCC 4.5.2, x86-64).
      f0d80d43
  15. 21 Feb, 2011 1 commit
    • Paul Eggert's avatar
      Declare file-scope functions and variables static if not exported. · b23b5a5b
      Paul Eggert authored
      This is more consistent, and is nicer with gcc -Wstrict-prototypes.
      * ebrowse.c, emacsclient.c, fakemail.c, make-docfile.c, movemail.c:
      * profile.c, test-distrib.c, update-game-score.c:
      Declare non-'main' functions and variables to be static.
      * ebrowse.c: Omit redundant function prototypes.
      b23b5a5b
  16. 26 Jan, 2011 1 commit
  17. 25 Jan, 2011 1 commit
  18. 15 Jan, 2011 1 commit
  19. 09 Jan, 2011 1 commit
  20. 02 Jan, 2011 1 commit
  21. 11 Aug, 2010 1 commit
    • Jan D's avatar
      Fix warnings produced by compiling with -Wwrite_strings (i.e. use const char *). · 988e88ab
      Jan D authored
      * b2m.c (concat, fatal): Use const char*.
      (main): Don't assign labels a string literal.
      
      * ebrowse.c (struct member): filename, def_filename is const.
      (struct sym): filename, sfilename is const.
      (struct kw): name is const.
      (add_sym, yyerror, token_string, insert_keyword, main): Use const char*.
      
      * emacsclient.c (message, sock_err_message, send_to_emacs)
      (quote_argument, set_local_socket)
      (start_daemon_and_retry_set_socket): Use const char*.
      
      * etags.c (compressor, language, Ada_suffix, Ada_help, Asm_suffixes)
      (Asm_help, default_C_suffixes, default_C_help, Cplusplus_suffixes)
      (Cplusplus_help, Cjava_suffixes, Cobol_suffixes, Cstar_suffixes)
      (Erlang_suffixes, Erlang_help, Forth_suffixes, Forth_help)
      (Fortran_suffixes, Fortran_help, HTML_suffixes,  HTML_help)
      (Lisp_suffixes, Lisp_help, Lua_suffixes, Lua_help)
      (Makefile_filenames, Makefile_help, Objc_suffixes, Objc_help)
      (Pascal_suffixes, Pascal_help, Perl_suffixes, Perl_interpreters)
      (Perl_help, PHP_suffixes, PHP_help, plain_C_suffixses, PS_suffixes)
      (PS_help, Prolog_suffixes, Prolog_help, Python_suffixes, Python_help)
      (Scheme_suffixes, Scheme_help, TeX_suffixes, TeX_help, Texinfo_suffixes)
      (Texinfo_help, Yacc_suffixes, Yacc_help, auto_help, none_help)
      (no_lang_help, print_language_names)
      (get_language_from_interpreter, get_language_from_filename)
      (init, make_tag, struct C_stab_entry, write_classname, TEX_defenv)
      (TEX_decode_env, nocase_tail, savestr, savenstr, fatal, pfatal)
      (concat): Use const char*.
      
      * make-docfile.c (error, fatal, scan_c_file, scan_lisp_file): Use
      const char *.
      
      * movemail.c (fatal, error, concat): Use const char *.
      
      * pop.c (pop_multi_first, socket_connection, sendline): Use conat char*.
      
      * pop.h (pop_multi_first): Use const char *.
      (_ARGS): Remove.
      
      * sorted-doc.c (error, fatal, states): Use const char *.
      
      * update-game-score.c (get_prefix, write_scores, main): Use const char*.
      988e88ab
  22. 24 Jul, 2010 1 commit
    • Dan Nicolaescu's avatar
      Add NO_RETURN specifiers to functions in lib-src. · 68441b90
      Dan Nicolaescu authored
      * lib-src/update-game-score.c (usage):  Add NO_RETURN specifier.
      * lib-src/movemail.c (fatal, pfatal_with_name, pfatal_and_delete):
      * lib-src/make-docfile.c (fatal):
      * lib-src/hexl.c (usage):
      * lib-src/fakemail.c (fatal):
      * lib-src/etags.c (fatal, suggest_asking_for_help, pfatal):
      * lib-src/emacsclient.c (fatal):
      * lib-src/b2m.c (fatal): Likewise.
      68441b90
  23. 08 Jul, 2010 1 commit
    • Dan Nicolaescu's avatar
      Remove leftover P_ macros. · 0216627e
      Dan Nicolaescu authored
      * lib-src/update-game-score.c (P_): Remove macro.
      * lib-src/ebrowse.c: Remove include guards.
      (P_): Remove macro.
      0216627e
  24. 03 Jul, 2010 1 commit
    • Dan Nicolaescu's avatar
      Convert function definitions to standard C. · 873fbd0b
      Dan Nicolaescu authored
      * lib-src/update-game-score.c: Convert function definitions to standard C.
      * lib-src/sorted-doc.c:
      * lib-src/profile.c:
      * lib-src/pop.c:
      * lib-src/movemail.c:
      * lib-src/make-docfile.c:
      * lib-src/hexl.c:
      * lib-src/fakemail.c:
      * lib-src/etags.c:
      * lib-src/ebrowse.c:
      * lib-src/digest-doc.c:
      * lib-src/b2m.c: Likewise.
      873fbd0b
  25. 02 Jul, 2010 1 commit
    • Jan D's avatar
      Remove __P and P_ from .c and .m files and definition of P_ · f57e2426
      Jan D authored
      * lisp.h:
      * atimer.h: Remove define for P_.
      
      * alloc.c: Remove __P and P_ from .c and .m files.
      * atimer.c:
      * buffer.c:
      * callint.c:
      * category.c:
      * charset.c:
      * chartab.c:
      * cm.c:
      * coding.c:
      * composite.c:
      * data.c:
      * dired.c:
      * dispnew.c:
      * doc.c:
      * editfns.c:
      * emacs.c:
      * eval.c:
      * fileio.c:
      * filelock.c:
      * fns.c:
      * font.c:
      * fontset.c:
      * frame.c:
      * ftfont.c:
      * ftxfont.c:
      * gmalloc.c:
      * gtkutil.c:
      * image.c:
      * indent.c:
      * intervals.c:
      * keyboard.c:
      * keymap.c:
      * lread.c:
      * marker.c:
      * menu.c:
      * minibuf.c:
      * print.c:
      * process.c:
      * scroll.c:
      * search.c:
      * sound.c:
      * strftime.c:
      * syntax.c:
      * sysdep.c:
      * term.c:
      * terminal.c:
      * textprop.c:
      * unexalpha.c:
      * w32console.c:
      * w32fns.c:
      * w32font.c:
      * w32menu.c:
      * w32term.c:
      * w32uniscribe.c:
      * window.c:
      * xdisp.c:
      * xfaces.c:
      * xfns.c:
      * xfont.c:
      * xftfont.c:
      * xmenu.c:
      * xselect.c:
      * xterm.c: Likewise.
      
      * ebrowse.c: Remove P_ and __P.
      * etags.c:
      * movemail.c:
      * pop.c:
      * update-game-score.c: Likewise.
      f57e2426
  26. 13 Jan, 2010 1 commit
  27. 24 Sep, 2009 1 commit
  28. 11 Sep, 2009 1 commit
  29. 08 Jan, 2009 1 commit
  30. 09 May, 2008 1 commit
  31. 07 Jan, 2008 1 commit
  32. 25 Jul, 2007 1 commit
  33. 21 Jan, 2007 1 commit
  34. 06 Feb, 2006 1 commit
  35. 07 Aug, 2005 1 commit
  36. 04 Jul, 2005 1 commit
  37. 08 May, 2004 1 commit
  38. 16 Apr, 2004 1 commit
  39. 08 Sep, 2003 1 commit
  40. 01 Sep, 2003 1 commit