1. 11 Jan, 2006 3 commits
  2. 10 Jan, 2006 6 commits
    • Bill Wohler's avatar
      * mh-index.el (mh-index-search): Checking mh-find-path-run is · 191c8741
      Bill Wohler authored
      unnecessary.
      
      * mh-init.el (mh-sys-path): Co-locate with mh-variants, which uses it.
      (mh-variants): Note variable isn't meant to be accessed directly; use
      function mh-variants instead.
      (mh-variant-info, mh-variant-mh-info, mh-variant-mu-mh-info)
      (mh-variant-nmh-info): Co-locate next to mh-variants, which uses them.
      Updated to use mh-file-command-p which is more accurrate than
      file-executable-p which returns t for directories.
      (mh-file-command-p): Move here from mh-utils, since mh-variant-*-info
      are the only functions to use it.
      (mh-variant-set, mh-variant-set-variant, mh-variant-p): Use function
      mh-variants instead of variable. More robust.
      (mh-find-path-run): Move here from mh-utils.el. Mention that checking
      this variable is unnecessary.
      (mh-find-path): Move here from mh-utils.el. With the advent of MH
      variants and an mhparam command that doesn't work if there isn't an MH
      profile, we can't get libdir for running install-mh. So don't bother.
      If there's an issue with the environment, direct the user to install
      MH and run install-mh (closes SF #835192). Don't read ~/.mh_profile
      directly. Use mh-profile-component which uses mhparam (closes SF
      #1016027).
      
      * mh-utils.el (mh-get-profile-field): Rename to
      mh-profile-component-value. Add colon to search removing unnecessary
      addition of colon to field in mh-profile-component.
      (mh-profile-component): Modify call to mh-profile-component-value
      accordingly. Move next to mh-profile-component-value.
      (mh-find-path-run, mh-find-path, mh-file-command-p): Move to
      mh-init.el. It makes sense that code that is only run once per session
      (more or less) is in mh-init.el rather than cluttering mh-utils.el.
      (mh-no-install, mh-install): Delete.
      191c8741
    • Bill Wohler's avatar
      12884b72
    • Bill Wohler's avatar
      abb73857
    • Bill Wohler's avatar
      (mh-variant-mu-mh-info, mh-variant-nmh-info): Applied patch from · b981c52c
      Bill Wohler authored
      Satyaki from SF #1016027.
      b981c52c
    • Bill Wohler's avatar
      (mh-rescan-folder): Try to keep cursor at current message, even if cur · 8f9efec8
      Bill Wohler authored
      sequence is no longer present (closes SF #1207247).
      8f9efec8
    • Bill Wohler's avatar
      d6e2b25f
  3. 09 Jan, 2006 7 commits
    • Bill Wohler's avatar
      Use ";; Shush compiler." comment consistently per Mark's suggestion. · b6d8f743
      Bill Wohler authored
      (mh-letter-mode): Derive from mail-mode and delete code copied from
      mail-mode (closes SF #1385571). Mention mail-mode-hook in docstring.
      (mh-fill-paragraph-function): Delete. Handled by mail-mode.
      (mh-to-field-choices): For consistency with mail-mode, add "a" for
      "Mail-Reply-To:", "l" for "Mail-Followup-To:", and "r" for
      "Reply-To:". Change "r" to "m" for "From:" (closes SF #1400139).
      (mh-to-fcc): Move setting of folder argument to interactive argument
      as is the norm.
      (mh-letter-complete-function-alist): Add mail-reply-to.
      (mh-letter-mode-map): Add keys for mh-to-field (Mail-Reply-To,
      Mail-Followup-To, Reply-To, From).
      b6d8f743
    • Bill Wohler's avatar
      Comment declaration to remind programmer to update forward definition · 90866475
      Bill Wohler authored
      if default changes.
      90866475
    • Bill Wohler's avatar
      * mh-funcs.el: · 04f6a2d1
      Bill Wohler authored
      * mh-inc.el:
      * mh-init.el:
      * mh-mime.el:
      * mh-seq.el:
      * mh-utils.el: Use ";; Shush compiler." comment consistently per
      Mark's suggestion.
      04f6a2d1
    • Bill Wohler's avatar
      Use consistent verbiage with compiler defvars. · 23847cd6
      Bill Wohler authored
      Removed hard tabs.
      23847cd6
    • Bill Wohler's avatar
      Fix typo. · 2e63e3d8
      Bill Wohler authored
      2e63e3d8
    • Bill Wohler's avatar
      Use consistent verbiage with compiler defvars. · 6eb83a35
      Bill Wohler authored
      Removed defvars that are no longer needed.
      6eb83a35
    • Bill Wohler's avatar
      * mh-alias.el (mh-alias-gecos-name): Use replace-regexp-in-string · 7094eefe
      Bill Wohler authored
      instead of mh-replace-in-string as mh-replace-in-string was replaced
      by a more appropriate defsubst in mh-xemacs.el.
      
      * mh-comp.el: Require cleanup, wrap compiler-shushing defvars with
      eval-when-compile.
      (mh-file-is-vcard-p): Removed redundant test.
      
      * mh-customize.el: Require cleanup, wrap compiler-shushing defvars
      with eval-when-compile.
      (mh-adaptive-cmd-note-flag, mh-invisible-header-fields)
      (mh-invisible-header-fields-default): Add forward definitions.
      (mh-invisible-header-fields-default): Alphabetize.
      
      * mh-e.el: Require cleanup, wrap compiler-shushing defvars with
      eval-when-compile.
      (mh-thread-scan-line-map-stack, tool-bar-mode): Delete unused
      variables.
      (mh-colors-available-p): Just call display-color-cells. It's on all
      supported Emacsen (and defaliased on XEmacs).
      
      * mh-funcs.el: mh-inc.el: mh-init.el: Wrap compiler-shushing defvars
      * with eval-when-compile.
      
      * mh-identity.el: Don't need (mh-require-cl).
      
      * mh-index.el: Don't need to load executable any more.
      
      * mh-mime.el: Wrap compiler-shushing defvars with eval-when-compile.
      (mh-have-file-command): Initialize variable to 'undefined. Add
      docstring. Update function of same name accordingly. Also don't need
      to load executable any more.
      (mh-mime-content-types): Delete.
      (mh-minibuffer-read-type): Prompt user for type if mh-file-mime-type
      returns application/octet-stream. Assume we have mailcap-mime-types.
      (mh-mime-display): Update error message.
      
      * mh-seq.el: Require cleanup, and wrap compiler-shushing defvars with
      eval-when-compile.
      
      * mh-utils.el: Require cleanup, and wrap compiler-shushing defvars
      with eval-when-compile.
      (mh-clean-msg-header): Don't set after-change-functions to nil.
      (mh-replace-in-string): Remove. Create defsubst in mh-xemacs.el
      instead.
      7094eefe
  4. 07 Jan, 2006 2 commits
  5. 04 Jan, 2006 3 commits
    • Mark D. Baushke's avatar
      * mh-e.el (mh-delete-a-msg): Fix whitespace nit. · 836f2863
      Mark D. Baushke authored
      * mh-index.el (mh-mairix-execute-search): Fix symbol quote.
      836f2863
    • Bill Wohler's avatar
      * mh-alias.el (mh-alias-add-alias): Grand message and error string · f9c53c97
      Bill Wohler authored
      unification. Use single sentence if possible by using semicolon. Don't
      end message with punctuation. Don't need format with message. Quote
      messages as in docstrings: use `' around symbols, \" for option
      choices. Don't use quotes around %s.
      
      * mh-comp.el (mh-complete-word): Ditto.
      
      * mh-customize.el (mh-adaptive-cmd-note-flag-check)
      (mh-scan-format-file-check): Ditto.
      
      * mh-e.el (mh-refile-or-write-again, mh-previous-unread-msg)
      (mh-delete-a-msg, mh-refile-a-msg, mh-next-unread-msg)
      (mh-msg-num-width-to-column): Ditto.
      
      * mh-identity.el (mh-identity-field-handler): Ditto.
      
      * mh-index.el (mh-mairix-execute-search)
      (mh-swish-execute-search, mh-swish++-execute-search)
      (mh-namazu-execute-search): Ditto.
      
      * mh-init.el (mh-variant-set): Ditto.
      
      * mh-mime.el (mh-mh-to-mime-undo, mh-mml-forward-message)
      (mh-secure-message, mh-mime-display): Ditto.
      
      * mh-pick.el (mh-search-folder, mh-pick-construct-regexp): Ditto.
      
      * mh-seq.el (mh-narrow-to-seq, mh-put-msg-in-seq, mh-read-seq)
      (mh-read-range, mh-thread-container-subject): Ditto.
      
      * mh-utils.el (mh-x-image-scale-and-display)
      (mh-prompt-for-folder, mh-handle-process-error)
      (mh-list-to-string-1): Ditto.
      f9c53c97
    • Bill Wohler's avatar
      * mh-comp.el (mh-reply): Use standard default notation in prompts · 078cb314
      Bill Wohler authored
      (closes SF #1275933).
      
      * mh-mime.el (mh-mime-save-parts): Ditto.
      
      * mh-seq.el (mh-read-seq, mh-read-range): Ditto.
      078cb314
  6. 03 Jan, 2006 4 commits
    • Bill Wohler's avatar
      * mh-customize.el (mh-folder-msg-number): Snow is actually off-white · 355ebcbf
      Bill Wohler authored
      on low color displays which turns to white when bold. This is
      unreadable on white backgrounds. Use snow with min-colors requirement.
      Use cyan on low-color displays.
      
      * mh-init.el (mh-defface-compat): On low-color displays, delete the
      high-color display rather than simply strip the min-colors requirement
      since the existing algorithm shadowed the desired display on low-color
      displays.
      355ebcbf
    • Bill Wohler's avatar
      e69d4e02
    • Bill Wohler's avatar
      * mh-alias.el (mh-alias-grab-from-field): Remove leading * from · af435184
      Bill Wohler authored
      docstring. Does this mean something in a defun?
      
      * mh-customize.el (bw-new-face-to-old, bw-old-face-to-new): Checkdoc
      fix.
      
      * mh-e.el (mh-inc-folder): Rename maildrop-name argument to file so it
      reads better in docstring and manual. Sync docstring with manual.
      
      * mh-init.el (mh-defface-compat): Remove trailing space (checkdoc).
      
      * mh-alias.el (mh-alias-apropos): Sync docstring with manual.
      
      * mh-comp.el (mh-redistribute, mh-to-field, mh-to-fcc)
      (mh-insert-auto-fields, mh-send-letter, mh-yank-cur-msg)
      (mh-fully-kill-draft, mh-open-line, mh-letter-complete)
      (mh-letter-complete-or-space, mh-letter-confirm-address)
      (mh-letter-next-header-field-or-indent)
      (mh-letter-previous-header-field): Ditto.
      
      * mh-customize.el (mh-alias-completion-ignore-case-flag)
      (mh-default-folder-for-message-function, mh-mml-method-default)
      (mh-signature-file-name, mh-yank-behavior, mh-show-hook)
      (mh-show-mode-hook) Ditto.
      
      * mh-e.el (mh-refile-or-write-again, mh-toggle-showing): Ditto.
      
      * mh-funcs.el (mh-pipe-msg, mh-sort-folder, mh-undo-folder)
      (mh-store-msg, mh-store-buffer): Ditto
      
      * mh-index.el (mh-index-search, mh-index-do-search)
      (mh-index-next-folder, mh-index-sequenced-messages): Ditto.
      
      * mh-junk.el (mh-spamassassin-blacklist): Ditto.
      
      * mh-mime.el (mh-mh-compose-external-compressed-tar)
      (mh-mh-compose-external-type, mh-mh-to-mime, mh-mh-to-mime-undo)
      (mh-mml-secure-message-sign, mh-mml-secure-message-encrypt)
      (mh-mml-secure-message-signencrypt): Ditto
      
      * mh-pick.el (mh-search-folder): Ditto.
      
      * mh-seq.el (mh-widen): Ditto.
      
      * mh-utils.el (mh-show, mh-modify): Ditto.
      af435184
    • Mark D. Baushke's avatar
  7. 01 Jan, 2006 1 commit
    • Bill Wohler's avatar
      * mh-customize.el: Sync docstrings with manual for faces and sort them · d49ed7d4
      Bill Wohler authored
      alphabetically.
      (mh-faces): Move below mh-hooks. (mh-folder-faces, mh-index-faces,
      mh-letter-faces)
      (mh-show-faces, mh-speed-faces): Delete. Organize faces like hooks.
      (mh-speed-update-interval): Fix group (mh-speedbar, not mh-speed).
      (facemenu-unlisted-faces): Might as well ignore all MH-E faces.
      (mh-folder-body-face, mh-folder-cur-msg-face)
      (mh-folder-cur-msg-number-face, mh-folder-date-face)
      (mh-folder-followup-face, mh-folder-msg-number-face)
      (mh-folder-deleted-face, mh-folder-refiled-face)
      (mh-folder-subject-face, mh-folder-address-face)
      (mh-folder-scan-format-face, mh-folder-to-face) (mh-index-folder-face,
      mh-show-cc-face, mh-show-date-face) (mh-show-header-face,
      mh-show-pgg-good-face) (mh-show-pgg-unknown-face,
      mh-show-pgg-bad-face)
      (mh-show-to-face, mh-show-from-face, mh-show-subject-face): Delete.
      (mh-folder-cur-msg): Unused. Delete.
      (mh-folder-address): Use defface; inherit from mh-folder-subject.
      (mh-folder-body, mh-folder-cur-msg-number, mh-folder-date): Inherit
      from mh-folder-msg-number.
      (mh-folder-deleted): Use defface. Inherit from mh-folder-msg-number.
      (mh-folder-sent-to-me-hint): New face. Inherit from mh-folder-date.
      (mh-folder-sent-to-me-sender): Rename from mh-folder-scan-format. Use
      defface. Inherit from mh-folder-followup.
      (mh-show-xface): Inherit from mh-show-from and highlight.
      (bw-face-generation, bw-toggle-faces)
      (bw-new-face-to-old, bw-old-face-to-new): New (tempoarary) variables,
      functions for toggling between old and new faces.
      
      * mh-e.el (font-lock-auto-fontify, font-lock-defaults): Hide in
      eval-when-compile. We should probably do this throughout.
      (mh-scan-good-msg-regexp, mh-scan-deleted-msg-regexp)
      (mh-scan-refiled-msg-regexp, mh-scan-cur-msg-number-regexp)
      (mh-scan-date-regexp, mh-scan-rcpt-regexp, mh-scan-body-regexp)
      (mh-scan-subject-regexp): Sync docstrings with manual
      (mh-scan-format-regexp): Rename to mh-scan-sent-to-me-sender-regexp.
      Drop date parenthesized expression. Make expression more like the
      others (anchored at the beginning of line). Sync docstrings with
      manual.
      (mh-folder-font-lock-keywords): Use faces directly rather than -face
      variables. Use mh-scan-sent-to-me-sender-regexp instead of
      mh-scan-format-regexp, and within that expression, use faces
      mh-folder-sent-to-me-hint and mh-folder-sent-to-me-sender instead of
      mh-folder-date-face and mh-folder-scan-format-face which were
      misleading.
      
      * mh-mime.el (mh-mime-security-button-face): Use faces directly rather
      than -face variables.
      
      * mh-utils.el (mh-show-font-lock-keywords): Use faces directly rather
      than -face variables.
      (mh-face-foreground-compat, mh-face-background-compat): New macros.
      (mh-face-display-function): Use mh-face-foreground-compat and
      mh-face-background-compat to use inherited attributes of mh-show-xface
      on Emacs 22 while still working on Emacs 21.
      d49ed7d4
  8. 28 Dec, 2005 1 commit
  9. 27 Dec, 2005 2 commits
  10. 23 Dec, 2005 5 commits
    • Bill Wohler's avatar
      (mh-folders-changed): Fix typo in docstring. · 7ba8dffd
      Bill Wohler authored
      7ba8dffd
    • Bill Wohler's avatar
      Follow MH-E Developers Guide conventions. Use `' quotes for Help · 5a4aad03
      Bill Wohler authored
      hyperlinks such as symbols, Info nodes, or URLs. Use \" quotes for
      everything else. Otherwise, you can accidently get links to
      nonsense symbols.
      5a4aad03
    • Bill Wohler's avatar
      Don't need to quote parenthesis within docstrings that are no longer · 4023e353
      Bill Wohler authored
      in the first column.
      4023e353
    • Bill Wohler's avatar
      Follow Emacs coding conventions. Use default setting of · 2dcf34f9
      Bill Wohler authored
      emacs-lisp-docstring-fill-column which is 65.
      2dcf34f9
    • Bill Wohler's avatar
      * mh-alias.el (mh-alias-reload): Sync docstrings with manual. · d1699462
      Bill Wohler authored
      * mh-comp.el (mh-letter-mode): Use 60 column width.
      (mh-forward, mh-insert-signature, mh-send-letter): Sync docstrings
      with manual.
      (mh-yank-cur-msg): Mention that mh-ins-buf-prefix isn't used if you
      have added a mail-citation-hook and neither are used if you use one of
      the supercite flavors of mh-yank-behavior. Sync docstrings with
      manual.
      
      * mh-customize.el (mh-ins-buf-prefix, mh-yank-behavior): Mention that
      mh-ins-buf-prefix isn't used if you have added a mail-citation-hook
      and neither are used if you use one of the supercite flavors of
      mh-yank-behavior. Sync docstrings with manual.
      (mail-citation-hook): Delete. Use one in sendmail.el.
      (mh-signature-file-name, mh-after-commands-processed-hook)
      (mh-alias-reloaded-hook, mh-before-commands-processed-hook)
      (mh-before-quit-hook, mh-before-send-letter-hook) (mh-delete-msg-hook,
      mh-find-path-hook, mh-folder-mode-hook) (mh-forward-hook,
      mh-inc-folder-hook, mh-insert-signature-hook)
      (mh-kill-folder-suppress-prompt-hooks, mh-letter-mode-hook)
      (mh-mh-to-mime-hook, mh-pick-mode-hook, mh-quit-hook)
      (mh-refile-msg-hook, mh-show-hook, mh-show-mode-hook)
      (mh-unseen-updated-hook): Sync docstrings with manual. Use "Hook run
      by `function'..." instead of "Invoked...".
      
      * mh-e.el (mh-last-destination, mh-last-destination-folder)
      (mh-last-destination-write, mh-folder-mode-map, mh-arrow-marker)
      (mh-delete-list, mh-refile-list, mh-folders-changed)
      (mh-next-direction, mh-view-ops, mh-folder-view-stack) (mh-index-data,
      mh-first-msg-num, mh-last-msg-num) (mh-mode-line-annotation,
      mh-sequence-notation-history)
      (mh-colors-available-flag): Move comment into
      docstring. (mh-delete-msg, mh-execute-commands, mh-inc-folder,
      mh-quit, mh-process-commands): Sync docstrings with manual.
      (mh-refile-msg): Small doc edit.
      (mh-delete-a-msg, mh-refile-a-msg): Sync docstrings with manual.
      Rename msg argument to message.
      
      * mh-funcs.el (mh-kill-folder): Sync docstrings with manual.
      
      * mh-e.el (mh-update-unseen): No longer say "The value of `foo-hook'
      is a list of functions to be called, with no arguments, ...," but
      rather just "The hook foo-hook is called...".
      
      * mh-mime.el (mh-mh-to-mime): Ditto
      
      * mh-pick.el (mh-pick-mode): Ditto.
      
      * mh-utils.el (mh-showing-mode): Use uppercase for argument in
      docstring.
      (mh-seq-list, mh-seen-list, mh-showing-with-headers): Move comment
      into docstring.
      (mh-show-mode, mh-show-msg, mh-find-path): Sync docstrings with
      manual.
      d1699462
  11. 20 Dec, 2005 1 commit
    • Stephen Gildea's avatar
      * mh-customize.el (mh-after-commands-processed-hook): New variable. · 2953de8c
      Stephen Gildea authored
      (mh-before-commands-processed-hook): Rename from mh-folder-updated-hook.
      * mh-e.el (mh-process-commands): Rename mh-folder-updated-hook to
      mh-before-commands-processed-hook, call new mh-after-commands-processed-hook.
      (mh-folders-changed): New variable (for mh-after-commands-processed-hook).
      2953de8c
  12. 19 Dec, 2005 2 commits
    • Bill Wohler's avatar
      * mh-acros.el: · cee9f5c6
      Bill Wohler authored
      * mh-alias.el:
      * mh-comp.el:
      * mh-customize.el:
      * mh-e.el:
      * mh-funcs.el:
      * mh-gnus.el:
      * mh-identity.el:
      * mh-inc.el:
      * mh-index.el:
      * mh-init.el:
      * mh-junk.el:
      * mh-mime.el:
      * mh-pick.el:
      * mh-print.el:
      * mh-seq.el:
      * mh-speed.el:
      * mh-utils.el:
      Follow commenting conventions. Don't use ;;; form so much, except for
      headings. Precede headings with page feed. This was mostly already
      done, so I made it a convention. Did not update copyright on a couple
      of files since this was an insignificant change.
      cee9f5c6
    • Bill Wohler's avatar
      * mh-customize.el (mh-toolbar): Rename to mh-tool-bar. · fa4075e3
      Bill Wohler authored
      (mh-tool-bar-search-function): Sync docstrings with manual.
      (mh-tool-bar-customize): Replace toolbar with tool bar in docstring.
      (mh-tool-bar-letter-help): Fix manual reference.
      (mh-xemacs-use-toolbar-flag): Rename to mh-xemacs-use-tool-bar-flag.
      Initialize to mh-xemacs-has-tool-bar-flag. Sync docstrings with
      manual.
      (mh-xemacs-toolbar-position): Rename to mh-xemacs-tool-bar-position.
      Initialize to nil. Drop "no tool bar" option (redundant) and change
      "Same As Default Tool Bar" setting to nil. Sync docstrings with
      manual.
      (mh-tool-bar-define): Replace toolbar with tool-bar or tool bar
      depending on context.
      (mh-toolbar-init): Rename to mh-tool-bar-init. Simplified condition
      for calling set-specifier. Only look at the value of
      mh-xemacs-use-tool-bar-flag.
      (mh-tool-bar-folder-buttons, mh-tool-bar-letter-buttons): Sync
      docstrings with manual.
      
      * mh-comp.el (mh-letter-mode): Use mh-tool-bar-init instead of
      mh-toolbar-init.
      
      * mh-e.el (mh-folder-mode): Ditto.
      
      * mh-utils.el (mh-show-mode): Ditto.
      fa4075e3
  13. 15 Dec, 2005 1 commit
  14. 14 Dec, 2005 1 commit
    • Bill Wohler's avatar
      * mh-customize.el (mh-speed-flists-interval): Rename to · 6b960c10
      Bill Wohler authored
      mh-speed-update-interval.
      (mh-speed-run-flists-flag): Delete. Setting mh-speed-flists-interval
      to 0 accomplishes the same thing.
      
      * mh-speed.el (mh-folder-speedbar-buttons, mh-speed-flists): Use
      mh-speed-update-interval instead of mh-speed-run-flists-flag.
      (mh-speed-toggle, mh-speed-view, mh-speed-refresh): Sync docstrings
      with manual.
      6b960c10
  15. 10 Dec, 2005 1 commit