1. 13 Jun, 2011 15 commits
  2. 12 Jun, 2011 2 commits
    • Paul Eggert's avatar
      Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts. · d37ca623
      Paul Eggert authored
      These casts should not be needed on 32-bit hosts, either.
      * keyboard.c (read_char):
      * lread.c (Fload): Remove casts to unsigned.
      d37ca623
    • Paul Eggert's avatar
      * lisp.h (UNSIGNED_CMP): New macro. · ea204efb
      Paul Eggert authored
      This fixes comparison bugs on 64-bit hosts.
      (ASCII_CHAR_P): Use it.
      * casefiddle.c (casify_object):
      * character.h (ASCII_BYTE_P, CHAR_VALID_P):
      (SINGLE_BYTE_CHAR_P, CHAR_STRING):
      * composite.h (COMPOSITION_ENCODE_RULE_VALID):
      * dispextern.h (FACE_FROM_ID):
      * keyboard.c (read_char): Use UNSIGNED_CMP.
      ea204efb
  3. 11 Jun, 2011 3 commits
    • Paul Eggert's avatar
      Merge from trunk. · 78cf1fe8
      Paul Eggert authored
      78cf1fe8
    • Paul Eggert's avatar
      Merge from trunk. · fc83f7d3
      Paul Eggert authored
      fc83f7d3
    • Chong Yidong's avatar
      Cruft removal in struct image. · b50691aa
      Chong Yidong authored
      * src/dispextern.h (struct image): Replace data member, whose int_val
      and ptr_val fields were not used by anything, with a single
      lisp_val object.
      
      * src/image.c (Fimage_metadata, make_image, mark_image, tiff_load)
      (gif_clear_image, gif_load, imagemagick_load_image)
      (gs_clear_image, gs_load): Callers changed.
      b50691aa
  4. 10 Jun, 2011 15 commits
    • Paul Eggert's avatar
      * buffer.h: Include <time.h>, for time_t. · cca69397
      Paul Eggert authored
      Needed to build on FreeBSD 8.2.  Problem reported by Herbert J. Skuhra.
      cca69397
    • Paul Eggert's avatar
      Merge: Fix minor problems found by static checking. · 109e28d0
      Paul Eggert authored
      * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
      
      Make identifiers static if they are not used in other modules.
      * data.c (Qcompiled_function, Qframe, Qvector):
      * image.c (QimageMagick, Qsvg):
      * minibuf.c (Qmetadata):
      * window.c (resize_window_check, resize_root_window): Now static.
      * window.h (resize_window_check, resize_root_window): Remove decls.
      
      * window.c (window_deletion_count, delete_deletable_window):
      Remove; unused.
      (window_body_lines): Now static.
      (Fdelete_other_windows_internal): Mark vars as initialized.
      Make sure 'resize_failed' is initialized.
      (run_window_configuration_change_hook): Rename local to avoid shadowing.
      (resize_window_apply): Remove unused local.
      * window.h (delete_deletable_window): Remove decl.
      
      * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
      (imagemagick_load_image): Fix pointer signedness problem by changing
      last arg from unsigned char * to char *.  All uses changed.
      Also, fix a local for similar reasons.
      Remove unused locals.  Remove locals to avoid shadowing.
      (fn_rsvg_handle_free): Remove; unused.
      (svg_load, svg_load_image): Fix pointer signedness problem.
      (imagemagick_load_image): Don't use garbage pointer image_wand.
      
      * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
      109e28d0
    • Paul Eggert's avatar
    • Paul Eggert's avatar
      Make identifiers static if they are not used in other modules. · 4b66faf3
      Paul Eggert authored
      * data.c (Qcompiled_function, Qframe, Qvector):
      * image.c (QimageMagick, Qsvg):
      * minibuf.c (Qmetadata):
      * window.c (resize_window_check, resize_root_window): Now static.
      * window.h (resize_window_check, resize_root_window): Remove decls.
      4b66faf3
    • Paul Eggert's avatar
    • Paul Eggert's avatar
      * window.c: Fix minor problems reported by GCC 4.6.0. · 46a4ce9e
      Paul Eggert authored
      (window_deletion_count, delete_deletable_window): Remove; unused.
      (window_body_lines): Now static.
      (Fdelete_other_windows_internal): Mark vars as initialized.
      Make sure 'resize_failed' is initialized.
      (run_window_configuration_change_hook): Rename local to avoid shadowing.
      (resize_window_apply): Remove unused local.
      * window.h (delete_deletable_window): Remove decl.
      46a4ce9e
    • Paul Eggert's avatar
      * image.c: Fix minor problems reported by GCC 4.6.0. · 33290528
      Paul Eggert authored
      (gif_load, svg_load_image): Rename locals to avoid shadowing.
      (imagemagick_load_image): Fix pointer signedness problem by changing
      last arg from unsigned char * to char *.  All uses changed.
      Also, fix a local for similar reasons.
      Remove unused locals.  Remove locals to avoid shadowing.
      (fn_rsvg_handle_free): Remove; unused.
      (svg_load, svg_load_image): Fix pointer signedness problem.
      33290528
    • Paul Eggert's avatar
    • Paul Eggert's avatar
      Merge from trunk. · e41e9a0e
      Paul Eggert authored
      e41e9a0e
    • Paul Eggert's avatar
      * movemail.c: Fix race condition and related bugs (Bug#8836). · 529a133c
      Paul Eggert authored
      (main) [!MAIL_USE_SYSTEM_LOCK]: Prefer mkstemp to mktemp, as this
      fixes some race conditions.  Report mkstemp/mktemp errno rather
      than a possibly-garbage errno.  Reinitialize the template each
      time through the loop, as earlier mkstemp/mktemp calls could have
      trashed it.  Pass 0600 (not 0666) to mktemp, for consistency
      with mkstemp; the permissions don't matter anyway.
      529a133c
    • Chong Yidong's avatar
    • Martin Rudalics's avatar
      Some more window.h fixes missing in 2011-06-10T06:55:18Z!rudalics@gmx.at. · 2c8e37d4
      Martin Rudalics authored
      * window.h (resize_proportionally, orig_total_lines)
      (orig_top_line): Remove from window structure.
      (set_window_height, set_window_width, change_window_heights)
      (Fdelete_window): Remove prototypes.
      (resize_frame_windows): Remove duplicate declaration.
      2c8e37d4
    • Eli Zaretskii's avatar
      Avoid compiler warnings about missing prototypes of window.c functions. · 440a42e3
      Eli Zaretskii authored
       src/window.h (resize_frame_windows, resize_window_check)
       (delete_deletable_window, resize_root_window)
       (resize_frame_windows): Declare prototypes.
       src/ window.c (resize_window_apply): Make definition be "static" to
       match the prototype.
      440a42e3
    • Martin Rudalics's avatar
      Move window resize code from window.c to window.el. · 562dd5e9
      Martin Rudalics authored
      * window.c: Remove declarations of Qwindow_size_fixed,
      window_min_size_1, window_min_size_2, window_min_size,
      size_window, window_fixed_size_p, enlarge_window, delete_window.
      Remove static from declaration of Qdelete_window, it's
      temporarily needed by Fbury_buffer.
      (replace_window): Don't assign orig_top_line and
      orig_total_lines.
      (Fdelete_window, delete_window): Remove.  Window deletion is
      handled by window.el.
      (window_loop): Remove DELETE_OTHER_WINDOWS case.  Replace
      Fdelete_window calls with calls to Qdelete_window.
      (Fdelete_other_windows): Remove.  Deleting other windows is
      handled by window.el.
      (window_fixed_size_p): Remove.  Fixed-sizeness of windows is
      handled in window.el.
      (window_min_size_2, window_min_size_1, window_min_size): Remove.
      Window minimum sizes are handled in window.el.
      (shrink_windows, size_window, set_window_height)
      (set_window_width, change_window_heights, window_height)
      (window_width, CURBEG, CURSIZE, enlarge_window)
      (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
      (Fenlarge_window, Fshrink_window): Remove.  Window resizing is
      handled in window.el.
      (make_dummy_parent): Rename to make_parent_window and give it a
      second argument horflag.
      (make_window): Don't set resize_proportionally any more.
      (Fsplit_window): Remove.  Windows are split in window.el.
      (save_restore_action, save_restore_orig_size)
      (shrink_window_lowest_first, save_restore_orig_size): Remove.
      Resize mini windows in window.el.
      (grow_mini_window, shrink_mini_window): Implement by calling
      Qresize_root_window_vertically, resize_window_check and
      resize_window_apply.
      (saved_window, Fset_window_configuration, save_window_save): Do
      not handle orig_top_line, orig_total_lines, and
      resize_proportionally.
      (window_min_height, window_min_width): Move to window.el.
      (keys_of_window): Move bindings for delete-other-windows,
      split-window, delete-window and enlarge-window to window.el.
      
      * buffer.c: Temporarily extern Qdelete_window.
      (Fbury_buffer): Temporarily call Qdelete_window instead of
      Fdelete_window (Fbury_buffer will move to window.el soon).
      
      * frame.c (set_menu_bar_lines_1): Remove code handling
      orig_top_line and orig_total_lines.
      
      * dispnew.c (adjust_frame_glyphs_initially): Don't use
      set_window_height but set heights directly.
      (change_frame_size_1): Use resize_frame_windows.
      
      * xdisp.c (init_xdisp): Don't use set_window_height but set
      heights directly.
      
      * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
      resize_frame_windows instead of change_window_heights and run
      run_window_configuration_change_hook.
      
      * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
      instead of change_window_heights and run
      run_window_configuration_change_hook.
      
      * window.el (window-min-height, window-min-width): Move here
      from window.c.  Add defcustoms and rewrite doc-strings.
      (resize-mini-window, resize-window): New functions.
      (adjust-window-trailing-edge, enlarge-window, shrink-window):
      Move here from window.c.
      (maximize-window, minimize-window): New functions.
      (delete-window, delete-other-windows, split-window): Move here
      from window.c.
      (window-split-min-size): New function.
      (split-window-keep-point): Mention split-window-above-each-other
      instead of split-window-vertically.
      (split-window-above-each-other, split-window-vertically): Rename
      split-window-vertically to split-window-above-each-other and
      provide defalias for old definition.
      (split-window-side-by-side, split-window-horizontally): Rename
      split-window-horizontally to split-window-side-by-side and provide
      defalias for the old definition.
      (ctl-x-map): Move bindings for delete-window,
      delete-other-windows and enlarge-window here from window.c.
      Replace bindings for split-window-vertically and
      split-window-horizontally by bindings for
      split-window-above-each-other and split-window-side-by-side.
      
      * cus-start.el (all): Remove entries for window-min-height and
      window-min-width.  Add entries for window-splits and
      window-nest.
      562dd5e9
    • Katsumi Yamaoka's avatar
      Improve Gnus' dribble data handling. · b229f37d
      Katsumi Yamaoka authored
      b229f37d
  5. 09 Jun, 2011 5 commits