1. 16 Aug, 2013 4 commits
  2. 15 Aug, 2013 2 commits
    • Stefan Monnier's avatar
      * lisp/emacs-lisp/debug.el (debugger-setup-buffer): Put point on the · 10fa0ed3
      Stefan Monnier authored
      previous line.
      (debugger-eval-expression, debugger-record-expression):
      Use read--expression (bug#15102).
      
      Fixes: debbugs:15101
      10fa0ed3
    • Michael Albinus's avatar
      Remove byte compiler warnings, visible when compiling with · 5d89d9d2
      Michael Albinus authored
      `byte-compile-force-lexical-warnings' set to t.
      
      * net/tramp.el (tramp-debug-message, tramp-message, tramp-error)
      (tramp-error-with-buffer): Rename ARGS to ARGUMENTS and BUFFER to BUF.
      (tramp-handle-unhandled-file-name-directory)
      (tramp-handle-file-notify-add-watch, tramp-action-login)
      (tramp-action-succeed, tramp-action-permission-denied)
      (tramp-action-terminal, tramp-action-process-alive): Prefix unused
      arguments with "_".
      
      * net/tramp-adb.el (tramp-adb-parse-device-names)
      (tramp-adb-handle-insert-directory, tramp-adb-handle-delete-file)
      (tramp-adb-handle-copy-file): Prefix unused arguments with "_".
      (tramp-adb-handle-file-truename): Remove unused arguments.
      
      * net/tramp-cache.el (tramp-flush-directory-property)
      (tramp-flush-connection-property, tramp-list-connections)
      (tramp-parse-connection-properties): Prefix unused arguments with "_".
      
      * net/tramp-compat.el (tramp-compat-make-temp-file): Rename
      FILENAME to F.
      
      * net/tramp-gvfs.el (tramp-gvfs-handle-file-notify-add-watch)
      (tramp-gvfs-handle-write-region, tramp-bluez-parse-device-names)
      (tramp-zeroconf-parse-workstation-device-names)
      (tramp-zeroconf-parse-webdav-device-names)
      (tramp-synce-parse-device-names): Prefix unused arguments with "_".
      
      * net/tramp-gw.el (tramp-gw-gw-proc-sentinel)
      (tramp-gw-aux-proc-sentinel): Prefix unused arguments with "_".
      
      * net/tramp-sh.el (tramp-sh-handle-file-truename): Remove unused
      arguments.
      (tramp-sh-handle-copy-file, tramp-sh-handle-dired-compress-file)
      (tramp-sh-handle-insert-file-contents-literally)
      (tramp-sh-handle-file-notify-add-watch): Prefix unused arguments
      with "_".
      (tramp-do-copy-or-rename-file, tramp-barf-if-no-shell-prompt):
      Remove unused variables.
      
      * net/tramp-smb.el (tramp-smb-handle-copy-directory)
      (tramp-smb-handle-copy-file, tramp-smb-handle-delete-file)
      (tramp-smb-read-file-entry): Prefix unused arguments with "_".
      
      * net/tramp-uu.el (tramp-uu-b64-alphabet, tramp-uu-b64-char-to-byte):
      Make them a defconst.
      (tramp-uuencode-region): Remove unused variable.
      5d89d9d2
  3. 14 Aug, 2013 3 commits
    • Juanma Barranquero's avatar
      lisp/frameset.el: Allow orphaned minibufferless frames. · 14d1e463
      Juanma Barranquero authored
      (frameset-filter-minibuffer): Deal with the case that the minibuffer
      parameter was already set in FILTERED.  Doc fix.
      (frameset--record-minibuffer-relationships): Allow saving a
      minibufferless frame without its corresponding minibuffer frame.
      (frameset--reuse-frame): Accept a match from an orphaned minibufferless
      frame, if the frame id matches.
      (frameset--minibufferless-last-p): Sort non-orphaned minibufferless
      frames before orphaned ones.
      (frameset-restore): Warn about orphaned windows, instead of error out.
      14d1e463
    • Juanma Barranquero's avatar
      lisp/frameset.el: Use gv-setter declaration. · 62f33bae
      Juanma Barranquero authored
      (frameset--prop-setter): New function.
      (frameset-prop): Add gv-setter declaration.
      62f33bae
    • Martin Rudalics's avatar
      Fix some issues in window.el. · c660a885
      Martin Rudalics authored
      * window.el (window-make-atom): Don't overwrite parameter
      already present.
      (display-buffer-in-atom-window): Handle special case where we
      split an already atomic window.
      (window--major-non-side-window, display-buffer-in-side-window)
      (window--side-check): Ignore minibuffer window when walking
      window tree.
      (window-deletable-p): Return 'frame only if no other frame uses
      our minibuffer window.
      (record-window-buffer): Run buffer-list-update-hook.
      (split-window): Make sure window--check-frame won't destroy an
      existing atomic window in case the new window gets nested
      inside.
      (display-buffer-at-bottom): Ignore minibuffer window when
      walking window tree.  Don't split a side window.
      (pop-to-buffer): Don't set-buffer here, the select-window call
      should do that.
      (mouse-autoselect-window-select): Autoselect only if we are in the
      text portion of the window.
      c660a885
  4. 13 Aug, 2013 9 commits
  5. 12 Aug, 2013 3 commits
  6. 11 Aug, 2013 3 commits
    • Lars Magne Ingebrigtsen's avatar
      * net/eww.el (eww-display-html): Ignore coding system errors. · 3e41a054
      Lars Magne Ingebrigtsen authored
      One web site uses "utf-8lias" as the coding system.
      3e41a054
    • Juanma Barranquero's avatar
    • Juanma Barranquero's avatar
      lisp/*.el: More lexical-binding warnings' cleanups. · 9a4ebc74
      Juanma Barranquero authored
      * tutorial.el (tutorial--describe-nonstandard-key): Use string-match-p.
        (tutorial--detailed-help): Remove unused local variables.
        (tutorial--save-tutorial-to): Use ignore-errors.
        (help-with-tutorial): Use looking-at-p.
      
      * view.el (view-buffer-other-window, view-buffer-other-frame):
        Mark unused arguments.
      
      * woman.el (woman-parse-colon-path, woman-parse-colon-path)
        (woman-select-symbol-fonts, woman, woman-find-file)
        (woman-insert-file-contents, woman-non-underline-faces):
        Use string-match-p.
        (woman1-unquote): Move declaration.
      
      * xml.el (xml-parse-tag-1, xml-parse-string): Use looking-at-p.
        (xml-parse-dtd): Use looking-at-p, string-match-p.  Mark unused
        argument.  Remove unused local variable.
        (xml-parse-elem-type): Use string-match-p.
        (xml-substitute-numeric-entities): Use ignore-errors.
      9a4ebc74
  7. 10 Aug, 2013 3 commits
    • Juanma Barranquero's avatar
      lisp/*.el: Remove lexical-binding warnings; additional small cleanups. · 45fdb482
      Juanma Barranquero authored
      * calculator.el (calculator): Mark unused argument.
        (calculator-paste, calculator-quit, calculator-integer-p):
        Use ignore-errors.
        (calculator-string-to-number, calculator-decimal, calculator-exp)
        (calculator-op-or-exp): Use string-match-p.
      
      * dired-aux.el (dired-compress): Use ignore-errors.
        (dired-do-chxxx, dired-do-chmod, dired-trample-file-versions)
        (dired-do-async-shell-command, dired-do-shell-command)
        (dired-shell-stuff-it, dired-compress-file, dired-insert-subdir)
        (dired-insert-subdir-validate): Use string-match-p.
        (dired-map-dired-file-lines, dired-subdir-hidden-p): Use looking-at-p.
        (dired-add-entry): Use string-match-p, looking-at-p.
        (dired-insert-subdir-newpos): Remove unused local variable.
      
      * dired.el (dired-buffer-more-recently-used-p): Declare.
        (dired-insert-set-properties, dired-insert-old-subdirs):
        Use ignore-errors.
      
      * filenotify.el (file-notify-callback): Remove unused local variable.
      
      * filesets.el (filesets-error): Mark unused argument.
        (filesets-which-command-p, filesets-filter-dir-names)
        (filesets-directory-files, filesets-get-external-viewer)
        (filesets-ingroup-get-data): Use string-match-p.
      
      * find-file.el (ff-other-file-name, ff-other-file-name)
        (ff-find-the-other-file, ff-cc-hh-converter):
        Remove unused local variables.
        (ff-get-file-name): Use string-match-p.
        (ff-all-dirs-under): Use ignore-errors.
      
      * follow.el (follow-comint-scroll-to-bottom): Mark unused argument.
        (follow-select-if-visible): Remove unused local variable.
      
      * forms.el (read-file-filter): Move declaration.
        (forms--make-format, forms--make-parser, forms-insert-record):
        Quote function with #'.
        (forms--update): Use string-match-p.  Quote function with #'.
      
      * help-mode.el (help-dir-local-var-def): Mark unused argument.
        (help-make-xrefs): Use looking-at-p.
        (help-xref-on-pp): Use looking-at-p, ignore-errors.
      
      * ibuffer.el (ibuffer-ext-visible-p): Declare.
        (ibuffer-confirm-operation-on): Use string-match-p.
      
      * msb.el (msb-item-handler, msb-dired-item-handler):
        Mark unused arguments.
      
      * ses.el (ses-decode-cell-symbol)
        (ses-kill-override): Remove unused local variable.
        (ses-create-cell-variable, ses-relocate-formula): Use string-match-p.
        (ses-load): Use ignore-errors, looking-at-p.
        (ses-jump-safe): Use ignore-errors.
        (ses-export-tsv, ses-export-tsf, ses-unsafe): Mark unused arguments.
      
      * tabify.el (untabify, tabify): Mark unused arguments.
      
        * thingatpt.el (thing-at-point--bounds-of-well-formed-url):
        Mark unused argument.
        (bounds-of-thing-at-point, thing-at-point-bounds-of-list-at-point)
        (thing-at-point-newsgroup-p, form-at-point): Use ignore-errors.
      45fdb482
    • Juanma Barranquero's avatar
    • Juanma Barranquero's avatar
      lisp/completion.el: Remove stuff unused since 2013-03-15T16:06:12Z!handa@gnu.org. · 5660113b
      Juanma Barranquero authored
      (*record-cmpl-statistics-p*): Remove (was commented out ).
      (cmpl-statistics-block): Remove (body was commented out).
      All callers changed.
      (add-completions-from-buffer, load-completions-from-file):
      Remove unused variables.
      5660113b
  8. 09 Aug, 2013 7 commits
    • Juanma Barranquero's avatar
      lisp/filecache.el (file-cache-delete-file-list): Print message only when told so. · 5c5dee78
      Juanma Barranquero authored
      (file-cache-files-matching): Use #' in mapconcat argument.
      5c5dee78
    • Juanma Barranquero's avatar
    • Stefan Monnier's avatar
      * lisp/subr.el (define-error): New function. · 54bd972f
      Stefan Monnier authored
      * doc/lispref/control.texi (Signaling Errors): Refer to define-error.
      (Error Symbols): Add `define-error'.
      * doc/lispref/errors.texi (Standard Errors): Don't refer to `error-conditions'.
      * lisp/progmodes/ada-xref.el (ada-error-file-not-found): Rename from
      error-file-not-found and define with define-error.
      * lisp/emacs-lisp/cl-lib.el (cl-assertion-failed): Move here from subr.el
      and define with define-error.
      * lisp/userlock.el (file-locked, file-supersession):
      * lisp/simple.el (mark-inactive):
      * lisp/progmodes/js.el (js-moz-bad-rpc, js-js-error):
      * lisp/progmodes/ada-mode.el (ada-mode-errors):
      * lisp/play/life.el (life-extinct):
      * lisp/nxml/xsd-regexp.el (xsdre-invalid-regexp, xsdre-parse-error):
      * lisp/nxml/xmltok.el (xmltok-markup-declaration-parse-error):
      * lisp/nxml/rng-util.el (rng-error):
      * lisp/nxml/rng-uri.el (rng-uri-error):
      * lisp/nxml/rng-match.el (rng-compile-error):
      * lisp/nxml/rng-cmpct.el (rng-c-incorrect-schema):
      * lisp/nxml/nxml-util.el (nxml-error, nxml-file-parse-error):
      * lisp/nxml/nxml-rap.el (nxml-scan-error):
      * lisp/nxml/nxml-outln.el (nxml-outline-error):
      * lisp/net/soap-client.el (soap-error):
      * lisp/net/gnutls.el (gnutls-error):
      * lisp/net/ange-ftp.el (ftp-error):
      * lisp/mpc.el (mpc-proc-error):
      * lisp/json.el (json-error, json-readtable-error, json-unknown-keyword)
      (json-number-format, json-string-escape, json-string-format)
      (json-key-format, json-object-format):
      * lisp/jka-compr.el (compression-error):
      * lisp/international/quail.el (quail-error):
      * lisp/international/kkc.el (kkc-error):
      * lisp/emacs-lisp/ert.el (ert-test-failed):
      * lisp/calc/calc.el (calc-error, inexact-result, math-overflow)
      (math-underflow):
      * lisp/bookmark.el (bookmark-error-no-filename):
      * lisp/epg.el (epg-error): Define with define-error.
      54bd972f
    • Stefan Monnier's avatar
      * lisp/time.el (display-time-event-handler) · 0ea9e53a
      Stefan Monnier authored
      (display-time-next-load-average): Don't call sit-for since it seems
      unnecessary.
      
      Fixes: debbugs:15045
      0ea9e53a
    • Stefan Monnier's avatar
      * lisp/emacs-lisp/checkdoc.el: Remove redundant :group keywords. · b0429158
      Stefan Monnier authored
      Use #' instead of ' to quote functions.
      (checkdoc-output-mode): Use setq-local.
      (checkdoc-spellcheck-documentation-flag, checkdoc-ispell-lisp-words)
      (checkdoc-verb-check-experimental-flag, checkdoc-proper-noun-regexp)
      (checkdoc-common-verbs-regexp): Mark safe-local-variable.
      (checkdoc-ispell, checkdoc-ispell-current-buffer)
      (checkdoc-ispell-interactive, checkdoc-ispell-message-interactive)
      (checkdoc-ispell-message-text, checkdoc-ispell-start)
      (checkdoc-ispell-continue, checkdoc-ispell-comments)
      (checkdoc-ispell-defun): Remove unused arg `take-notes'.
      
      Fixes: debbugs:15010
      b0429158
    • Stefan Monnier's avatar
    • Juanma Barranquero's avatar
      Move frameset-to-register stuff from register.el to frameset.el. · 77187e6f
      Juanma Barranquero authored
      lisp/register.el (frameset-frame-id, frameset-frame-with-id, frameset-p)
      (frameset-restore, frameset-save, frameset-session-filter-alist):
      Remove declarations.
      (register-alist): Doc fix.
      (frameset-to-register): Move to frameset.el.
      (jump-to-register, describe-register-1): Remove frameset-specific code.
      
      lisp/frameset.el (frameset-p): Add autoload cookie.
      (frameset--jump-to-register): New function, based on code moved from
      register.el.
      (frameset-to-register): Move from register.el.  Adapt to `registerv'.
      77187e6f
  9. 08 Aug, 2013 6 commits