1. 26 Jan, 2015 10 commits
  2. 25 Jan, 2015 9 commits
    • Eli Zaretskii's avatar
      Use bool for boolean in w32term.c · 03a20dc9
      Eli Zaretskii authored
       src/w32term.c (x_update_window_begin, x_update_window_end)
       (x_update_end, x_after_update_window_line)
       (x_set_glyph_string_gc, x_draw_glyph_string_background)
       (x_draw_image_glyph_string, x_draw_glyph_string)
       (x_draw_stretch_glyph_string, note_mouse_movement)
       (w32_mouse_position, x_scroll_bar_report_motion)
       (x_horizontal_scroll_bar_report_motion, w32_read_socket)
       (w32_set_vertical_scroll_bar, w32_set_horizontal_scroll_bar)
       (w32_draw_window_cursor, x_new_font, x_set_offset)
       (x_set_window_size, x_make_frame_invisible, x_iconify_frame): Use
       bool where appropriate.
    • Eli Zaretskii's avatar
      Use bool for boolean in w32fns.c · 49b82274
      Eli Zaretskii authored
       src/w32fns.c (w32_defined_color, x_decode_color)
       (Fxw_color_defined_p, Fxw_color_values, x_set_icon_type)
       (x_set_menu_bar_lines, x_change_tool_bar_height)
       (x_set_internal_border_width, x_explicitly_set_name)
       (x_implicitly_set_name, Fx_create_frame, w32_window)
       (x_create_tip_frame, Fx_show_tip): Use bool where appropriate.
    • Paul Eggert's avatar
      Use bool for boolean in xfns.c · 11a9f377
      Paul Eggert authored
      * xfaces.c (x_update_menu_appearance):
      * xfns.c (x_real_positions, x_defined_color, x_decode_color)
      (xg_set_icon, xg_set_icon_from_xpm_data, x_set_cursor_color)
      (x_set_icon_type, x_set_icon_name, x_set_menu_bar_lines)
      (x_change_tool_bar_height, x_set_internal_border_width)
      (x_encode_text, x_set_name_internal, x_explicitly_set_name)
      (x_implicitly_set_name, x_default_scroll_bar_color_parameter)
      (hack_wm_protocols, xic_create_fontsetname, xic_free_xfontset)
      (x_window, x_icon, Fx_wm_set_size_hint, Fx_create_frame)
      (Fxw_color_defined_p, Fxw_color_values, x_create_tip_frame)
      (Fx_show_tip, clean_up_file_dialog, Fx_file_dialog)
      (clean_up_dialog, syms_of_xfns):
      * xterm.h (xg_set_icon, xg_set_icon_from_xpm_data)
      Use bool for boolean.
      * xfns.c: Include bitmaps/gray.xbm unconditionally.
    • Paul Eggert's avatar
      Count MANY function args more reliably · a3689d3c
      Paul Eggert authored
      * alloc.c (Fgc_status, purecopy, unbind_to, garbage_collect_1):
      * buffer.c (Fbuffer_list, Fkill_buffer):
      * callint.c (read_file_name, Fcall_interactively):
      * charset.c (Fset_charset_priority, syms_of_charset):
      * chartab.c (uniprop_encode_value_numeric):
      * coding.c (syms_of_coding):
      * composite.c (syms_of_composite):
      * data.c (wrong_range):
      * dbusbind.c (syms_of_dbusbind):
      * dired.c (file_attributes):
      * editfns.c (Fdecode_time, update_buffer_properties, format2):
      * eval.c (run_hook_with_args_2, apply1, call1, call2, call3)
      (call4, call5, call6, call7):
      * fileio.c (Finsert_file_contents, choose_write_coding_system)
      (Fcar_less_than_car, build_annotations, auto_save_error):
      * filelock.c (get_boot_time):
      * fns.c (internal_equal, nconc2, Fyes_or_no_p, Fwidget_apply):
      (maybe_resize_hash_table, secure_hash):
      * font.c (font_style_to_value, font_open_by_name, Flist_fonts):
      * fontset.c (fontset_add, Fset_fontset_font):
      * ftfont.c (ftfont_lookup_cache):
      * gtkutil.c (xg_get_font):
      * insdel.c (signal_before_change, signal_after_change):
      * keymap.c (append_key):
      * lread.c (load_warn_old_style_backquotes, Fload, init_lread):
      * minibuf.c (Fread_buffer):
      * print.c (print_preprocess):
      * process.c (Fformat_network_address, Fmake_network_process)
      * sound.c (Fplay_sound_internal):
      * term.c (Fsuspend_tty, Fresume_tty):
      * window.c (window_list):
      * xdisp.c (run_redisplay_end_trigger_hook, add_to_log)
      * xfaces.c (Fx_list_fonts):
      * xfont.c (syms_of_xfont):
      * xselect.c (x_handle_selection_request)
      (x_handle_selection_clear, x_clear_frame_selections)
      Prefer CALLMANY and CALLN to counting args by hand.
      * doc.c (reread_doc_file): Remove unused code.
      * fns.c (concat2, concat3): Redo to avoid need for local-var vector.
      (cmpfn_user_defined, hashfn_user_defined, Fmaphash):
      Prefer call1 and call2 to Ffuncall.
      * keyboard.c (safe_run_hook_funcall, safe_run_hooks):
      Use struct literal rather than a local var, for simplicity.
      * keymap.c (where_is_internal): Use NULL rather than a pointer
      to unused args.
      * lisp.h (CALLMANY, CALLN): New macros.
      * sound.c (Fplay_sound_internal): Coalesce duplicate code.
      Fixes: bug#19634
    • Stefan Monnier's avatar
      * lisp/emacs-lisp/cl-generic.el: Fix next-method-p test · c4e54f96
      Stefan Monnier authored
      Fixes: debbugs:19672
      * lisp/emacs-lisp/cl-generic.el (cl--generic-no-next-method-function): New.
      (cl--generic-build-combined-method, cl--generic-nnm-sample): Use it.
      (cl--generic-typeof-types): Add support for `sequence'.
      (cl-defmethod): Add non-keywords in the qualifiers.
    • Lars Ingebrigtsen's avatar
    • Paul Eggert's avatar
      * indent/shell.sh (bar): Use '[ $# -eq 0 ]', not '[ $# == 0 ]'. · 407e6bee
      Paul Eggert authored
      This is more portable in shell scripts.
      Fixes: bug#19658
    • Paul Eggert's avatar
      Use gnustep-config if available · f6ef8365
      Paul Eggert authored
      * configure.ac (--with-gnustep): Document this.
      (NS_GNUSTEP_CONFIG): New variable, set if gnustep-config works.
      If gnustep-config works, use 'gnustep-config --objc-flags' and
      'gnustep-config --gui-libs' to compute GNUstep configuration
      variables, instead of attempting to infer them individually.
      * etc/NEWS: Document this.
      * src/emacs.c [NS_IMPL_GNUSTEP]: Don't include <GNUstepBase/GSConfig.h>.
      It doesn't appear to be needed, and the inclusion breaks on
      Ubuntu 14.10 when 'configure' uses 'gnustep-config'.
      Fixes: bug#19507
    • Dmitry Gutov's avatar
      (find-function-regexp): Don't match `defgroup' · bce27d88
      Dmitry Gutov authored
      * lisp/emacs-lisp/find-func.el (find-function-regexp): Don't match
      `defgroup' (regression from the previous change here).
  3. 24 Jan, 2015 1 commit
    • Paul Eggert's avatar
      Fix a couple of AM_V_GEN bugs · 02cbd38a
      Paul Eggert authored
      * admin/unidata/Makefile.in (unifiles):
      Use AM_V_at instead of AM_V_GEN, since this doesn't generate a file.
      * lib-src/Makefile.in (AM_V_GEN, am__v_GEN_, am__v_GEN_0, am__v_GEN_1)
      (AM_V_at, am__v_at_, am__v_at_0, am__v_at_1):
      New macros, copied from ../src/Makefile.in.
  4. 23 Jan, 2015 3 commits
  5. 22 Jan, 2015 12 commits
    • Jorgen Schaefer's avatar
      Re-add and fix prioritized archives test. · 2f908e0c
      Jorgen Schaefer authored
      * automated/package-test.el (package-test-install-prioritized):
      Re-add the test case and add priority to the correct repository
      this time around.
    • Eli Zaretskii's avatar
    • Glenn Morris's avatar
      Auto-commit of loaddefs files. · d7995b18
      Glenn Morris authored
    • Paul Eggert's avatar
      Check exit statuses in lib-src/Makefile · 74ab488f
      Paul Eggert authored
      * Makefile.in ($(DESTDIR)${archlibdir}, install, uninstall)
      (mostlyclean, clean, distclean, extraclean):
      Check exit statuses more carefully.  Reindent to fit in 80 chars.
      (bootstrap-clean maintainer-clean): Remove unnecessary 'true'.
    • Paul Eggert's avatar
      Use bool for boolean in xfont.c, xftfont.c, xgselect.c · b631bb57
      Paul Eggert authored
      * xfont.c (xfont_driver, xfont_chars_supported)
      * xftfont.c (xftfont_get_colors, xftfont_open)
      (xftfont_prepare_face, xftfont_done_face)
      * xgselect.c (xg_select):
      Use bool for boolean.
    • Ulrich Müller's avatar
      Don't fail if chown or chgrp for 'update-game-score' is unsuccessful. · 7f4e7dd3
      Ulrich Müller authored
      * lib-src/Makefile.in ($(DESTDIR)${archlibdir}): Don't fail if the
      chown or chgrp command is unsuccessful; the 'update-game-score'
      program has a fallback for this at runtime.
    • Paul Eggert's avatar
      Spelling fix · 394b976f
      Paul Eggert authored
    • Paul Eggert's avatar
      Don't downcase system diagnostics' first letters · 8dd58a2d
      Paul Eggert authored
      * etc/NEWS: Document this.
      * lisp/emacs-lisp/bytecomp.el (byte-compile-file):
      * lisp/ffap.el (find-file-at-point):
      * lisp/files.el (insert-file-1):
      * lisp/net/ange-ftp.el (ange-ftp-barf-if-not-directory)
      * lisp/progmodes/etags.el (visit-tags-table):
      * lisp/url/url-dav.el (url-dav-delete-directory, url-dav-delete-file)
      Keep diagnostics consistent with system's.
      * lisp/erc/erc-dcc.el (erc-dcc-server):
      * lisp/ffap.el (ffap-machine-p):
      Ignore case while comparing diagnostics.
      * src/fileio.c (report_file_errno): Don't downcase, and simplify.
      Fixes: bug#19642
    • Stefan Monnier's avatar
      Avoid generating invalid usage info for pathological function · 938bca8e
      Stefan Monnier authored
      Fixes: debbugs:19645
      * lisp/help.el (help-make-usage): Don't turn a "_" arg into an empty-string.
      * lisp/emacs-lisp/cl-generic.el (cl--generic-lambda): Don't confuse a string
      body with a docstring.
    • Paul Eggert's avatar
      Better isolate code that assumes NIL_IS_ZERO · 74244d23
      Paul Eggert authored
      Suggested by Stefan Monnier in:
      * alloc.c (allocate_pseudovector):
      Use memclear, not memsetnil, to remove a 'verify'.
      * callint.c (Fcall_interactively):
      * dispnew.c (realloc_glyph_pool):
      * xdisp.c (init_iterator):
      Use memclear, not memset, to remove a 'verify'.
      * lisp.h (memclear): Rename from memsetnil, and take a byte
      count rather than a word count.  All callers changed.
    • Dmitry Gutov's avatar
      xref: Replace defgeneric and defmethod with cl- counterparts · 03346fb0
      Dmitry Gutov authored
      * lisp/progmodes/xref.el (xref-location-marker, xref-location-group):
      Use `cl-defgeneric' and `cl-defmethod' instead of the EIEIO
      * lisp/progmodes/etags.el (xref-location-marker): Same.
    • Dmitry Gutov's avatar
      xref: Input history and minor tweaks · a17a5dae
      Dmitry Gutov authored
      * lisp/progmodes/xref.el (xref--current): Rename from `xref--selected'.
      (xref--inhibit-mark-current): Rename from
      `xref--inhibit-mark-selected'.  Update the usages.
      (xref-quit): Reword the docstring.  Kill buffers after quitting
      windows instead of before.
      (xref--insert-xrefs): Tweak help-echo.
      (xref--read-identifier-history, xref--read-pattern-history):
      New variables.
      (xref--read-identifier, xref-find-apropos): Use them.
  6. 21 Jan, 2015 5 commits
    • Ulrich Müller's avatar
      Allow update-game-score to run sgid instead of suid. · 20f66485
      Ulrich Müller authored
      * configure.ac (gamegroup): New AC_SUBST.
      (--with-gameuser): Allow to specify a group instead of a user.
      In the default case, check at configure time if a 'games' user
      * lib-src/update-game-score.c: Allow the program to run sgid
      instead of suid, in order to match common practice for most games.
      (main): Check if we are running sgid.  Pass appropriate file
      permission bits to 'write_scores'.
      (write_scores): New 'mode' argument, instead of hardcoding 0644.
      (get_prefix): Update error message.
      * lib-src/Makefile.in (gamegroup): New variable, set by configure.
      ($(DESTDIR)${archlibdir}): Handle both suid or sgid when
      installing the 'update-game-score' program.
      * lisp/play/gamegrid.el (gamegrid-add-score-with-update-game-score):
      Allow the 'update-game-score' helper program to run suid or sgid.
    • Stefan Monnier's avatar
      * lisp/emacs-lisp/eieio*.el: Fix up warnings and improve compatibility · 59e7fe6d
      Stefan Monnier authored
      Fixes: debbugs:19645
      * lisp/emacs-lisp/cl-generic.el (cl-defgeneric): Add support for `declare'.
      (cl--generic-setf-rewrite): Setup the setf expander right away.
      (cl-defmethod): Make sure the setf expander is setup before we expand
      the body.
      (cl-defmethod): Silence byte-compiler warnings.
      (cl-generic-define-method): Shuffle code to change return value.
      (cl--generic-method-info): New function, extracted from
      (cl--generic-describe): Use it.
      * lisp/emacs-lisp/eieio-speedbar.el:
      * lisp/emacs-lisp/eieio-datadebug.el:
      * lisp/emacs-lisp/eieio-custom.el:
      * lisp/emacs-lisp/eieio-base.el: Use cl-defmethod.
      * lisp/emacs-lisp/eieio-compat.el (eieio--defmethod): Avoid no-next-method
      errors when there's a `before' but no `primary'.
      (next-method-p): Return nil rather than signal an error.
      (eieio-defgeneric): Remove bogus (fboundp 'method).
      * lisp/emacs-lisp/eieio-opt.el: Adapt to cl-generic.
      (eieio--specializers-apply-to-class-p):	New function.
      (eieio-all-generic-functions): Use it.
      (eieio-method-documentation): Use it as well as cl--generic-method-info.
      Change format of return value.
      (eieio-help-class): Adapt accordingly.
      * lisp/emacs-lisp/eieio.el: Use cl-defmethod.
      (defclass): Generate cl-defmethod calls; use setf methods for :accessor.
      (eieio-object-name-string): Declare as obsolete.
      * test/automated/cl-generic-tests.el (setf cl--generic-2): Make sure
      the setf can be used already in the body of the method.
    • Glenn Morris's avatar
      Auto-commit of loaddefs files. · 41efcf4d
      Glenn Morris authored
    • Dmitry Gutov's avatar
      Remap quit-window to xref-quit in xref buffers · e7697d97
      Dmitry Gutov authored
      Fixes: debbugs:19466
      * lisp/progmodes/xref.el (xref--xref-buffer-mode-map): Define before
      the major mode.  Remap `quit-window' to `xref-quit'.
      (xref--xref-buffer-mode): Inherit from special-mode.
    • Dmitry Gutov's avatar
      xref: Keep track of temporary buffers · 956b13c5
      Dmitry Gutov authored
      Fixes: debbugs:19466
      xref: Keep track of temporary buffers.
      * lisp/progmodes/xref.el (xref--temporary-buffers, xref--selected)
      (xref--inhibit-mark-selected): New variables.
      (xref--mark-selected): New function.
      (xref--show-location): Maybe add the buffer to
      `xref--temporary-buffers', add `xref--mark-selected' to
      `buffer-list-update-hook' there.
      (xref--window): Add docstring.
      (xref-quit): Rename from `xref--quit'.  Update both references.
      Add KILL argument.  When it's non-nil, kill the temporary buffers
      that haven't been selected by the user.
      (xref--show-xref-buffer): Change the second argument to alist,
      extract the values for `xref--window' and
      `xref--temporary-buffers' from it.  Add `xref--mark-selected' to
      `buffer-list-update-hook' to each buffer in the list.
      (xref--show-xrefs): Move the logic of calling `xref-find-function'
      here.  Save the difference between buffer lists before and after
      it's called as "temporary buffers", and `pass it to
      (xref--find-definitions, xref-find-references)
      (xref-find-apropos): Update accordingly.