GitLab

Without this change, on typical 64-bit hosts error ("...%d...", N)
was used to print both 32- and 64-bit integers N, which relied on
undefined behavior.
* lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
New macro.
* lisp.h (error, verror): Mark as printf-like functions.
* eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
Report overflow in size calculations when allocating printf buffer.
Do not truncate output string at its first null byte.
* xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
Truncate the output at a character boundary, since vsnprintf does not
do that.
* charset.c (check_iso_charset_parameter): Convert internal
character to string before calling 'error', since %c now has the
printf meaning.
* coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
overflow when computing char to be passed to 'error'.  Do not
pass Lisp_Object to 'error'; pass the integer instead.
* nsfns.m (Fns_do_applescript): Use int, not long, since it's
formatted with plain %d.

 msdos/sedlibmk.inp: Update checklist.
 (am_libgnu_a_OBJECTS): Remove careadlinkat.$(OBJEXT).
 ($(top_builddir)/config.status): Edit away, both as target and in
 prerequisites.
 (@am__fastdepCC_FALSE@): Fix editing.
 (@GL_GENERATE_STDBOOL_H_TRUE@, @GL_GENERATE_STDBOOL_H_FALSE@)
 (@GL_GENERATE_STDDEF_H_TRUE@, @GL_GENERATE_STDDEF_H_FALSE@)
 (@GL_GENERATE_STDINT_H_TRUE@, @GL_GENERATE_STDINT_H_FALSE@): Edit
 to either nothing or "#".
 src/msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.

 src/w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
 lib/makefile.w32-in ($(BLD)/careadlinkat.$(O), GNULIBOBJS):
 Revert last change.

by passing a long int to a printf format expecting an int.

Mark as printf-like functions.

printf-like functions.
(tiff_load): Add casts to remove these marks before passing them
to system-supplied API.

directly, rather than having caller test rule sign.  This avoids
some unnecessary tests.
* composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
(COMPOSITION_ENCODE_RULE): Arguments now must be valid.  This
affects only one use, in DECODE_COMPOSITION_RULE, which is changed.

This avoids several warnings with gcc -Wstrict-overflow.

Use EMACS_INT, not int, for length.

breaking out part of COMPOSITION_DECODE_RULE.
(COMPOSITION_DECODE_RULE): Use it.
* composite.c (get_composition_id): Remove unused local vars,
by using the new macro.

since the condition is always true at first.

All uses changed.

(exec_sentinel): Remove vars that were set but not used.