1. 01 Dec, 2019 1 commit
    • Michael Albinus's avatar
      Suppress superfluous messages in tramp-tests · ec65b9ad
      Michael Albinus authored
      * test/lisp/net/tramp-tests.el (tramp-test10-write-region)
      (tramp-test10-write-region-file-precious-flag)
      (tramp-test34-connection-local-variables)
      (tramp-test36-vc-registered): Let-bind `inhibit-message'.
      ec65b9ad
  2. 13 Nov, 2019 1 commit
    • Michael Albinus's avatar
      Adapt Tramp docstrings according to checkdoc · d3438460
      Michael Albinus authored
      * lisp/net/tramp.el (tramp-backup-directory-alist)
      (tramp-echoed-echo-mark-regexp, tramp-syntax-values)
      (tramp-lookup-syntax, tramp-build-prefix-format)
      (tramp-build-prefix-regexp, tramp-build-method-regexp)
      (tramp-build-postfix-method-format)
      (tramp-build-postfix-method-regexp)
      (tramp-build-prefix-ipv6-format, tramp-build-prefix-ipv6-regexp)
      (tramp-build-postfix-ipv6-format)
      (tramp-build-postfix-ipv6-regexp)
      (tramp-build-postfix-host-format)
      (tramp-build-postfix-host-regexp, tramp-unknown-id-string)
      (tramp-unknown-id-integer, tramp-build-file-name-regexp)
      (tramp-build-completion-file-name-regexp, tramp-chunksize)
      (tramp-find-method, tramp-find-user, tramp-find-host)
      (tramp-dissect-file-name, tramp-get-buffer)
      (tramp-get-connection-buffer, tramp-debug-message, tramp-error)
      (with-tramp-connection-property, tramp-run-real-handler)
      (tramp-file-name-for-operation, tramp-file-name-handler)
      (tramp-completion-file-name-handler)
      (tramp-completion-handle-file-name-completion)
      (tramp-completion-dissect-file-name)
      (tramp-completion-dissect-file-name1)
      (tramp-handle-file-name-as-directory)
      (tramp-handle-file-name-directory)
      (tramp-handle-file-name-nondirectory, tramp-mode-string-to-int)
      (tramp-file-mode-from-int):
      * lisp/net/tramp-adb.el (tramp-adb-file-name-p):
      * lisp/net/tramp-archive.el (tramp-archive-run-real-handler)
      (tramp-archive-file-name-handler)
      (tramp-archive-dissect-file-name)
      (with-parsed-tramp-archive-file-name)
      (tramp-archive-gvfs-file-name, tramp-archive-handle-access-file):
      * lisp/net/tramp-cmds.el (tramp-list-remote-buffers):
      * lisp/net/tramp-compat.el (tramp-unload-file-name-handlers)
      (tramp-compat-funcall, tramp-compat-tramp-file-name-slots):
      * lisp/net/tramp-ftp.el (tramp-ftp-file-name-handler)
      (tramp-ftp-file-name-p):
      * lisp/net/tramp-gvfs.el (tramp-gvfs-file-name-p)
      (tramp-gvfs-file-name-handler)
      (tramp-gvfs-stringify-dbus-message)
      (tramp-gvfs-monitor-process-filter)
      (tramp-gvfs-handler-mounted-unmounted):
      * lisp/net/tramp-integration.el
      (tramp-rfn-eshadow-update-overlay-regexp):
      * lisp/net/tramp-rclone.el (tramp-rclone-file-name-p)
      (tramp-rclone-file-name-handler, tramp-rclone-send-command):
      * lisp/net/tramp-sh.el (tramp-sh--quoting-style-options)
      (tramp-sh-gio-monitor-process-filter)
      (tramp-sh-gvfs-monitor-dir-process-filter)
      (tramp-sh-inotifywait-process-filter, tramp-find-executable)
      (tramp-set-remote-path, tramp-open-shell, tramp-find-shell)
      (tramp-send-command-and-check, tramp-shell-case-fold)
      (tramp-get-remote-path):
      * lisp/net/tramp-smb.el (tramp-smb-file-name-p)
      (tramp-smb-file-name-handler)
      (tramp-smb-do-file-attributes-with-stat)
      (tramp-smb-handle-substitute-in-file-name)
      (tramp-smb-get-stat-capability, tramp-smb-shell-quote-argument):
      * lisp/net/tramp-sudoedit.el (tramp-sudoedit-file-name-p)
      (tramp-sudoedit-file-name-handler)
      (tramp-sudoedit-send-command-string):
      * test/lisp/net/tramp-archive-tests.el (tramp-archive-test-all):
      * test/lisp/net/tramp-tests.el (tramp--test-gvfs-p)
      (tramp--test-with-proper-process-name-and-buffer)
      (tramp-test-all): Adapt docstrings according to `checkdoc'.
      d3438460
  3. 07 Nov, 2019 1 commit
    • Michael Albinus's avatar
      Make ange-ftp fit for tramp-tests · 4ab78001
      Michael Albinus authored
      * lisp/net/ange-ftp.el (ange-ftp-repaint-minibuffer): Use empty message.
      (ange-ftp-quote-string): Unquote the string.
      (ange-ftp-substitute-in-file-name, ange-ftp-access-file)
      (ange-ftp-copy-directory, ange-ftp-make-symbolic-link)
      (ange-ftp-add-name-to-file): New defuns.  Set 'ange-ftp property.
      (ange-ftp-real-substitute-in-file-name)
      (ange-ftp-real-copy-directory): New defuns.
      (ange-ftp-file-name-as-directory): Care about `non-essential'.
      (ange-ftp-file-attributes): Handle ID-STRING.
      (ange-ftp-copy-file-internal, ange-ftp-rename-file)
      (ange-ftp-make-directory): Improve error handling.
      (ange-ftp-insert-directory): Initialize SWITCHES if they are nil.
      
      * test/lisp/net/tramp-tests.el (ange-ftp-make-backup-files): Declare.
      (tramp-test39-make-nearby-temp-file, tramp--test-ange-ftp-p): New defun.
      (tramp-test05-expand-file-name-relative)
      (tramp-test06-directory-file-name, tramp-test10-write-region)
      (tramp-test11-copy-file, tramp-test12-rename-file)
      (tramp-test17-insert-directory)
      (tramp-test26-file-name-completion)
      (tramp-test37-make-auto-save-file-name)
      (tramp-test38-find-backup-file-name)
      (tramp--test-special-characters): Use it.
      4ab78001
  4. 06 Nov, 2019 1 commit
    • Michael Albinus's avatar
      More error checks in Tramp's make-directory · da2df1c1
      Michael Albinus authored
      * lisp/net/tramp-adb.el (tramp-adb-handle-make-directory):
      * lisp/net/tramp-gvfs.el (tramp-gvfs-handle-make-directory):
      * lisp/net/tramp-sh.el (tramp-sh-handle-make-directory):
      * lisp/net/tramp-smb.el (tramp-smb-handle-make-directory):
      * lisp/net/tramp-sudoedit.el (tramp-sudoedit-handle-make-directory):
      Signal `file-already-exists' if DIR exists.
      
      * test/lisp/net/tramp-tests.el (tramp-test04-substitute-in-file-name):
      Fix thinko.
      (tramp-test13-make-directory, tramp-test14-delete-directory)
      (tramp-test15-copy-directory): Extend tests.
      da2df1c1
  5. 04 Nov, 2019 1 commit
    • Michael Albinus's avatar
      Improve Tramp error handling · dd19cc3a
      Michael Albinus authored
      * lisp/net/tramp.el (tramp-set-syntax): Add missing argument.
      (tramp-signal-hook-function): Make it more robust.
      (tramp-handle-directory-files):
      * lisp/net/tramp-adb.el
      (tramp-adb-handle-directory-files-and-attributes)
      (tramp-adb-handle-copy-file, tramp-adb-handle-rename-file):
      * lisp/net/tramp-gvfs.el (tramp-gvfs-do-copy-or-rename-file):
      * lisp/net/tramp-rclone.el (tramp-rclone-do-copy-or-rename-file)
      (tramp-rclone-handle-directory-files):
      * lisp/net/tramp-sh.el (tramp-sh-handle-directory-files-and-attributes)
      (tramp-sh-handle-copy-directory, tramp-do-copy-or-rename-file):
      * lisp/net/tramp-smb.el (tramp-smb-handle-copy-directory)
      (tramp-smb-handle-copy-file, tramp-smb-handle-directory-files)
      (tramp-smb-handle-rename-file):
      * lisp/net/tramp-sudoedit.el (tramp-sudoedit-do-copy-or-rename-file):
      Improve error handling.
      
      * test/lisp/net/tramp-tests.el (tramp-test11-copy-file)
      (tramp-test12-rename-file, tramp-test14-delete-directory)
      (tramp-test15-copy-directory, tramp-test16-directory-files)
      (tramp-test19-directory-files-and-attributes): Extend tests.
      dd19cc3a
  6. 31 Oct, 2019 1 commit
    • Michael Albinus's avatar
      Fix some minor Tramp problems · bdb33af3
      Michael Albinus authored
      * lisp/net/tramp-gvfs.el (tramp-gvfs-maybe-open-connection):
      Check, that `tramp-password-save-function' is a function.
      
      * lisp/net/tramp-smb.el (tramp-smb-handle-file-system-info):
      Check, that there is a share.
      
      * lisp/net/tramp.el (outline-regexp): Declare.
      (tramp-get-debug-buffer): Let-bind `signal-hook-function'.
      
      * test/lisp/net/tramp-tests.el (tramp-test04-substitute-in-file-name):
      Skip some tests for Emacs 24 and 25; they let Emacs crash.
      bdb33af3
  7. 27 Oct, 2019 1 commit
    • Michael Albinus's avatar
      Some Tramp trace improvements · 6e66d9a9
      Michael Albinus authored
      * lisp/net/tramp.el (tramp-call-process): `result' can also be nil.
      
      * test/lisp/net/tramp-tests.el (tramp--test-timeout-handler):
      Improve trace format.
      6e66d9a9
  8. 18 Oct, 2019 1 commit
  9. 12 Oct, 2019 1 commit
    • Michael Albinus's avatar
      Adapt some Tramp tests · 15ed1598
      Michael Albinus authored
      * test/lisp/net/tramp-archive-tests.el
      (tramp-archive-test17-insert-directory): Adapt regexp of summary line.
      
      * test/lisp/net/tramp-tests.el (tramp-test21-file-links):
      Extend test for symlinked directories.
      15ed1598
  10. 26 Sep, 2019 1 commit
  11. 18 Sep, 2019 1 commit
  12. 13 Sep, 2019 1 commit
  13. 31 Aug, 2019 1 commit
  14. 30 Aug, 2019 1 commit
  15. 27 Aug, 2019 1 commit
  16. 26 Aug, 2019 1 commit
    • Michael Albinus's avatar
      ; Continued attempt to fix Bug#36940 · f87ace2a
      Michael Albinus authored
      * test/lisp/net/tramp-tests.el (tramp--test-file-attributes-equal-p):
      Handle link number.
      (tramp--test-check-files): Encode search string on macOS.  (Bug#36940)
      f87ace2a
  17. 24 Aug, 2019 1 commit
    • Michael Albinus's avatar
      Fix some problems of Bug#36940 · 42f8fa80
      Michael Albinus authored
      * test/lisp/net/tramp-tests.el (tramp-test22-file-times): Do not
      compare time value lists by `equal'.  (Bug#36940).
      (tramp-test30-make-process): Adapt "kill" message to match on macOS.
      42f8fa80
  18. 11 Aug, 2019 1 commit
    • Michael Albinus's avatar
      Retrieve start time from remote machine, use compat attrib functions · 95552e08
      Michael Albinus authored
      * lisp/net/tramp-compat.el (tramp-compat-file-attribute-access-time)
      (tramp-compat-file-attribute-status-change-time): New defaliases.
      
      * test/lisp/net/tramp-tests.el (tramp--test-start-time): New defvar.
      (tramp--test-file-attributes-equal-p)
      (tramp-test19-directory-files-and-attributes): Use it.
      (tramp-test18-file-attributes)
      (tramp--test-file-attributes-equal-p, tramp-test20-file-modes)
      (tramp-test22-file-times, tramp--test-check-files):
      Use `tramp-compat-file-attribute-*' functions.
      95552e08
  19. 10 Aug, 2019 1 commit
  20. 08 Aug, 2019 1 commit
  21. 07 Aug, 2019 3 commits
  22. 06 Aug, 2019 1 commit
    • Michael Albinus's avatar
      Fix Bug#36940 · 998f3612
      Michael Albinus authored
      * test/lisp/net/tramp-tests.el (tramp--test-file-attributes-equal-p):
      Make the check more precise.  (Bug#36940)
      (tramp-test19-directory-files-and-attributes): Move some checks to
      `tramp--test-file-attributes-equal-p'.
      998f3612
  23. 05 Aug, 2019 1 commit
    • Michael Albinus's avatar
      Improve Tramp's caching · 6c1d0d53
      Michael Albinus authored
      * lisp/net/tramp.el (tramp-handle-add-name-to-file)
      (tramp-handle-write-region):
      * lisp/net/tramp-adb.el (tramp-adb-handle-make-directory)
      (tramp-adb-handle-delete-directory)
      (tramp-adb-handle-delete-file, tramp-adb-handle-write-region)
      (tramp-adb-handle-set-file-modes)
      (tramp-adb-handle-set-file-times, tramp-adb-handle-copy-file)
      (tramp-adb-handle-rename-file):
      * lisp/net/tramp-gvfs.el (tramp-gvfs-do-copy-or-rename-file)
      (tramp-gvfs-handle-delete-directory)
      (tramp-gvfs-handle-delete-file)
      (tramp-gvfs-handle-make-directory)
      (tramp-gvfs-handle-set-file-modes)
      (tramp-gvfs-handle-set-file-times, tramp-gvfs-set-file-uid-gid):
      * lisp/net/tramp-rclone.el (tramp-rclone-do-copy-or-rename-file)
      (tramp-rclone-handle-delete-directory)
      (tramp-rclone-handle-delete-file):
      * lisp/net/tramp-sh.el (tramp-sh-handle-make-symbolic-link)
      (tramp-sh-handle-set-file-modes, tramp-sh-handle-set-file-times)
      (tramp-sh-handle-add-name-to-file)
      (tramp-sh-handle-copy-directory, tramp-do-copy-or-rename-file)
      (tramp-sh-handle-delete-directory, tramp-sh-handle-delete-file)
      (tramp-sh-handle-write-region):
      * lisp/net/tramp-smb.el (tramp-smb-handle-add-name-to-file)
      (tramp-smb-handle-copy-directory, tramp-smb-handle-copy-file)
      (tramp-smb-handle-delete-directory)
      (tramp-smb-handle-delete-file)
      (tramp-smb-handle-make-directory-internal)
      (tramp-smb-handle-make-symbolic-link)
      (tramp-smb-handle-rename-file, tramp-smb-handle-write-region):
      * lisp/net/tramp-sudoedit.el (tramp-sudoedit-handle-add-name-to-file)
      (tramp-sudoedit-do-copy-or-rename-file)
      (tramp-sudoedit-handle-delete-directory)
      (tramp-sudoedit-handle-delete-file)
      (tramp-sudoedit-handle-set-file-modes)
      (tramp-sudoedit-handle-set-file-times)
      (tramp-sudoedit-handle-make-symbolic-link): Do not flush all file
      properties of upper directory.
      
      * lisp/net/tramp-cache.el (tramp-flush-file-upper-properties):
      New defun.
      (tramp-flush-file-properties, tramp-flush-directory-properties):
      Use it.
      
      * test/lisp/net/tramp-tests.el (tramp-time-diff): Declare.
      (tramp--test-file-attributes-equal-p): Handle also modification
      and status change time.
      6c1d0d53
  24. 04 Aug, 2019 1 commit
    • Michael Albinus's avatar
      Implement set-file-* functions for tramp-gvfs.el · 2abcca23
      Michael Albinus authored
      * lisp/net/tramp-gvfs.el (tramp-gvfs-gio-mapping):
      Add "gvfs-set-attribute".
      (tramp-gvfs-file-name-handler-alist):
      Add `tramp-gvfs-handle-set-file-modes',
      `tramp-gvfs-handle-set-file-times' and
      `tramp-gvfs-handle-set-file-uid-gid'.
      (tramp-gvfs-handle-set-file-modes)
      (tramp-gvfs-handle-set-file-times)
      (tramp-sh-handle-set-file-uid-gid): New defuns.
      
      * lisp/net/tramp.el (tramp-handle-write-region): Set file modes.
      
      * test/lisp/net/tramp-tests.el (tramp-test20-file-modes)
      (tramp-test22-file-times): Do not skip for tramp-gvfs.el.
      2abcca23
  25. 22 Jul, 2019 1 commit
  26. 18 Jul, 2019 1 commit
  27. 12 Jul, 2019 1 commit
    • Michael Albinus's avatar
      Check directory in Tramp's {copy,rename}-file · 955db220
      Michael Albinus authored
      * lisp/net/tramp-adb.el (tramp-adb-handle-copy-file)
      (tramp-adb-handle-rename-file):
      * lisp/net/tramp-gvfs.el (tramp-gvfs-do-copy-or-rename-file):
      * lisp/net/tramp-rclone.el (tramp-rclone-do-copy-or-rename-file):
      * lisp/net/tramp-sh.el (tramp-do-copy-or-rename-file):
      * lisp/net/tramp-smb.el (tramp-smb-handle-copy-file)
      (tramp-smb-handle-rename-file):
      * lisp/net/tramp-sudoedit.el (tramp-sudoedit-do-copy-or-rename-file):
      Check, that NEWNAME is not a directory given as file name.
      
      * test/lisp/net/tramp-tests.el (tramp-test11-copy-file)
      (tramp-test12-rename-file): Extend tests.
      955db220
  28. 30 Jun, 2019 1 commit
    • Michael Albinus's avatar
      Release Tramp 2.4.2 · 10af8c58
      Michael Albinus authored
      * lisp/net/tramp.el: Bump version.
      
      * test/lisp/net/tramp-tests.el (tramp--test-instrument-test-case):
      Add `add-name-to-file' error message.
      (tramp--test-ignore-add-name-to-file-error): Make error handler
      more explicit about the error.
      10af8c58
  29. 28 Jun, 2019 1 commit
    • Michael Albinus's avatar
      Tramp requires Emacs 24.4 · aae5bf44
      Michael Albinus authored
      * doc/misc/tramp.texi (Frequently Asked Questions):
      Use `with-eval-after-load'. in example.
      
      * doc/misc/trampver.texi: Set variable emacsver.
      
      * lisp/net/tramp.el (tramp-send-string, tramp-call-process)
      (tramp-call-process-region, tramp-process-lines):
      * lisp/net/tramp-adb.el (tramp-adb-handle-file-truename)
      (tramp-adb-sh-fix-ls-output, tramp-adb-maybe-open-connection):
      * lisp/net/tramp-gvfs.el (tramp-gvfs-get-directory-attributes)
      (tramp-gvfs-handle-file-notify-add-watch)
      * lisp/net/tramp-sh.el (tramp-sh-handle-file-truename)
      (tramp-do-copy-or-rename-file-out-of-band)
      (tramp-sh-handle-file-notify-add-watch, tramp-find-executable)
      (tramp-set-remote-path)
      (tramp-open-connection-setup-interactive-shell)
      (tramp-maybe-open-connection, tramp-send-command):
      * lisp/net/tramp-smb.el (tramp-smb-handle-copy-directory)
      (tramp-smb-handle-file-acl, tramp-smb-handle-process-file)
      (tramp-smb-handle-set-file-acl)
      (tramp-smb-handle-start-file-process)
      (tramp-smb-maybe-open-connection):
      * lisp/net/tramp-sudoedit.el (tramp-sudoedit-handle-set-file-acl):
      (tramp-sudoedit-send-command): Use `string-join' and `string-empty-p'.
      
      * lisp/net/tramp-adb.el:
      * lisp/net/tramp-archive.el:
      * lisp/net/tramp-integration.el:
      * lisp/net/tramp-ftp.el: Use `with-eval-after-load'.
      
      * lisp/net/tramp-cmds.el (tramp-cleanup-connection)
      (tramp-cleanup-all-connections): Cancel timer.
      
      * lisp/net/tramp-compat.el (subr-x): Require.
      (default-toplevel-value): Don't make it a defalias.
      
      * lisp/net/tramp-gvfs.el: Use `dbus-event-error-functions'.  Do
      not special handle `split-string'.
      
      * lisp/net/tramp.el: Require Emacs 24.4.
      (tramp-password-prompt-regexp): Use `password-word-equivalents'.
      (tramp-user-error): Use `user-error'.
      (tramp-replace-environment-variables): Use `substitute-env-vars'.
      (tramp-wait-for-regexp): Rearrange `with-current-buffer' call.
      (tramp-get-local-gid): Use `group-gid'.
      
      * lisp/net/trampver.el: Check for Emacs 24.4.
      
      * test/lisp/net/tramp-tests.el (tramp-test02-file-name-dissect)
      (tramp-test02-file-name-dissect-simplified)
      (tramp-test02-file-name-dissect-separate)
      (tramp-test03-file-name-host-rules)
      (tramp-test03-file-name-method-rules): Don't check for `user-error'.
      aae5bf44
  30. 26 Jun, 2019 2 commits
  31. 24 Jun, 2019 1 commit
    • Michael Albinus's avatar
      Improve error handling in Tramp · 18a7e541
      Michael Albinus authored
      * lisp/net/tramp-compat.el (ls-lisp): Require.
      
      * lisp/net/tramp.el (ls-lisp-use-insert-directory-program):
      Don't declare.
      (tramp-current-connection): Adapt docstring.
      (tramp-debug-message): Adapt function names.
      (tramp-error, tramp-run-real-handler): Let-bind `signal-hook-function'.
      (tramp-signal-hook-function): New defun.
      (tramp-debug-on-error, tramp-condition-case-unless-debug): Remove.
      (tramp-file-name-handler): Handle `tramp-current-connection'.
      Let-bind `signal-hook-function'.  Use `unwind-protect' instead of
      `tramp-condition-case-unless-debug'.
      (tramp-handle-insert-directory): Don't require ls-lisp.
      (tramp-process-actions): Check, that
      `tramp-password-save-function' is non-nil.
      (tramp-equal-remote): Handle the case both files are local.
      
      * test/lisp/net/tramp-tests.el (tramp--test-instrument-test-case):
      Do not bind `tramp-debug-on-error'.
      (tramp--test-ignore-make-symbolic-link-error): Make error handler
      more explicit about the error.
      18a7e541
  32. 15 Jun, 2019 3 commits
  33. 14 Jun, 2019 1 commit
  34. 11 Jun, 2019 1 commit
  35. 10 Jun, 2019 1 commit
    • Michael Albinus's avatar
      Make tramp-test43-asynchronous-requests working, again · 03b66d23
      Michael Albinus authored
      * test/lisp/net/tramp-tests.el (tramp-list-tramp-buffers):
      Declare `tramp-list-tramp-buffers'.
      (tramp--test-ignore-make-symbolic-link-error)
      (tramp--test-ignore-add-name-to-file-error): Improve declaration.
      (tramp--test-with-proper-process-name-and-buffer): New macro.
      (tramp-test43-asynchronous-requests): Use the macro for timer,
      process filter and process sentinel.  Comment the remote file
      operation in the timer.  Remove further async events.  Accept
      output from all processes.
      03b66d23