1. 06 Mar, 2011 1 commit
    • Juanma Barranquero's avatar
      * lisp/bookmark.el: · 845fc5e5
      Juanma Barranquero authored
      * lisp/desktop.el:
      * lisp/emacs-lock.el:
      * lisp/ps-print.el:
      * lisp/saveplace.el:
      * lisp/net/tramp-cache.el:
      * lisp/textmodes/reftex.el:
      * lisp/org/org-id.el: Don't set `kill-emacs-hook' on noninteractive sessions.
      
      Fixes: debbugs:8137
      845fc5e5
  2. 10 Feb, 2011 1 commit
    • Stefan Monnier's avatar
      Move keymap initialization into declaration. · b016851c
      Stefan Monnier authored
      * lisp/textmodes/enriched.el (enriched-mode-map):
      * lisp/textmodes/bib-mode.el (bib-mode-map):
      * lisp/term/lk201.el (lk201-function-map):
      * lisp/tar-mode.el (tar-mode-map):
      * lisp/replace.el (occur-mode-map):
      * lisp/progmodes/idlwave.el (idlwave-rinfo-mouse-map, idlwave-rinfo-map):
      * lisp/progmodes/idlw-help.el (idlwave-help-mode-map):
      * lisp/progmodes/gdb-mi.el (gdb-memory-format-menu, gdb-memory-unit-menu):
      * lisp/play/solitaire.el (solitaire-mode-map):
      * lisp/play/snake.el (snake-mode-map, snake-null-map):
      * lisp/play/pong.el (pong-mode-map):
      * lisp/play/handwrite.el (menu-bar-handwrite-map):
      * lisp/play/gametree.el (gametree-mode-map):
      * lisp/net/rcirc.el (rcirc-mode-map, rcirc-browse-url-map
      (rcirc-multiline-minor-mode-map, rcirc-track-minor-mode-map):
      * lisp/net/newst-plainview.el (newsticker-menu, newsticker-mode-map)
      (newsticker--url-keymap):
      * lisp/net/net-utils.el (nslookup-mode-map, ftp-mode-map):
      * lisp/menu-bar.el (menu-bar-file-menu, menu-bar-i-search-menu)
      (menu-bar-search-menu, menu-bar-replace-menu, menu-bar-goto-menu)
      (menu-bar-edit-menu, menu-bar-custom-menu)
      (menu-bar-showhide-fringe-ind-menu, menu-bar-showhide-fringe-menu)
      (menu-bar-showhide-scroll-bar-menu, menu-bar-showhide-menu)
      (menu-bar-line-wrapping-menu, menu-bar-options-menu)
      (menu-bar-games-menu, menu-bar-encryption-decryption-menu)
      (menu-bar-tools-menu, menu-bar-describe-menu)
      (menu-bar-search-documentation-menu, menu-bar-manuals-menu)
      (menu-bar-help-menu):
      * lisp/mail/rmailsum.el (rmail-summary-mode-map):
      * lisp/kmacro.el (kmacro-step-edit-map):
      * lisp/ibuffer.el (ibuffer-mode-groups-popup, ibuffer-mode-map)
      (ibuffer-mode-operate-map):
      * lisp/hi-lock.el (hi-lock-menu, hi-lock-map):
      * lisp/emulation/vip.el (vip-mode-map):
      * lisp/emacs-lisp/re-builder.el (reb-lisp-mode-map):
      * lisp/bookmark.el (bookmark-bmenu-mode-map):
      * lisp/help-mode.el (help-mode-map):
      * lisp/erc/erc-list.el (erc-list-menu-mode-map):
      * lisp/org/org-remember.el (org-remember-mode-map):
      * lisp/org/org-src.el (org-src-mode-map): Move initialization into declaration.
      b016851c
  3. 01 Feb, 2011 1 commit
    • Sam Steingold's avatar
      * lisp/simple.el (special-mode-map): Bind "h" to `describe-mode'; · abef340a
      Sam Steingold authored
      bind "z" to `kill-this-buffer'.
      (completion-list-mode-map): Bind "z" to `kill-this-buffer'.
      * lisp/apropos.el (apropos-mode-map): Inherit from `special-mode-map'.
      (apropos-mode): Inherit from `special-mode'.
      * lisp/arc-mode.el (archive-mode-map): Inherit from `special-mode-map'.
      * lisp/bookmark.el (bookmark-bmenu-mode): Define using
      `define-derived-mode' inheriting from `special-mode'.
      * lisp/dired.el (dired-mode-map): Inherit from `special-mode-map'.
      * lisp/image-mode.el (image-mode-map): Ditto.
      * lisp/replace.el (occur-mode): Define using
      `define-derived-mode' inheriting from `special-mode'.
      * lisp/tar-mode.el (tar-mode): Inherit from `special-mode'.
      * lisp/calendar/diary-lib.el (diary-fancy-display-mode):
      Inherit from `special-mode-map'.
      * lisp/emacs-lisp/ert.el (ert-simple-view-mode, ert-results-mode):
      Inherit from `special-mode'.
      * lisp/emacs-lisp/package.el (package-menu-mode-map): Copy from
      `special-mode-map'.
      (package-menu-mode): Define using `define-derived-mode'
      inheriting from `special-mode'.
      * erc/erc-list.el (erc-list-menu-mode): Inherit from `special-mode'.
      * lisp/net/xesam.el (xesam-mode): Inherit from `special-mode'.
      (xesam-mode-map): Define separately.
      * lisp/play/solitaire.el (solitaire-mode): Inherit from `special-mode'.
      * lisp/progmodes/compile.el (compilation-minor-mode-map)
      (compilation-mode-map): Inherit from `special-mode-map'.
      * lisp/vc/diff-mode.el (diff-mode-shared-map):
      Inherit from `special-mode-map'.
      * lisp/vc/log-view.el (log-view-mode-map): Add a comment.
      abef340a
  4. 26 Jan, 2011 1 commit
  5. 25 Jan, 2011 1 commit
  6. 16 Jan, 2011 1 commit
  7. 02 Jan, 2011 1 commit
  8. 12 Dec, 2010 1 commit
  9. 08 Dec, 2010 1 commit
    • Karl Fogel's avatar
      Adjust parameter names and doc strings to resolve confusion over · eff37c5e
      Karl Fogel authored
      whether "bookmark" meant a bookmark name or a bookmark record.
      Along the way, shorten one function's name for similar reasons.
      
      (Issue #7548)
      
      * lisp/bookmark.el
        (bookmark-name-from-record):
          New name for `bookmark-name-from-full-record'.  All callers changed.
        (bookmark-get-bookmark, bookmark-get-bookmark-record,
         bookmark-default-annotation-text, bookmark-prop-get, bookmark-prop-set,
         bookmark-get-annotation, bookmark-set-annotation,
         bookmark-get-filename, bookmark-set-filename,
         bookmark-get-position, bookmark-set-position,
         bookmark-get-front-context-string, bookmark-set-front-context-string,
         bookmark-get-rear-context-string, bookmark-set-rear-context-string,
         bookmark-get-handler, bookmark-edit-annotation, bookmark--jump-via,
         bookmark-handle-bookmark, bookmark-location, bookmark-show-annotation):
          Rename `bookmark' parameter to `bookmark-name-or-record', to
          clearly show its role, and shorten or adjust doc strings accordingly.
        (bookmark-set-name):
          Same, and pass the parameter directly to `bookmark-get-bookmark'
          instead of redundantly doing the callee's work.
        (bookmark-default-annotation-text, bookmark-send-edited-annotation,
         bookmark-relocate, bookmark-insert-location, bookmark-insert,
         bookmark-delete):
          Rename `bookmark' parameter to `bookmark-name', and in some cases
          shorten doc string accordingly.
        (bookmark-rename):
          Change `old' and `new' parameters to `old-name'
          and `new-name', and adjust an internal variable to avoid confusion.
        (bookmark-jump, bookmark-jump-noselect):
          Clarify `bookmark' parameter in doc string.
      eff37c5e
  10. 06 Nov, 2010 1 commit
    • Glenn Morris's avatar
      Use line-end-position rather than end-of-line, etc. · 5ed619e0
      Glenn Morris authored
      * textmodes/texnfo-upd.el (texinfo-start-menu-description)
      (texinfo-update-menu-region-beginning, texinfo-menu-first-node)
      (texinfo-delete-existing-pointers, texinfo-find-pointer)
      (texinfo-clean-up-node-line, texinfo-insert-node-lines)
      (texinfo-multiple-files-update):
      * textmodes/table.el (table--probe-cell-left-up)
      (table--probe-cell-right-bottom):
      * textmodes/picture.el (picture-tab-search):
      * textmodes/page-ext.el (pages-copy-header-and-position)
      (pages-directory-for-addresses):
      * progmodes/vera-mode.el (vera-get-offset):
      * progmodes/simula.el (simula-calculate-indent):
      * progmodes/python.el (python-pdbtrack-overlay-arrow):
      * progmodes/prolog.el (end-of-prolog-clause):
      * progmodes/perl-mode.el (perl-calculate-indent, perl-indent-exp):
      * progmodes/icon.el (indent-icon-exp):
      * progmodes/etags.el (tag-re-match-p):
      * progmodes/ebrowse.el (ebrowse-show-file-name-at-point):
      * progmodes/ebnf2ps.el (ebnf-begin-file):
      * progmodes/dcl-mode.el (dcl-back-to-indentation-1)
      (dcl-save-local-variable):
      * play/life.el (life-setup):
      * play/gametree.el (gametree-looking-at-ply):
      * nxml/nxml-maint.el (nxml-insert-target-repertoire-glyph-set):
      * mail/sendmail.el (mail-mode-auto-fill):
      * emacs-lisp/lisp-mode.el (calculate-lisp-indent):
      * emacs-lisp/edebug.el (edebug-overlay-arrow):
      * emacs-lisp/checkdoc.el (checkdoc-this-string-valid):
      * woman.el (woman-parse-numeric-value, woman2-TH, woman2-SH)
      (woman-tab-to-tab-stop, WoMan-warn-ignored):
      * type-break.el (type-break-file-keystroke-count):
      * term.el (term-replace-by-expanded-history-before-point)
      (term-skip-prompt, term-extract-string):
      * speedbar.el (speedbar-edit-line, speedbar-expand-line)
      (speedbar-contract-line, speedbar-toggle-line-expansion)
      (speedbar-parse-c-or-c++tag, speedbar-parse-tex-string)
      (speedbar-buffer-revert-buffer, speedbar-highlight-one-tag-line):
      * sort.el (sort-skip-fields):
      * skeleton.el (skeleton-internal-list):
      * simple.el (line-move-finish, line-move-to-column):
      * shell.el (shell-forward-command):
      * misc.el (copy-from-above-command):
      * makesum.el (double-column):
      * ebuff-menu.el (electric-buffer-update-highlight):
      * dired.el (dired-move-to-end-of-filename):
      * dframe.el (dframe-popup-kludge):
      * bookmark.el (bookmark-kill-line, bookmark-bmenu-show-filenames):
      * arc-mode.el (archive-get-lineno):
      Use line-end-position and line-beginning-position.
      
      * net/ange-ftp.el, progmodes/hideif.el, reposition.el:
      Same, but only in comments.
      5ed619e0
  11. 14 Jul, 2010 3 commits
    • Karl Fogel's avatar
      * lisp/bookmark.el (bookmark-load-hook): Fix doc string as suggested · 077e0753
      Karl Fogel authored
        by Drew Adams (Bug#5504).
      077e0753
    • Thierry Volpiatto's avatar
      Allow C-w when setting a bookmark in a Gnus Article buffer (Bug#5975). · 8f2eaa8a
      Thierry Volpiatto authored
      * lisp/bookmark.el (bookmark-set): Don't set `bookmark-yank-point' and
        `bookmark-current-buffer' if they have been already set in another
        buffer (e.g gnus-art).
      
      * lisp/gnus/gnus-sum.el (gnus-summary-bookmark-make-record): Set
        `bookmark-yank-point' and `bookmark-current-buffer' to allow C-w.
      8f2eaa8a
    • Karl Fogel's avatar
      Preparation for setting bookmarks in Gnus article buffers (Bug#5975). · e44fa724
      Karl Fogel authored
      * lisp/bookmark.el (bookmark-make-record-default): Allow unneeded
        information to be omitted from the record.
      
      Adjust declarations and calls:
      
      * lisp/info.el (bookmark-make-record-default): Adjust declaration.
        (Info-bookmark-make-record): Adjust call.
      
      * lisp/woman.el (bookmark-make-record-default): Adjust declaration.
        (woman-bookmark-make-record): Adjust call.
      
      * lisp/man.el (bookmark-make-record-default): Adjust declaration.
        (Man-bookmark-make-record): Adjust call.
      
      * lisp/image-mode.el (bookmark-make-record-default): Adjust declaration.
      
      * lisp/doc-view.el (bookmark-make-record-default): Adjust declaration.
      
      * lisp/gnus/gnus-sum.el (bookmark-make-record-default): Adjust declaration.
      e44fa724
  12. 13 Jul, 2010 2 commits
    • Karl Fogel's avatar
      * lisp/bookmark.el (bookmark-show-annotation): Use `when' instead of `if'. · 0c4371fe
      Karl Fogel authored
        This is also from Thierry Volpiatto's patch in bug #6444.  However,
        because it was extraneous to the functional change in that patch,
        and causes a re-indendation, I am committing it separately.
      0c4371fe
    • Karl Fogel's avatar
      [[[ · 068a0233
      Karl Fogel authored
      * lisp/bookmark.el (bookmark-bmenu-switch-other-window,
        bookmark-bmenu-other-window, bookmark-bmenu-2-window): Don't override
        ambient binding of `bookmark-automatically-show-annotations'.  (Bug #6515)
      ]]]
      
      === modified file 'lisp/bookmark.el'
      --- lisp/bookmark.el	2010-04-14 15:07:53 +0000
      +++ lisp/bookmark.el	2010-06-27 03:40:14 +0000
      @@ -1860,8 +1860,7 @@
               (pop-up-windows t))
           (delete-other-windows)
           (switch-to-buffer (other-buffer))
      -    (let ((bookmark-automatically-show-annotations nil)) ;FIXME: needed?
      -      (bookmark--jump-via bmrk 'pop-to-buffer))
      +    (bookmark--jump-via bmrk 'pop-to-buffer)
           (bury-buffer menu)))
       
       
      @@ -1875,8 +1874,7 @@
         "Select this line's bookmark in other window, leaving bookmark menu visible."
         (interactive)
         (let ((bookmark (bookmark-bmenu-bookmark)))
      -    (let ((bookmark-automatically-show-annotations t)) ;FIXME: needed?
      -      (bookmark--jump-via bookmark 'switch-to-buffer-other-window))))
      +    (bookmark--jump-via bookmark 'switch-to-buffer-other-window)))
       
       
       (defun bookmark-bmenu-switch-other-window ()
      @@ -1887,8 +1885,7 @@
               (pop-up-windows t)
               same-window-buffer-names
               same-window-regexps)
      -    (let ((bookmark-automatically-show-annotations t)) ;FIXME: needed?
      -      (bookmark--jump-via bookmark 'display-buffer))))
      +    (bookmark--jump-via bookmark 'display-buffer)))
       
       (defun bookmark-bmenu-other-window-with-mouse (event)
         "Select bookmark at the mouse pointer in other window, leaving bookmark menu visible."
      
      === modified file 'lisp/saveplace.el'
      --- lisp/saveplace.el	2010-01-13 08:35:10 +0000
      +++ lisp/saveplace.el	2010-02-07 23:14:52 +0000
      @@ -213,7 +213,7 @@
                             (symbol-name coding-system-for-write)))
             (let ((print-length nil)
                   (print-level nil))
      -        (print save-place-alist (current-buffer)))
      +        (pp save-place-alist (current-buffer)))
             (let ((version-control
                    (cond
                     ((null save-place-version-control) nil)
      068a0233
  13. 04 Jul, 2010 1 commit
  14. 27 Jun, 2010 1 commit
  15. 14 Apr, 2010 1 commit
    • Stefan Monnier's avatar
      Add a new field `location' to bookmarks for non-file bookmarks. · ebb9641f
      Stefan Monnier authored
      * bookmark.el (bookmark-location): Use the new field, if present.
      (bookmark-insert-location): Undo last change, not needed any more.
      * man.el (Man-bookmark-make-record):
      * woman.el (woman-bookmark-make-record):
      * gnus-sum.el (gnus-summary-bookmark-make-record): Add `location' field.
      ebb9641f
  16. 12 Apr, 2010 2 commits
    • Stefan Monnier's avatar
    • Stefan Monnier's avatar
      Clean up last bookmark changes for man/woman/gnus-summary. · 398a825b
      Stefan Monnier authored
      * gnus-sum.el: Add bookmark declarations to silence the compiler.
      (gnus-mark-xrefs-as-read, gnus-summary-limit-to-bodies):
      Use with-current-buffer to silence the byte-compiler.
      (gnus-summary-bookmark-make-record): Use derived-mode-p and don't
      bother to require `gnus'.
      (gnus-summary-bookmark-jump): Don't forget to autoload.  Simplify.
      * woman.el: Add bookmark declarations to silence the compiler.
      (bookmark-prop-get): Use `man-args' rather than `filename' as a first
      step to compatibility between man and woman bookmarks.
      Adjust for Man-default-bookmark-title renaming.
      (woman-bookmark-jump): Adjust accordingly.  Don't forget to autoload.
      * man.el: Add bookmark declarations to silence the compiler.
      (Man-name-local-regexp): Make it match NAME as well.
      (Man-getpage-in-background): Return the buffer.
      (Man-notify-when-ready): Use `case'.
      (man-set-default-bookmark-title): Rename to Man-default-bookmark-title.
      Don't hardcode "NAME".  Simplify.
      (Man-bookmark-make-record): Use Man-arguments rather than buffer-name.
      Rename from Man-bookmark-make-record.
      (Man-bookmark-jump): Rename from man-bookmark-jump.  Simplify now that
      we have the actual man-args.  Use Man-getpage-in-background rather
      than `man' since the arg is already processed.  Let bookmark.el do the
      window handling.  Only wait for the relevant process.
      Don't forget to autoload.
      * bookmark.el (bookmark-default-file): Use locate-user-emacs-file.
      398a825b
  17. 18 Feb, 2010 1 commit
  18. 10 Feb, 2010 1 commit
  19. 13 Jan, 2010 2 commits
  20. 02 Jan, 2010 10 commits
  21. 24 Nov, 2009 2 commits
  22. 21 Nov, 2009 2 commits
    • Stefan Monnier's avatar
      (bookmark-bmenu-bookmark-column): Remove var. · fc9d6ad6
      Stefan Monnier authored
      (bookmark-bmenu-list): Save name on `bookmark-name-prop' text-prop.
      (bookmark-bmenu-show-filenames): Use push.
      (bookmark-bmenu-hide-filenames): Use local var instead of
      bookmark-bmenu-bookmark-column.  Use pop.  Don't save window-excursion.
      (bookmark-bmenu-bookmark): Use the new `bookmark-name-prop' text-prop.
      (bookmark-bmenu-execute-deletions): Don't bother adding/removing the
      filenames now that the bookmark names are always available.
      fc9d6ad6
    • Stefan Monnier's avatar
      (bookmark-search-prompt, bookmark-search-timer): Remove. · 26d9285f
      Stefan Monnier authored
      (bookmark-search-pattern): Move and leave unbound.
      (bookmark-bmenu-mode-map): Change binding.
      (bookmark-read-search-input): Simplify.
      Don't use text-char-description.  Don't error on non-char events.
      (bookmark-filtered-alist-by-regexp-only): Remove by folding into the
      only caller (i.e. bookmark-bmenu-filter-alist-by-regexp).
      (bookmark-bmenu-search): Don't check we're in a bookmark-list buffer.
      Use a local var for the timer.
      (bookmark-bmenu-cancel-search): Remove by folding into the only caller
      (i.e. bookmark-bmenu-search).
      26d9285f
  23. 20 Nov, 2009 2 commits
    • Karl Fogel's avatar
      * lisp/bookmark.el: Formatting and doc fixes only: · 6aeaa3dc
      Karl Fogel authored
        (bookmark-search-delay): Shorten doc string to fit in 80 columns.
        (bookmark-bmenu-search): Wrap to fit within 80 columns.  Minor
          grammar and punctuation fixes in doc string.
        (bookmark-read-search-input): Adjust to fit within 80 columns.
      6aeaa3dc
    • Stefan Monnier's avatar
      * bookmark.el (bookmark-search-delay, bookmark-search-prompt): New options. · 1e7d4475
      Stefan Monnier authored
      (bookmark-search-pattern, bookmark-search-timer, bookmark-quit-flag): New vars.
      (bookmark-read-search-input, bookmark-filtered-alist-by-regexp-only)
      (bookmark-bmenu-filter-alist-by-regexp)
      (bookmark-bmenu-goto-bookmark, bookmark-bmenu-cancel-search): New funs.
      (bookmark-bmenu-search): New command.
      (bookmark-bmenu-mode-map): Bind it.
      1e7d4475