1. 06 Jul, 2019 4 commits
  2. 03 Jul, 2019 1 commit
    • Stefan Kangas's avatar
      Add tests for bookmark.el (Bug#36452) · 22760ab3
      Stefan Kangas authored
      * test/lisp/bookmark-resources/example.txt:
      * test/lisp/bookmark-resources/test.bmk:
      * test/lisp/bookmark-tests.el: New files.
      * lisp/bookmark.el: Minor cleanups.
      (bookmark-insert-annotation): Signal error on invalid bookmark.
      (bookmark-write-file): Add newline at end of file.
  3. 28 Jun, 2019 1 commit
  4. 20 Jun, 2019 1 commit
  5. 18 Jun, 2019 2 commits
    • Lars Ingebrigtsen's avatar
      Fix compilation warning in bookmark.el · e040870e
      Lars Ingebrigtsen authored
      * lisp/bookmark.el (bookmarks-already-loaded): Move obsolete alias
      definition to before its referent.
      In toplevel form:
      bookmark.el:279:1:Warning: Alias for `bookmark-bookmarks-timestamp' should be
          declared before its referent
    • Roland Winkler's avatar
      * bookmark.el: Watch bookmark file. Use lexical binding. · 0f4d368f
      Roland Winkler authored
      (bookmark-watch-bookmark-file): New user variable.
      (bookmark-alist): Fix docstring.
      (bookmark-bookmarks-timestamp): Renamed from bookmarks-already-loaded.
      (bookmark-maybe-load-default-file, bookmark-save, bookmark-load):
      Use bookmark-bookmarks-timestamp.
      (bookmark-bmenu-mode-map): Define menu bar menu.
      (bookmark-show-annotation, bookmark-show-all-annotations):
      Make bookmarks buffer read-only.
      (bookmark-bmenu-save): Use call-interactively.
  6. 15 Jun, 2019 2 commits
  7. 13 Jun, 2019 1 commit
  8. 09 Jun, 2019 5 commits
    • Stefan Kangas's avatar
      Make bookmark-old-default-file variable obsolete · abe18f59
      Stefan Kangas authored
      * lisp/bookmark.el (bookmark-old-default-file):
      Redefine as obsolete variable alias for 'bookmark-default-file'.
      (bookmark-maybe-load-default-file): Don't try to rename file
      'bookmark-old-default-file' (~/.emacs-bkmrks) to new name (Bug#35940).
    • Stefan Kangas's avatar
      Make bookmark-maybe-message obsolete (Bug#35918) · d11dd6a9
      Stefan Kangas authored
      * lisp/bookmark.el (bookmark-maybe-message):
      Redefine as obsolete function alias for 'message'.
      (bookmark-write-file): Use a progress reporter.
      (bookmark-load-file): Use a progress reporter.
    • Stefan Kangas's avatar
      Make `bookmark-file' variable obsolete · 9816aba5
      Stefan Kangas authored
      * lisp/bookmark.el (bookmark-file): Redefine as obsolete variable
      alias for `bookmark-default-file'.  (Bug#35917)
    • Stefan Kangas's avatar
      Remove interactive spec from bookmark-set-internal (bug#36121) · 323648bf
      Stefan Kangas authored
      * lisp/bookmark.el (bookmark-set-internal): Remove interactive spec.
    • Stefan Kangas's avatar
      Checkdoc fixes in lisp/bookmark.el · fb6610f5
      Stefan Kangas authored
      * lisp/bookmark.el (bookmark-bmenu-inline-header-height)
      (bookmark-bmenu-marks-width, bookmark-map, bookmark-quit-flag)
      (bookmark-name-from-full-record, bookmark-set-internal)
      (bookmark-insert-annotation, bookmark--jump-via)
      (bookmark-bmenu-set-header, bookmark-show-annotation)
      (bookmark-bmenu-other-window-with-mouse, bookmark-bmenu-relocate):
      Checkdoc docstring fixes.  (Bug#35916)
  9. 30 May, 2019 1 commit
  10. 26 May, 2019 1 commit
    • Paul Eggert's avatar
      Remove Maintainer: when it duplicates Author: · 797ee587
      Paul Eggert authored
      The convention is that a file with Author: but not Maintainer:
      means the author is a maintainer, which makes it confusing
      when a file lists the same person as author and maintainer.
      Avoid the confusion by removing the duplicate Maintainer: line.
  11. 01 Jan, 2019 1 commit
  12. 20 Nov, 2018 1 commit
  13. 09 Nov, 2018 1 commit
  14. 25 Jul, 2018 1 commit
  15. 24 Jul, 2018 1 commit
  16. 06 Jun, 2018 1 commit
    • Allen Li's avatar
      Fix prompt in bookmark.el (Bug#24726) · d20beef5
      Allen Li authored
      * lisp/bookmark.el (bookmark-set-internal): Conform to the standard
      default prompt format (per `minibuffer-electric-default-mode') which
      does not use a colon.
  17. 11 Mar, 2018 1 commit
    • Glenn Morris's avatar
      Remove many items obsolete since Emacs 22.1 · f1c48b0e
      Glenn Morris authored
      Emacs 22.1 was five major releases and over decade ago.
      In bug reporting statistics, it's been absent for around 5 years.
      Ref: https://debbugs.gnu.org/stats/emacs.html
      This list can be reviewed before to the next release, but for
      now hopefully this motivates any needed external updates.
      * lisp/arc-mode.el (archive-mouse-extract):
      * lisp/bookmark.el (bookmark-exit-hooks):
      * lisp/comint.el (comint-use-prompt-regexp-instead-of-fields):
      * lisp/cus-edit.el (custom-face-save-command):
      * lisp/descr-text.el (describe-char-after):
      * lisp/desktop.el (desktop-enable, desktop-basefilename)
      (desktop-buffer-modes-to-save, desktop-buffer-misc-functions)
      (desktop-buffer-handlers, desktop-load-default):
      * lisp/dired-x.el (dired-omit-files-p):
      * lisp/frame.el (new-frame, set-default-font, delete-frame-hook)
      * lisp/generic-x.el (generic-define-mswindows-modes)
      * lisp/help.el (describe-project, view-todo):
      * lisp/hilit-chg.el (highlight-changes-colours):
      * lisp/ibuffer.el (ibuffer-elide-long-columns, ibuffer-hooks)
      * lisp/imenu.el (imenu-always-use-completion-buffer-p):
      * lisp/isearch.el (isearch-lazy-highlight-cleanup)
      * lisp/mwheel.el (mouse-wheel-down-button)
      (mouse-wheel-up-button, mouse-wheel-click-button):
      * lisp/novice.el (disabled-command-hook):
      * lisp/recentf.el (recentf-menu-append-commands-p):
      * lisp/savehist.el (savehist-load):
      * lisp/speedbar.el (speedbar-ignored-path-expressions)
      (speedbar-ignored-path-regexp, speedbar-add-ignored-path-regexp)
      (speedbar-line-path, speedbar-buffers-line-path, speedbar-path-line):
      * lisp/subr.el (assoc-ignore-case, assoc-ignore-representation)
      (x-lost-selection-hooks, x-sent-selection-hooks)
      * lisp/calendar/icalendar.el (icalendar-convert-diary-to-ical)
      * lisp/emacs-lisp/autoload.el (update-autoloads-from-directories):
      * lisp/emacs-lisp/derived.el (derived-mode-class):
      * lisp/emacs-lisp/generic.el (generic-font-lock-defaults):
      * lisp/emacs-lisp/timer.el (timer-set-time-with-usecs):
      * lisp/gnus/spam.el (spam-list-of-processors):
      * lisp/international/latin1-disp.el (latin1-char-displayable-p):
      * lisp/mail/rmail.el (rmail-pop-password, rmail-pop-password-required):
      * lisp/net/goto-addr.el (goto-address-at-mouse):
      * lisp/net/net-utils.el (ipconfig-program, ipconfig-program-options):
      * lisp/obsolete/iswitchb.el (iswitchb-use-fonts):
      * lisp/play/dunnet.el (dungeon-mode-map):
      * lisp/progmodes/compile.el (compilation-finish-function)
      * lisp/progmodes/cperl-mode.el (cperl-vc-header-alist)
      * lisp/progmodes/gud.el (tooltip-gud-modes, tooltip-gud-display)
      * lisp/progmodes/pascal.el (pascal-outline):
      * lisp/progmodes/perl-mode.el (electric-perl-terminator):
      * lisp/textmodes/nroff-mode.el (count-text-lines)
      (forward-text-line, backward-text-line, electric-nroff-newline)
      * lisp/vc/log-edit.el (vc-comment-ring, vc-comment-ring-index)
      (vc-previous-comment, vc-next-comment)
      (vc-comment-search-reverse, vc-comment-search-forward)
      * lisp/vc/pcvs-info.el (cvs-display-full-path)
      * lisp/vc/vc.el (vc-diff-switches-list):
      Remove items, obsolete since Emacs 22.1.
      * lisp/ibuffer.el (ibuffer-cached-elide-long-columns):
      Remove internal variable.
      (ibuffer-compile-make-eliding-form, ibuffer-check-formats):
      (ibuffer-mode): Remove support for ibuffer-elide-long-columns.
      * lisp/cedet/semantic/sb.el (semantic-sb-token-jump):
      Remove support for speedbar-line-path.
      * lisp/emacs-lisp/unsafep.el (assoc-ignore-case):
      Stop marking as side-effect-free.
      * lisp/gnus/spam.el (spam-group-processor-p):
      Remove support for spam-list-of-processors.
      * lisp/progmodes/compile.el (define-compilation-mode)
      Remove support for compilation-finish-function.
      * lisp/progmodes/cperl-mode.el (cperl-mode):
      Remove support for cperl-vc-header-alist.
      ; * lisp/files.el: Comments.
      ; * etc/NEWS: List removed items.
  18. 01 Jan, 2018 1 commit
  19. 09 Dec, 2017 1 commit
  20. 13 Sep, 2017 1 commit
    • Paul Eggert's avatar
      Prefer HTTPS to FTP and HTTP in documentation · bc511a64
      Paul Eggert authored
      Most of this change is to boilerplate commentary such as license URLs.
      This change was prompted by ftp://ftp.gnu.org's going-away party,
      planned for November.  Change these FTP URLs to https://ftp.gnu.org
      instead.  Make similar changes for URLs to other organizations moving
      away from FTP.  Also, change HTTP to HTTPS for URLs to gnu.org and
      fsf.org when this works, as this will further help defend against
      man-in-the-middle attacks (for this part I omitted the MS-DOS and
      MS-Windows sources and the test tarballs to keep the workload down).
      HTTPS is not fully working to lists.gnu.org so I left those URLs alone
      for now.
  21. 12 Feb, 2017 2 commits
    • Karl Fogel's avatar
      Convert more uses of `looking-at' to `following-char' · a84da83c
      Karl Fogel authored
      This follows up to Mark Oteiza's commit of 12 Feb 2017, 14:46:03 UTC
      (commit 91478f46) with more of the same.
      * lisp/bookmark.el (bookmark-send-edited-annotation):
        (bookmark-bmenu-execute-deletions): Replace instances of looking-at
        with char comparisons using following-char.
    • Mark Oteiza's avatar
      Nix some useless uses of looking-at, looking-back · 91478f46
      Mark Oteiza authored
      * lisp/allout.el (allout-kill-topic):
      * lisp/bookmark.el (bookmark-kill-line):
      * lisp/cus-edit.el (custom-save-variables, custom-save-faces):
      * lisp/cus-theme.el (custom-theme-write-variables):
      * lisp/emacs-lisp/autoload.el (autoload-generate-file-autoloads):
      * lisp/emacs-lisp/bytecomp.el (byte-compile-from-buffer):
      * lisp/emacs-lisp/checkdoc.el (checkdoc-interactive-loop):
      (checkdoc-message-interactive-ispell-loop, checkdoc-this-string-valid):
      * lisp/emacs-lisp/elint.el (elint-get-top-forms):
      * lisp/emulation/viper-cmd.el (viper-backward-indent):
      * lisp/image-dired.el (image-dired-delete-char):
      * lisp/simple.el (kill-visual-line): Replace instances of looking-at,
      looking-back with char comparisons using following-char, preceding-char.
  22. 10 Jan, 2017 1 commit
  23. 07 Jan, 2017 1 commit
    • Eli Zaretskii's avatar
      Specify encoding of the bookmark file · e2720327
      Eli Zaretskii authored
      * lisp/bookmark.el (bookmark-insert-file-format-version-stamp):
      Accept an argument CODING and include a 'coding:' cookie in the
      bookmark file preamble.
      (bookmark-upgrade-file-format-from-0): Call
      'bookmark-insert-file-format-version-stamp' with the file buffer's
      encoding, as detected when it was read.
      (bookmark-file-coding-system): New variable.
      (bookmark-load): Set bookmark-file-coding-system to the encoding
      of the loaded file.
      (bookmark-write-file): Bind coding-system-for-write to either the
      user setting via "C-x RET c" or to the existing file encoding,
      defaulting to 'utf-8-emacs'.  Update the value of
      bookmark-file-coding-system.  (Bug#25365)
  24. 01 Jan, 2017 1 commit
  25. 22 Dec, 2016 1 commit
  26. 25 Apr, 2016 1 commit
  27. 01 Jan, 2016 1 commit
  28. 10 Nov, 2015 1 commit
    • Karl Fogel's avatar
      Fix some recently-perturbed bookmark autoloads · 0f50e516
      Karl Fogel authored
      * lisp/bookmark.el (bookmark-set-internal): Remove unnecessary autoload.
        (bookmark-set): Restore autoload.
        (bookmark-set-no-overwrite): Add autoload.
      Thanks to Juanma Barranquero for noticing the autoload problems
      introduced by my recent commit adding/changing the above functions
      (Sun Nov 8 14:16:43 2015 -0500, git commit 3812e179).
  29. 08 Nov, 2015 1 commit
    • Karl Fogel's avatar
      Offer non-overwrite bookmark setter (Bug#15746) · 3812e179
      Karl Fogel authored
      * lisp/bookmark.el (bookmark-set-internal): New helper function to do
        what `bookmark-set' used to do, but with more choices for overwrite
        vs push, and with minor changes to the interactive prompt format.
        (bookmark-set): Rewrite as wrapper around above.
        If overwriting, inform the user of that in the prompt.
        (bookmark-set-no-overwrite): New function, also done as wrapper.
        Bind to "M" in `ctl-x-r-map' autoloads.
        (bookmark-map): Similarly bind "M" here.
  30. 17 Sep, 2015 1 commit
    • Paul Eggert's avatar
      Backslash cleanup in Elisp source files · 284c470e
      Paul Eggert authored
      This patch should not change behavior.  It typically omits backslashes
      where they are redundant (e.g., in the string literal "^\$").
      In a few places, insert backslashes where they make regular
      expressions clearer: e.g., replace "^\*" (equivalent to "^*") with
      "^\\*", which has the same effect as a regular expression.
      Also, use ‘\ %’ instead of ‘\%’ when avoiding confusion with SCCS IDs,
      and similarly use ‘\ $’ instead of ‘\$’ when avoiding confusion with
      RCS IDs, as that makes it clearer that the backslash is intended.