1. 14 Nov, 2021 18 commits
    • Alan Third's avatar
      Allow resizing undecorated frames on macOS (bug#28512, bug#31795) · 6ab3dc17
      Alan Third authored
      * src/nsterm.m (FRAME_DECORATED_FLAGS, FRAME_UNDECORATED_FLAGS):
      Remove unused defines.
      * src/nsterm.m ([EmacsWindow initWithEmacsFrame:fullscreen:screen:]):
      Since this is now the only place these defines are used just put them
      inline and add NSWindowStyleMaskResizable for undecorated frames on
      Cocoa.
      6ab3dc17
    • Alan Third's avatar
      Make NS toolbar item ID more unique (bug#50160) · 7d2c360a
      Alan Third authored
      * src/nsmenu.m
      ([EmacsToolbar addDisplayItemWithImage:idx:tag:labelText:helpText:enabled:]):
      Add the label to the identifier to avoid collisions between toolbar
      items that use the same image.
      7d2c360a
    • Alan Third's avatar
      Make NS toolbar use NSString instead of C strings · 9eadfb78
      Alan Third authored
      * src/nsfns.m ([NSString stringWithLispString:]): Ensure that the lisp
      object is actually a string.
      * src/nsmenu.m (update_frame_tool_bar): Convert to NSString instead of
      C strings.
      ([EmacsToolbar addDisplayItemWithImage:idx:tag:labelText:helpText:enabled:]):
      No need to convert to NSString here anymore.
      9eadfb78
    • Alan Third's avatar
      Fix macfont backend color handling · ee8e8af8
      Alan Third authored
      * src/macfont.m (get_cgcolor): Replace use of ns_lookup_indexed_color.
      (CG_SET_FILL_COLOR_WITH_FACE_FOREGROUND):
      (CG_SET_FILL_COLOR_WITH_FACE_BACKGROUND):
      (CG_SET_STROKE_COLOR_WITH_FACE_FOREGROUND): Fix call to get_cgcolor
      and fix all callers.
      ee8e8af8
    • Alan Third's avatar
      Further cleanup of NS color code · bc3b8f34
      Alan Third authored
      * src/dispextern.h (FACE_COLOR_TO_PIXEL): Remove define and fix all
      callers.
      * src/nsterm.h (struct nsfont_info): Remove color_table.
      * src/nsterm.m ([NSColor colorWithUnsignedLong:]): Always assume the
      input contains the correct alpha value.
      (ns_lookup_indexed_color):
      (ns_index_color):
      (ns_color_index_to_rgba): Remove functions and fix all callers.
      (ns_query_color): No longer set pixel to the lookup table index,
      always just set it to the ARGB integer value.
      (ns_defined_color): Ignore makeindex as we no longer set pixel to the
      lookup table index.
      (ns_initialize_display_info):
      (ns_redisplay_interface): Remove lookup table.
      (ns_term_init): Fix the alpha setting.
      bc3b8f34
    • Alan Third's avatar
      Simplify NS color handling · 2dd414a0
      Alan Third authored
      * src/image.c (RGB_TO_ULONG):
      (ARGB_TO_ULONG):
      (RED_FROM_ULONG):
      (RED16_FROM_ULONG):
      (GREEN16_FROM_ULONG):
      (BLUE16_FROM_ULONG): Define these here for NS too.
      * src/nsfns.m (ns_set_foreground_color):
      (ns_set_background_color): Use new EmacsColor methods.
      * src/nsterm.h (struct ns_color_table): Replace this struct with a
      built-in Objective C type.
      (RGB_TO_ULONG):
      (ARGB_TO_ULONG):
      (ALPHA_FROM_ULONG):
      (RED_FROM_ULONG):
      (GREEN_FROM_ULONG):
      (BLUE_FROM_ULONG):
      (RED16_FROM_ULONG):
      (GREEN16_FROM_ULONG):
      (BLUE16_FROM_ULONG): These are no longer needed in the NS specific code.
      (struct ns_display_info): Use an NSMutableArray instead of a custom struct.
      * src/nsterm.m ([NSColor colorWithUnsignedLong:hasAlpha:]):
      ([NSColor unsignedLong]): New methods.
      (ns_lookup_indexed_color):
      (ns_index_color): Use the NSMutableArray lookup table.
      (ns_term_init):
      (ns_color_index_to_rgba):
      (ns_query_color): Use the new EmacsColor methods.
      (ns_initialize_display_info):
      (ns_delete_display): Initialize and release the NSMutableArray lookup table.
      2dd414a0
    • Alan Third's avatar
      Only set LANG if the ID is valid · 5e4ba5c1
      Alan Third authored
      * src/nsterm.m (ns_init_locale): Check the provided locale identifier
      is available before trying to use it.
      5e4ba5c1
    • Po Lu's avatar
      Expose xwidget navigation history to Lisp code · c3f53d26
      Po Lu authored
      * doc/lispref/display.texi (Xwidgets): Document changes.
      * etc/NEWS: Announce new function.
      * src/xwidget.c (Fxwidget_webkit_back_forward_list): New
      function.
      (syms_of_xwidget): Define new subr.
      c3f53d26
    • Po Lu's avatar
      Add `kill-xwidget' · 609bc1d3
      Po Lu authored
      * doc/lispref/display.texi (Xwidgets): Document 'kill-xwidget'.
      * src/xwidget.c (kill_xwidget, Fkill_xwidget): New function.
      (syms_of_xwidget): Define new subr.
      (kill_buffer_xwidgets): Use `kill_xwidget' instead.
      609bc1d3
    • Lars Ingebrigtsen's avatar
      Fix previous -responsible-p change · 06632fba
      Lars Ingebrigtsen authored
      * lisp/vc/vc-sccs.el (vc-sccs-responsible-p):
      * lisp/vc/vc-rcs.el (vc-rcs-responsible-p):
      * lisp/vc/vc-cvs.el (vc-cvs-responsible-p): Make the previous
      change work with relative file names, too.
      06632fba
    • Lars Ingebrigtsen's avatar
      Explain in the manual how to make `cursor-intangible' work · 370d4038
      Lars Ingebrigtsen authored
      * doc/lispref/text.texi (Special Properties): Explain how to make
      `cursor-intangible' work (bug#51095).
      370d4038
    • Po Lu's avatar
      Fix crash in xwidget_end_redisplay · 9627b731
      Po Lu authored
      * src/xwidget.c (xwidget_end_redisplay): Always test if xv is
      NULL.
      9627b731
    • Lars Ingebrigtsen's avatar
      Fix `C-h k' in gnus-article-mode · e29c9308
      Lars Ingebrigtsen authored
      * lisp/gnus/gnus-art.el (gnus-article-describe-key):
      (gnus-article-describe-key-briefly): Fix `describe-key' calling
      convention (bug#51796).
      e29c9308
    • Lars Ingebrigtsen's avatar
      Make all vc-*-responsible-p functions return a string · ad442b88
      Lars Ingebrigtsen authored
      * lisp/vc/vc-sccs.el (vc-sccs-responsible-p):
      * lisp/vc/vc-rcs.el (vc-rcs-responsible-p):
      * lisp/vc/vc-dav.el (vc-dav-responsible-p):
      * lisp/vc/vc-cvs.el (vc-cvs-responsible-p): Return a file name
      instead of t when we get a match (which is what
      vc-backend-for-registration expects) (bug#51800).
      ad442b88
    • Kévin Le Gouguec's avatar
      Fix customization group of python-forward-sexp-function · 48ffbcf7
      Kévin Le Gouguec authored
      * lisp/progmodes/python.el (python-forward-sexp-function): Move from
      the "Flymake integration" subsection to the "Navigation" subsection,
      so that the option is sorted into the 'python' group rather than the
      'python-flymake' group (bug#51807).
      48ffbcf7
    • Lars Ingebrigtsen's avatar
      Fix Gnus gcc header tokenization · 08ce17c2
      Lars Ingebrigtsen authored
      * lisp/gnus/gnus-msg.el (gnus-summary-resend-message-insert-gcc)
      (gnus-inews-do-gcc): Fix tokenization of the gcc header.
      08ce17c2
    • Lars Ingebrigtsen's avatar
      Adjust build-dep-zips.py download link · 5beed9df
      Lars Ingebrigtsen authored
      * admin/nt/dist-build/build-dep-zips.py (download_source): Adjust
      the download link (bug#40628).
      5beed9df
    • Manuel Giraud's avatar
      Find most specific backend for `vc-backend-for-registration'. · 439a3094
      Manuel Giraud authored
      * lisp/vc/vc.el (vc-backend-for-registration): Count file name
      components instead of the length of the file name string (bug#50572).
      439a3094
  2. 13 Nov, 2021 15 commits
    • Stephen Gildea's avatar
      MH-E threads code: use mh-scan variables correctly · 4df334a0
      Stephen Gildea authored
      * lisp/mh-e/mh-thread.el (mh-thread-current-indentation-level)
      (mh-thread-find-children): Fix off-by-one error by using
      'mh-scan-field-from-start-offset' directly, as
      'mh-thread-parse-scan-line' does.  Previously, these functions would
      incorrectly consider the "date note" column as part of the thread
      indenting.  Since that column is almost always a Space character, that
      almost always worked.
      (mh-thread-ancestor): Update caller.
      * test/lisp/mh-e/mh-thread-tests.el: New unit tests for affected code.
      * lisp/mh-e/mh-scan.el (mh-msg-num-width-to-column): Fix doc string typo.
      4df334a0
    • Michael Albinus's avatar
      d3666ccd
    • Michael Albinus's avatar
      Remove Tramp's `dired-compress-file' handler, not needed anymore · aa88845a
      Michael Albinus authored
      * lisp/dired-aux.el (dired-check-process, dired-shell-command):
      Call `dired-uncache'.
      (dired-compress-file): Use `file-local-name'.
      
      * lisp/net/tramp-adb.el (tramp-adb-file-name-handler-alist):
      * lisp/net/tramp-archive.el (tramp-archive-file-name-handler-alist):
      * lisp/net/tramp-crypt.el (tramp-crypt-file-name-handler-alist):
      * lisp/net/tramp-gvfs.el (tramp-gvfs-file-name-handler-alist):
      * lisp/net/tramp-rclone.el (tramp-rclone-file-name-handler-alist):
      * lisp/net/tramp-smb.el (tramp-smb-file-name-handler-alist):
      * lisp/net/tramp-sshfs.el (tramp-sshfs-file-name-handler-alist):
      * lisp/net/tramp-sudoedit.el (tramp-sudoedit-file-name-handler-alist):
      Remove superfluous comment.
      
      * lisp/net/tramp-sh.el (dired-compress-file): Declare.
      (tramp-sh-handle-dired-compress-file): Call real handler for
      Emacs >= 29.
      
      * lisp/net/tramp.el (tramp-file-name-for-operation): Reorder list.
      
      * test/lisp/net/tramp-tests.el (tramp-test45-dired-compress-file)
      (tramp-test45-dired-compress-dir): Adapt comment.
      aa88845a
    • Po Lu's avatar
      Fix scroll event test in handle_one_xevent · f7abc04c
      Po Lu authored
      * src/xterm.c (handle_one_xevent): Test for scroll wheel button
      correctly in xwidget code.
      f7abc04c
    • Eli Zaretskii's avatar
      Fix font selection via :family on MS-Windows · 89d7a71c
      Eli Zaretskii authored
      * src/font.c (font_delete_unmatched) [HAVE_NTGUI]: Allow non-exact
      matches of :weight when looking for a suitable font.  (Bug#51768)
      89d7a71c
    • Alan Mackenzie's avatar
      Correct patch from 2021-11-12 on src/fileio.c · f740becf
      Alan Mackenzie authored
      * src/fileio.c (restore_window_points): Reverse commit
      97419241 and instead replace a < by a <=.
      This ensures that if w->mpoint is at the top of the middle region being
      replaced, it gets adjusted and stays at the top after the reinsertion.
      f740becf
    • Po Lu's avatar
      Don't emit SELECT_WINDOW_EVENT when an xwidget is scrolled · 102406ed
      Po Lu authored
      * src/xterm.c (handle_one_event): Don't select xwidget window
      on button event if the button pressed actually represents the
      scroll wheel.
      102406ed
    • Alan Mackenzie's avatar
      C++ Mode: Fix incoorect background fontification of < · 60a85834
      Alan Mackenzie authored
      Where c-record-found-types gets "bound" to itself, we postpone the calling of
      c-fontify-new-type on possible new found types until these are confirmed by
      the return from the function tentatively finding these types, for exmaple
      c-forward-<>-arglist.  We check this "binding" by testing the value of
      c-record-found-types.
      
      Correct the background fontification algorithm.
      
      * lisp/progmodes/cc-engine.el (c-record-found-types): Move the definition to
      earlier in the file.
      (c-add-type-1): Check additionally c-record-found-types is nil before calling
      c-fontify-new-found-type.
      (c-forward-<>-arglist, c-forward-type): On return from a function which
      collects found types in c-record-found-types, call c-fontify-new-found-types
      for each such type.
      
      * lisp/progmodes/c-fonts.el (c-force-redisplay): Actually fontify the new
      found type.
      (c-fontify-new-found-type): Test for font-lock-mode being enabled.  Remove the
      spurious condition on the `fontified' text property being nil before causing
      c-force-redisplay to get called.
      60a85834
    • Lars Ingebrigtsen's avatar
      Don't create links to undefined commands in help--describe-command · f32280bf
      Lars Ingebrigtsen authored
      * lisp/help.el (help--describe-command): Don't create links to
      commands that aren't defined.
      f32280bf
    • Po Lu's avatar
      Use GTK native file choosers in xwidget callback · dafebe37
      Po Lu authored
      * src/xwidget.c (run_file_chooser_cb): Use GtkFileChooserNative
      instead.
      dafebe37
    • Stefan Kangas's avatar
      Merge from origin/emacs-28 · b4c6ab8c
      Stefan Kangas authored
      42d4e24f ; Fix typos
      0d0125da Improve documentation of 'decode-coding-region'
      b4c6ab8c
    • Po Lu's avatar
      Prevent NULL-pointer dereference on xwidget callback error · a5008352
      Po Lu authored
      * src/xwidget.c (webkit_javascript_finished_cb): Check if
      `error' is NULL before freeing it.
      a5008352
    • Po Lu's avatar
      Fix file chooser hangs inside xwidget-webkit · eb4567e5
      Po Lu authored
      * src/xwidget.c (run_file_chooser_cb): New function that runs
      a nested event loop instead of acting asynchronously.
      (Fmake_xwidget): Attach file chooser signal.
      eb4567e5
    • Po Lu's avatar
      Remove unused xwidget code in EmacsFixed GTK widget class · 59a58328
      Po Lu authored
      This is no longer required, as we rely on X to position
      xwidgets now.  It also makes resizing Emacs frames slightly
      slower.
      
      * src/emacsgtkfixed.c (EMACS_FIXED_GET_CLASS)
      (struct GtkFixedPrivateL)
      (emacs_fixed_gtk_widget_size_allocate)
      (emacs_fixed_class_init) [HAVE_XWIDGETS]: Remove unused code.
      59a58328
    • Po Lu's avatar
      Prevent xwidget webkit isearch messages from entering log buffer · 3ea70eea
      Po Lu authored
      * lisp/xwidget.el (xwidget-webkit-isearch--update): Prevent
      logging when displaying search contents message.
      3ea70eea
  3. 12 Nov, 2021 7 commits
    • Ken Brown's avatar
      Don't start both timerfd and alarms on Cygwin · e4f8ce78
      Ken Brown authored
      * src/atimer.c (set_alarm) [CYGWIN]: Don't start both timerfd and
      alarms; this causes a slowdown.  (Bug#51734)
      e4f8ce78
    • Alan Mackenzie's avatar
      In insert_file_contents, always set windows' point markers. · 97419241
      Alan Mackenzie authored
      This fixes bug #51776.
      
      * src/fileio.c (restore_window_points): Restore a w->mpoint even when that
      marker originally pointed into the unchanged area near BOB or EOB.  This
      prevents that window's point being moved a long way from its starting place
      due to the removal of the central part of the buffer by insert_file_contents.
      97419241
    • Michael Albinus's avatar
      Remove Emacs 25 compatibility from Tramp · 2c5be6dd
      Michael Albinus authored
      * doc/misc/tramp.texi (Remote programs, Remote processes)
      (Frequently Asked Questions): Adapt Emacs versions.
      
      * doc/misc/trampver.texi:
      * lisp/net/trampver.el: Change version to "2.6.0-pre".
      
      * lisp/net/tramp-adb.el (top): Don't use `tramp-compat-funcall' for
      connection-local functions.
      
      * lisp/net/tramp-compat.el (tramp-unload-file-name-handlers)
      (tramp-handle-temporary-file-directory)
      (tramp-compat-temporary-file-directory-function)
      (tramp-compat-file-attribute-type)
      (tramp-compat-file-attribute-link-number)
      (tramp-compat-file-attribute-user-id)
      (tramp-compat-file-attribute-group-id)
      (tramp-compat-file-attribute-access-time)
      (tramp-compat-file-attribute-modification-time)
      (tramp-compat-file-attribute-status-change-time)
      (tramp-compat-file-attribute-size)
      (tramp-compat-file-attribute-modes, tramp-file-missing)
      (tramp-compat-file-missing, tramp-compat-file-local-name): Remove.
      (tramp-compat-file-name-quoted-p, tramp-compat-file-name-quote)
      (tramp-compat-file-name-unquote)
      (tramp-compat-progress-reporter-update)
      (tramp-compat-file-modes, tramp-compat-set-file-modes)
      (tramp-compat-set-file-times, tramp-compat-directory-files)
      (tramp-compat-directory-files-and-attributes): Adapt implementation.
      
      * lisp/net/tramp.el:
      * lisp/net/tramp-adb.el:
      * lisp/net/tramp-archive.el:
      * lisp/net/tramp-crypt.el:
      * lisp/net/tramp-fuse.el:
      * lisp/net/tramp-gvfs.el:
      * lisp/net/tramp-rclone.el:
      * lisp/net/tramp-sh.el:
      * lisp/net/tramp-smb.el:
      * lisp/net/tramp-sudoedit.el: Adapt callees.
      
      * lisp/net/tramp-crypt.el (tramp-crypt-config-file-name):
      Expand file name.
      
      * lisp/net/tramp-fuse.el (tramp-fuse-handle-file-readable-p): Remove.
      
      * lisp/net/tramp-gvfs.el (tramp-gvfs-enabled): Don't check Emacs version.
      (tramp-gvfs-handler-mounted-unmounted): Use `make-tramp-file-name'.
      
      * lisp/net/tramp-integration.el (rfn-eshadow-overlay):
      Remove declaration.
      (top): Don't use `tramp-compat-funcall' for connection-local functions.
      
      * lisp/net/tramp-rclone.el (tramp-rclone-file-name-handler-alist):
      Use `tramp-rclone-handle-file-readable-p'.
      (tramp-rclone-handle-file-readable-p): New defun.
      
      * lisp/net/tramp-sshfs.el (tramp-sshfs-file-name-handler-alist):
      Use `tramp-handle-file-readable-p'.
      
      * lisp/net/tramp.el (tramp-temp-name-prefix, tramp-lookup-syntax):
      Adapt docstring.
      (tramp-set-connection-local-variables)
      (tramp-set-connection-local-variables-for-buffer): Don't use
      `tramp-compat-funcall' for connection-local functions.
      (tramp-file-name-for-operation): Reorder list.
      (tramp-handle-make-symbolic-link): Don't handle TARGET and
      OK-IF-ALREADY-EXISTS.
      (tramp-read-passwd): Don't use `read-passwd' any longer.
      (top): Don't check for `interrupt-process-functions'.
      
      * test/lisp/net/tramp-archive-tests.el (tramp-archive--test-emacs26-p):
      Remove.
      (tramp-archive-test02-file-name-dissect): Use `make-tramp-file-name'.
      (all): Replace Emacs 26 compatibility functions with their
      original name.
      (tramp-archive-test46-auto-load)
      (tramp-archive-test46-delay-load): Rename.
      
      * test/lisp/net/tramp-tests.el (dired-aux, seq): Require them.
      (dired-compress, connection-local-criteria-alist)
      (connection-local-profile-alist, async-shell-command-width):
      Don't declare.
      (all): Replace Emacs 26 compatibility functions with their
      original name.
      (tramp-test04-substitute-in-file-name)
      (tramp-test10-write-region, tramp-test11-copy-file)
      (tramp-test12-rename-file, tramp-test15-copy-directory)
      (tramp-test17-insert-directory)
      (tramp-test17-dired-with-wildcards, tramp-test21-file-links)
      (tramp-test31-interrupt-process)
      (tramp-test34-connection-local-variables)
      (tramp-test34-explicit-shell-file-name)
      (tramp-test40-make-nearby-temp-file)
      (tramp-test41-special-characters, tramp-test42-utf8)
      (tramp-test46-delay-load, tramp-test46-remote-load-path)
      (tramp-test47-unload): Don't check for Emacs 26 special features.
      (tramp--test-emacs26-p): Remove.
      (tramp--test-emacs29-p): New defun.
      (tramp-test45-dired-compress-file)
      (tramp-test45-dired-compress-dir): Use it.
      (tramp-test44-asynchronous-requests): Use `seq-random-elt'.
      2c5be6dd
    • Stefan Kangas's avatar
      ; Fix typos · 42d4e24f
      Stefan Kangas authored
      42d4e24f
    • Po Lu's avatar
      Fix typos in etc/PROBLEMS · 12d554e5
      Po Lu authored
      * etc/PROBLEMS (Internationalization problems): Fix typos.
      12d554e5
    • Po Lu's avatar
      Document problem with fcitx and xwidgets · 449bc51d
      Po Lu authored
      * etc/PROBLEMS (Internationalization problems): Document buggy fcitx
      with xwidgets.
      449bc51d
    • Michael Albinus's avatar
      ; * etc/NEWS: Fix typos. · 75e21916
      Michael Albinus authored
      75e21916