Skip to content

GitLab

Move lexical-binding warning from checkdoc to byte-compiler 

This warning is much more appropriate for the compiler, since lexical
binding affects what it can reason and warn about, than for checkdoc
as the warning has no bearing to documentation at all.
The move also improves the reach of the warning.

* etc/NEWS: Update.
* lisp/emacs-lisp/checkdoc.el (checkdoc-lexical-binding-flag)
(checkdoc-file-comments-engine): Move warning from here....
* lisp/emacs-lisp/bytecomp.el (byte-compile-file): ...to here.
* test/lisp/emacs-lisp/bytecomp-resources/no-byte-compile.el:
* test/lisp/emacs-lisp/bytecomp-tests.el
(bytecomp-tests--unescaped-char-literals)
(bytecomp-tests-function-put, bytecomp-tests--not-writable-directory)
(bytecomp-tests--target-file-no-directory):
Update tests.
(bytecomp-tests--log-from-compilation)
(bytecomp-tests--lexical-binding-cookie): New test.
2 jobs for master in 3 minutes and 31 seconds (queued for 29 seconds)
a3db5033
No related merge requests found.
Status Job ID Name Coverage
  Build Images
failed #75795
build-image-inotify

00:03:31

 
  Normal
skipped #75796
test-lisp-emacs-lisp-inotify
 
Name Stage Failure
failed
build-image-inotify Build Images 
$ docker login -u ${CI_REGISTRY_USER} -p ${CI_REGISTRY_PASSWORD} ${CI_REGISTRY}
WARNING! Using --password via the CLI is insecure. Use --password-stdin.
Error response from daemon: Get "https://emba.gnu.org:5050/v2/": Get "https://emba.gnu.org//jwt/auth?account=gitlab-ci-token&client_id=docker&offline_token=true&service=container_registry": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
Running after script...
$ test -n "$(docker ps -aq -f name=${test_name})" && docker cp ${test_name}:checkout/test ${test_name}
$ test -n "$(docker ps -aq -f name=${test_name})" && docker rm ${test_name}
$ find ${test_name} ! \( -name "*.log" -o -name ${EMACS_TEST_JUNIT_REPORT} \) -type f -delete
find: build-image-inotify-a3db5033: No such file or directory
ERROR: Job failed: exit code 1