Commit 9063124b authored by Robert Pluim's avatar Robert Pluim

Use pthread_setname_np to set thread name

* Remove check for sys/prctl.h and prctl, check for
pthread_setname_np instead.

* systhread.c: Remove sys/prctl.h include.
(sys_thread_create) [HAVE_PTHREAD_SETNAME_NP]: Use pthread_setname_np
to set the name of the newly created thread (Bug#38632).

* thread.c (Fmake_thread): Use ENCODE_SYSTEM instead of
ENCODE_UTF_8 on the thread name.
parent 088bfcc2
Pipeline #4501 passed with stage
in 54 minutes and 58 seconds
......@@ -1767,7 +1767,7 @@ AC_CHECK_HEADERS_ONCE(
coff.h pty.h
sys/utsname.h pwd.h utmp.h util.h sys/prctl.h)
sys/utsname.h pwd.h utmp.h util.h)
......@@ -4180,7 +4180,7 @@ pthread_sigmask strsignal setitimer timer_getoverrun \
sendto recvfrom getsockname getifaddrs freeifaddrs \
gai_strerror sync \
getpwent endpwent getgrent endgrent \
cfmakeraw cfsetspeed __executable_start log2 prctl)
cfmakeraw cfsetspeed __executable_start log2 pthread_setname_np)
dnl No need to check for posix_memalign if aligned_alloc works.
......@@ -98,10 +98,6 @@ sys_thread_yield (void)
#include <sched.h>
#include <sys/prctl.h>
sys_mutex_init (sys_mutex_t *mutex)
......@@ -227,9 +223,18 @@ sys_thread_create (sys_thread_t *thread_ptr, const char *name,
if (!pthread_attr_setdetachstate (&attr, PTHREAD_CREATE_DETACHED))
result = pthread_create (thread_ptr, &attr, func, arg) == 0;
#if defined (HAVE_SYS_PRCTL_H) && defined (HAVE_PRCTL) && defined (PR_SET_NAME)
if (result && name != NULL)
prctl (PR_SET_NAME, name);
/* We need to truncate here otherwise pthread_setname_np
fails to set the name. TASK_COMM_LEN is what the length
is called in the Linux kernel headers (Bug#38632). */
#define TASK_COMM_LEN 16
char p_name[TASK_COMM_LEN];
strncpy (p_name, name, TASK_COMM_LEN - 1);
p_name[TASK_COMM_LEN - 1] = '\0';
pthread_setname_np (*thread_ptr, p_name);
......@@ -826,7 +826,7 @@ If NAME is given, it must be a string; it names the new thread. */)
new_thread->next_thread = all_threads;
all_threads = new_thread;
char const *c_name = !NILP (name) ? SSDATA (ENCODE_UTF_8 (name)) : NULL;
char const *c_name = !NILP (name) ? SSDATA (ENCODE_SYSTEM (name)) : NULL;
if (c_name)
new_thread->thread_name = xstrdup (c_name);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment