1. 18 May, 2019 26 commits
    • Stefan Monnier's avatar
      * lisp/emacs-lisp/package.el: Fix decoding of downloaded files · 5f9671e5
      Stefan Monnier authored
      This is a different fix for bug#34909, which should also fix bug#35739.
      
      Our downloading code used to automatically decode the result according
      to the usual heuristics for files.  This caused problems when we later
      needed to save the data in a file that needed to be byte-for-byte
      equal to the original in order to pass the signature verification,
      especially because we didn't keep track of which coding-system was
      used to decode the data.
      
      (package--unless-error): New macro extracted from
      package--with-response-buffer-1, so that we can specify edebug and
      indent specs.
      (package--with-response-buffer-1): Use it.  More importantly, change
      code so it runs `body` in a unibyte buffer with undecoded data.
      (package--download-one-archive): Don't encode with utf-8 since the data
      is not decoded yet.
      (describe-package-1): Explicitly decode the readem.txt files here.
      
      * lisp/url/url-handlers.el (url-insert-file-contents): Use it.
      (url-insert): Don't decode if buffer is unibyte.
      
      * lisp/url/url-http.el (url-http--insert-file-helper): New function,
      extracted from url-insert-file-contents.
      5f9671e5
    • Stefan Monnier's avatar
      * lisp/emacs-lisp/package.el: Reduce macrology in ...with-response-buffer · 2a570576
      Stefan Monnier authored
      (package--with-response-buffer-1): New function, extracted from
      package--with-response-buffer.
      (package--with-response-buffer): Use it.
      2a570576
    • Mattias Engdegård's avatar
      Fix broken logic in file-notify · 3dcacb09
      Mattias Engdegård authored
      * lisp/filenotify.el (file-notify-callback):
      Repair warped condition that didn't match rename-to/from events correctly.
      3dcacb09
    • Paul Eggert's avatar
    • Jean-Christophe Helary's avatar
      Bob Chassell passed away · d6e7b18d
      Jean-Christophe Helary authored
      * doc/lispintro/emacs-lisp-intro.texi (About the Author): Update.
      d6e7b18d
    • Paul Eggert's avatar
      Fix recent Tramp typo that broke the build · ae705679
      Paul Eggert authored
      ‘make bootstrap’ without this patch should reproduce the problem.
      * lisp/net/tramp-gvfs.el (tramp-gvfs-enabled):
      Autoload zeroconf-init.
      ae705679
    • Basil L. Contovounesios's avatar
      Remove XEmacs audio checks from mm-decode.el · 63ffb613
      Basil L. Contovounesios authored
      For discussion, see the following threads:
      https://lists.gnu.org/archive/html/emacs-devel/2019-03/msg01087.html
      https://lists.gnu.org/archive/html/emacs-devel/2019-05/msg00584.html
      * lisp/gnus/mm-decode.el (mm-inline-media-tests): Remove no-op media
      tests for XEmacs features.
      63ffb613
    • Paul Eggert's avatar
      For SVG, 8192 is the new 256 · db9af103
      Paul Eggert authored
      Prefer librsvg for display of splash.svg
      When both librsvg and Imagemagick are available, Emacs should
      prefer librsvg to render SVG images.  However, Emacs was using
      Imagemagick to render its own splash.svg file because
      image-type-from-file-header returned nil for that file.
      * lisp/image.el (image-type-from-buffer)
      (image-type-from-file-header): Look at the first 8192 bytes of
      the image, not just the first 256.  For Emacs’s own splash.svg
      file, image-type-header-regexps needs to look at 939 bytes.
      8192 bytes is a reasonable number nowadays given typical file
      system design.
      * test/lisp/image-tests.el (image-tests--emacs-images-directory):
      New contant.
      (image-type-from-file-header-test): New test.
      db9af103
    • Michael Albinus's avatar
      5b8be580
    • Michael Albinus's avatar
      Bug#35769 · 16f14a4d
      Michael Albinus authored
      * lisp/net/tramp-sh.el: (tramp-maybe-open-connection):
      Arrange `process-environment' that it doesn't work for local
      processes.  (Bug#35769)
      16f14a4d
    • Alan Mackenzie's avatar
      CC Mode: Handle several consecutive noise macros in declaration contexts. · 95fb826d
      Alan Mackenzie authored
      In the bug scenario, the second and subsequent noise macros with parentheses
      were getting font-lock-type-face.
      
      * lisp/progmodes/cc-engine.el (c-end-of-token)
      (c-forward-noise-clause-not-macro-decl): New functions.
      (c-find-decl-prefix-search): Handle noise macros by skipping over them.
      (c-forward-decl-or-cast-1): In the loop checking for types, skip over all
      consecutive noise macros with parens, not just one.
      95fb826d
    • Eli Zaretskii's avatar
    • Bastien's avatar
      Fix missing declaration in gnus-sum.el · 9fcc9912
      Bastien authored
      * lisp/gnus/gnus-sum.el (gnus-tmp-name): Declare var.
      9fcc9912
    • Eli Zaretskii's avatar
      Fix display of images on MS-Windows broken by a recent commit · 721c520f
      Eli Zaretskii authored
      * src/image.c (initialize_image_type): Test if the type is in
      Vlibrary_cache up front, and return true without calling the
      'init' method if the type was already initialized.
      721c520f
    • Michael Albinus's avatar
      Suppress compiler warnings for older Emacsen in tramp-tests.el · b0a0705a
      Michael Albinus authored
      * test/lisp/net/tramp-tests.el (tramp-test17-insert-directory):
      Add error name to test.
      (tramp-test30-make-process, tramp-test45-unload):
      Suppress compiler warnings from older Emacsen.
      b0a0705a
    • Michael Albinus's avatar
      Require less packages in Tramp · cac8884d
      Michael Albinus authored
      * lisp/net/tramp-compat.el (format-spec): Do not require advice, cl-lib,
      custom, password-cache, timer and ucs-normalize.
      
      * lisp/net/tramp-gvfs.el: Do not require zeroconf.  Declare
      zeroconf-* functions.
      (tramp-gvfs-enabled): Autoload `zeroconf-init'.
      
      * lisp/net/tramp-sh.el: Do not require dired.
      
      * lisp/net/tramp.el (tramp-get-debug-buffer): Do not require outline.
      (tramp-file-name-for-operation): Extend docstring.
      (tramp-parse-netrc): Do not require netrc.  Autoload `netrc-parse'.
      cac8884d
    • Mattias Engdegård's avatar
      Don't use file notification on non-file buffers · 1943220d
      Mattias Engdegård authored
      Allow non-file buffers to declare that notification on their
      default-directory is sufficient to know when auto-revert updates are
      required by setting the new variable `buffer-auto-revert-by-notification'
      to non-nil.  If nil, the default, then auto-revert will poll
      those buffers instead. (bug#35418).
      Currently, only Dired sets that variable.
      
      * lisp/autorevert.el (auto-revert-buffers):
      Modify condition for using notification.
      * lisp/files.el (buffer-auto-revert-by-notification): New variable.
      * lisp/dired.el (dired-mode): Set buffer-auto-revert-by-notification.
      * doc/emacs/arevert-xtra.texi (Non-File Buffers): Document new variable.
      * etc/NEWS (Changes in Specialized Modes and Packages): Describe new variable.
      1943220d
    • Lars Ingebrigtsen's avatar
      (epa-file-decode-and-insert): Byte compilation warning fix · 4bf447bb
      Lars Ingebrigtsen authored
      * lisp/epa-file.el (epa-file-decode-and-insert): Remove
      superfluous call to `string-to-multibyte string'.
      4bf447bb
    • Michael Albinus's avatar
    • Michael Albinus's avatar
      ; Add comment in tramp-archive.el · b9303ac2
      Michael Albinus authored
      b9303ac2
    • Eli Zaretskii's avatar
      Remove usage of string-as-unibyte in arc-mode · 45ffe732
      Eli Zaretskii authored
      * lisp/arc-mode.el (archive-l-e): Encode with utf-8-emacs-unix
      instead of using string-as-unibyte.
      45ffe732
    • Eli Zaretskii's avatar
      Fix visiting and saving UTF-16 encoded XML files · 6c9a1deb
      Eli Zaretskii authored
      * lisp/international/mule.el (sgml-xml-auto-coding-function):
      When the 'enncoding' tag specifies a UTF-16 encoding, enforce
      saving the buffer with BOM, per the XML spec.
      (xml-find-file-coding-system): Recognize UTF-16 encodings with
      BOM.  (Bug#35766)  (Bug#8282)
      * lisp/international/mule-cmds.el (select-safe-coding-system):
      Don't consider UTF-16 encodings with and without BOM as
      "different", so as not to annoy users with redundant questions
      about mismatch between the XML/SGML header and the selected
      explicit encoding.
      6c9a1deb
    • Lars Ingebrigtsen's avatar
      Mitigate byte-compile warning in arc-mode · d0b72dbb
      Lars Ingebrigtsen authored
      * lisp/arc-mode.el (byte-after): Remove defsubst.
      Replace all calls to byte-after with get-byte throughout the file,
      because byte-after gave compilation warnings.
      d0b72dbb
    • Eli Zaretskii's avatar
      (hexl-insert-multibyte-char): Avoid using `string-as-unibyte' · a7a730e3
      Eli Zaretskii authored
      * lisp/hexl.el (hexl-insert-multibyte-char): Avoid using
      `string-as-unibyte' in the fallback case.
      a7a730e3
    • Lars Ingebrigtsen's avatar
      (dirtrack-toggle, dirtrackp): Remove obsolete aliases · 635d7a39
      Lars Ingebrigtsen authored
      * lisp/dirtrack.el (dirtrack-toggle, dirtrackp): Remove
      function/variable aliases declared obsolete in Emacs 23.1 (and
      that issued a byte-compile warning).
      635d7a39
    • Paul Eggert's avatar
      Clean up and simplify image-type setup · 41bf8653
      Paul Eggert authored
      This also fixes an unlikely hang involving a circular image
      description.
      * src/dispextern.h (struct image.type): Now pointer-to-const.
      * src/image.c (struct image_type.init) [!WINDOWSNT]: Omit.
      (IMAGE_TYPE_INIT): New macro.
      (image_types): Now a small array-of-const, not a pointer.
      (CACHE_IMAGE_TYPE): Remove; the code’s simpler without it.
      (ADD_IMAGE_TYPE): Remove this macro, replacing with ...
      (add_image_type): ... this equivalent function.  All uses changed.
      (define_image_type): Remove.  All uses removed.
      (valid_image_p): Use FOR_EACH_TAIL_SAFE to avoid Emacs hanging
      if the user creates a circular description of an image.
      (xbm_type, xpm_type, pbm_type, png_type, jpeg_type, tiff_type)
      (gif_type, imagemagick_type, svg_type, gs_type):
      Remove; now done by image_types.
      (init_imagemagick_functions): Remove decl of nonexistent function.
      (gs_clear_image): Remove; all uses replaced by image_clear_image.
      (initialize_image_type): New function, which captures a lot
      of the previously-scattered WINDOWSNT ifdefs.
      (lookup_image_type): Use it.
      (reset_image_types): Remove.  All uses removed.
      (syms_of_image): Don’t worry about ignoring image_types for
      pdumper, since it’s a constant now.
      41bf8653
  2. 17 May, 2019 14 commits