1. 18 Apr, 2019 5 commits
    • Paul Eggert's avatar
      Fix make-fingerprint off-by-one bug · df5ca4f7
      Paul Eggert authored
      Problem reported by Alex Gramiak in:
      https://lists.gnu.org/r/emacs-devel/2019-04/msg00784.html
      * lib-src/make-fingerprint.c (main): Fix recently-introduced
      off-by-one bug when accessing args after -r.
      df5ca4f7
    • Michael Albinus's avatar
    • Eric Abrahamsen's avatar
      Only encode Gnus group names if they come from symbol-name · a18336a8
      Eric Abrahamsen authored
      * lisp/gnus/gnus-start.el (gnus-active-to-gnus-format): Names that
        were strings to begin with should already be properly encoded.
      a18336a8
    • Paul Eggert's avatar
      Mark _Noreturn error functions as cold · 6d6c55db
      Paul Eggert authored
      On my platform this made ‘make compile-always’ 1.3% faster.
      Suggested by Alex Gramiak in:
      https://lists.gnu.org/r/emacs-devel/2019-04/msg00684.html
      * configure.ac (nw): Don’t use -Wsuggest-attribute=cold.
      * lib-src/make-docfile.c (write_globals):
      Mark noreturn functions as cold.
      * src/callproc.c (exec_failed):
      * src/data.c (wrong_length_argument, wrong_type_argument):
      * src/emacs-module.c (module_abort):
      * src/emacs.c (terminate_due_to_signal):
      * src/eval.c (unwind_to_catch):
      * src/image.c (my_png_error, my_error_exit):
      * src/json.c (json_out_of_memory, json_parse_error):
      * src/keyboard.c (quit_throw_to_read_char, user_error):
      * src/lisp.h (die, wrong_type_argument, wrong_choice)
      (args_out_of_range, args_out_of_range_3, circular_list)
      (buffer_overflow, memory_full, buffer_memory_full)
      (string_overflow, xsignal, xsignal0, xsignal1, xsignal2)
      (xsignal3, signal_error, overflow_error, error, verror)
      (nsberror, report_file_errno, report_file_error)
      (report_file_notify_error, terminate_due_to_signal)
      (emacs_abort, fatal):
      * src/lread.c (load_error_old_style_backquotes)
      (end_of_file_error, invalid_syntax):
      * src/pdumper.c (error_unsupported_dump_object):
      * src/puresize.h (pure_write_error):
      * src/search.c (matcher_overflow):
      * src/sound.c (sound_perror, alsa_sound_perror):
      * src/sysdep.c (handle_arith_signal):
      * src/systime.h (time_overflow):
      * src/term.c (maybe_fatal, vfatal):
      * src/textprop.c (text_read_only):
      * src/timefns.c (invalid_time_zone_specification)
      (time_error, invalid_hz):
      * src/xterm.c (x_connection_closed):
      Use AVOID instead of _Noreturn void, so that it’s marked cold.
      * src/conf_post.h (__has_attribute_cold) [!__has_attribute]:
      New macro.
      (ATTRIBUTE_COLD): New macro.
      * src/frame.h (WINDOW_SYSTEM_RETURN): Add ATTRIBUTE_COLD.
      * src/lisp.h (AVOID): New macro.
      * src/xterm.c: Omit unnecessary static decls, so that we needn’t
      worry about which functions should be marked cold.
      (x_io_error_quitter): Mark as cold.
      6d6c55db
    • YAMAMOTO Mitsuharu's avatar
  2. 17 Apr, 2019 12 commits
    • Philipp Stephani's avatar
      Add ERT explainer for 'tramp--test-file-attributes-equal-p' · 774da197
      Philipp Stephani authored
      * test/lisp/net/tramp-tests.el (tramp--test-file-attributes-equal-p):
      Use ERT explainer for 'equal' to improve failure messages.
      774da197
    • Michael Albinus's avatar
      Fix tramp-test32-shell-command · 2116dfff
      Michael Albinus authored
      * test/lisp/net/tramp-tests.el (tramp-test32-shell-command):
      Run only if "tput" exist.
      2116dfff
    • Glenn Morris's avatar
      Merge from origin/emacs-26 · 0797897f
      Glenn Morris authored
      a1c53d42 (origin/emacs-26) * admin/admin.el (make-manuals-dist--1): Up...
      d0f745f6 Document some compilation-mode faces
      23ccba0c Mention the assignment form in "Copyright Assignment"
      0f5568ea Fix confusing wording in the user manual
      70ec3928 Fix the MSDOS build when running under CWSDPMI
      7a608fc6 * lisp/progmodes/python.el: Be more careful about temp file r...
      0797897f
    • Glenn Morris's avatar
      ; Merge from origin/emacs-26 · 41d9004e
      Glenn Morris authored
      The following commits were skipped:
      
      b3cab419 Backport: Plug memory leak in GTK x-display-monitor-attribute...
      e40f39be Backport: * lisp/frame.el (frame--size-history): Fix infloop....
      41d9004e
    • Glenn Morris's avatar
      Merge from origin/emacs-26 · 632f489f
      Glenn Morris authored
      266c6229 Downcase charset
      92f3459c Update for Emacs-26
      beb4eac6 * doc/lispref/display.texi (Showing Images): Fix a typo.  (Bu...
      632f489f
    • Noam Postavsky's avatar
      ; Fix files-tests-executable-find on w32 (Bug#35241) · 63a190a6
      Noam Postavsky authored
      * test/lisp/files-tests.el (files-tests-executable-find): Make the
      tmpfile end with one of exec-suffixes, so that it will be executable
      on w32.
      63a190a6
    • Michael Albinus's avatar
      314c2aa7
    • Michael Albinus's avatar
      Fix Bug#35241 · 2c06731d
      Michael Albinus authored
      * lisp/files.el (executable-find): Quote default-directory.  (Bug#35241)
      
      * test/lisp/files-tests.el (files-tests-executable-find): New test.
      2c06731d
    • Michael Albinus's avatar
      * test/lisp/files-tests.el: Unify test names · 48a6a3ac
      Michael Albinus authored
      * test/lisp/files-tests.el (files-tests-local-variables)
      (files-tests-bug-18141, files-tests-make-temp-file-empty-prefix)
      (files-tests-bug-21454)
      (files-tests-save-buffers-kill-emacs--confirm-kill-processes)
      (files-tests-read-file-in-~)
      (files-tests-file-name-non-special--subprocess)
      (files-tests-file-name-non-special--buffers)
      (files-tests-insert-directory-wildcard-in-dir-p)
      (files-tests-make-directory, files-tests-no-file-write-contents)
      (files-tests-copy-directory, files-tests-abbreviated-home-dir):
      Unify test names.
      48a6a3ac
    • Michael Albinus's avatar
      Test `shell-command-width' in Tramp · 7e07bb2d
      Michael Albinus authored
      * test/lisp/net/tramp-tests.el
      (tramp--test-shell-command-to-string-asynchronously): Move up.
      (tramp-test32-shell-command): Test `shell-command-width'.
      7e07bb2d
    • YAMAMOTO Mitsuharu's avatar
      Use cairo_scaled_font_t object for text drawing and metrics calculation · acec59c9
      YAMAMOTO Mitsuharu authored
      * src/ftfont.h (struct font_info): Replace member cr_font_face of type
      cairo_font_face_t * with cr_scaled_font of type cairo_scaled_font_t *.
      * src/ftcrfont.c: Include math.h for floor, ceiling, and lround.
      (ftcrfont_glyph_extents): Use cairo_scaled_font_glyph_extents.
      (ftcrfont_open): Create cairo_scaled_font_t object and set it to
      cr_scaled_font member of struct font_info.
      (ftcrfont_close): Use cairo_scaled_font_destroy.
      (ftcrfont_draw): Use cairo_set_scaled_font.
      acec59c9
    • Andrii Kolomoiets's avatar
      Make python-shell-prompt-block-regexp match IPython prompt · 6f8fe0d5
      Andrii Kolomoiets authored
      * lisp/progmodes/python.el (python-shell-prompt-block-regexp): Match
      also IPython's multiline prompt.  It allows to correctly disable
      non-native completions during multiline statement in
      inferior-python-mode that runs IPython interpreter (Bug#34582).
      
      Copyright-paperwork-exempt: yes
      6f8fe0d5
  3. 16 Apr, 2019 11 commits
  4. 15 Apr, 2019 11 commits
    • Eli Zaretskii's avatar
      Minor change in a comment · 74412e7d
      Eli Zaretskii authored
      * test/src/callproc-tests.el
      (call-process-w32-debug-spawn-error): Minor copyedits of the
      commentary.
      74412e7d
    • Eli Zaretskii's avatar
      Fix the MSDOS build when running under CWSDPMI · 70ec3928
      Eli Zaretskii authored
      * src/msdos.c (the_only_tty_output): Define.
      * src/msdos.h (the_only_tty_output): Declare.
      * src/frame.c (make_terminal_frame) [MSDOS]:
      * src/dispnew.c (init_display) [MSDOS]: Set up
      f->output_data.tty pointer using the_only_tty_output, before
      dereferencing the pointer.  This prevents crashes with DPMI
      servers that provide NULL pointer protection.
      70ec3928
    • Eli Zaretskii's avatar
      Fix MS-Windows build broken by make-fingerprint changes · 3ec22997
      Eli Zaretskii authored
      * lib-src/make-fingerprint.c (fseeko) [WNDOWSNT]: Define to
      fseeko64 for non-MinGW64 MinGW.
      
      * lib-src/ntlib.c (stat): Fix calculation of file size.
      (fstat): New function, a subset of src/w32.c:fstat.  This is
      needed because make-fingerprint.c now calls 'fstat', and the
      MS version will fail to produce reliable results because
      nt/inc/sys/stat.h redefines 'struct stat'.
      3ec22997
    • Michael Albinus's avatar
    • Mattias Engdegård's avatar
      Don't remove notify descriptor that is already gone · e9e807e9
      Mattias Engdegård authored
      * lisp/autorevert.el (auto-revert-use-notify, auto-revert-mode,
      global-auto-revert-mode, auto-revert-notify-rm-watch,
      auto-revert-notify-add-watch, auto-revert-notify-handler,
      auto-revert-notify-rm-watch-callback):
      Don't remove a notify descriptor after receiving a `stopped' notification
      event, because the descriptor is then already gone and any attempt to
      remove it causes a recursive call to `auto-revert-notify-handler'.
      e9e807e9
    • Michael Albinus's avatar
      * doc/misc/tramp.texi: Fix direntry. · ba6ed9a4
      Michael Albinus authored
      ba6ed9a4
    • Paul Eggert's avatar
      Remove static var system_eol_type · 8065e05a
      Paul Eggert authored
      * src/coding.c (system_eol_type): Remove.
      (coding_inherit_eol_type, syms_of_coding):
      Simplify to avoid the need for system_eol_type.
      8065e05a
    • YAMAMOTO Mitsuharu's avatar
      Avoid compiler warnings on cairo build · da3e3fc7
      YAMAMOTO Mitsuharu authored
      * src/image.c (jpeg_load_body) [USE_CAIRO]: #ifdef out USE_SAFE_ALLOCA
      and SAFE_FREE.
      * src/xterm.c (x_composite_image) [USE_CAIRO]: #ifdef out unused function.
      (x_draw_image_glyph_string) [USE_CAIRO]: #ifdef out unused variable pixmap.
      da3e3fc7
    • Noam Postavsky's avatar
      Let debugger handle process spawn errors on w32 (Bug#33016) · 9800df69
      Noam Postavsky authored
      Since child_setup() is called between block_input()...unblock_input(),
      when an error is signaled the Lisp debugger is prevented from
      starting.  Therefore, let the callers signal the error instead (which
      they already do for non-w32 platforms, just the error message needs an
      update).
      * src/callproc.c (child_setup) [WINDOWSNT]: Don't call
      report_file_error here.
      (call_process) [WINDOWNT]:
      * src/process.c (create_process) [WINDOWSNT]: Call report_file_errno
      here instead, after the unblock_input() call, same as for !WINDOWSNT.
      * src/lisp.h (CHILD_SETUP_ERROR_DESC): New preprocessor define.  Flip
      the containing ifndef DOS_NT branches so that it's ifdef DOS_NT.
      * src/eval.c (when_entered_debugger): Remove.
      (syms_of_eval) <internal-when-entered-debugger>: Define it as a Lisp
      integer variable instead.
      (maybe_call_debugger): Update comment.
      * test/src/process-tests.el (make-process-w32-debug-spawn-error):
      * test/src/callproc-tests.el (call-process-w32-debug-spawn-error): New
      tests.
      9800df69
    • Alexander Gramiak's avatar
      Bump minimum GTK versions to 2.24 and 3.10 · fc0f469f
      Alexander Gramiak authored
      * configure.ac: Bump required GTK 2 and GTK 3 versions and the
      associated GLib versions. Remove obsolete AC_CHECK_FUNCS calls. These
      check for functions available in later GTK 2 versions. These checks
      and can safely be removed with the exception of
      gtk_window_set_has_resize_grip, which according to a comment in
      gtkutil.c causes an issue in Ubuntu's GTK 2.
      
      * src/gtkutil.c:
      * src/xfns.c:
      * src/xterm.c:
      * src/xterm.h: Remove now unused conditional blocks. Use HAVE_GTK3
      instead of GTK_CHECK_VERSION where now applicable. Remove checks of
      now always true USE_GTK_TOOLTIP.
      fc0f469f
    • Paul Eggert's avatar
      Replace executable’s fingerprint in place · 5c2f94a1
      Paul Eggert authored
      * admin/merge-gnulib (GNULIB_MODULES): Add memmem-simple.
      (AVOIDED_MODULES): Add memchr.
      * configure.ac (HAVE_PDUMPER): AC_SUBST it, too, for use in makefiles.
      * lib/Makefile.in (libgnu_a_OBJECTS): Add fingerprint.o.
      * lib/fingerprint.c: New file.
      * lib/memmem.c, lib/str-two-way.h, m4/memmem.m4: New files,
      copied from Gnulib.
      * lib/fingerprint.h: Rename from src/fingerprint.h.
      * lib-src/make-fingerprint.c: Include limits.h, sys/stat.h,
      fingerprint.h, intprops.h, min-max.h.
      (SSIZE_MAX): New macro, if not already defined.
      (main): Without -r, Replace the fingerprint in the input file
      instead of generating a fingerprint.c.
      * lib/Makefile.in (libgnu_a_OBJECTS): Add fingerprint.o.
      * lib/gnulib.mk.in, m4/gnulib-comp.m4: Regenerate.
      * src/Makefile.in (HAVE_PDUMPER, MAKE_PDUMPER_FINGERPRINT):
      New macros.
      (temacs$(EXEEXT)): Use them to replace the fingerprint instead
      of precalculating it.
      (mostlyclean, ctagsfiles1): Do not worry about fingerprint.c.
      5c2f94a1
  5. 14 Apr, 2019 1 commit